alexfh added inline comments.
================
Comment at:
clang-tools-extra/clang-tidy/readability/NamespaceCommentCheck.cpp:79
+ } else { // Any other kind of token is unexpected here.
+ return llvm::None;
+ }
----------------
aaron.ballman wrote:
> How well do these test cases work?
> ```
> namespace [[]] {
> }
>
> namespace frobble::inline bar {
> }
> ```
> I'm not certain what we want the comment to be for the second example, and
> I'm not certain the first example will parse properly here.
Both work correctly, in the second case the `inline` is dropped (why would we
want it not to?). See
clang-tools-extra/test/clang-tidy/checkers/google-readability-namespace-comments.cpp:66
and
clang-tools-extra/test/clang-tidy/checkers/google-readability-namespace-comments-c++17.cpp:4
for tests covering very similar cases. Just in case, I've added a test with an
empty attribute list.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70974/new/
https://reviews.llvm.org/D70974
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
