[PATCH] D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining

bader marked 5 inline comments as done. bader added inline comments. Comment at: clang/test/SemaSYCL/kernel-attribute.cpp:4-5 + +__attribute((sycl_kernel)) void foo() { +} aaron.ballman wrote: > aaron.ballman wrote: > > Missing some tests: > > * test that both at

[PATCH] D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining

bader updated this revision to Diff 231644. bader marked an inline comment as done. bader added a comment. Applied @aaron.ballman suggestions to kernel-attribute.cpp test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60455/new/ https://reviews.llvm

[PATCH] D70746: [clangd] Highlighting dependent types in more contexts

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. Thanks! LGTM Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:275 + if (NNS->getKind() == NestedNameSpecifier::Identifier) { +H.addTok

[PATCH] D70863: [clangd] Try harder to find a plausible `clang` as argv0, particularly on Mac.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. The code LG, but my mac is at home, so I could not verify it. @kbobyrev, would you mind running this on your machine? Comment at: clang-tools-extra/clangd/Globa

[PATCH] D70863: [clangd] Try harder to find a plausible `clang` as argv0, particularly on Mac.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:135 +// On other platforms, just look for compilers on the PATH. +for (const char* Name : {"clang", "gcc", "ccc"}) + if (auto PathCC = llvm::sys::findProgramByName(Name

[PATCH] D69223: WDocumentation: Implement the \anchor.

gribozavr2 added a comment. A few more comments, but generally looks good! Comment at: clang/include/clang-c/Documentation.h:188 + /** + * Command argument should not be rendered (since it is a only defines + * an anchor). "since it is a only" => "since it

[PATCH] D70862: [ARM][AArch64] Complex addition Neon intrinsics for Armv8.3-A

t.p.northover added a comment. Why are you only implementing rot90 and rot270 intrinsics? My quick calculations made rot0 and rot90 the natural ones to implement a bog-standard complex multiplication, but even if I slipped up there I'd expect the others to be useful in some situations. =

[clang-tools-extra] 902dc6c - [clangd] Fix a regression issue in local rename.

Author: Haojian Wu Date: 2019-12-02T10:32:55+01:00 New Revision: 902dc6c69ce7985427efa103a7c4099c372da6fa URL: https://github.com/llvm/llvm-project/commit/902dc6c69ce7985427efa103a7c4099c372da6fa DIFF: https://github.com/llvm/llvm-project/commit/902dc6c69ce7985427efa103a7c4099c372da6fa.diff LO

[PATCH] D70853: [clangd] Fix a regression issue in local rename.

This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rG902dc6c69ce7: [clangd] Fix a regression issue in local rename. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D70853?vs=231525&id=231647

[PATCH] D70862: [ARM][AArch64] Complex addition Neon intrinsics for Armv8.3-A

t.p.northover accepted this revision. t.p.northover added a comment. This revision is now accepted and ready to land. > Why are you only implementing rot90 and rot270 intrinsics? My quick > calculations made rot0 and rot90 the natural ones to implement a bog-standard > complex multiplication, bu

[PATCH] D70489: [clangd] Add xref for macro to static index.

usaxena95 marked an inline comment as done. usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:374 +Roles & static_cast(index::SymbolRole::Definition) || +Roles & static_cast(index::SymbolRole::Reference))) return

[PATCH] D70489: [clangd] Add xref for macro to static index.

usaxena95 updated this revision to Diff 231648. usaxena95 marked 5 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70489/new/ https://reviews.llvm.org/D70489 Files: clang-tool

[PATCH] D70849: [AST] Traverse the class type loc inside the member pointer type loc.

hokein updated this revision to Diff 231649. hokein marked 3 inline comments as done. hokein added a comment. Herald added subscribers: arphaman, jkorous. address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70849/new/ https://rev

[PATCH] D70856: [Syntax] Build nodes for simple cases of top level declarations

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:346 +/// static_assert(, ) +/// static_assert() +class StaticAssertDeclaration final : public Declaration {

[PATCH] D70863: [clangd] Try harder to find a plausible `clang` as argv0, particularly on Mac.

ilya-biryukov added a comment. Another interesting consideration: we choose to ask users to whitelists compilers we might run from `compile_commands.json` that we can. We are in a better position here, since we're not running the binaries based on user input. Technically, we could consider usin

[PATCH] D70863: [clangd] Try harder to find a plausible `clang` as argv0, particularly on Mac.

kbobyrev added a comment. The current version of the patch fixes one of the related issues. When running on a simple file like this #include int main() { std::cout << "Hello, world" << std::endl; return 0; } Clangd would fail to find `iostream` header and produce e

[PATCH] D70863: [clangd] Try harder to find a plausible `clang` as argv0, particularly on Mac.

sammccall planned changes to this revision. sammccall added a comment. @kbobyrev tested this and it turns out we also have to set `$SDKROOT`. And we probably want to fix `clang` in compile_commands.json too. In D70863#1764785 , @ilya-biryukov wrote: > A

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

klimek added a comment. I'm not generally opposed to this, given that a) clang-format already changes code; I think by now we're not fixing double semicolon mainly for workflow reasons, would be fine to add b) the implementation is very self contained Comment at: clang/docs/Cl

[PATCH] D70489: [clangd] Add xref for macro to static index.

merge_guards_bot added a comment. Build result: pass - 60166 tests passed, 0 failed and 730 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70489: [clangd] Add xref for macro to static index.

usaxena95 marked 2 inline comments as done. usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:374 +Roles & static_cast(index::SymbolRole::Definition) || +Roles & static_cast(index::SymbolRole::Reference))) return

[PATCH] D69840: [Basic] Make SourceLocation usable as key in hash maps, NFCI

miyuki added a comment. ping^3 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69840/new/ https://reviews.llvm.org/D69840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D70489: [clangd] Add xref for macro to static index.

usaxena95 updated this revision to Diff 231660. usaxena95 added a comment. Added correct documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70489/new/ https://reviews.llvm.org/D70489 Files: clang-tools-extra/clangd/index/SymbolCollecto

[PATCH] D70829: [ARM][MVE][Intrinsics] Add VMINQ/VMAXQ/VMINNMQ/VMAXNMQ intrinsics.

simon_tatham accepted this revision. simon_tatham added a comment. I do, but only an indentation quibble. Comment at: clang/include/clang/Basic/arm_mve.td:205 +(select (icmp_ule $a, $b), $a, $b)>, +NameOverride

[PATCH] D70253: [AArch64][SVE2] Implement remaining SVE2 floating-point intrinsics

kmclaughlin added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:898 + llvm_i32_ty], +[IntrNoMem]>; + sdesmalen wrote: > efriedma wrote: > > kmclaughlin wrote: > > > sdesmalen wrote: > > > > I'd expect the `

[clang] 510792a - [ARM][MVE][Intrinsics] Add VMINQ/VMAXQ/VMINNMQ/VMAXNMQ intrinsics.

Author: Mark Murray Date: 2019-12-02T11:18:53Z New Revision: 510792a2e0e3792871baa00ed34e162bba7cd9a2 URL: https://github.com/llvm/llvm-project/commit/510792a2e0e3792871baa00ed34e162bba7cd9a2 DIFF: https://github.com/llvm/llvm-project/commit/510792a2e0e3792871baa00ed34e162bba7cd9a2.diff LOG: [

[PATCH] D70489: [clangd] Add xref for macro to static index.

merge_guards_bot added a comment. Build result: pass - 60166 tests passed, 0 failed and 730 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70829: [ARM][MVE][Intrinsics] Add VMINQ/VMAXQ/VMINNMQ/VMAXNMQ intrinsics.

MarkMurrayARM updated this revision to Diff 231664. MarkMurrayARM added a comment. Address whitespace nit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70829/new/ https://reviews.llvm.org/D70829 Files: clang/include/clang/Basic/arm_mve.td cla

[PATCH] D70437: [AArch64][SVE] Implement shift intrinsics

kmclaughlin updated this revision to Diff 231663. kmclaughlin added a comment. - Rebased & enclosed additional //setOperationAction// calls within check for //Subtarget->isSVE()// CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70437/new/ https://reviews.llvm.org/D70437 Files: llvm/in

[PATCH] D70829: [ARM][MVE][Intrinsics] Add VMINQ/VMAXQ/VMINNMQ/VMAXNMQ intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rG510792a2e0e3: [ARM][MVE][Intrinsics] Add VMINQ/VMAXQ/VMINNMQ/VMAXNMQ intrinsics. (authored by MarkMurrayARM). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7

[PATCH] D70829: [ARM][MVE][Intrinsics] Add VMINQ/VMAXQ/VMINNMQ/VMAXNMQ intrinsics.

MarkMurrayARM marked an inline comment as done. MarkMurrayARM added a comment. Nit terminated with extreme prejudice. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70829/new/ https://reviews.llvm.org/D70829 __

[PATCH] D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining

Fznamznon accepted this revision. Fznamznon added a comment. LGTM with a couple of minor comments. Comment at: clang/include/clang/Basic/AttrDocs.td:273 +cgh.parallel_for(range<1>{1024}, [=](id<1> index) { + A[index] = index[0] * 2 + index[1] + foo(42); +}); --

[PATCH] D70863: [clangd] Try harder to find a plausible `clang` as argv0, particularly on Mac.

sammccall added a comment. @kbobyrev would you mind testing this again? Dropping an empty compile_flags.txt should also work (and test the other codepath) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70863/new/ https://reviews.llvm.org/D70863

[PATCH] D70863: [clangd] Try harder to find a plausible `clang` as argv0, particularly on Mac.

sammccall updated this revision to Diff 231674. sammccall added a comment. This revision is now accepted and ready to land. Also add detected -isysroot on mac unless $SDKROOT is set. Also add path to driver when bare driver name comes from CDB. While here, address -resource-dir fixme. Repository

[PATCH] D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining

aaron.ballman added inline comments. Comment at: clang/test/SemaSYCL/kernel-attribute.cpp:4-5 + +__attribute((sycl_kernel)) void foo() { +} bader wrote: > aaron.ballman wrote: > > aaron.ballman wrote: > > > Missing some tests: > > > * test that both attributes ca

[PATCH] D70073: [ConstExprPreter] Implemented function calls and if statements

nand added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70073/new/ https://reviews.llvm.org/D70073 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining

bader added a comment. I hope all comments from are @Fznamznon and @aaron.ballman are applied. @ABataev, do you have any other comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60455/new/ https://reviews.llvm.org/D60455 ___

[PATCH] D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining

bader updated this revision to Diff 231679. bader marked 2 inline comments as done. bader added a comment. Fixed SYCL code example for sycl_kernel attribute documentation and commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60455/new/

[PATCH] D70849: [AST] Traverse the class type loc inside the member pointer type loc.

ilya-biryukov added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:1168 DEF_TRAVERSE_TYPELOC(MemberPointerType, { - TRY_TO(TraverseType(QualType(TL.getTypePtr()->getClass(), 0))); + if (auto *TSI = TL.getClassTInfo()) +TRY_TO(TraverseTypeLoc(TSI

[PATCH] D70740: [clangd] Find reference to template parameter in 'sizeof...' expression

ilya-biryukov added a comment. Could you add another test for `findExplicitReferences` too? Those tests are right after `targetDecl`. These two functions kinda duplicate each other a lot, but that's intentional - those two functions do a somewhat similar thing and we want to keep them in sync (

[PATCH] D70863: [clangd] Try harder to find a plausible `clang` as argv0, particularly on Mac.

kbobyrev accepted this revision. kbobyrev added a comment. In D70863#1764977 , @sammccall wrote: > @kbobyrev would you mind testing this again? > > Dropping an empty compile_flags.txt should also work (and test the other > codepath) I've tested again (a

[PATCH] D70437: [AArch64][SVE] Implement shift intrinsics

kmclaughlin updated this revision to Diff 231693. kmclaughlin added a comment. - Removed re-ordering of integer arithmetic & logical op intrinsic definitions in IntrinsicsAArch64.td CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70437/new/ https://reviews.llvm.org/D70437 Files: llvm/

[clang] 6236496 - [OpenCL] Fix address space for implicit conversion (PR43145)

Author: Sven van Haastregt Date: 2019-12-02T14:20:15Z New Revision: 62364965619bd7e8847418b21ec327a78bd1624c URL: https://github.com/llvm/llvm-project/commit/62364965619bd7e8847418b21ec327a78bd1624c DIFF: https://github.com/llvm/llvm-project/commit/62364965619bd7e8847418b21ec327a78bd1624c.diff

[PATCH] D70605: [OpenCL] Fix address space for implicit conversion (PR43145)

This revision was automatically updated to reflect the committed changes. Closed by commit rG62364965619b: [OpenCL] Fix address space for implicit conversion (PR43145) (authored by svenvh). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D70902: Fix compatibility with python3 of clang-include-fixer.py

yannack created this revision. yannack added a reviewer: bkramer. Herald added a project: clang. Herald added a subscriber: cfe-commits. clang-include-fixer was recently updated to be python3-compatible. However, an exception handling clause was improperly using the deprecated `message` property

[clang] dcf11c5 - [ARM][AArch64] Complex addition Neon intrinsics for Armv8.3-A

Author: Victor Campos Date: 2019-12-02T14:38:39Z New Revision: dcf11c5e86cee94ec649a7a31c5dd259f60579d6 URL: https://github.com/llvm/llvm-project/commit/dcf11c5e86cee94ec649a7a31c5dd259f60579d6 DIFF: https://github.com/llvm/llvm-project/commit/dcf11c5e86cee94ec649a7a31c5dd259f60579d6.diff LOG:

[PATCH] D70862: [ARM][AArch64] Complex addition Neon intrinsics for Armv8.3-A

This revision was automatically updated to reflect the committed changes. Closed by commit rGdcf11c5e86ce: [ARM][AArch64] Complex addition Neon intrinsics for Armv8.3-A (authored by vhscampos). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70862/new/

[PATCH] D70594: [clangd] Implement range patching heuristics for cross-file rename.

sammccall added a comment. High level comments based on offline discussion: I think we want to define/formalize the concept of a near miss, to make precise the tradeoffs between false positives, false negatives, and implementability. Not just at the individual level (an index occurrence vs a lex

[PATCH] D70863: [clangd] Try harder to find a plausible `clang` as argv0, particularly on Mac.

sammccall added a comment. In D70863#1765042 , @kbobyrev wrote: > In D70863#1764977 , @sammccall wrote: > > > @kbobyrev would you mind testing this again? > > > > Dropping an empty compile_flags.txt should also work

[PATCH] D70863: [clangd] Try harder to find a plausible `clang` as argv0, particularly on Mac.

This revision was automatically updated to reflect the committed changes. Closed by commit rG88bccded8fa1: [clangd] Try harder to find a plausible `clang` as argv0, particularly on Mac. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[clang-tools-extra] 88bccde - [clangd] Try harder to find a plausible `clang` as argv0, particularly on Mac.

Author: Sam McCall Date: 2019-12-02T16:17:40+01:00 New Revision: 88bccded8fa169481fa367debf5ec615640635a1 URL: https://github.com/llvm/llvm-project/commit/88bccded8fa169481fa367debf5ec615640635a1 DIFF: https://github.com/llvm/llvm-project/commit/88bccded8fa169481fa367debf5ec615640635a1.diff LO

[PATCH] D70594: [clangd] Implement range patching heuristics for cross-file rename.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.h:95 + /// \p getBest, exposing for testing only. + static MatchType match(llvm::ArrayRef LHS, llvm::ArrayRef RHS); + Oops, forgot this... I think the public API isn't quite r

[PATCH] D69043: [RFC] Adding time-trace to LLD?

russell.gallop added a comment. I've re-implemented this using thread local time tracing. Have broken the changes down into a couple of patches. First one doing some minor tidying up here (https://reviews.llvm.org/D70904). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

dblaikie added a comment. Looks OK to me - please recommit when you're ready. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70111/new/ https://reviews.llvm.org/D70111 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D70849: [AST] Traverse the class type loc inside the member pointer type loc.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:1168 DEF_TRAVERSE_TYPELOC(MemberPointerType, { - TRY_TO(TraverseType(QualType(TL.getTypePtr()->getClass(), 0))); + if (auto *TSI = TL.getClassTInfo(

[PATCH] D69620: Add AIX assembler support

stevewan updated this revision to Diff 231712. stevewan added a comment. State in the comment the expectation to driver in handling assembler source input when invoking as(1). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69620/new/ https://review

[PATCH] D70857: [llvm][Support] Take in CurrentDirectory as a parameter in ExpandResponseFiles

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: llvm/include/llvm/Support/CommandLine.h:1972 +/// \param [in] CurrentDir Path used to resolve relative rsp files when \p +/// RelativeNames is set to tr

[PATCH] D70905: Actually delay processing DelayedDllExportClasses until the outermost class is finished (PR40006)

hans created this revision. hans added reviewers: rnk, rsmith. This was already the intention of DelayedDllExportClasses, but this test case would break it: template struct Tmpl {}; struct Outer { struct Inner { __declspec(dllexport) Inner() = default; unsigned int

[PATCH] D70183: Detect source location overflow due includes

miyuki added a comment. > clang shall either die due an assert in debug [...] I think I have already mentioned the reasons why I don't think this is acceptable: - it would break tests, as they are usually run with enabled assertions (and since this diagnostic is quite easy to test, it should b

[PATCH] D70489: [clangd] Add xref for macro to static index.

hokein added a comment. btw, could you measure the increasing size of the index with this patch? You could run ./bin/clangd-indexer -format=binary -executor=all-TUs . > static-index.idx ./bin/dexp static-index.idx # you will see the memory usage. Comment at: clang-tools

[PATCH] D70876: [clang-tidy] Add spuriously-wake-up-functions check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/MiscTidyModule.cpp:45-46 "misc-redundant-expression"); +CheckFactories.registerCheck( +"misc-spuriously-wake-up-functions"); CheckFactories.registerCheck("misc-static-asse

[PATCH] D70485: [ARM,MVE] Add intrinsics to deal with predicates.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd173fb5d2854: [ARM,MVE] Add intrinsics to deal with predicates. (authored by simon_tatham). Changed prior to commit: https://reviews.llvm.org/D70485?vs=230627&id=231718#toc Repository: rG LLVM Github

[clang] 3ebfab7 - Add AIX assembler support

Author: stevewan Date: 2019-12-02T11:29:36-05:00 New Revision: 3ebfab709583cfa7635693b123e56f76a1de765b URL: https://github.com/llvm/llvm-project/commit/3ebfab709583cfa7635693b123e56f76a1de765b DIFF: https://github.com/llvm/llvm-project/commit/3ebfab709583cfa7635693b123e56f76a1de765b.diff LOG:

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

Meinersbur added a comment. In D61446#1763278 , @serge-sans-paille wrote: > @Meinersbur I have a strange symbol issue when activating the GPu part: > https://github.com/serge-sans-paille/llvm-project/pull/2/checks?check_run_id=324901896#step:5:4888 > An

[PATCH] D65591: [AST] Add a flag indicating if any subexpression had errors

ilya-biryukov added a comment. I would actually try to counter the type proposal and defend the `containsErrors` bit. Here's my thinking. Not knowing that `int()` had errors inside can lead to situations with bad diagnostics. We won't be able to suppress any non-type-related error, e.g. `int *a

[PATCH] D69620: Add AIX assembler support

This revision was automatically updated to reflect the committed changes. Closed by commit rG3ebfab709583: Add AIX assembler support (authored by stevewan, committed by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69620/new/ https://revi

[PATCH] D70748: [clang test] Do not assume default target

thegameg accepted this revision. thegameg added a comment. This revision is now accepted and ready to land. LGTM, thanks for fixing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70748/new/ https://reviews.llvm.org/D70748 __

[PATCH] D69740: [profile] Support counter relocation at runtime

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Lgtm with a small cleanup. Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:674 + if (isRuntimeCounterRelocationEnabled()) { +Type *Int64Ty = Type::getInt64T

[PATCH] D70571: [Coverage] Emit a gap region to cover switch bodies

vsk updated this revision to Diff 231724. vsk added a comment. Add test case from PR44011. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70571/new/ https://reviews.llvm.org/D70571 Files: clang/docs/SourceBasedCodeCoverage.rst clang/lib/CodeGen/CoverageMappingGen.cpp clang/test/Co

[PATCH] D70819: [ASTImporter] Support functions with placeholder return types ...

martong marked 9 inline comments as done. martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:3008 +// which is equal to the given DC. +bool isAncestorDeclContextOf(DeclContext *DC, Decl *D) { + DeclContext *DCi = D->getDeclContext(); a_sido

[PATCH] D70819: [ASTImporter] Support functions with placeholder return types ...

martong updated this revision to Diff 231725. martong marked 4 inline comments as done. martong added a comment. - Address Alexei's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70819/new/ https://reviews.llvm.org/D70819 Files: clang/li

[PATCH] D70819: [ASTImporter] Support functions with placeholder return types ...

martong added a comment. Alexei, thanks for the assiduous review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70819/new/ https://reviews.llvm.org/D70819 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D69979: clang: Guess at some platform FTZ/DAZ default settings

arsenm updated this revision to Diff 231726. arsenm added a comment. DAZ/FTZ seem to be set in crtfastmath.o, so try to reproduce the logic for linking that CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69979/new/ https://reviews.llvm.org/D69979 Files: clang/include/clang/Driver/Too

[PATCH] D70537: [clang] CGDebugInfo asserts `!DT.isNull()` when compiling with debug symbols

vsk added inline comments. Comment at: clang/test/CodeGenCXX/pr42710.cpp:4 +// RUN: %clang %s -DTYPE=int -emit-llvm -S -g -o - -std=c++17 +// expected-no-diagnostics + Could you validate the debug info for the struct members in the `int` case? (It may be simpler

[PATCH] D69770: [APFloat] Add recoverable string parsing errors to APFloat

ekatz added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69770/new/ https://reviews.llvm.org/D69770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D70157: Align branches within 32-Byte boundary

reames added a comment. I want to chime in support of jyknight's meta comments - particularly the one about the need to balance execution speed vs code size differently in hot vs cold code. For our use case, we have a very large amount of branch dense known cold paths, and being able to only a

[PATCH] D70253: [AArch64][SVE2] Implement remaining SVE2 floating-point intrinsics

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. Thanks @kmclaughlin , LGTM. Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:898 + llvm_i32_ty], +[IntrNoMem]>; +

[PATCH] D70437: [AArch64][SVE] Implement shift intrinsics

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70437/new/ https://reviews.llvm.org/D70437 ___ cfe-commits mailing list cfe-co

[PATCH] D70872: [clangd] Implement "textDocument/documentLink" protocol support

sammccall added a comment. Thanks, looks nice! It occurred to me we could compute (but not resolve) the ranges cheaply to speed up the UI. We don't need to do this now. Only real thing to do is add a gunit test. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1204 +

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

aprantl added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1140 + for (auto D: ExternalDeclarations) { +if (!D || D->isInvalidDecl() || D->getPreviousDecl() || !D->isUsed()) clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D70911: [clangd] Switch Hover.All to structured tests

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D70911 Files: clang-tools-extra/clan

[PATCH] D70911: [clangd] Switch Hover.All to structured tests

merge_guards_bot added a comment. Build result: FAILURE - Log files: console-log.txt , CMakeCache.txt Repository: rG LLV

[PATCH] D70912: [Analyzer] Iterator Modeling: Print Container Data and Iterator Positions when printing the Program State

baloghadamsoftware updated this revision to Diff 231738. baloghadamsoftware added a comment. Wrong diff uploaded. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70912/new/ https://reviews.llvm.org/D70912 Files: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp clang/test/Analys

[PATCH] D70537: [clang] CGDebugInfo asserts `!DT.isNull()` when compiling with debug symbols

probinson added a comment. I guess first I'm confused about why the type would be undeduced in the first place, given that it is actually instantiated. And if undeduced is correct, wouldn't we rather emit these with DW_TAG_unspecified_type? Comment at: clang/test/CodeGenCXX/p

[clang] 9ec6d71 - [clang][modules] Add support for merging lifetime-extended temporaries

Author: Tyker Date: 2019-12-02T19:55:13+01:00 New Revision: 9ec6d7121132d30db68818e4f684910f76307fdf URL: https://github.com/llvm/llvm-project/commit/9ec6d7121132d30db68818e4f684910f76307fdf DIFF: https://github.com/llvm/llvm-project/commit/9ec6d7121132d30db68818e4f684910f76307fdf.diff LOG: [c

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

probinson added a comment. For the case: cat def.c int global_var = 2; def.o should have debug info for the definition of global_var. For the case: cat noref.c extern int global_var; int main() {} I would not expect to see debug info for the declaration of global_var. For

[clang] 478541a - [OPENMP]Fix PR44133: Emit definitions of used constructors/functions.

Author: Alexey Bataev Date: 2019-12-02T14:07:29-05:00 New Revision: 478541a6da59fa3eadab98cabdcb0126fad3fdb5 URL: https://github.com/llvm/llvm-project/commit/478541a6da59fa3eadab98cabdcb0126fad3fdb5 DIFF: https://github.com/llvm/llvm-project/commit/478541a6da59fa3eadab98cabdcb0126fad3fdb5.diff

[clang] f17a1d8 - [OPENMP]Use cast instead dyn_cast, NFC.

Author: Alexey Bataev Date: 2019-12-02T14:16:52-05:00 New Revision: f17a1d8b283d227dcbc88caf94acf55abc91c1f9 URL: https://github.com/llvm/llvm-project/commit/f17a1d8b283d227dcbc88caf94acf55abc91c1f9 DIFF: https://github.com/llvm/llvm-project/commit/f17a1d8b283d227dcbc88caf94acf55abc91c1f9.diff

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

aprantl added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2925 +return C.getQualifiedType(T.getTypePtr(), Quals); + } case Type::DeducedTemplateSpecialization: { aprantl wrote: > You need to mark this `LLVM_FALLTHROUGH` now or

[PATCH] D68101: [MC][ELF] Prevent globals with an explicit section from being mergeable

rjmccall added a comment. Let me try to restate what's happening here so that I can see if I understand it. There are two concepts of "section" in play here: - a unit in an object file with a particular section name, which need not be unique within the object file, and which can have interesti

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

yonghong-song marked an inline comment as done. yonghong-song added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1140 + for (auto D: ExternalDeclarations) { +if (!D || D->isInvalidDecl() || D->getPreviousDecl() || !D->isUsed()) aprantl wrote: > cla

[PATCH] D70863: [clangd] Try harder to find a plausible `clang` as argv0, particularly on Mac.

arphaman added a comment. @sammccall Sam, it looks like the tests are failing on the darwin bots: http://lab.llvm.org:8080/green/job/clang-stage1-RA/4243/consoleFull Value of: CDB.getFallbackCommand(testPath("bar.cc")).CommandLine Expected: has 6 elements where element #0 ends with "clang"

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

dblaikie added a comment. In D70696#1765637 , @probinson wrote: > For the case: > > cat def.c > int global_var = 2; > > > def.o should have debug info for the definition of global_var. > For the case: > > cat noref.c > extern int global_va

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

yonghong-song added a comment. @probinson for the question, > Does bpf require debug info for the declaration of global_var in noref.c ? No, bpf only cares the referenced external global variables. So my current implementation does not emit debug info for external global_var in noref.c. It is

[PATCH] D69979: clang: Guess at some platform FTZ/DAZ default settings

spatel added a subscriber: andreadb. spatel added inline comments. Comment at: clang/include/clang/Driver/ToolChain.h:580 + /// This checks for presence of the -Ofast, -ffast-math or -funsafe-math flags. + virtual bool FastMathRuntimeIsAvailable( +const llvm::opt::ArgList

[PATCH] D70041: register cuda language activation event and activate for .cuh files

ptaylor updated this revision to Diff 231742. ptaylor added a comment. drop comment about vscode cuda syntax highlighting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70041/new/ https://reviews.llvm.org/D70041 Files: clang-tools-extra/clangd/cl

[PATCH] D10833: Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface

jkorous added a comment. Hi @arthurp, I can review the libclang part of the patch. Could you please remove the changes that are just code formatting? You can land those as a separate NFC commit. Comment at: clang/tools/libclang/CIndex.cpp:259 + + std::pair Begin = SM.getDeco

[clang] 1d45873 - [AArch64] Attempt to fixup test line. NFC

Author: David Green Date: 2019-12-02T19:30:54Z New Revision: 1d4587346f51ca5cc5741337cadfaeb208ca59ad URL: https://github.com/llvm/llvm-project/commit/1d4587346f51ca5cc5741337cadfaeb208ca59ad DIFF: https://github.com/llvm/llvm-project/commit/1d4587346f51ca5cc5741337cadfaeb208ca59ad.diff LOG: [

[PATCH] D69223: WDocumentation: Implement the \anchor.

Mordante marked 6 inline comments as done. Mordante added inline comments. Comment at: clang/lib/Index/CommentToXML.cpp:650 +assert(C->getNumArgs() == 1); +Result << ""; +appendToResultWithXMLEscaping(Arg0); gribozavr2 wrote: > Sholudn't this code be

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

yonghong-song added a comment. @dblaikie Good points. I will guard external variable debug info generation under `-fstandalone-debug` flag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70696/new/ https://reviews.llvm.org/D70696 ___

[clang] 8f1e215 - [WebAssembly] Find wasm-opt with GetProgramPath

Author: Dan Gohman Date: 2019-12-02T11:48:36-08:00 New Revision: 8f1e2151b8e923345a18aa3025a7d074e134768b URL: https://github.com/llvm/llvm-project/commit/8f1e2151b8e923345a18aa3025a7d074e134768b DIFF: https://github.com/llvm/llvm-project/commit/8f1e2151b8e923345a18aa3025a7d074e134768b.diff LO

  1   2   >