t.p.northover accepted this revision.
t.p.northover added a comment.
This revision is now accepted and ready to land.

> Why are you only implementing rot90 and rot270 intrinsics? My quick 
> calculations made rot0 and rot90 the natural ones to implement a bog-standard 
> complex multiplication, but even if I slipped up there I'd expect the others 
> to be useful in some situations.

Sorry, ignore that. I didn't notice you were doing the addition instructions 
rather than multiplication. LGTM!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70862/new/

https://reviews.llvm.org/D70862



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to