[PATCH] D70440: [Driver] Use VFS to check if sanitizer blacklists exist

thakis added a comment. Do we need to add a dep on Frontend to DriverTests here? That's a heavy dependency (it pulls in Sema etc). If it is needed, maybe the test is in the wrong binary? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70440/new/ ht

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

awpandey updated this revision to Diff 230601. awpandey marked 3 inline comments as done. awpandey added a comment. This revision includes 1. Added check for return type it is attached to the exact node we're expecting it to. 2. Removed unnecessary strings and checks. CHANGES SINCE LAST ACTION

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

awpandey marked 2 inline comments as done. awpandey added a comment. Thanks @aprantl for your suggestions. I have revised by patch based on that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70524/new/ https://reviews.llvm.org/D70524 ___

[PATCH] D70588: Don't report "main" as missing a prototype in freestanding mode

void created this revision. void added a reviewer: efriedma. Herald added a project: clang. Herald added a subscriber: cfe-commits. A user may want to use freestanding mode with the standard "main" entry point. It's not useful to warn about a missing prototype as it's not typical to have a prototy

[PATCH] D70445: [clangd] Show lambda signature for lambda autocompletions

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Great, thanks for fixing this! Comment at: clang/test/CodeCompletion/lambdas.cpp:66 + auto my_lambda = [&](int a, double &b) { return 1.f; }; + my_ + // RUN: %clang_

[PATCH] D67149: Fix argument order for BugType instation for

MTC added a comment. Good catch, the fix is reasonable to me. However, I'm no longer wok on the analyzer now, maybe you can add @NoQ Or some other active reviewers to review the code. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67149/new/ https://reviews.llv

[PATCH] D70569: [clangd] Allow extract-to-function on regions that always return.

merge_guards_bot added a comment. Build result: pass - 60231 tests passed, 0 failed and 732 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70445: [clangd] Show lambda signature for lambda autocompletions

kbobyrev updated this revision to Diff 230619. kbobyrev added a comment. Get rid of incomplete identifiers in test code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70445/new/ https://reviews.llvm.org/D70445 Files: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp clang/li

[PATCH] D70554: [libTooling] Add stencil combinators for nodes that may be pointers or values.

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Tooling/Transformer/Stencil.h:95 +// Constructs an expression that idiomatically represents a value, taking into +// account whe

[PATCH] D68388: [PR41008][OpenCL] Add OpenCL C compatibility mode to C++ for OpenCL

kpet updated this revision to Diff 230620. kpet retitled this revision from "[PR41008][OpenCL] Support restrict keyword in C++ mode" to "[PR41008][OpenCL] Add OpenCL C compatibility mode to C++ for OpenCL". kpet edited the summary of this revision. kpet added a comment. As discussed offline, le

[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang Tidy's script

gribozavr2 added a comment. > This patch introduces a way to apply the fix-its by the Analyzer: I'm not sure this option is very useful... I don't know of anyone who uses the same option in Clang or ClangTidy. The only way I know people apply fixits is with the help of IDEs. I am also skeptical

[PATCH] D70569: [clangd] Allow extract-to-function on regions that always return.

kadircet added a comment. btw forgot to add a comment, it might be worth mentioning in change description that, this works in its current state because we don't allow extractions inside lambda expressions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D69022: [coroutines] Remove assert on CoroutineParameterMoves in Sema::buildCoroutineParameterMoves

junparser added a comment. In D69022#1756138 , @modocache wrote: > LGTM, thanks! Please let me know if you'd like me to commit this change. commit it please, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69022/new/ https://reviews.llvm

[PATCH] D70569: [clangd] Allow extract-to-function on regions that always return.

kadircet accepted this revision. kadircet marked an inline comment as done. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp:173 +bool alwaysReturns(const Extraction

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

kadircet added a comment. Sorry wrote comments but forgot to hit submit :( Comment at: clang/include/clang/Tooling/CompilationDatabase.h:229 +/// \return true if all @files were expanded successfully or there were none. +bool expandResponseFiles(tooling::CompileCommand &Cmd, +

[PATCH] D70569: [clangd] Allow extract-to-function on regions that always return.

sammccall marked 2 inline comments as done. sammccall added a comment. (Thanks! Will address comments, just wanted to ask for a clarification) Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp:180 + Last = CS->body_back(); + return llvm::isa(Last);

[PATCH] D70157: Align branches within 32-Byte boundary

skan added a comment. In D70157#1755927 , @jyknight wrote: > An alternative would be to simply emit NOPs before branches as needed. That > would be substantially simpler, since it would only require special handling > for a branch or a fused-branch. I as

[PATCH] D68362: [libunwind][RISCV] Add 64-bit RISC-V support

abidh added inline comments. Comment at: libunwind/src/Registers.hpp:3765 +inline void Registers_riscv::setFloatRegister(int regNum, double value) { +#ifdef __riscv_flen == 64 + assert(validFloatRegister(regNum)); I am building these changes and get the followin

[PATCH] D70485: [ARM,MVE] Add intrinsics to deal with predicates.

simon_tatham updated this revision to Diff 230627. simon_tatham edited the summary of this revision. simon_tatham added a comment. Revised again to fix test failures. But I've also split off the rework of `int_arm_vctp` into a separate patch D70592 , to make it c

[clang-tools-extra] 7f0dcf6 - [clangd] Show lambda signature for lambda autocompletions

Author: Kirill Bobyrev Date: 2019-11-22T12:48:06+01:00 New Revision: 7f0dcf665dd22be296805bc7a1c71a36243c4e09 URL: https://github.com/llvm/llvm-project/commit/7f0dcf665dd22be296805bc7a1c71a36243c4e09 DIFF: https://github.com/llvm/llvm-project/commit/7f0dcf665dd22be296805bc7a1c71a36243c4e09.diff

[PATCH] D70180: [AArch64][SVE] Implement floating-point conversion intrinsics

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. Herald added a reviewer: efriedma. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70180/new/ https://reviews.llvm.org/D70180 _

[PATCH] D70594: [clangd] Implement range patching heuristics for cross-file rename.

hokein created this revision. hokein added reviewers: sammccall, ilya-biryukov. Herald added subscribers: usaxena95, kadircet, arphaman, mgrang, jkorous, MaskRay. Herald added a project: clang. The heuristic is simple, only for cases we are confident. Repository: rG LLVM Github Monorepo http

[PATCH] D70569: [clangd] Allow extract-to-function on regions that always return.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp:611 + // (Others are possible if there are conversions, but this seems clearest). + if (CapturedInfo.HasReturnStmt) { +// If the return is conditional, neither replacing

[PATCH] D70253: [AArch64][SVE2] Implement remaining SVE2 floating-point intrinsics

sdesmalen added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:898 + llvm_i32_ty], +[IntrNoMem]>; + I'd expect the `llvm_i32_ty` to be an immediate for these instructions, right? If so you'll need to add `I

[PATCH] D70445: [clangd] Show lambda signature for lambda autocompletions

This revision was automatically updated to reflect the committed changes. Closed by commit rG7f0dcf665dd2: [clangd] Show lambda signature for lambda autocompletions (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70445/new/ htt

[PATCH] D70594: [clangd] Implement range patching heuristics for cross-file rename.

merge_guards_bot added a comment. Build result: FAILURE - Could not check out parent git hash "6171238cb7e9e8616d21ce09d463e945ce0a9fb8". It was not found in the repository. Did you configure the "Parent Revision" in Phabricator properly? Trying to apply the patch to the master branch instead..

[PATCH] D69223: WDocumentation: Implement the \anchor.

gribozavr2 added a comment. Thank you for the contribution and sorry for the review delay! Comment at: clang/bindings/xml/comment-xml-schema.rng:583 + + + Since the name of the anchor is not a part of the document text, it should be an at

[PATCH] D70437: [AArch64][SVE] Implement shift intrinsics

sdesmalen added a comment. Herald added a reviewer: efriedma. Two small comments, but overall looks good! Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:835 + LLVMMatchType<0>, + llvm_i32_ty], +[IntrNoMem]>; ---

[PATCH] D70494: [clangd] Fix diagnostic location for macro expansions

hokein added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:121 const SourceManager &SM = Info.getSourceManager(); + const SourceLocation &DiagLoc = SM.getFileLoc(Info.getLocation()); SourceLocation IncludeInMainFile; should we use g

[PATCH] D68388: [PR41008][OpenCL] Add OpenCL C compatibility mode to C++ for OpenCL

Anastasia added a comment. I think we should use `-fpermissive` rather than adding similar flag to Clang. At the end we might end up with other cases where we need similar mechanism it doesn't make sense to add a flag for each case. Also I am not sure that what you are doing here is really enab

[PATCH] D70494: [clangd] Fix diagnostic location for macro expansions

kadircet marked 5 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:121 const SourceManager &SM = Info.getSourceManager(); + const SourceLocation &DiagLoc = SM.getFileLoc(Info.getLocation()); SourceLocation Includ

[PATCH] D70494: [clangd] Fix diagnostic location for macro expansions

kadircet updated this revision to Diff 230636. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70494/new/ https://reviews.llvm.org/D70494 Files: clang-tools-ex

[PATCH] D70596: [analyzer][docs] NFC: Extend documentation for MallocOverflow checker

steakhal created this revision. steakhal added reviewers: Szelethus, NoQ, krememek. Herald added subscribers: cfe-commits, Charusso, donat.nagy, dexonsmith, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a project: clang. Adds and example for `MallocOv

[PATCH] D70494: [clangd] Fix diagnostic location for macro expansions

merge_guards_bot added a comment. Build result: pass - 60220 tests passed, 0 failed and 732 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D68388: [PR41008][OpenCL] Add OpenCL C compatibility mode to C++ for OpenCL

kpet added a comment. Thanks for the feedback. > I think we should use -fpermissive rather than adding similar flag to Clang. Could you point me at a use of `-fpermissive` for a similar case? Also it seems `-fpermissive` is not mentioned in the Clang manual or the help text. Am I missing somet

[PATCH] D68388: [PR41008][OpenCL] Add OpenCL C compatibility mode to C++ for OpenCL

Anastasia added a comment. In D68388#1756701 , @kpet wrote: > Thanks for the feedback. > > > I think we should use -fpermissive rather than adding similar flag to Clang. > > Could you point me at a use of `-fpermissive` for a similar case? Also it > seems

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

russell.gallop added a comment. Thanks for this change. I applied this patch (prior to splitting out https://reviews.llvm.org/D70568) and it built and worked okay (I only see one clang-cl in process explorer). I don't see anything like same performance improvement however. I did my own assessm

[PATCH] D70071: [ConstExprPreter] Removed the flag forcing the use of the interpreter

nand added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70071/new/ https://reviews.llvm.org/D70071 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D70588: Don't report "main" as missing a prototype in freestanding mode

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70588/new/ https://reviews.llvm.org/D70588

[PATCH] D69840: [Basic] Make SourceLocation usable as key in hash maps, NFCI

miyuki added a comment. ping^2 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69840/new/ https://reviews.llvm.org/D69840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D70554: [libTooling] Add stencil combinators for nodes that may be pointers or values.

ymandel marked 5 inline comments as done. ymandel added a comment. Thanks for the review! Comment at: clang/include/clang/Tooling/Transformer/Stencil.h:96 +// Constructs an expression that idiomatically represents a value, taking into +// account whether `ExprId` is a pointer o

[PATCH] D70554: [libTooling] Add stencil combinators for nodes that may be pointers or values.

ymandel updated this revision to Diff 230647. ymandel added a comment. fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70554/new/ https://reviews.llvm.org/D70554 Files: clang/include/clang/Tooling/Transformer/Stencil.h clang/lib/Tooling

[PATCH] D70554: [libTooling] Add stencil combinators for nodes that may be pointers or values.

ymandel updated this revision to Diff 230646. ymandel added a comment. renamed combinators; reordered cases to pair x and maybeX. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70554/new/ https://reviews.llvm.org/D70554 Files: clang/include/clang

[PATCH] D70554: [libTooling] Add stencil combinators for nodes that may be pointers or values.

gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang/include/clang/Tooling/Transformer/Stencil.h:90 +/// If \p ExprId is of pointer type, constructs an idiomatic dereferencing of +/// the expression bound to \p ExprId, including wrapping it in

[PATCH] D70554: [libTooling] Add stencil combinators for nodes that may be pointers or values.

gribozavr2 marked an inline comment as done. gribozavr2 added inline comments. Comment at: clang/include/clang/Tooling/Transformer/Stencil.h:96 +// Constructs an expression that idiomatically represents a value, taking into +// account whether `ExprId` is a pointer or already a v

[PATCH] D69282: [RFC] Add a VCS conflict marker format printing on tooling::ReplacementError

jdemeule added a reviewer: ioeric. jdemeule added a comment. Kindly ping reviewers and adding Eric as you were interested last year about that. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69282/new/ https://reviews.llvm.org/D69282 __

[PATCH] D69475: [clang] Provide better fix-it on exception spec error

jdemeule added a comment. Kindly ping reviewer. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69475/new/ https://reviews.llvm.org/D69475 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D70485: [ARM,MVE] Add intrinsics to deal with predicates.

dmgreen accepted this revision. dmgreen added a comment. Thanks. I'm still happy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70485/new/ https://reviews.llvm.org/D70485 ___ cfe-commits mailing list c

[clang] 26fa9e3 - Add support to find out resource dir and add it as compilation args

Author: Kousik Kumar Date: 2019-11-22T07:43:54-08:00 New Revision: 26fa9e31f58a7ff693f3a5d8c2eb1b6a5a13b133 URL: https://github.com/llvm/llvm-project/commit/26fa9e31f58a7ff693f3a5d8c2eb1b6a5a13b133 DIFF: https://github.com/llvm/llvm-project/commit/26fa9e31f58a7ff693f3a5d8c2eb1b6a5a13b133.diff

[PATCH] D69122: Add support to find out resource dir and add it as compilation args

This revision was automatically updated to reflect the committed changes. Closed by commit rG26fa9e31f58a: Add support to find out resource dir and add it as compilation args (authored by kousikk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69122/

[PATCH] D62574: Initial draft of target-configurable address spaces.

ebevhan marked 2 inline comments as done. ebevhan added a comment. Sorry for the very late response on this. Hope it's not completely off your radar. Comment at: include/clang/AST/ASTContext.h:2598 + /// Returns true if address space A overlaps with B. + bool isAddressSpaceO

[clang] 6f7c876 - [OPENMP]Fix behaviour of defaultmap for OpenMP 4.5.

Author: Alexey Bataev Date: 2019-11-22T11:26:09-05:00 New Revision: 6f7c8760a5c01edaa8e9c8e48940e1b8a7aa4128 URL: https://github.com/llvm/llvm-project/commit/6f7c8760a5c01edaa8e9c8e48940e1b8a7aa4128 DIFF: https://github.com/llvm/llvm-project/commit/6f7c8760a5c01edaa8e9c8e48940e1b8a7aa4128.diff

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

aprantl added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2925 +return C.getQualifiedType(T.getTypePtr(), Quals); + } case Type::DeducedTemplateSpecialization: { You need to mark this `LLVM_FALLTHROUGH` now or you'll get a war

[clang] 0b3d1d1 - [coroutines] Remove assert on CoroutineParameterMoves in Sema::buildCoroutineParameterMoves

Author: Brian Gesiak Date: 2019-11-22T11:39:13-05:00 New Revision: 0b3d1d1348da78c8b12e89f138577b0a8ffd4b2f URL: https://github.com/llvm/llvm-project/commit/0b3d1d1348da78c8b12e89f138577b0a8ffd4b2f DIFF: https://github.com/llvm/llvm-project/commit/0b3d1d1348da78c8b12e89f138577b0a8ffd4b2f.diff

[PATCH] D69022: [coroutines] Remove assert on CoroutineParameterMoves in Sema::buildCoroutineParameterMoves

This revision was automatically updated to reflect the committed changes. Closed by commit rG0b3d1d1348da: [coroutines] Remove assert on CoroutineParameterMoves in Sema… (authored by modocache). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69022/new

[PATCH] D69022: [coroutines] Remove assert on CoroutineParameterMoves in Sema::buildCoroutineParameterMoves

modocache added a comment. Thanks again for the patch @junparser! And sorry the review took so long! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69022/new/ https://reviews.llvm.org/D69022 ___ cfe-com

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

probinson added inline comments. Comment at: llvm/test/DebugInfo/X86/debug-info-auto-return.ll:30 +; CHECK: DW_TAG_subprogram [7] * +; CHECK-NEXT: DW_AT_linkage_name [DW_FORM_strx1](indexed (0007) string = "_ZN7myClass7findMaxEv") +; CHECK: DW_AT_type [DW_FORM_ref4] {{.

[PATCH] D70368: [clang-tidy] Rewrite modernize-avoid-bind check

zturner updated this revision to Diff 230661. zturner added a comment. Addressed suggestions from @Eugene.Zelenko CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70368/new/ https://reviews.llvm.org/D70368 Files: clang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp clang-tools-ex

[clang] 5459a90 - [OPENMP]Simplify processing of context selectors, NFC.

Author: Alexey Bataev Date: 2019-11-22T11:53:06-05:00 New Revision: 5459a905c23c03fad68e80b2dff23ca1ca3b7c7c URL: https://github.com/llvm/llvm-project/commit/5459a905c23c03fad68e80b2dff23ca1ca3b7c7c DIFF: https://github.com/llvm/llvm-project/commit/5459a905c23c03fad68e80b2dff23ca1ca3b7c7c.diff

[PATCH] D70368: [clang-tidy] Rewrite modernize-avoid-bind check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:194 + The check now supports supports diagnosing and fixing arbitrary callables instead of + only simple free functions. The ``PermissiveParameterList`` option has also been + added to

[PATCH] D70470: [analyzer] Add FuchsiaHandleCheck to catch handle leaks, use after frees and double frees

xazax.hun updated this revision to Diff 230668. xazax.hun added a comment. - Fix member operator modeling. - Added new lines to the end of files. - Added documentation. - Minor typo fixes in tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70470/new/ https://reviews.llvm.org/D70470

[PATCH] D70572: [Serialization] #pragma clang transform

Meinersbur updated this revision to Diff 230670. Meinersbur added a comment. - Remove some leftovers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70572/new/ https://reviews.llvm.org/D70572 Files: clang/include/clang/Serialization/ASTBitCodes.h

[PATCH] D70551: [clang-offload-wrapper] Add data layout to the wrapper bitcode

sdmitriev added a comment. Ok, it is possible to do it like you suggested, but I think that teaching wrapper tool to set data layout without external help is more preferable. There is a certain difference between opt and wrapper tool – opt works on the existing .bc that is provided in command l

[PATCH] D69180: [Format] Add format check for coroutine keywords with negative numbers

jonathoma added a comment. @modocache Feel free to commit from my end! Thanks again :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69180/new/ https://reviews.llvm.org/D69180 ___ cfe-commits mailing l

[PATCH] D70551: [clang-offload-wrapper] Add data layout to the wrapper bitcode

ABataev added a comment. In D70551#1756997 , @sdmitriev wrote: > Ok, it is possible to do it like you suggested, but I think that teaching > wrapper tool to set data layout without external help is more preferable. > There is a certain difference between

[clang] 01e8dd2 - [libTooling] Add stencil combinators for nodes that may be pointers or values.

Author: Yitzhak Mandelbaum Date: 2019-11-22T12:36:40-05:00 New Revision: 01e8dd2e7a852794a60e50f356f171f893503598 URL: https://github.com/llvm/llvm-project/commit/01e8dd2e7a852794a60e50f356f171f893503598 DIFF: https://github.com/llvm/llvm-project/commit/01e8dd2e7a852794a60e50f356f171f893503598.

[PATCH] D70554: [libTooling] Add stencil combinators for nodes that may be pointers or values.

This revision was automatically updated to reflect the committed changes. ymandel marked an inline comment as done. Closed by commit rG01e8dd2e7a85: [libTooling] Add stencil combinators for nodes that may be pointers or values. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D70603: Change while to do-while

pi1024e created this revision. pi1024e added a project: LLVM. Herald added a project: clang. Herald added a subscriber: cfe-commits. pi1024e added a reviewer: llvm.org. pi1024e edited reviewers, added: modocache, sammccall, Quuxplusone; removed: llvm.org. The assert statement says that the locati

[PATCH] D61837: Make it possible control matcher traversal kind with ASTContext

steveire updated this revision to Diff 230678. steveire added a comment. Rebase and update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61837/new/ https://reviews.llvm.org/D61837 Files: clang/include/clang/AST/ASTContext.h clang/include/clang

[PATCH] D70551: [clang-offload-wrapper] Add data layout to the wrapper bitcode

sdmitriev added a comment. I would agree with you if data layout was indeed available in the driver, but unfortunately driver does not have access to any existing TargetInfo instance (or maybe I just have not found it). So, I have to create TargetInfo and build data layout even for the case whe

[PATCH] D70551: [clang-offload-wrapper] Add data layout to the wrapper bitcode

ABataev added a comment. In D70551#1757065 , @sdmitriev wrote: > I would agree with you if data layout was indeed available in the driver, but > unfortunately driver does not have access to any existing TargetInfo instance > (or maybe I just have not fou

[PATCH] D70603: Change while to do-while

lebedev.ri added a comment. Missing a test; please upload all patches with full context (`-U9`) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70603/new/ https://reviews.llvm.org/D70603 ___ cfe-comm

[PATCH] D70605: [OpenCL] Fix address space for implicit conversion (PR43145)

svenvh created this revision. svenvh added reviewers: Anastasia, rjmccall. Herald added a subscriber: yaxunl. Clang was creating a `DerivedToBase` `ImplicitCastExpr` that was also casting between address spaces as part of the second step in the standard conversion sequence. Defer the address spac

[PATCH] D70603: Change while to do-while

pi1024e added a comment. What do you mean? I test compiled this and there are no errors after running the test benchmark. Was I supposed to do something else? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70603/new/ https://reviews.llvm.org/D70603

[PATCH] D70603: Change while to do-while

xbolva00 added a comment. This is fine as NFC/NFCI patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70603/new/ https://reviews.llvm.org/D70603 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D70551: [clang-offload-wrapper] Add data layout to the wrapper bitcode

sdmitriev added a comment. Wrapper tool is invoked at link phase, therefore there just could be no .bc files available to read data layout from. Ok, looks like there is no good solution for the data layout problem, so I will drop the idea of passing wrapper .bc directly to the linker when LTO i

[PATCH] D70537: [clang] CGDebugInfo asserts `!DT.isNull()` when compiling with debug symbols

vsk requested changes to this revision. vsk added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1437 +if (isa(V)) + continue; + I see that we don't attempt to handle `VarTemplateSpec

[clang-tools-extra] e1e7b6f - [clang-include-fixer] Suppress cmd prompt from Vim on Windows

Author: Reid Kleckner Date: 2019-11-22T11:28:42-08:00 New Revision: e1e7b6f381a9a5640605fdc4a3e78eb01f8fc8b9 URL: https://github.com/llvm/llvm-project/commit/e1e7b6f381a9a5640605fdc4a3e78eb01f8fc8b9 DIFF: https://github.com/llvm/llvm-project/commit/e1e7b6f381a9a5640605fdc4a3e78eb01f8fc8b9.diff

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

aprantl added inline comments. Comment at: llvm/test/DebugInfo/X86/debug-info-auto-return.ll:1 +;RUN: %llc_dwarf %s -filetype=obj -o - | llvm-dwarfdump -v - | FileCheck %s + I don't think the FORMs are relevant for this test, so we can do without the `-v` CHAN

[PATCH] D70368: [clang-tidy] Rewrite modernize-avoid-bind check

Eugene.Zelenko added a comment. Please mark addressed comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70368/new/ https://reviews.llvm.org/D70368 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D70518: [clang-include-fixer] Suppress cmd prompt from Vim on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rGe1e7b6f381a9: [clang-include-fixer] Suppress cmd prompt from Vim on Windows (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70518/new/ http

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

dblaikie added a comment. Generally if you're not touching LLVM code, I would suggest not adding an LLVM test - unless this is new or surprising usage of existing LLVM functionality (or the functionality was otherwise undertested in LLVM previously). But I'm guessing that's not the case here?

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

dblaikie added a comment. In D70111#1754702 , @awpandey wrote: > I am considering this > > - Will commit this without C bindings > - will give separate patch for C bindings and release notes (if necessary). > - will give another patch for Go bindings and r

[PATCH] D69620: Add AIX assembler support

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:37 + + // Specify the mode in which the as command operates. + if (IsArch32Bit) { Refer to the other comment regarding confusion of "as" with the English word. =

[PATCH] D70411: [analyzer] CERT: StrChecker: 31.c

Charusso added a comment. Now I have simplified the checker so we do not need any ASCII-art, I believe. Do we have any better logic than the current implementation to catch when the string is read? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70411/new/ https://reviews.llvm.org/D7041

[PATCH] D70411: [analyzer] CERT: StrChecker: 31.c

Charusso updated this revision to Diff 230702. Charusso marked an inline comment as done. Charusso retitled this revision from "[analyzer][WIP] CERT: StrChecker: 31.c" to "[analyzer] CERT: StrChecker: 31.c". Charusso added a comment. - Remove the report storing map so we do not traverse backwards

[PATCH] D70342: [Diagnostics] Put "deprecated copy" warnings into -Wdeprecated-copy

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good to me - can handle anything else from @rsmith in post-commit review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70342/new/ htt

[PATCH] D70342: [Diagnostics] Put "deprecated copy" warnings into -Wdeprecated-copy

xbolva00 added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70342/new/ https://reviews.llvm.org/D70342 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D70613: Add method to ignore invisible AST nodes

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D70613 Files: clang/include/clang/AST/ASTNodeTraverser.h clang/include/clang/

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

aprantl added a comment. In D70524#1757237 , @dblaikie wrote: > Generally if you're not touching LLVM code, I would suggest not adding an > LLVM test - unless this is new or surprising usage of existing LLVM > functionality (or the functionality was othe

[PATCH] D67149: Fix argument order for BugType instation for

NoQ added a comment. Ah, the good old "stringly typed" APIs. Would you like to write a LIT test for the fix, say by `FileCheck`ing the Plist output? (i could write one for you if it's not your cup of tea) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67149/new/

[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang Tidy's script

NoQ added a comment. In D69746#1756448 , @gribozavr2 wrote: > > This patch introduces a way to apply the fix-its by the Analyzer: > > I'm not sure this option is very useful... I don't know of anyone who uses > the same option in Clang or ClangTidy. The o

[PATCH] D70467: [Distro] Bypass distro detection on non-Linux hosts

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. In D70467#1755364 , @aganea wrote: > Actually, I'm not sure the `DetectDistro()` does what it intends to do when > cross-compiling: if I compile on Ubuntu an

[clang] e0f22fe - [RISCV] Use compiler-rt if no GCC installation detected

Author: Edward Jones Date: 2019-11-22T20:05:29Z New Revision: e0f22fe04a5c9eb244ff0533549743b7deb03b99 URL: https://github.com/llvm/llvm-project/commit/e0f22fe04a5c9eb244ff0533549743b7deb03b99 DIFF: https://github.com/llvm/llvm-project/commit/e0f22fe04a5c9eb244ff0533549743b7deb03b99.diff LOG:

[clang] 0c7a1c0 - [OPENMP] [DOCS] correct status for use_device_addr clause

Author: Kelvin Li Date: 2019-11-22T15:32:40-05:00 New Revision: 0c7a1c0cfc2a4e5b8b7f3920b2797c12963b8384 URL: https://github.com/llvm/llvm-project/commit/0c7a1c0cfc2a4e5b8b7f3920b2797c12963b8384 DIFF: https://github.com/llvm/llvm-project/commit/0c7a1c0cfc2a4e5b8b7f3920b2797c12963b8384.diff LOG

[PATCH] D68407: [RISCV] Use compiler-rt if no GCC installation detected

This revision was automatically updated to reflect the committed changes. Closed by commit rGe0f22fe04a5c: [RISCV] Use compiler-rt if no GCC installation detected (authored by edward-jones). Changed prior to commit: https://reviews.llvm.org/D68407?vs=229284&id=230708#toc Repository: rG LLVM

[PATCH] D70608: [OPENMP] [DOCS] correct status for use_device_addr clause

This revision was automatically updated to reflect the committed changes. Closed by commit rG0c7a1c0cfc2a: [OPENMP] [DOCS] correct status for use_device_addr clause (authored by kkwli0). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D70071: [ConstExprPreter] Removed the flag forcing the use of the interpreter

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70071/new/ https://reviews.llvm.org/D70071 _

[clang] 9180f8a - Don't report "main" as missing a prototype in freestanding mode

Author: Bill Wendling Date: 2019-11-22T12:35:43-08:00 New Revision: 9180f8a57436da0ce91d9d4885702a10f89571bc URL: https://github.com/llvm/llvm-project/commit/9180f8a57436da0ce91d9d4885702a10f89571bc DIFF: https://github.com/llvm/llvm-project/commit/9180f8a57436da0ce91d9d4885702a10f89571bc.diff

[PATCH] D70588: Don't report "main" as missing a prototype in freestanding mode

This revision was automatically updated to reflect the committed changes. Closed by commit rG9180f8a57436: Don't report "main" as missing a prototype in freestanding mode (authored by void). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70588/new/ h

  1   2   >