sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land.
Great, thanks for fixing this! ================ Comment at: clang/test/CodeCompletion/lambdas.cpp:66 + auto my_lambda = [&](int a, double &b) { return 1.f; }; + my_ + // RUN: %clang_cc1 -fsyntax-only -code-completion-at=%s:66:5 %s -o - | FileCheck -check-prefix=CHECK-9 %s ---------------- nit: often preferable to make the examples valid syntax (and set code completion point to interrupt it, to avoid different tests interfering with each other. (Here the my_ prefix isn't needed - plain completion on an empty line will yield the result you want) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70445/new/ https://reviews.llvm.org/D70445 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits