[clang-tools-extra] 339502c - [clangd] Reland b5135a86e0476: Fix a crash in expected types

Author: Ilya Biryukov Date: 2019-11-21T09:46:40+01:00 New Revision: 339502cc8abb375e3dc8b5d3e9ef35c2541ccbbd URL: https://github.com/llvm/llvm-project/commit/339502cc8abb375e3dc8b5d3e9ef35c2541ccbbd DIFF: https://github.com/llvm/llvm-project/commit/339502cc8abb375e3dc8b5d3e9ef35c2541ccbbd.diff

[PATCH] D70480: [clangd] Use expansion location when the ref is inside macros.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:280 (Roles & static_cast(index::SymbolRole::Reference)) && - SM.getFileID(SpellingLoc) == SM.getMainFileID()) + SM.getFileID(SM.getSpellingLoc(Loc)) == SM.getMainF

[PATCH] D70480: [clangd] Use expansion location when the ref is inside macros.

ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp:659 + TYPE(TYPE([[Foo]])) foo3; + [[CAT]](Fo, o) foo4; +} Previously we would not report any

[PATCH] D70481: [clangd] Fix a crash in expected types

ilya-biryukov added a comment. Relanded in 339502cc8abb375e3dc8b5d3e9ef35c2541ccbbd . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70481/new/ https://reviews.llvm.org/D70481

[clang] df876a0 - [RISCV] Support mutilib in baremetal environment

Author: Zakk Chen Date: 2019-11-21T01:13:41-08:00 New Revision: df876a026981b7a125b31bbb85ba4b1144edb0f9 URL: https://github.com/llvm/llvm-project/commit/df876a026981b7a125b31bbb85ba4b1144edb0f9 DIFF: https://github.com/llvm/llvm-project/commit/df876a026981b7a125b31bbb85ba4b1144edb0f9.diff LOG

[PATCH] D70440: [Driver] Use VFS to check if sanitizer blacklists exist

kadircet added inline comments. Comment at: clang/unittests/Driver/SanitizerArgsTest.cpp:37 + +static constexpr const char *ClangPath = "/opt/llvm/bin/clang"; +static constexpr const char *InputFile = "/sources/foo.c"; can't this be just `clang` ? as we are passi

[PATCH] D70445: [clangd] Show lambda signature for lambda autocompletions

kbobyrev updated this revision to Diff 230387. kbobyrev marked 12 inline comments as done. kbobyrev added a comment. Add initial support for generic lambdas, put more tests into `clang/test/CodeCompletion`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70445/new/ https://reviews.llvm.o

[PATCH] D70445: [clangd] Show lambda signature for lambda autocompletions

kbobyrev added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:3335 +return nullptr; + const auto *LambdaType = VD->getType().getTypePtr(); + if (const auto *SugaredType = dyn_cast(LambdaType)) sammccall wrote: > VD->getType()->getAsCXXReco

[PATCH] D68912: Adds -Wrange-loop-analysis to -Wall

xbolva00 added a comment. I think you can commit it, you already fixed some warnings. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68912/new/ https://reviews.llvm.org/D68912 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D70342: [Diagnostics] Put "deprecated copy" warnings into -Wdeprecated-copy

xbolva00 added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70342/new/ https://reviews.llvm.org/D70342 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D70527: [clang] Fix the canonicalization of paths in -fdiagnostics-absolute-paths

Ka-Ka created this revision. Ka-Ka added reviewers: rsmith, hans, rnk, ikudrin. Herald added a project: clang. In the current implementation of clang the canonicalization of paths in diagnostic messages (when using -fdiagnostics-absolute-paths) only works if the symbolic link is in the directory p

[PATCH] D70440: [Driver] Use VFS to check if sanitizer blacklists exist

ilya-biryukov updated this revision to Diff 230394. ilya-biryukov marked 7 inline comments as done. ilya-biryukov added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70440/new/ https://reviews.llvm.org/D70440 Files:

[PATCH] D70440: [Driver] Use VFS to check if sanitizer blacklists exist

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang/unittests/Driver/SanitizerArgsTest.cpp:89 +return FS; + }; + llvm::Optional Driver; nit: semicolon Repository: rG LLV

[PATCH] D69608: [clangd] Helper for getting nested namespace qualification

ilya-biryukov added a comment. Just NITs about various comments and requests to optimize the code a bit. The code itself LG, thanks! Comment at: clang-tools-extra/clangd/AST.cpp:77 +llvm::DenseSet +getUsingNamespceDirectives(const DeclContext *DestContext, +

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

awpandey added a comment. I am considering this - Will commit this without C bindings - will give separate patch for C bindings and release notes (if necessary). - will give another patch for Go bindings and release notes (if necessary). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D70440: [Driver] Use VFS to check if sanitizer blacklists exist

ilya-biryukov updated this revision to Diff 230397. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Remove redundant semicolon Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70440/new/ https://reviews.llvm.org/D70440

[clang] ba6f906 - [Driver] Use VFS to check if sanitizer blacklists exist

Author: Ilya Biryukov Date: 2019-11-21T11:00:30+01:00 New Revision: ba6f906854263375cff3257d22d241a8a259cf77 URL: https://github.com/llvm/llvm-project/commit/ba6f906854263375cff3257d22d241a8a259cf77 DIFF: https://github.com/llvm/llvm-project/commit/ba6f906854263375cff3257d22d241a8a259cf77.diff

[PATCH] D70528: [NFC] ASSERT_EQ before accessing items in containers

kbobyrev created this revision. kbobyrev added a reviewer: ilya-biryukov. kbobyrev added a project: clang-tools-extra. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. As discussed offline, `ASSERT_EQ` should be used to check if the cont

[PATCH] D70440: [Driver] Use VFS to check if sanitizer blacklists exist

This revision was automatically updated to reflect the committed changes. Closed by commit rGba6f90685426: [Driver] Use VFS to check if sanitizer blacklists exist (authored by ilya-biryukov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70440/new/

[PATCH] D70439: [Analyzer][Docs][NFC] Add CodeChecker to the command line tools

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. For reasons other than being a part of the project, CodeChecker is objectively an amazing tool to use with the analyzer. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 9f3fdb0 - Revert "[Driver] Use VFS to check if sanitizer blacklists exist"

Author: Ilya Biryukov Date: 2019-11-21T11:31:14+01:00 New Revision: 9f3fdb0d7fab73083e354768eb5808597474e1b8 URL: https://github.com/llvm/llvm-project/commit/9f3fdb0d7fab73083e354768eb5808597474e1b8 DIFF: https://github.com/llvm/llvm-project/commit/9f3fdb0d7fab73083e354768eb5808597474e1b8.diff

[clang] 5cf5876 - Atomics: support min/max orthogonally

Author: Tim Northover Date: 2019-11-21T10:37:56Z New Revision: 5cf58768cb3ba31ee37facaf23f7a74f78781590 URL: https://github.com/llvm/llvm-project/commit/5cf58768cb3ba31ee37facaf23f7a74f78781590 DIFF: https://github.com/llvm/llvm-project/commit/5cf58768cb3ba31ee37facaf23f7a74f78781590.diff LOG:

[clang] 35388dc - [OpenCL] Fix address space for base method call (PR43145)

Author: Sven van Haastregt Date: 2019-11-21T10:39:33Z New Revision: 35388dcbbc4ce6ce7125f718b3050be33c339464 URL: https://github.com/llvm/llvm-project/commit/35388dcbbc4ce6ce7125f718b3050be33c339464 DIFF: https://github.com/llvm/llvm-project/commit/35388dcbbc4ce6ce7125f718b3050be33c339464.diff

[PATCH] D55562: Atomics: support min/max orthogonally

t.p.northover closed this revision. t.p.northover added a comment. Thanks JF. Finally pushed it today: To github.com:llvm/llvm-project.git 9f3fdb0d7fab..5cf58768cb3b master -> master Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55562/new/ https://reviews.ll

[PATCH] D69810: [OpenCL] Fix address space for base method call (PR43145)

This revision was automatically updated to reflect the committed changes. Closed by commit rG35388dcbbc4c: [OpenCL] Fix address space for base method call (PR43145) (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69810/new/ https

[clang] aa981c1 - Reland 9f3fdb0d7fab: [Driver] Use VFS to check if sanitizer blacklists exist

Author: Ilya Biryukov Date: 2019-11-21T11:56:09+01:00 New Revision: aa981c1802d7353c777e399f2568e5a0e12dea21 URL: https://github.com/llvm/llvm-project/commit/aa981c1802d7353c777e399f2568e5a0e12dea21 DIFF: https://github.com/llvm/llvm-project/commit/aa981c1802d7353c777e399f2568e5a0e12dea21.diff

[PATCH] D69033: [clangd] Improve symbol qualification in DefineInline code action

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp:200 +std::string Qualifier; +// FIXME: Also take using directives and namespace aliases inside function +// body into account. kadircet wrote: >

[PATCH] D70440: [Driver] Use VFS to check if sanitizer blacklists exist

teemperor added a comment. FYI, this doesn't compile, see: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/10890 (and probably all other build bots that are starting to break). FAILED: tools/sancov/CMakeFiles/sancov.dir/sancov.cpp.o

[PATCH] D70528: [NFC] ASSERT_EQ before accessing items in containers

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:1877 -EXPECT_EQ(Results.Completions.size(), 1u); +ASSERT_EQ(Results.Completions.size(), 1u); EXPECT_THAT(Results.Completions.front().CompletionTokenRange,

[PATCH] D68682: format::cleanupAroundReplacements removes whole line when Removals leave previously non-blank line blank

kadircet added a comment. `ToolingTests/ApplyAtomicChangesTest.FormatsCorrectLineWhenHeaderIsRemoved` also seems to be failing, you can run it with `ninja ToolingTests && ./tools/clang/unittests/Tooling/ToolingTests --gtest_filter="ApplyAtomicChangesTest.FormatsCorrectLineWhenHeaderIsRemoved"`

[PATCH] D70528: [NFC] ASSERT_EQ before accessing items in containers

kbobyrev updated this revision to Diff 230412. kbobyrev marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70528/new/ https://reviews.llvm.org/D70528 Files: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp clang-tools-extra/clangd/unittests/Diagno

[PATCH] D70528: [NFC] ASSERT_EQ before accessing items in containers

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM, but please update the other diff as well! Comment at: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:712 for (const auto &D : Parsed.getDiagno

[PATCH] D69033: [clangd] Improve symbol qualification in DefineInline code action

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:1730 +TEST_F(DefineInlineTest, DropCommonNamespecifiers) { + struct { NIT: capitalize the last word: `DropCommonNameSpecifiers` Repository: rG LLVM Github Mo

[PATCH] D70440: [Driver] Use VFS to check if sanitizer blacklists exist

ilya-biryukov added a comment. @teemperor Sorry for the trouble. I did not run LLVM tests, so had to revert the change. Was reverted in 9f3fdb0d7fab73083e354768eb5808597474e1b8 and relanded as aa981c1802d7353c777e399f2568e5a

[PATCH] D69033: [clangd] Improve symbol qualification in DefineInline code action

ilya-biryukov accepted this revision. ilya-biryukov added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:1865 +)cpp"; + // FIXME: The last reference to cux() in body of foo should not be qualifi

[PATCH] D70440: [Driver] Use VFS to check if sanitizer blacklists exist

teemperor added a comment. Thanks for the quick fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70440/new/ https://reviews.llvm.org/D70440 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

serge-sans-paille added a comment. In D61446#1681841 , @Meinersbur wrote: > Keep in mind that for static linking you will need something that pulls-in a > symbol from the pass static library. In this patch, `NewPMDriver.cpp` does it > for `opt` by callin

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

serge-sans-paille updated this revision to Diff 230415. serge-sans-paille marked an inline comment as done. serge-sans-paille added a comment. Take into account most of the reviews. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61446/new/ https://r

[PATCH] D70528: [NFC] ASSERT_EQ before accessing items in containers

kbobyrev updated this revision to Diff 230416. kbobyrev marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70528/new/ https://reviews.llvm.org/D70528 Files: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp clang-tools-extra/clangd/unittests/Diagno

[clang] 2e298a6 - [Driver] Fix a shadowing warning. NFC

Author: Ilya Biryukov Date: 2019-11-21T12:21:20+01:00 New Revision: 2e298a6a51065a25240d15872cb350e0761ea04d URL: https://github.com/llvm/llvm-project/commit/2e298a6a51065a25240d15872cb350e0761ea04d DIFF: https://github.com/llvm/llvm-project/commit/2e298a6a51065a25240d15872cb350e0761ea04d.diff

[PATCH] D70528: [NFC] ASSERT_EQ before accessing items in containers

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:713 +if (D.Fixes.size() != 1) { + ADD_FAILURE() << "D.Fixes.size() != 1"; +} add `continue`! CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D69608: [clangd] Helper for getting nested namespace qualification

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM when the comments are addressed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69608/new/ https://reviews.llvm.org/D69608 _

[PATCH] D70528: [NFC] ASSERT_EQ before accessing items in containers

kbobyrev updated this revision to Diff 230417. kbobyrev marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70528/new/ https://reviews.llvm.org/D70528 Files: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp clang-tools-extra/clangd/unittests/Diagno

[clang] 013f4ba - Fix Wshadow warning against global None variable. NFC.

Author: Simon Pilgrim Date: 2019-11-21T12:08:00Z New Revision: 013f4ba9c21f91accc516e5a70c70efc69d92b69 URL: https://github.com/llvm/llvm-project/commit/013f4ba9c21f91accc516e5a70c70efc69d92b69 DIFF: https://github.com/llvm/llvm-project/commit/013f4ba9c21f91accc516e5a70c70efc69d92b69.diff LOG:

[PATCH] D69938: [OpenCL] Use __generic addr space when generating internal representation of lambda

Anastasia added a comment. In D69938#1752024 , @rjmccall wrote: > Yes, in that case copy-elision into the global variable is guaranteed. You > can write arbitrary expressions in global initializers, however, and those > can use temporary lambdas. I gu

[clang] bdb1f1d - Revert "[RISCV] Support mutilib in baremetal environment"

Author: Zakk Chen Date: 2019-11-21T04:34:56-08:00 New Revision: bdb1f1dcb9f1164b9df6b49eea7b38e16574bdf2 URL: https://github.com/llvm/llvm-project/commit/bdb1f1dcb9f1164b9df6b49eea7b38e16574bdf2 DIFF: https://github.com/llvm/llvm-project/commit/bdb1f1dcb9f1164b9df6b49eea7b38e16574bdf2.diff LOG

[PATCH] D69608: [clangd] Helper for getting nested namespace qualification

kadircet marked 14 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:330 + [&](NestedNameSpecifier *NNS) { +return llvm::any_of( +VisibleNamesp

[PATCH] D69608: [clangd] Helper for getting nested namespace qualification

kadircet updated this revision to Diff 230423. kadircet marked 14 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69608/new/ https://reviews.llvm.org/D69608 Files: clang-tools-e

[PATCH] D69033: [clangd] Improve symbol qualification in DefineInline code action

kadircet updated this revision to Diff 230424. kadircet marked 4 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69033/new/ https://reviews.llvm.org/D69033 Files: clang-tools-ex

[PATCH] D70390: [clang-tidy] new performance-no-automatic-move check.

courbet updated this revision to Diff 230428. courbet marked 2 inline comments as done. courbet added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70390/new/ https://reviews.llvm.org/D70390 Files: clang-tools-extra/

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

lenary added a comment. Re-applied with typo fix in rGdf876a026981 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67508/new/ https://reviews.llvm.org/D67508 _

[PATCH] D69608: [clangd] Helper for getting nested namespace qualification

merge_guards_bot added a comment. Build result: pass - 60224 tests passed, 0 failed and 732 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70518: [clang-include-fixer] Suppress cmd prompt from Vim on Windows

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70518/new/ https://reviews.llvm.org/D70518 ___

[PATCH] D70535: [clangd] Define out-of-line qualify return value

kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. kadircet added a parent revision: D69298: [clangd] Define out-of-line initial apply logic. Return type mi

[clang-tools-extra] c63f1b1 - [DeclCXX] Remove unknown external linkage specifications

Author: Ehud Katz Date: 2019-11-21T15:23:05+02:00 New Revision: c63f1b160eb68cfac30113f259abae508d8be798 URL: https://github.com/llvm/llvm-project/commit/c63f1b160eb68cfac30113f259abae508d8be798 DIFF: https://github.com/llvm/llvm-project/commit/c63f1b160eb68cfac30113f259abae508d8be798.diff LOG

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

This revision was automatically updated to reflect the committed changes. Closed by commit rGc63f1b160eb6: [DeclCXX] Remove unknown external linkage specifications (authored by ekatz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69935/new/ https:/

[PATCH] D70535: [clangd] Define out-of-line qualify return value

kadircet updated this revision to Diff 230439. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70535/new/ https://reviews.llvm.org/D70535 Files: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp clang-

[PATCH] D69298: [clangd] Define out-of-line initial apply logic

kadircet updated this revision to Diff 230437. kadircet added a comment. - Get rid of raw string literals inside macros Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69298/new/ https://reviews.llvm.org/D69298 Files: clang-tools-extra/clangd/refa

[PATCH] D70537: [clang] CGDebugInfo asserts `!DT.isNull()` when compiling with debug symbols

kamleshbhalui created this revision. kamleshbhalui added reviewers: rsmith, dblaikie, vsk. kamleshbhalui added a project: debug-info. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes this assert failure. Which occured due to deduction of auto type of templated variabl

[PATCH] D70537: [clang] CGDebugInfo asserts `!DT.isNull()` when compiling with debug symbols

kamleshbhalui updated this revision to Diff 230444. kamleshbhalui added a comment. formatted the diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70537/new/ https://reviews.llvm.org/D70537 Files: clang/lib/CodeGen/CGDebugInfo.cpp Index: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D70445: [clangd] Show lambda signature for lambda autocompletions

sammccall added a comment. Behavior looks good, and I wouldn't extend it any further (other than to non-lambda functors someday). Implementation can be simplified a bit I think - see comment about the templated function codepath. (Would like to see one more round if that's OK, if I'm wrong abo

[PATCH] D70440: [Driver] Use VFS to check if sanitizer blacklists exist

merge_guards_bot added a comment. Build result: FAILURE - Log files: console-log.txt , CMakeCache.txt Repository: rG LLVM

[PATCH] D70539: [clang][CodeGen] Implicit Conversion Sanitizer: handle increment/derement (PR44054)

lebedev.ri created this revision. lebedev.ri added reviewers: rjmccall, erichkeane, rsmith, vsk. lebedev.ri added a project: LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits, dexonsmith, mehdi_amini. Herald added projects: clang, Sanitizers. Implicit Conversion Sanitizer is *

[clang] 103f3c9 - [OPENMP50]Add if clause in for simd directive.

Author: Alexey Bataev Date: 2019-11-21T09:29:12-05:00 New Revision: 103f3c9e3b3ce663b5451e321e3800e09f851b8a URL: https://github.com/llvm/llvm-project/commit/103f3c9e3b3ce663b5451e321e3800e09f851b8a DIFF: https://github.com/llvm/llvm-project/commit/103f3c9e3b3ce663b5451e321e3800e09f851b8a.diff

[PATCH] D70539: [clang][CodeGen] Implicit Conversion Sanitizer: handle increment/derement (PR44054)

erichkeane added a comment. I haven't looked at the tests because I don't terribly understand the sanitizer IR (hopefully someone else can take a look), but the logic/motivation seems solid to me. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2422 } else if (type->isInteg

[PATCH] D70539: [clang][CodeGen] Implicit Conversion Sanitizer: handle increment/derement (PR44054)

lebedev.ri added a comment. Thank you for taking a look! In D70539#1755121 , @erichkeane wrote: > I haven't looked at the tests because I don't terribly understand the > sanitizer IR (hopefully someone else can take a look), You can ignore the final IR

[PATCH] D70539: [clang][CodeGen] Implicit Conversion Sanitizer: handle increment/derement (PR44054)

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2424 +type->isPromotableIntegerType()) { + // While `x += 1` (for `x` with width less than int) is modelled as + // promotion+arithmetics+demotion, and we can catch lossy demotio

[PATCH] D69893: libunwind: Evaluating DWARF operation DW_OP_pick is broken

kamleshbhalui added a comment. @ldionne Can you please commit this for me. I do not have commit access. Repository: rUNW libunwind CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69893/new/ https://reviews.llvm.org/D69893 ___ cfe-commits m

[PATCH] D70485: [ARM,MVE] Add intrinsics to deal with predicates.

dmgreen added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsARM.td:780 def int_arm_vctp8 : Intrinsic<[llvm_v16i1_ty], [llvm_i32_ty], [IntrNoMem]>; def int_arm_vctp16 : Intrinsic<[llvm_v8i1_ty], [llvm_i32_ty], [IntrNoMem]>; Should we rename int_

[PATCH] D70390: [clang-tidy] new performance-no-automatic-move check.

JonasToth accepted this revision. JonasToth added a comment. This revision is now accepted and ready to land. LGTM after the variable names are adjusted Comment at: clang-tools-extra/clang-tidy/performance/NoAutomaticMoveCheck.cpp:32 + + const auto const_local_variable = +

[clang-tools-extra] d4e006e - Fix unused variable warning. NFCI.

Author: Simon Pilgrim Date: 2019-11-21T16:09:19Z New Revision: d4e006e84461bb98977388bd8742413d45c245c4 URL: https://github.com/llvm/llvm-project/commit/d4e006e84461bb98977388bd8742413d45c245c4 DIFF: https://github.com/llvm/llvm-project/commit/d4e006e84461bb98977388bd8742413d45c245c4.diff LOG:

[clang] 77d049d - [OPENMP]Fix datasharing checks for if clause in parallel taskloop

Author: Alexey Bataev Date: 2019-11-21T11:20:38-05:00 New Revision: 77d049d0c653798698fa24556115874828aae87b URL: https://github.com/llvm/llvm-project/commit/77d049d0c653798698fa24556115874828aae87b DIFF: https://github.com/llvm/llvm-project/commit/77d049d0c653798698fa24556115874828aae87b.diff

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

aprantl added a comment. Thanks! Couple of minor comments inline. Comment at: clang/test/CodeGenCXX/debug-info-auto-return.cpp:2 +// Test for debug info for C++11 auto return member functions +// Supported: -O0, standalone DI +// RUN: %clang_cc1 -dwarf-version=5 -emit-llvm -t

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

aprantl added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:822 + auto BTName = "auto"; + return DBuilder.createUnspecifiedType(BTName); +} ` DBuilder.createUnspecifiedType("auto")` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

aprantl added a comment. Sounds good to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70111/new/ https://reviews.llvm.org/D70111 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D70470: [analyzer] Add FuchsiaHandleCheck to catch handle leaks, use after frees and double frees

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/FuchsiaHandleChecker.cpp:19-20 +// handle variable is passed to different function calls or syscalls, its state +// changes. The state changes can be general

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

CodaFi added a comment. C binding changes LGTM. Don’t worry about changing them, they are marked as experimental and subject to change at any time. Comment at: llvm/include/llvm-c/DebugInfo.h:878 LLVMMetadataRef File, unsigned LineNo, -

[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

jdoerfert marked 4 inline comments as done. jdoerfert added a comment. ping Comment at: llvm/include/llvm/Frontend/OpenMPIRBuilder.h:69-71 + void pushFinalizationCB(FinalizationInfo &&FI) { +FinalizationStack.emplace_back(std::move(FI)); + } jdoerfert wro

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69785/new/ https://reviews.llvm.org/D69785 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[clang] c4afc65 - Fix compilation warning. NFC.

Author: Michael Liao Date: 2019-11-21T12:07:13-05:00 New Revision: c4afc6566a64e6be3f77271781a147bb5ff98b0c URL: https://github.com/llvm/llvm-project/commit/c4afc6566a64e6be3f77271781a147bb5ff98b0c DIFF: https://github.com/llvm/llvm-project/commit/c4afc6566a64e6be3f77271781a147bb5ff98b0c.diff

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

ABataev added inline comments. Comment at: llvm/lib/Frontend/OpenMPIRBuilder.cpp:152-155 + std::string LineStr = std::to_string(DIL->getLine()); + std::string ColumnStr = std::to_string(DIL->getColumn()); + std::string SrcLocStr = (";" + Filename + ";" + Function).str() + ";"

[PATCH] D70485: [ARM,MVE] Add intrinsics to deal with predicates.

simon_tatham updated this revision to Diff 230468. simon_tatham marked an inline comment as done. simon_tatham added a comment. Made all the requested changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70485/new/ https://reviews.llvm.org/D70485

[PATCH] D70245: [OPENMP50]Add device/kind context selector support.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70245/new/ https://reviews.llvm.org/D70245

[PATCH] D70485: [ARM,MVE] Add intrinsics to deal with predicates.

simon_tatham added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsARM.td:780 def int_arm_vctp8 : Intrinsic<[llvm_v16i1_ty], [llvm_i32_ty], [IntrNoMem]>; def int_arm_vctp16 : Intrinsic<[llvm_v8i1_ty], [llvm_i32_ty], [IntrNoMem]>; dmgreen wrote: >

[PATCH] D70537: [clang] CGDebugInfo asserts `!DT.isNull()` when compiling with debug symbols

vsk added a comment. Could you add a regression test? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70537/new/ https://reviews.llvm.org/D70537 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D70539: [clang][CodeGen] Implicit Conversion Sanitizer: handle increment/derement (PR44054)

lebedev.ri added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2422 } else if (type->isIntegerType()) { -// Note that signed integer inc/dec with width less than int can't -// overflow because of promotion rules; we're just eliding a few steps here.

[PATCH] D70539: [clang][CodeGen] Implicit Conversion Sanitizer: handle increment/derement (PR44054)

lebedev.ri updated this revision to Diff 230469. lebedev.ri marked 7 inline comments as done. lebedev.ri added a comment. @erichkeane & @aaron.ballman thank you for taking a look. Addressed review notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D70467: [Distro] Bypass distro detection on Windows

aganea added a comment. In D70467#1752611 , @rnk wrote: > Hm, I guess it does happen. I think that condition should be restructured to > only do all that BSD, PS4, Android, Gentoo etc logic if the format is ELF, if > COFF, then always default to -faddrsi

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert marked 4 inline comments as done. jdoerfert added a comment. Anything else? Comment at: llvm/lib/Frontend/OpenMPIRBuilder.cpp:152-155 + std::string LineStr = std::to_string(DIL->getLine()); + std::string ColumnStr = std::to_string(DIL->getColumn()); + std::string S

[PATCH] D69091: [Sema] #pragma clang transform

Meinersbur added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69091/new/ https://reviews.llvm.org/D69091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D70467: [Distro] Bypass distro detection on Windows

aganea added a comment. Actually, I'm not sure the `DetectDistro()` does what it intends to do when cross-compiling: if I compile on Ubuntu and I forcibly specify `-target x86_64-linux` on the cmd-line, should it detect which Linux distro I'm on? Shouldn't it use the target triple, not the host

[PATCH] D70190: [clang][modules] Add support for merging lifetime-extended temporaries

Tyker added a comment. @rsmith ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70190/new/ https://reviews.llvm.org/D70190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D70544: Debug info: Emit objc_direct methods as members of their containing class

aprantl created this revision. aprantl added reviewers: MadCoder, JDevlieghere, vsk, friss. aprantl added a project: debug-info. Emit objc_direct methods as members of their containing class even in DWARF 4 and earlier. This allows the debugger to recognize them as direct functions as opposed t

[PATCH] D70545: [ARM][MVE][Intrinsics] Add MVE VABD intrinsics.

MarkMurrayARM created this revision. MarkMurrayARM added reviewers: simon_tatham, ostannard, dmgreen. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. Add MVE VABD intrinsics. Repository: rG LLVM Github Monorepo https://reviews

[PATCH] D52861: Driver: Prefer gcc toolchains with libgcc_s.so when not static linking libgcc

jdenny added a comment. This patch handles libgcc_s.so, but what about libatomic.so? It's also not provided by x86_64-linux-gnu, at least on CentOS Linux release 7.7.1908. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52861/new/ https://reviews.llvm.org/D52861

[PATCH] D70547: [ARM][MVE][Intrinsics] Add MVE VAND/VORR/VORN/VEOR/VBIC intrinsics.

MarkMurrayARM created this revision. MarkMurrayARM added reviewers: simon_tatham, ostannard, dmgreen. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. Add MVE VAND/VORR/VORN/VEOR/VBIC intrinsics. Repository: rG LLVM Github Monor

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

Tyker added a comment. @rsmith ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63960/new/ https://reviews.llvm.org/D63960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D70546: [ARM][MVE][Intrinsics] Add MVE VMUL intrinsics.

MarkMurrayARM created this revision. MarkMurrayARM added reviewers: simon_tatham, ostannard, dmgreen. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. Add MVE VMUL intrinsics. Repository: rG LLVM Github Monorepo https://reviews

[PATCH] D70549: [OPENMP]Fix PR41826: symbols visibility in device code.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added a subscriber: guansong. Herald added a project: clang. Currently, we ignore all locality attributes/info when building for the device and thus all symblos are externally visible and can be preemted at the runtime. It

[PATCH] D70544: Debug info: Emit objc_direct methods as members of their containing class

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM with two minor comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4729 - SmallVector EltTys; - auto CurrenetElts = InterfaceDecl->getElements(); - EltTys.append(CurrenetElts.begin(), C

  1   2   >