[PATCH] D70157: Align branches within 32-Byte boundary

skan added a comment. In D70157#1747428 , @davezarzycki wrote: > In D70157#1746793 , @MaskRay wrote: > > > On x86, the preferred function alignment is 16 > > (https://github.com/llvm/llvm-project/blob/arcpatch-D70

[PATCH] D70299: [clangd] Replace getLangOpts().isHeaderFile usage with isHeaderFile helper.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/FindSymbolsTests.cpp:181 TEST_F(WorkspaceSymbolsTest, AnonymousNamespace) { - addFile("foo.h", R"cpp( + // header

[PATCH] D70157: Align branches within 32-Byte boundary

xbolva00 added a comment. > Even though core2 isn't affected by the erratum, core2 code can run on CPUs > that do have the bug (and core2 is a popular target for code that needs to > run "everywhere"), therefore all target CPUs that predate a hardware fix > really So perf of all code/generic c

[PATCH] D70235: [clangd] Add isHeaderFile helper.

hokein added a comment. in case you miss this patch, I saw you have stamped the other patch depends on this patch, but this patch still needs approval. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70235/new/ https://reviews.llvm.org/D70235 ___

[PATCH] D70157: Align branches within 32-Byte boundary

skan marked 3 inline comments as done. skan added inline comments. Comment at: llvm/test/MC/X86/i386-align-branch-1a.s:1 +# RUN: llvm-mc -filetype=obj -triple i386-unknown-unknown --x86-align-branch-boundary=32 --x86-align-branch=fused-jcc-jmp --x86-align-branch-prefix-size=5

[PATCH] D70307: [CodeComplete] Constructor overload candidates report as vector(int) instead of vector(int)

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/CodeCompletion/templates.cpp:35 +// CHECK-CONSTRUCTOR: OVERLOAD: X(<#double#>) +// (rather than X(<#double#>) shouldn't be now `X`

[PATCH] D67543: [Clang][ASTImporter] Added visibility check for ClassTemplateDecl.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc2f6efc732ef: [Clang][ASTImporter] Added visibility check for ClassTemplateDecl. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67543/

[PATCH] D70297: [ARM,MVE] Add intrinsics for vector comparisons.

simon_tatham marked 2 inline comments as done. simon_tatham added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:6798 +static llvm::Value *ARMMVEDupVector(CGBuilderTy &Builder, llvm::Value *V) { + // Helper function to duplicate a scalar value V into all lanes of

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

merge_guards_bot added a comment. Build result: pass - 60093 tests passed, 0 failed and 729 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70307: [CodeComplete] Constructor overload candidates report as vector(int) instead of vector(int)

sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clang/test/CodeCompletion/templates.cpp:35 +// CHECK-CONSTRUCTOR: OVERLOAD: X(<#double#>) +// (rather than X(<#double#>) hokein wrote: > shouldn't be now `X` after your recen

[PATCH] D70235: [clangd] Add isHeaderFile helper.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/SourceCode.cpp:1133 + Lang != types::TY_INVALID && types::onlyPrecompileType(Lang); + if (!LangOpts) +return IsHeader

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

usaxena95 updated this revision to Diff 229529. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Modified tests for better error messages. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70008/new/ https://reviews.llvm.org/D7000

[PATCH] D70235: [clangd] Add isHeaderFile helper.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.h:302 +bool isHeaderFile(llvm::StringRef FileName, + llvm::Optional LangOpts = None); + nit: = llvm::None Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/unittests/CollectMacrosTests.cpp:80 +<< Test; +EXPECT_THAT(collectKnownReferences(AST.getMacros()), AreMacroRefsFrom(T)) +<< Test; hokein wrote: > usaxena95 wrote: > > hokei

[clang] a763d98 - [gen_ast_dump_json_test.py] Add a --update flag

Author: Alex Richardson Date: 2019-11-15T12:52:30Z New Revision: a763d985012bdc5c5fc7bbc836b0dfddbb9af2d8 URL: https://github.com/llvm/llvm-project/commit/a763d985012bdc5c5fc7bbc836b0dfddbb9af2d8 DIFF: https://github.com/llvm/llvm-project/commit/a763d985012bdc5c5fc7bbc836b0dfddbb9af2d8.diff LO

[PATCH] D70307: [CodeComplete] Constructor overload candidates report as vector(int) instead of vector(int)

merge_guards_bot added a comment. Build result: pass - 60091 tests passed, 0 failed and 729 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70297: [ARM,MVE] Add intrinsics for vector comparisons.

dmgreen added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:6798 +static llvm::Value *ARMMVEDupVector(CGBuilderTy &Builder, llvm::Value *V) { + // Helper function to duplicate a scalar value V into all lanes of an MVE Is this the same as or simi

[PATCH] D69934: [clangd] Implement rename by using SelectionTree and findExplicitReferences.

hokein updated this revision to Diff 229530. hokein marked 6 inline comments as done. hokein added a comment. address review comments: - don't rename inside macro body - fixed a corner case where the rename occurrence may come from a non-preamble #include - add more tests, and simplify the testc

[PATCH] D69825: [Clang][Driver] Bypass cc1 process and re-enter driver main

aganea added a comment. @hans : Simply because `ExecuteCC1Tool()` lives in the clang tool (`clang/tools/driver/driver.cpp`) and we're calling it from the clangDriver.lib (`clang/lib/Driver/Job.cpp`). The clangDriver.lib is linked into many other tools (clang-refactor, clang-rename, clang-diff,

[PATCH] D70157: Align branches within 32-Byte boundary

davezarzycki added a comment. In D70157#1747510 , @xbolva00 wrote: > > Even though core2 isn't affected by the erratum, core2 code can run on CPUs > > that do have the bug (and core2 is a popular target for code that needs to > > run "everywhere"), there

[PATCH] D68862: [ARM] Allocatable Global Register Variables for ARM

anwel updated this revision to Diff 229531. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68862/new/ https://reviews.llvm.org/D68862 Files: clang/docs/ClangCommandLineReference.rst clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang/Basic/DiagnosticGroups.td cl

[PATCH] D70157: Align branches within 32-Byte boundary

emaste added a comment. > Shall we default to -mbranches-within-32B-boundaries if the specified -march= > or -mtune= may be affected by the erratum? I think we should enable it based on `-mtune` specifying an affected CPU (and implicitly based on `-march` if `-mtune` is not specified). CHANGE

[PATCH] D70308: [clangd] Don't consider class template params part of constructor name.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This is shorter and usually the extra info is noise. There are cases where the params become t

[clang] fa3b87f - [CodeComplete] Constructor overload candidates report as vector(int) instead of vector(int)

Author: Sam McCall Date: 2019-11-15T15:42:18+01:00 New Revision: fa3b87fbeb465c7ff9fd3c24b168d534d380af16 URL: https://github.com/llvm/llvm-project/commit/fa3b87fbeb465c7ff9fd3c24b168d534d380af16 DIFF: https://github.com/llvm/llvm-project/commit/fa3b87fbeb465c7ff9fd3c24b168d534d380af16.diff LO

[PATCH] D70309: [clangd] Fix typo in symbol kind conversion

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D70309 Files: clang-tools-e

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

usaxena95 updated this revision to Diff 229535. usaxena95 added a comment. Minor change: Resued variable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70008/new/ https://reviews.llvm.org/D70008 Files: clang-tools-extra/clangd/CollectMacros.h

[PATCH] D19031: [clang-format] Flexible line endings

cameron314 updated this revision to Diff 229533. cameron314 added a comment. Rebased diff on latest upstream. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D19031/new/ https://reviews.llvm.org/D19031 Files: clang/include/clang/Format/Format.h clang/lib/Format/Format.cpp clang/unit

[PATCH] D69934: [clangd] Implement rename by using SelectionTree and findExplicitReferences.

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:225 tooling::Replacements FilteredChanges; - for (const tooling::SymbolOccurrence &Rename : - findOccurrencesWithinFile(AST, RenameDecl)) { -// Currently, we only support normal r

[PATCH] D70307: [CodeComplete] Constructor overload candidates report as vector(int) instead of vector(int)

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rGfa3b87fbeb46: [CodeComplete] Constructor overload candidates report as vector(int) instead of… (authored by sammccall). Repository: rG LLVM Github Monorepo C

[PATCH] D70302: [CodeGen] Fix clang crash on aggregate initialization of array of labels

nickie marked an inline comment as done. nickie added a comment. LGTM, for all that it's worth. Comment at: clang/lib/CodeGen/CGExpr.cpp:1021 void CodeGenModule::EmitExplicitCastExprType(const ExplicitCastExpr *E, - CodeGenFunction *

[clang] e6584b2 - Move floating point related entities to namespace level

Author: Serge Pavlov Date: 2019-11-15T19:56:33+07:00 New Revision: e6584b2b7b2de06f1e59aac41971760cac1e1b79 URL: https://github.com/llvm/llvm-project/commit/e6584b2b7b2de06f1e59aac41971760cac1e1b79 DIFF: https://github.com/llvm/llvm-project/commit/e6584b2b7b2de06f1e59aac41971760cac1e1b79.diff

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

khchen updated this revision to Diff 229507. khchen added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67508/new/ https://reviews.llvm.org/D67508 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/lib/Driver/ToolChains/RISCVTo

[PATCH] D19031: [clang-format] Flexible line endings

cameron314 added a comment. I've got a rebased diff but Phabricator won't let me attach it to this differential review (too old?). What do I do? EDIT: Ah, it must be because I'm not the owner, despite it being editable by all. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D19031/new/

[PATCH] D70306: clang: Exherbo multiarch ajustments

Keruspe created this revision. Keruspe added reviewers: dlj, rsmith, compnerd. Keruspe added a project: clang. Herald added a subscriber: cfe-commits. Exherbo multiarch layout being somewhat specific, some adjustments need to be made wrt the lookup paths. Based in parts on patches by Marvin Schm

[PATCH] D70307: [CodeComplete] Constructor overload candidates report as vector(int) instead of vector(int)

sammccall created this revision. sammccall added reviewers: hokein, lh123. Herald added subscribers: cfe-commits, usaxena95, kadircet, ilya-biryukov. Herald added a project: clang. This is shorter, shouldn't be confusing (is consistent with how they're declared), and avoids messy cases that are p

[PATCH] D70308: [clangd] Don't consider class template params part of constructor name.

merge_guards_bot added a comment. Build result: pass - 60134 tests passed, 0 failed and 729 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D69564: Include the mangled name in -ast-dump=json

This revision was automatically updated to reflect the committed changes. Closed by commit rG3c3048c18b09: Include the mangled name in -ast-dump=json (authored by Alex Richardson ). Changed prior to commit: https://reviews.llvm.org/D69564?vs=226893&id=229514#t

[PATCH] D70157: Align branches within 32-Byte boundary

skan added a comment. In D70157#1746793 , @MaskRay wrote: > On x86, the preferred function alignment is 16 > (https://github.com/llvm/llvm-project/blob/arcpatch-D70157/llvm/lib/Target/X86/X86ISelLowering.cpp#L1893), > which is the default function alignm

[PATCH] D19031: [clang-format] Flexible line endings

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. This LGTM, I think this could help more than people might at first realize. I love the idea that I can use clang-format in dry-run (-n) mode to now make line endings seem a com

[PATCH] D69552: Move floating point related entities to namespace level

This revision was automatically updated to reflect the committed changes. Closed by commit rGe6584b2b7b2d: Move floating point related entities to namespace level (authored by sepavloff). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://rev

[PATCH] D70305: clang-format: fix regression in middle pointer alignment

Typz created this revision. Typz added reviewers: MyDeveloperDay, klimek, sammccall. Herald added a project: clang. a75f8d98d7ac introduced a regression with Middle pointer alignment, which this patch fixes. Repository: rG

[clang] e3d5ff5 - [RISCV] Match GCC `-march`/`-mabi` driver defaults

Author: Sam Elliott Date: 2019-11-15T15:10:42Z New Revision: e3d5ff5a0b102febcddd9d58f24f18b00d4ecb4e URL: https://github.com/llvm/llvm-project/commit/e3d5ff5a0b102febcddd9d58f24f18b00d4ecb4e DIFF: https://github.com/llvm/llvm-project/commit/e3d5ff5a0b102febcddd9d58f24f18b00d4ecb4e.diff LOG: [

[PATCH] D70312: [clangd] Fix SelectionTree behavior on constructor init-lists.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. hokein accepted this revision. hokein added a comment. This revision is now accepted and ready

[PATCH] D69383: [RISCV] Match GCC `-march`/`-mabi` driver defaults

This revision was automatically updated to reflect the committed changes. Closed by commit rGe3d5ff5a0b10: [RISCV] Match GCC `-march`/`-mabi` driver defaults (authored by lenary). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69383/new/ https://revi

[PATCH] D69934: [clangd] Implement rename by using SelectionTree and findExplicitReferences.

merge_guards_bot added a comment. Build result: pass - 60093 tests passed, 0 failed and 729 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D69383: [RISCV] Match GCC `-march`/`-mabi` driver defaults

lenary updated this revision to Diff 229542. lenary added a comment. Rebase and update comments and release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69383/new/ https://reviews.llvm.org/D69383 Files: clang/docs/ReleaseNotes.rst clang

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

ABataev added inline comments. Comment at: clang/test/OpenMP/target_defaultmap_codegen.cpp:1544-1545 + // CK26: [[ONE:%.+]] = load float, float* [[ZERO]] +#pragma omp target defaultmap(none:aggregate) map(A) + compute(A); +} Don't understand how does it test ma

[PATCH] D70312: [clangd] Fix SelectionTree behavior on constructor init-lists.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70312/new/ https://reviews.llvm.org/D70312

[clang-tools-extra] 509efe5 - [clangd] Add isHeaderFile helper.

Author: Haojian Wu Date: 2019-11-15T16:18:27+01:00 New Revision: 509efe5d8edee5637b26fcb645978325de0a7283 URL: https://github.com/llvm/llvm-project/commit/509efe5d8edee5637b26fcb645978325de0a7283 DIFF: https://github.com/llvm/llvm-project/commit/509efe5d8edee5637b26fcb645978325de0a7283.diff LO

[PATCH] D70157: Align branches within 32-Byte boundary

davezarzycki added a comment. In D70157#1746793 , @MaskRay wrote: > On x86, the preferred function alignment is 16 > (https://github.com/llvm/llvm-project/blob/arcpatch-D70157/llvm/lib/Target/X86/X86ISelLowering.cpp#L1893), > which is the default functio

[PATCH] D70235: [clangd] Add isHeaderFile helper.

hokein updated this revision to Diff 229545. hokein marked an inline comment as done. hokein added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70235/new/ https://reviews.llvm.org/D70235 Files: clang-tools-extra/cla

[PATCH] D70157: Align branches within 32-Byte boundary

jyknight added a comment. In D70157#1747551 , @davezarzycki wrote: > In D70157#1747510 , @xbolva00 wrote: > > > > Even though core2 isn't affected by the erratum, core2 code can run on > > > CPUs that do have the

[PATCH] D70235: [clangd] Add isHeaderFile helper.

This revision was automatically updated to reflect the committed changes. Closed by commit rG509efe5d8ede: [clangd] Add isHeaderFile helper. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70235/new/ https://reviews.llvm.org/D702

[PATCH] D70309: [clangd] Fix typo in symbol kind conversion

merge_guards_bot added a comment. Build result: pass - 60134 tests passed, 0 failed and 729 were skipped. Log files: console-log.txt , CMakeCache.txt

[clang-tools-extra] b221c9d - [clangd] Replace getLangOpts().isHeaderFile usage with isHeaderFile helper.

Author: Haojian Wu Date: 2019-11-15T16:28:10+01:00 New Revision: b221c9d09dd12bde75f00f3541c8f344925d4d59 URL: https://github.com/llvm/llvm-project/commit/b221c9d09dd12bde75f00f3541c8f344925d4d59 DIFF: https://github.com/llvm/llvm-project/commit/b221c9d09dd12bde75f00f3541c8f344925d4d59.diff LO

[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:1499-1509 +OMPBuilder->pushFinalizationCB(std::move(FI)); + } + CGOpenMPOutlinedRegionInfo CGInfo(*CS, ThreadIDVar, CodeGen, InnermostKind, HasCancel, Out

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

awpandey updated this revision to Diff 229544. awpandey added a comment. Thanks for your suggestion @aprantl. I have revised the data type based on your suggestion. Please inform me if any other changes are required. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70111/new/ https://revi

[PATCH] D68206: [clang] Remove the DIFlagArgumentNotModified debug info flag

vsk added a comment. I’d expect only the entry values test to fail. Is that the one? Could you just mark it as skipped (there are examples of how to do this for inline tests, see the skipIf decorator) and file a bugzilla PR for me to look at? CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D70312: [clangd] Fix SelectionTree behavior on constructor init-lists.

merge_guards_bot added a comment. Build result: pass - 60134 tests passed, 0 failed and 729 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

merge_guards_bot added a comment. Build result: pass - 60093 tests passed, 0 failed and 729 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70299: [clangd] Replace getLangOpts().isHeaderFile usage with isHeaderFile helper.

This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rGb221c9d09dd1: [clangd] Replace getLangOpts().isHeaderFile usage with isHeaderFile helper. (authored by hokein). Changed prior to commit: https://reviews.llvm.org

[clang] cb17614 - clang: enable unwind tables on FreeBSD !amd64

Author: Ed Maste Date: 2019-11-15T10:37:45-05:00 New Revision: cb1761465a0d4c904f4fca489afe97478382b553 URL: https://github.com/llvm/llvm-project/commit/cb1761465a0d4c904f4fca489afe97478382b553 DIFF: https://github.com/llvm/llvm-project/commit/cb1761465a0d4c904f4fca489afe97478382b553.diff LOG:

[PATCH] D68711: Implement target(branch-protection) attribute for AArch64

This revision was automatically updated to reflect the committed changes. Closed by commit rGaa6d48fa70eb: Implement target(branch-protection) attribute for AArch64 (authored by chill). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo C

[clang] aa6d48f - Implement target(branch-protection) attribute for AArch64

Author: Momchil Velikov Date: 2019-11-15T15:40:46Z New Revision: aa6d48fa70eb5d1769ea09ac0a2c4d956deeb06d URL: https://github.com/llvm/llvm-project/commit/aa6d48fa70eb5d1769ea09ac0a2c4d956deeb06d DIFF: https://github.com/llvm/llvm-project/commit/aa6d48fa70eb5d1769ea09ac0a2c4d956deeb06d.diff LO

[PATCH] D70235: [clangd] Add isHeaderFile helper.

merge_guards_bot added a comment. Build result: pass - 60093 tests passed, 0 failed and 729 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

lenary added a comment. Do rebase this patch now that D69383 has landed, and check that it is still working correctly. If so, you can land this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67508/new/ http

[PATCH] D70110: [Driver][FreeBSD] Enable unwind tables on !amd64

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb1761465a0d: clang: enable unwind tables on FreeBSD !amd64 (authored by emaste). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70110/new/ https://reviews.l

[PATCH] D70157: Align branches within 32-Byte boundary

davezarzycki added a comment. In D70157#1747640 , @jyknight wrote: > In D70157#1747551 , @davezarzycki > wrote: > > > In D70157#1747510 , @xbolva00 > > wrote: > > > > > > E

[PATCH] D68206: [clang] Remove the DIFlagArgumentNotModified debug info flag

djtodoro added a comment. I will do that way. Yes, only the entry values test fails, so we should skip only that one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68206/new/ https://reviews.llvm.org/D68206 ___ cfe-commits mailing list cfe-

[PATCH] D69938: [OpenCL] Use __generic addr space when generating internal representation of lambda

rjmccall added a comment. > I was already planning to add this. I could look into it next and maybe just > a add FIXME in the test for now. Sure. > Btw global lambda objects are in `__global` address space in OpenCL. Just based on being written outside of a function body or in a static-local

[PATCH] D70302: [CodeGen] Fix clang crash on aggregate initialization of array of labels

johannes updated this revision to Diff 229556. johannes added a comment. Remove unneccesary const on parameter Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70302/new/ https://reviews.llvm.org/D70302 Files: clang/lib/CodeGen/CGExprAgg.cpp clan

[PATCH] D70302: [CodeGen] Fix clang crash on aggregate initialization of array of labels

johannes marked an inline comment as done. johannes added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:1021 void CodeGenModule::EmitExplicitCastExprType(const ExplicitCastExpr *E, - CodeGenFunction *CGF) { +

[PATCH] D70317: [clangd] More sensible output for constructors/destructors in hover.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Previously: both had type void() and return type void. Now: neither have a type. Constructors

[PATCH] D68862: [ARM] Allocatable Global Register Variables for ARM

carwil accepted this revision. carwil added a comment. This revision is now accepted and ready to land. I think there's been plenty of time for comments here. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68862/new/ https://reviews.llvm.org/D68862 __

[clang-tools-extra] c908196 - [clangd] Fix typo in symbol kind conversion

Author: Sam McCall Date: 2019-11-15T17:34:22+01:00 New Revision: c9081968ead183ee1df824f7b96fcafcfcbe57cd URL: https://github.com/llvm/llvm-project/commit/c9081968ead183ee1df824f7b96fcafcfcbe57cd DIFF: https://github.com/llvm/llvm-project/commit/c9081968ead183ee1df824f7b96fcafcfcbe57cd.diff LO

[clang-tools-extra] ad9fd32 - [clangd] Fix SelectionTree behavior on constructor init-lists.

Author: Sam McCall Date: 2019-11-15T17:32:13+01:00 New Revision: ad9fd320091d44d4b8782c28b72a7be21a2bd68d URL: https://github.com/llvm/llvm-project/commit/ad9fd320091d44d4b8782c28b72a7be21a2bd68d DIFF: https://github.com/llvm/llvm-project/commit/ad9fd320091d44d4b8782c28b72a7be21a2bd68d.diff LO

[PATCH] D70312: [clangd] Fix SelectionTree behavior on constructor init-lists.

This revision was automatically updated to reflect the committed changes. Closed by commit rGad9fd320091d: [clangd] Fix SelectionTree behavior on constructor init-lists. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70312/new

[PATCH] D70309: [clangd] Fix typo in symbol kind conversion

This revision was automatically updated to reflect the committed changes. Closed by commit rGc9081968ead1: [clangd] Fix typo in symbol kind conversion (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70309/new/ https://reviews.

[PATCH] D70308: [clangd] Don't consider class template params part of constructor name.

This revision was automatically updated to reflect the committed changes. Closed by commit rG713c30b38960: [clangd] Don't consider class template params part of constructor name. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang-tools-extra] 713c30b - [clangd] Don't consider class template params part of constructor name.

Author: Sam McCall Date: 2019-11-15T17:32:55+01:00 New Revision: 713c30b389602eda5c70b696e8c640487cc8b2cb URL: https://github.com/llvm/llvm-project/commit/713c30b389602eda5c70b696e8c640487cc8b2cb DIFF: https://github.com/llvm/llvm-project/commit/713c30b389602eda5c70b696e8c640487cc8b2cb.diff LO

[clang] 358eaa3 - [clang-format] Flexible line endings

Author: Cameron Desrochers Date: 2019-11-15T11:50:22-05:00 New Revision: 358eaa3dcea1dee6350c2cbf80aab3c25db4d4d9 URL: https://github.com/llvm/llvm-project/commit/358eaa3dcea1dee6350c2cbf80aab3c25db4d4d9 DIFF: https://github.com/llvm/llvm-project/commit/358eaa3dcea1dee6350c2cbf80aab3c25db4d4d9.

[PATCH] D70317: [clangd] More sensible output for constructors/destructors in hover.

merge_guards_bot added a comment. Build result: pass - 60137 tests passed, 0 failed and 729 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70157: Align branches within 32-Byte boundary

craig.topper added a comment. In D70157#1747726 , @davezarzycki wrote: > In D70157#1747640 , @jyknight wrote: > > > In D70157#1747551 , @davezarzycki > > wrote: > > > > > I

[PATCH] D19031: [clang-format] Flexible line endings

This revision was automatically updated to reflect the committed changes. Closed by commit rG358eaa3dcea1: [clang-format] Flexible line endings (authored by Cameron Desrochers ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D70319: [ARM,MVE] Add intrinsics for scalar shifts.

simon_tatham created this revision. simon_tatham added reviewers: ostannard, MarkMurrayARM, dmgreen. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. This fills in the small family of MVE intrinsics that have nothing to do with vect

[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMPIRBuilder.h:69-71 + void pushFinalizationCB(FinalizationInfo &&FI) { +FinalizationStack.emplace_back(std::move(FI)); + } ABataev wrote:

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. LGTM with one change to DIBuilder inline. Comment at: llvm/include/llvm/IR/DIBuilder.h:243 + unsigned LineNo, DIScope *Context, +

[PATCH] D61549: Fix use of 'is' operator for comparison

j-carl added a comment. Gentle ping ... ArchLinux update to Python 3.8 and it's not possible to use clang-format.py from vim anymore. Thanks Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61549/new/ https://reviews.llvm.org/D61549 _

[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

jdoerfert updated this revision to Diff 229573. jdoerfert added a comment. Replace conditional by RAII object Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70258/new/ https://reviews.llvm.org/D70258 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:1481-1509 + if (OMPBuilder) { + +// The following callback is the crucial part of clangs cleanup process. +// +// NOTE: +// Once the OpenMPIRBuilder is used to create parallel region

[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

ABataev added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMPIRBuilder.h:69-71 + void pushFinalizationCB(FinalizationInfo &&FI) { +FinalizationStack.emplace_back(std::move(FI)); + } jdoerfert wrote: > ABataev wrote: > > jdoerfert wrote: > > >

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG with a nit Comment at: clang/lib/Sema/SemaOpenMP.cpp:4459 } -if (!ImplicitMaps.empty()) { +unsigned ClauseKindCnt = -1; +for (ArrayRef ImplicitMap : Imp

[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

jdoerfert updated this revision to Diff 229582. jdoerfert marked an inline comment as done. jdoerfert added a comment. Make it a specialized push-pop RAII object (just moved code) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70258/new/ https://rev

[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMPIRBuilder.h:69-71 + void pushFinalizationCB(FinalizationInfo &&FI) { +FinalizationStack.emplace_back(std::move(FI)); + } ABataev wrote:

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

cchen added a comment. Alexey, thanks so much for your help, you really make me learn so much about Clang and coding in general. Can you land this patch for me since I'm still new to llvm/clang and haven't have the commit access. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

ABataev added a comment. In D69204#1747941 , @cchen wrote: > Alexey, thanks so much for your help, you really make me learn so much about > Clang and coding in general. Can you land this patch for me since I'm still > new to llvm/clang and haven't have t

[PATCH] D70052: [clang-tidy] Add misc-mutating-copy check

aaron.ballman added a comment. In D70052#1741246 , @gbencze wrote: > In D70052#1740235 , @Eugene.Zelenko > wrote: > > > If this is CERT rule, why check is not placed in relevant module? > > > To be honest I was hop

[PATCH] D69620: Add AIX assembler support

Xiangling_L added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:28 + const char *LinkingOutput) const { + claimNoWarnArgs(Args); + ArgStringList CmdArgs; The definition of `claimNoWarnArgs` is to suppress warn

[clang] 575e09d - [AST] Let DeclarationNameInfo printing use PrintingPolicy, and fix const-correctness

Author: Sam McCall Date: 2019-11-15T19:19:41+01:00 New Revision: 575e09d9f82f3bd0894dc10d1fa5873e97a7e70f URL: https://github.com/llvm/llvm-project/commit/575e09d9f82f3bd0894dc10d1fa5873e97a7e70f DIFF: https://github.com/llvm/llvm-project/commit/575e09d9f82f3bd0894dc10d1fa5873e97a7e70f.diff LO

[clang-tools-extra] 209e30b - [clangd] Don't repeat class template args when printing constructor definitions

Author: Sam McCall Date: 2019-11-15T19:23:20+01:00 New Revision: 209e30b7e0c20796f8f2c941d13e7e4994479c6b URL: https://github.com/llvm/llvm-project/commit/209e30b7e0c20796f8f2c941d13e7e4994479c6b DIFF: https://github.com/llvm/llvm-project/commit/209e30b7e0c20796f8f2c941d13e7e4994479c6b.diff LO

  1   2   3   >