dmgreen added inline comments.
================ Comment at: clang/lib/CodeGen/CGBuiltin.cpp:6798 +static llvm::Value *ARMMVEDupVector(CGBuilderTy &Builder, llvm::Value *V) { + // Helper function to duplicate a scalar value V into all lanes of an MVE ---------------- Is this the same as or similar enough to CreateVectorSplat to use that instead? ================ Comment at: llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp:3311 } + case Intrinsic::arm_mve_pred_i2v: { + Value *Arg = II->getArgOperand(0); ---------------- This can be a separate change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70297/new/ https://reviews.llvm.org/D70297 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits