[PATCH] D69841: Target Ivy bridge on macOS Mojave and later

davezarzycki added a comment. @bob.wilson – Ping. While Ivy Bridge (or really, Sandy Bridge) has AVX1, which enables faster memcpy, memset, and even memcmp (for common scenarios). If there is something I'm missing? If you can't explain why, that's okay. :-) Repository: rG LLVM Github Monorep

[PATCH] D69921: [clang-format] refactor the use of the SMDiagnostics in replacement warnings

MyDeveloperDay updated this revision to Diff 228826. MyDeveloperDay added a comment. Move adding the source file to the source mgr outside the replacements loop CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69921/new/ https://reviews.llvm.org/D69921 Files: clang/tools/clang-format/Cl

[clang] a75f8d9 - [clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly for some operator functions

Author: mydeveloperday Date: 2019-11-12T09:25:00Z New Revision: a75f8d98d7ac9e557b238a229a9a2647c71feed1 URL: https://github.com/llvm/llvm-project/commit/a75f8d98d7ac9e557b238a229a9a2647c71feed1 DIFF: https://github.com/llvm/llvm-project/commit/a75f8d98d7ac9e557b238a229a9a2647c71feed1.diff LOG

[PATCH] D69573: [clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly for some operator functions

This revision was automatically updated to reflect the committed changes. Closed by commit rGa75f8d98d7ac: [clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly for some… (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

MyDeveloperDay added a comment. NOTE: Add foo() const override and foo() const override LLVM_READONLY test examples as these currently fail CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 ___ cfe-c

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

MyDeveloperDay updated this revision to Diff 228842. MyDeveloperDay set the repository for this revision to rG LLVM Github Monorepo. MyDeveloperDay added a comment. Fix an issue with foo() const override/final Be more specific about this being turned off in all the base styles CHANGES SINCE LAST

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

MyDeveloperDay updated this revision to Diff 228843. MyDeveloperDay added a comment. Make the patch file correctly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Form

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

ekatz added a comment. In D69935#1741268 , @dblaikie wrote: > In D69935#1739235 , @dblaikie wrote: > > > +1 to this & then it seems fine (probably without a committed test, but I > > wouldn't mind a copy/paste of c

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

JonChesterfield added a comment. Uncertainty over the handling of constant data between clang and libopenmp not withstanding, I think this is good to go. Comment at: llvm/include/llvm/IR/OpenMPKinds.def:186 +///{ + +#ifndef OMP_IDENT_FLAG Meinersbur wrote: > J

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

lenary added a comment. The follow-up patch, implementing this correctly, is D70116 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67409/new/ https://reviews.llvm.org/D67409

[PATCH] D67787: Add 8548 CPU definition and attributes

vit9696 accepted this revision. vit9696 added a comment. This revision is now accepted and ready to land. Actually thanks for adding C checks too. The new revision also looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67787/new/ http

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

merge_guards_bot added a comment. Build result: pass - 59989 tests passed, 0 failed and 763 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D69618: NeonEmitter: clean up prototype modifiers

t.p.northover added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69618/new/ https://reviews.llvm.org/D69618 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

uabelho added a comment. In D69935#1739235 , @dblaikie wrote: > In D69935#1738273 , @uabelho wrote: > > > Don't you need to also remove > > > > case LinkageSpecDecl::lang_cxx_11: > > case LinkageSpecDecl::lang_c

[PATCH] D69760: [Clang][Driver] Don't pun -fuse-ld=lld as -fuse-ld=lld-link with msvc

mstorsjo added a comment. In D69760#1739044 , @Ericson2314 wrote: > While I am fine making `-fuse-ld=lld` mean "use that lld driver most > appropriate for the clang driver", in principle the clang driver and lld > driver choices are orthogonal In princ

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

awpandey updated this revision to Diff 228852. awpandey added a comment. Revised and address comments of @djtodoro CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70111/new/ https://reviews.llvm.org/D70111 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/debug-info-temp

[PATCH] D69938: [OpenCL] Use __generic addr space when generating internal representation of lambda

Anastasia updated this revision to Diff 228851. Anastasia added a comment. - Added missing handling of lambda w/o param list. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69938/new/ https://reviews.llvm.org/D69938 Files: clang/lib/Sema/SemaLambda.cpp clang/lib/Sema/SemaType.cpp

[PATCH] D69938: [OpenCL] Use __generic addr space when generating internal representation of lambda

Anastasia added a comment. In D69938#1741713 , @rjmccall wrote: > In D69938#1741080 , @Anastasia wrote: > > > In D69938#1737196 , @rjmccall > > wrote: > > > > > It does make

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

awpandey marked 8 inline comments as done. awpandey added a comment. Thank you @djtodoro for reviewing this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70111/new/ https://reviews.llvm.org/D70111 ___ cfe-commits mailing list cfe-commits@

[PATCH] D69564: Include the mangled name in -ast-dump=json

arichardson added a comment. I've split out the update script changes into D70119 to make this easier to review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69564/new/ https://reviews.llvm.org/D69564 _

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

ekatz updated this revision to Diff 228860. ekatz added a comment. In D69935#1741995 , @uabelho wrote: > In D69935#1739235 , @dblaikie wrote: > > > In D69935#1738273 , @uabel

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

bader updated this revision to Diff 228868. bader added a subscriber: hfinkel. bader added a comment. Applied two remaining comments from Aaron. - Split diagnostics for `sycl_kernel` attribute to provide more informative message. - Moved attribute target check to TableGen file. I stole a workaro

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

bader marked an inline comment as done. bader added inline comments. Comment at: clang/test/SemaSYCL/device-attributes.cpp:35 +template +[[clang::sycl_kernel]] void foo1(); // expected-warning {{'sycl_kernel' attribute only applies to template funtions with special prototype, p

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

usaxena95 updated this revision to Diff 228869. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Herald added a subscriber: mgorny. Added tests for CollectMacros.h Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

usaxena95 updated this revision to Diff 228870. usaxena95 added a comment. Fixed typos. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70008/new/ https://reviews.llvm.org/D70008 Files: clang-tools-extra/clangd/CollectMacros.h clang-tools-extra/

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

usaxena95 marked an inline comment as done. usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/CollectMacros.h:29 std::vector Ranges; + llvm::DenseMap> MacroRefs; }; hokein wrote: > I think the `Ranges` and `MacrosRefs` have a lot of dupli

[clang] 44e5879 - AArch64: add arm64_32 support to Clang.

Author: Tim Northover Date: 2019-11-12T12:45:18Z New Revision: 44e5879f0fb7c28b90e8042fde81bba30b4090a3 URL: https://github.com/llvm/llvm-project/commit/44e5879f0fb7c28b90e8042fde81bba30b4090a3 DIFF: https://github.com/llvm/llvm-project/commit/44e5879f0fb7c28b90e8042fde81bba30b4090a3.diff LOG:

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

merge_guards_bot added a comment. Build result: pass - 59989 tests passed, 0 failed and 763 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D67750: Allow additional file suffixes/extensions considered as source in main include grouping

furdyna updated this revision to Diff 228872. furdyna marked 2 inline comments as done. furdyna added a comment. Hi @MyDeveloperDay, I changed the code following your advice. Thanks for cathing the operator==(), I was not sure if this omission was intentional or not - fixed both comparisons. C

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

merge_guards_bot added a comment. Build result: pass - 59989 tests passed, 0 failed and 763 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D61634: [clang/llvm] Allow efficient implementation of libc's memory functions in C/C++

gchatelet added a comment. In D61634#1732884 , @tejohnson wrote: > In D61634#1682660 , @gchatelet wrote: > > > In D61634#1679331 , @tejohnson > > wrote: > > > > > In D61634#

[PATCH] D67750: Allow additional file suffixes/extensions considered as source in main include grouping

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Thanks for the patch, This LGTM, in the future, just a small nit for the future, can you ensure the diff is a full context diff with something like `@git diff --cached -U99

[PATCH] D67750: Allow additional file suffixes/extensions considered as source in main include grouping

furdyna added a comment. @MyDeveloperDay Thanks for the review! I did rebase it a few hours ago. I actually made sure to use the full-context diff (with -U99 option) - I even have this as a last command in my command history, and the patch file on my disk is full-context. So either I still

[PATCH] D68362: [libunwind][RISCV] Add 64-bit RISC-V support

lenary accepted this revision. lenary added a comment. Thanks for updating the patch. I'm happy for this patch to land, but I would like you to wait for @luismarques to approve it as well before landing it. Comment at: libunwind/src/Registers.hpp:3756 +inline double Registers

[PATCH] D68185: [Diagnostics] Warn when class implements a copy constructor/copy assignment operator, but missing the copy assignment operator/copy constructor

xbolva00 added a comment. Should we reconsider this as a clang warning? I found that the newest GCC can diagnose it. GCC 9+: -Wdeprecated-copy, implied by -Wextra, warns about the C++11 deprecation of implicitly declared copy constructor and assignment operator if one of them is user-provided

[PATCH] D63131: arm64_32: implement the desired ABI for the ILP32 triple.

t.p.northover marked 6 inline comments as done. t.p.northover added a comment. Thanks, I've updated for most of the suggestions and committed it. I'll make the AArch64 naming changes separately if we decide to. Comment at: clang/lib/Basic/Targets/AArch64.cpp:167 // Target p

[PATCH] D69759: [BPF] Add preserve_access_index attribute for record definition

yonghong-song added a comment. @aaron.ballman just ping, could you let me know if you have any further comments? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69759/new/ https://reviews.llvm.org/D69759 __

[PATCH] D69825: [Clang][Driver] Bypass cc1 process and re-enter driver main

hans added a comment. Thanks for sharing this! I still need to take a proper look, but my first thought is this: Instead of invoking main() (or a similar function like ClangDriverMain) as an alternative to spinning up the cc1 process, would it be possible to call ExecuteCC1Tool() directly? I g

[PATCH] D70047: [Analyzer] Use a reference in a range-based for

Szelethus accepted this revision. Szelethus added a comment. Whoo! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70047/new/ https://reviews.llvm.org/D70047 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D69962: [CFG] Fix a flaky crash in CFGBlock::getLastCondition().

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. In D69962#1741503 , @NoQ wrote: > In D69962#1739440 , @NoQ wrote: > > > In D69962#1738618

[PATCH] D69962: [CFG] Fix a flaky crash in CFGBlock::getLastCondition().

Szelethus added a comment. Accepted accidentally. Well, in any case, I trust your judgement on this! I'd prefer not to commit the test file as-is. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69962/new/ https://reviews.llvm.org/D69962 ___

[PATCH] D69938: [OpenCL] Use __generic addr space when generating internal representation of lambda

rjmccall added a comment. In D69938#1742026 , @Anastasia wrote: > In D69938#1741713 , @rjmccall wrote: > > > In D69938#1741080 , @Anastasia > > wrote: > > > > > In D69938#17

[PATCH] D69393: [RFC][DebugInfo] emit user specified address_space in dwarf

ebevhan added a comment. For what it's worth, in our downstream fork of Clang we have added the ability for function types to possess an address space. Though technically, even in our fork it is not possible to actually declare functions/function pointers with an address space; the target-speci

[PATCH] D70063: clang/Modules: Error if ReadASTBlock does not find the main module

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM with some minor comment below! Comment at: clang/include/clang/Basic/DiagnosticSerializationKinds.td:78 +def err_module_file_missing_definition : Error< + "module file '%

[PATCH] D69841: Target Ivy bridge on macOS Mojave and later

arphaman added reviewers: Gerolf, dexonsmith. arphaman added a comment. @bob.wilson no longer works on llvm-project. I added Gerolf and Duncan. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69841/new/ https://reviews.llvm.org/D69841

[PATCH] D67160: [clang, ARM] Default to -fno-lax-vector-conversions in ARM v8.1-M.

simon_tatham added a comment. In D67160#1704840 , @rsmith wrote: > If overload resolution can't distinguish between overloads that perform a lax > vector conversions and those that do not, we should fix that in overload > resolution rather than papering

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

ABataev added inline comments. Comment at: llvm/lib/Frontend/OpenMPIRBuilder.cpp:179 +Builder.CreateCall(FnDecl, Ident, "omp_global_thread_num"); +if (Instruction *IdentI = dyn_cast(Ident)) + Call->moveAfter(IdentI); `auto *` C

[PATCH] D69922: [OpenMP] Use the OpenMP-IR-Builder

ABataev added a comment. In D69922#1741659 , @jdoerfert wrote: > Use IRBuilder for cancel barriers In general, it would better to implement cancellation barriers in the separate patch. Same for OpenMPIrBuilder. Repository: rG LLVM Github Monorepo

[clang] 83dcb34 - clang/Modules: Error if ReadASTBlock does not find the main module

Author: Duncan P. N. Exon Smith Date: 2019-11-12T08:40:53-08:00 New Revision: 83dcb34b6bf4c175040b18d3e8c3c468418009fc URL: https://github.com/llvm/llvm-project/commit/83dcb34b6bf4c175040b18d3e8c3c468418009fc DIFF: https://github.com/llvm/llvm-project/commit/83dcb34b6bf4c175040b18d3e8c3c4684180

[PATCH] D70063: clang/Modules: Error if ReadASTBlock does not find the main module

dexonsmith closed this revision. dexonsmith marked 2 inline comments as done. dexonsmith added a comment. Committed 83dcb34b6bf4c175040b18d3e8c3c468418009fc . Thanks for the reviews! Comment at: clang/lib/S

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

ABataev added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:2339-2345 +unsigned Modifier = getOpenMPSimpleClauseType( +Kind, Tok.isAnnotation() ? "" : PP.getSpelling(Tok)); +// Set defaultmap modifier to unknown if it is either scalar, aggregate, or

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

aprantl added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-template-align.cpp:8 + +// CHECK: DIDerivedType(tag: DW_TAG_typedef, {{.*}}, align: + Do we need to hardcode the target here? Could we check for the specific align value? =

[PATCH] D67160: [clang, ARM] Default to -fno-lax-vector-conversions in ARM v8.1-M.

simon_tatham added a comment. (The draft implementations of `vsetq_lane` are now in D70133 .) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67160/new/ https://reviews.llvm.org/D67160

[PATCH] D70133: [ARM, MVE] Add intrinsics for 'administrative' vector operations.

simon_tatham created this revision. simon_tatham added reviewers: ostannard, MarkMurrayARM, dmgreen. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. simon_tatham added a parent revision: D70088: [ARM,MVE] Add intrinsics for contiguous load/stores.. This batch

[PATCH] D70110: [Driver][FreeBSD] Enable unwind tables on !amd64

dim accepted this revision. dim added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70110/new/ https://reviews.llvm.org/D70110 ___ cfe-c

[PATCH] D69970: [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood (reland with fixes)

vsk added a comment. @dblaikie do you need more time to investigate? fwiw I didn't uncover any new failures in a stage2 build with this patch applied. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69970/new/ https://reviews.llvm.org/D69970 ___

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

cchen marked 2 inline comments as done. cchen added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:2339-2345 +unsigned Modifier = getOpenMPSimpleClauseType( +Kind, Tok.isAnnotation() ? "" : PP.getSpelling(Tok)); +// Set defaultmap modifier to unknown

[clang] 3c676e3 - [OPENMP]Use copy constructors instead of assignment operators in declare

Author: Alexey Bataev Date: 2019-11-12T13:13:37-05:00 New Revision: 3c676e3891b962b859e7613781419ee0dacce7dd URL: https://github.com/llvm/llvm-project/commit/3c676e3891b962b859e7613781419ee0dacce7dd DIFF: https://github.com/llvm/llvm-project/commit/3c676e3891b962b859e7613781419ee0dacce7dd.diff

[PATCH] D69825: [Clang][Driver] Bypass cc1 process and re-enter driver main

Meinersbur added inline comments. Comment at: clang/lib/Driver/Job.cpp:347 +StringRef DriverExe = llvm::sys::path::stem(D.ClangExecutable); +if (CommandExe.equals_lower(DriverExe)) + ClangDriverMain = Driver::Main; Why is this check necessary? Why no

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

ABataev added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:2339-2345 +unsigned Modifier = getOpenMPSimpleClauseType( +Kind, Tok.isAnnotation() ? "" : PP.getSpelling(Tok)); +// Set defaultmap modifier to unknown if it is either scalar, aggregate, or

[PATCH] D69832: [WebAssembly] -fwasm-exceptions enables reference-types

aheejin added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69832/new/ https://reviews.llvm.org/D69832 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D69825: [Clang][Driver] Bypass cc1 process and re-enter driver main

zturner added a comment. Does this change crash recovery semantics in any meaningful way? Will we still be able to get stack traces on all platforms when the compiler crashes? Comment at: llvm/lib/Support/CrashRecoveryContext.cpp:207 + // FIXME error: cannot compile this 'th

[PATCH] D69841: Target Ivy bridge on macOS Mojave and later

dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. Hi Dave, thanks for checking in on this, but unfortunately we're not ready for this yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D61458: [hip] Relax CUDA call restriction within `decltype` context.

hliao updated this revision to Diff 228924. hliao added a comment. This patch is revived with more changes addressing the previous concerns. Back to Justin's example: __host__ float bar(); __device__ int bar(); __host__ __device__ auto foo() -> decltype(bar()) { return bar(); } Even witho

[clang] 2149028 - [AST] Use an explicit copy in a range-based for

Author: Mark de Wever Date: 2019-11-12T20:47:46+01:00 New Revision: 2149028c49f8af1f3d8a9d81b2081a2b302b2d9a URL: https://github.com/llvm/llvm-project/commit/2149028c49f8af1f3d8a9d81b2081a2b302b2d9a DIFF: https://github.com/llvm/llvm-project/commit/2149028c49f8af1f3d8a9d81b2081a2b302b2d9a.diff

[clang] 51abceb - [OpenMP] Use an explicit copy in a range-based for

Author: Mark de Wever Date: 2019-11-12T20:50:38+01:00 New Revision: 51abcebbb6e5c8f8befaa523ae873adecf2d1012 URL: https://github.com/llvm/llvm-project/commit/51abcebbb6e5c8f8befaa523ae873adecf2d1012 DIFF: https://github.com/llvm/llvm-project/commit/51abcebbb6e5c8f8befaa523ae873adecf2d1012.diff

[PATCH] D70046: [OpenMP] Use an explicit copy in a range-based for

This revision was automatically updated to reflect the committed changes. Closed by commit rG51abcebbb6e5: [OpenMP] Use an explicit copy in a range-based for (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70046/new/ https://re

[PATCH] D70045: [AST] Use an explicit copy in a range-based for

This revision was automatically updated to reflect the committed changes. Closed by commit rG2149028c49f8: [AST] Use an explicit copy in a range-based for (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70045/new/ https://revie

[clang] 9648428 - [Analyzer] Use a reference in a range-based for

Author: Mark de Wever Date: 2019-11-12T20:53:08+01:00 New Revision: 964842861c8acd53b8df8799f7c3800c5528fb72 URL: https://github.com/llvm/llvm-project/commit/964842861c8acd53b8df8799f7c3800c5528fb72 DIFF: https://github.com/llvm/llvm-project/commit/964842861c8acd53b8df8799f7c3800c5528fb72.diff

[PATCH] D70047: [Analyzer] Use a reference in a range-based for

Mordante added a comment. @aaron.ballman good catch, I've fixed it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70047/new/ https://reviews.llvm.org/D70047 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D69825: [Clang][Driver] Bypass cc1 process and re-enter driver main

aganea marked an inline comment as done. aganea added a comment. In D69825#1742276 , @hans wrote: > Instead of invoking main() (or a similar function like ClangDriverMain) as an > alternative to spinning up the cc1 process, would it be possible to call >

[PATCH] D70047: [Analyzer] Use a reference in a range-based for

This revision was automatically updated to reflect the committed changes. Closed by commit rG964842861c8a: [Analyzer] Use a reference in a range-based for (authored by Mordante). Changed prior to commit: https://reviews.llvm.org/D70047?vs=228582&id=228935#toc Repository: rG LLVM Github Monor

[PATCH] D69598: Work on cleaning up denormal mode handling

andrew.w.kaylor accepted this revision. andrew.w.kaylor added a comment. Thanks. I understand your direction for denormal handling now, and I'm OK with this patch apart from the remaining references to subnormal that Sanjay mentioned. In D69598#1739723 ,

[PATCH] D6920: [clang-format] Add SpaceBeforeBrackets

MyDeveloperDay added a comment. I realize this is an old diff, and you and I have just spoke about it on twitter https://twitter.com/NIV_Anteru/status/1193792307386081281?s=20 would you consider rebasing as the /brief style isn't used any more It would help the approval process if you could hig

[PATCH] D68185: [Diagnostics] Warn when class implements a copy constructor/copy assignment operator, but missing the copy assignment operator/copy constructor

dblaikie added a comment. Yeah, I'm OK with warning on the deprecated cases (especially for symmetry with GCC's warning) - not sure why that didn't occur to me/why I didn't mention it in my previous comment... Deprecation wording is, in C++17, 15.8.1 [class.copy.ctor] p6, and 15.8.2 [class.cop

[PATCH] D70139: [clangd] Add bool return type to Index::refs API.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Similar to fuzzyFind, the bool indicates whether there are more xref results. Repository: rG LLVM Github Monorepo htt

[PATCH] D54628: Extend format with AllowShortEnumsOnASingleLine option

MyDeveloperDay added a comment. sorry searching through old issues, are you still interested in this patch? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54628/new/ https://reviews.llvm.org/D54628 ___ cfe-commits mai

[PATCH] D70139: [clangd] Add bool return type to Index::refs API.

merge_guards_bot added a comment. Build result: pass - 59972 tests passed, 0 failed and 763 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good - thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69935/new/ https://reviews.llvm.org/D69935 ___ cfe-commits mailin

[PATCH] D68185: [Diagnostics] Warn when class implements a copy constructor/copy assignment operator, but missing the copy assignment operator/copy constructor

xbolva00 added a comment. Ah, Clang has it under -Wdeprecated. https://clang.llvm.org/docs/DiagnosticsReference.html#wdeprecated. But combo -Wall -Wextra does not enable this warning, sadly. This should be extracted to -Wdeprecated-copy and put into -Wextra. Seems fine for you? CHANGES SINCE

[PATCH] D69934: [clangd] Implement rename by using SelectionTree and findExplicitReferences.

hokein updated this revision to Diff 228948. hokein marked 4 inline comments as done. hokein added a comment. - make rename only work when the position is on the name range of the decl - add more testsj Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D69934: [clangd] Implement rename by using SelectionTree and findExplicitReferences.

hokein added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:326 +// class Foo, but the token under the cursor is not corresponding to the +// "Foo" range, though the final result is correct. SourceLocation Loc = getBeginningOfIdentifier( -

[PATCH] D68185: [Diagnostics] Warn when class implements a copy constructor/copy assignment operator, but missing the copy assignment operator/copy constructor

dblaikie added a comment. In D68185#1742809 , @xbolva00 wrote: > Ah, Clang has it under -Wdeprecated. > https://clang.llvm.org/docs/DiagnosticsReference.html#wdeprecated. > > But combo -Wall -Wextra does not enable this warning, sadly. > > This should be

[PATCH] D69934: [clangd] Implement rename by using SelectionTree and findExplicitReferences.

merge_guards_bot added a comment. Build result: pass - 59990 tests passed, 0 failed and 763 were skipped. Log files: console-log.txt , CMakeCache.txt

[clang] 335ac2e - Allow additional file suffixes/extensions considered as source in main include grouping

Author: mydeveloperday Date: 2019-11-12T21:26:52Z New Revision: 335ac2eb662ce5f1888e2a50310b01fba2d40d68 URL: https://github.com/llvm/llvm-project/commit/335ac2eb662ce5f1888e2a50310b01fba2d40d68 DIFF: https://github.com/llvm/llvm-project/commit/335ac2eb662ce5f1888e2a50310b01fba2d40d68.diff LOG

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert marked 3 inline comments as done. jdoerfert added inline comments. Comment at: llvm/include/llvm/IR/OpenMPKinds.def:186 +///{ + +#ifndef OMP_IDENT_FLAG JonChesterfield wrote: > Meinersbur wrote: > > JonChesterfield wrote: > > > jdoerfert wrote: > > > >

[PATCH] D70142: [OpenMP5.0] Fix a parsing issue for the extended defaultmap

cchen created this revision. cchen added a reviewer: ABataev. Herald added subscribers: cfe-commits, guansong. Herald added a reviewer: jdoerfert. Herald added a project: clang. cchen retitled this revision from "[OpenMP5.0] Fix a parsing issue for the extended defaultmap This patch is for fixing

[PATCH] D70143: Check result of emitStrLen before passing it to CreateGEP

dim created this revision. dim added reviewers: xbolva00, spatel, jdoerfert, efriedma. Herald added subscribers: cfe-commits, hiraditya. Herald added projects: clang, LLVM. This fixes PR43081, where the transformation of `strchr(p, 0) -> p + strlen(p)` can cause a segfault, if `-fno-builtin-strlen

[PATCH] D70142: [OpenMP5.0] Fix a parsing issue for the extended defaultmap

ABataev added a comment. Add a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70142/new/ https://reviews.llvm.org/D70142 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D67750: Allow additional file suffixes/extensions considered as source in main include grouping

This revision was automatically updated to reflect the committed changes. Closed by commit rG335ac2eb662c: Allow additional file suffixes/extensions considered as source in main include… (authored by MyDeveloperDay). Changed prior to commit: https://reviews.llvm.org/D67750?vs=228872&id=228953#t

[PATCH] D70143: Check result of emitStrLen before passing it to CreateGEP

lebedev.ri added a comment. This should have a llvm ir test in `llvm/test/transforms/instcombine` i think, not a clang test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70143/new/ https://reviews.llvm.org/D70143 __

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

ABataev added inline comments. Comment at: llvm/lib/Frontend/OpenMPIRBuilder.cpp:228 + getOrCreateThreadID(getOrCreateIdent(SrcLocStr))}; + bool UseCancelBarrier = !ForceSimpleCall && CancellationBlock; + Value *Result = Builder.CreateCall( jd

[PATCH] D68185: [Diagnostics] Warn when class implements a copy constructor/copy assignment operator, but missing the copy assignment operator/copy constructor

xbolva00 added a comment. Yes, i will prepare a new patch and add him as a reviewer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68185/new/ https://reviews.llvm.org/D68185 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D70041: register cuda language activation event and activate for .cuh files

ptaylor added a comment. A similar PR has been submitted to the `vscode-cpptools` repo to enable debugging CUDA files via `cuda-gdb` with the official Microsoft VSCode C++ plugin: https://github.com/microsoft/vscode-cpptools/pull/4585 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: llvm/lib/Frontend/OpenMPIRBuilder.cpp:228 + getOrCreateThreadID(getOrCreateIdent(SrcLocStr))}; + bool UseCancelBarrier = !ForceSimpleCall && CancellationBlock; + Value *Re

[PATCH] D70144: clang-tidy: modernize-use-equals-default avoid adding redundant semicolons

poelmanc created this revision. poelmanc added reviewers: malcolm.parsons, angelgarcia, aaron.ballman. Herald added subscribers: cfe-commits, mgehre. Herald added a project: clang. `modernize-use-equals-default` replaces default constructors/destructors with `= default;`. When the optional semico

[PATCH] D70143: Check result of emitStrLen before passing it to CreateGEP

dim added a comment. In D70143#1742885 , @lebedev.ri wrote: > This should have a llvm ir test in `llvm/test/transforms/instcombine` i > think, not a clang test. Yes, I thought so too, but I could not get it to work (i.e. crash) with LLVM IR. I just do

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

ABataev added inline comments. Comment at: llvm/lib/Frontend/OpenMPIRBuilder.cpp:228 + getOrCreateThreadID(getOrCreateIdent(SrcLocStr))}; + bool UseCancelBarrier = !ForceSimpleCall && CancellationBlock; + Value *Result = Builder.CreateCall( jd

[PATCH] D67536: [clangd] Inactive regions support as an extension to semantic highlighting

nridge updated this revision to Diff 228959. nridge added a comment. Add unit tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67536/new/ https://reviews.llvm.org/D67536 Files: clang-tools-extra/clangd/ParsedAST.cpp clang-tools-extra/clangd

[PATCH] D67536: [clangd] Inactive regions support as an extension to semantic highlighting

nridge added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:143 +for (const SourceRange &R : + AST.getPreprocessor().getPreprocessingRecord()->getSkippedRanges()) { + if (isInsideMainFile(R.getBegin(), SM)) { hokei

  1   2   >