ABataev added inline comments.
================ Comment at: clang/lib/Parse/ParseOpenMP.cpp:2339-2345 + unsigned Modifier = getOpenMPSimpleClauseType( + Kind, Tok.isAnnotation() ? "" : PP.getSpelling(Tok)); + // Set defaultmap modifier to unknown if it is either scalar, aggregate, or + // pointer + if (Modifier < OMPC_DEFAULTMAP_MODIFIER_unknown) + Modifier = OMPC_DEFAULTMAP_MODIFIER_unknown; + Arg.push_back(Modifier); ---------------- cchen wrote: > ABataev wrote: > > I believe this problem exists in the original code? If so, better to split > > this patch and commit this fix in the separate patch. > Yes, this problem is from the original code, but `bool isDefaultmapModifier = > (M != OMPC_DEFAULTMAP_MODIFIER_unknown);` at line 16437 relies on this > change. Otherwise, I'll have to write `(M == OMPC_DEFAULTMAP_MODIFIER_to) || > (M == OMPC_DEFAULTMAP_MODIFIER_from) ||...`. > So do you think that I should just write `(M == OMPC_DEFAULTMAP_MODIFIER_to) > || (M == OMPC_DEFAULTMAP_MODIFIER_from) ||...` or `M > > OMPC_DEFAULTMAP_MODIFIER_unknown` for this patch and fix them in another > patch? You will just commit the second patch at first and then just rebase this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69204/new/ https://reviews.llvm.org/D69204 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
