[PATCH] D69950: Reapply "Fix crash on switch conditions of non-integer types in templates"

eandrews added a comment. The patch changes type dependency of field 'std::string s' and sets it based on field type (i.e. not type-dependent). I do not know how clang-tidy works internally, but I assume checker used to skip the field earlier since it was set as dependent (based on containing

[PATCH] D70052: [clang-tidy] Add misc-mutating-copy check

Eugene.Zelenko added a comment. In D70052#1741246 , @gbencze wrote: > In D70052#1740235 , @Eugene.Zelenko > wrote: > > > If this is CERT rule, why check is not placed in relevant module? > > > To be honest I was ho

[PATCH] D69876: Allow output constraints on "asm goto"

void updated this revision to Diff 228762. void added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Analyze "asm goto" for initialized variables. An "asm goto" statement is a terminator and thus doesn't indicate variable assignments like normal inline

[PATCH] D69876: Allow output constraints on "asm goto"

void added a comment. In D69876#1740289 , @jyknight wrote: > Also, since this means we are no longer simply implementing according to > GCC's documentation, I think this means we'll need a brand new section in the > Clang docs for its inline-asm support.

[PATCH] D69876: Allow output constraints on "asm goto"

void added a comment. In D69876#1740286 , @jyknight wrote: > I think -Wuninitialized (UninitializedValues.cpp) should be taught how to > detect the use of output variables in error blocks, at least for trivial > cases. > > Actually, for some reason -- it

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

ABataev added inline comments. Comment at: llvm/include/llvm/IR/OpenMPConstants.h:57 +#include "llvm/IR/OpenMPKinds.def" + LLVM_MARK_AS_BITMASK_ENUM(0x7FFF) +}; Why do you use `0x7FFF` as the largest value? Comment at: llvm/lib/IR/Open

[PATCH] D70099: [libcxx][test] Only call valarray::min and ::max on empty containers when testing libc++

CaseyCarter created this revision. CaseyCarter added reviewers: mclow.lists, EricWF, ldionne. Herald added a subscriber: dexonsmith. `valarray:min` and `valarray::max` have preconditions that require the `valarray` to be non-empty, so these calls are inherently non-portable. https://reviews.llv

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:16393-16416 +static DefaultMapImplicitBehavior +getImplicitBehaviorFromModifier(OpenMPDefaultmapClauseModifier M) { + switch (M) { + case OMPC_DEFAULTMAP_MODIFIER_allo

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert marked 2 inline comments as done. jdoerfert added inline comments. Comment at: llvm/include/llvm/IR/OpenMPConstants.h:57 +#include "llvm/IR/OpenMPKinds.def" + LLVM_MARK_AS_BITMASK_ENUM(0x7FFF) +}; ABataev wrote: > Why do you use `0x7FFF` as the

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:16393-16416 +static DefaultMapImplicitBehavior +getImplicitBehaviorFromModifier(OpenMPDefaultmapClauseModifier M) { + switch (M) { + case OMPC_DEFAULTMAP_MODIFIER_alloc: +return DMIB_alloc; + case OMP

[PATCH] D68407: [WIP][RISCV] Use compiler-rt if no GCC installation detected

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/RISCVToolchain.cpp:114 const char *LinkingOutput) const { - const ToolChain &ToolChain = getToolChain(); + const auto &ToolChain = getToolChain(); const Driver &D = ToolC

[PATCH] D68407: [WIP][RISCV] Use compiler-rt if no GCC installation detected

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/RISCVToolchain.cpp:49 + else +return ToolChain::RLT_CompilerRT; +} Ternary operator? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68407/new/ https://reviews.llvm.org/D68407

[PATCH] D67460: clang-tidy: modernize-use-using work with multi-argument templates

poelmanc updated this revision to Diff 228767. poelmanc added a comment. Changed post-increment/decrement to pre-increment/decrement. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67460/new/ https://reviews.llvm.org/D67460 Files: clang-tools-extr

[PATCH] D67460: clang-tidy: modernize-use-using work with multi-argument templates

poelmanc marked 2 inline comments as done. poelmanc added a comment. Done, thanks. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67460/new/ https://reviews.llvm.org/D67460 ___ cfe-commits mailing list c

[PATCH] D69238: Fix clang-tidy readability-redundant-string-init for c++17/c++2a

poelmanc added a comment. In D69238#1740914 , @gribozavr2 wrote: > Thanks! Do you have commit access or do you need me to commit for you? I don't have commit access, if you could commit it for me that would be great. Thanks! Repository: rCTE Clang T

[PATCH] D69548: Give clang-tidy readability-redundant-string-init a customizable list of string types to fix

poelmanc updated this revision to Diff 228769. poelmanc added a comment. Make requested fixes to documentation. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69548/new/ https://reviews.llvm.org/D69548 Files: clang-tools-extra/clang-tidy/readabili

Re: r373159 - For P0784R7: compute whether a variable has constant destruction if it

Hi Richard, I have a question about this commit. It looks like it started emitting `cxa_guard_acquire/release` calls in Objective-C code, for globals with constant initializers, causing link failures for things that don't link with libc++abi. Was that intentional? I'm still working on a reduced te

[PATCH] D67787: Add 8548 CPU definition and attributes

jhibbits added a comment. @vit9696 mind reviewing again with the added tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67787/new/ https://reviews.llvm.org/D67787 ___ cfe-commits mailing list cfe-c

[PATCH] D69876: Allow output constraints on "asm goto"

nickdesaulniers added a comment. In D69876#1741294 , @void wrote: > In D69876#1740286 , @jyknight wrote: > > > I think -Wuninitialized (UninitializedValues.cpp) should be taught how to > > detect the use of output

[PATCH] D70057: clang/Modules: Add missing diagnostics for malformed AST files

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Serialization/ASTReader.cpp:3412 + if (ParseLineTable(F, Record)) { +Error("malformed SOURCE_MANAGER_LINE_TABLE in AST file");

[PATCH] D70056: clang/Modules: Split loop in ReadAST between failable and not

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Serialization/ASTReader.cpp:4211 + // hit errors parsing the ASTs at this point. for (SmallVectorImpl::iterator M = Loaded.begin(),

[PATCH] D70063: clang/Modules: Error if ReadASTBlock does not find the main module

aprantl added a comment. Do we want to bother with a testcase for this? Comment at: clang/include/clang/Basic/DiagnosticSerializationKinds.td:78 +def err_module_file_missing_definition : Error< + "module file '%0' is missing the main module's definition">, DefaultFatal;

[PATCH] D70056: clang/Modules: Split loop in ReadAST between failable and not

dexonsmith marked an inline comment as done. dexonsmith added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:4236 + MEnd = Loaded.end(); + M != MEnd; ++M) { +ModuleFile &F = *M->Mod; apran

[PATCH] D69922: [OpenMP] Use the OpenMP-IR-Builder

jdoerfert updated this revision to Diff 228772. jdoerfert added a comment. update test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69922/new/ https://reviews.llvm.org/D69922 Files: clang/include/clang/Basic/LangOptions.def clang/include

[PATCH] D69922: [OpenMP] Use the OpenMP-IR-Builder

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69922/new/ https://reviews.llvm.org/D69922 ___

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D69876: Allow output constraints on "asm goto"

void added a comment. In D69876#1741381 , @nickdesaulniers wrote: > > Nice catch! I updated the patch with a fix. PTAL. > > Please add a test for that! I did, but the "arc" program pushed the wrong change. :-( Fixed. When are we going to use GitHub's P

[PATCH] D69876: Allow output constraints on "asm goto"

void updated this revision to Diff 228775. void added a comment. the real update this time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69876/new/ https://reviews.llvm.org/D69876 Files: clang/include/clang/AST/Stmt.h clang/lib/AST/Stmt.cpp

Re: r373159 - For P0784R7: compute whether a variable has constant destruction if it

Here's a reduced test case. ``` // OPTIONS: -x objective-c -std=gnu99 -fobjc-arc -emit-llvm @interface Foo @end Foo *foo() { static Foo *f = ((void*)0; return f; } // CHECK-NOT: cxa_guard ``` AFAIK clang should not emit C++ guard variables in non-C++ code. Is that correct? On Mon, 11 Nov 20

[PATCH] D70101: [X86] Fix the implementation of __readcr3/__writecr3 to work in 64-bit mode

rnk added a comment. What do you think of using `__INTPTR_TYPE__` for this instead? If that doesn't work, we could define and undefine our own macro to use as a typedef. The resulting code should be clean enough that we can generalize it to `__readcr0` etc. It looks like `long` is the correct

[PATCH] D69876: Allow output constraints on "asm goto"

void updated this revision to Diff 228777. void added a comment. Add blurb about asm goto with output constraints to the "language extensions" documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69876/new/ https://reviews.llvm.org/D69876

[PATCH] D69959: [C-index] Fix test when using Debug target & MSVC STL

rnk added a comment. I see. You know, these things would be nicely handled if we just had a reliable asynch SEH implementation. >_> What do you think of making `FrontendOptions::Inputs` be a `SmallVector<*, 0>`? It's janky and inconsistent with the rest of that struct, but it seems less invasi

[clang] eef6902 - clang/Modules: Delay err_module_file_conflict if a diagnostic is in flight

Author: Duncan P. N. Exon Smith Date: 2019-11-11T15:34:52-08:00 New Revision: eef69021607950487a9e4110851a05abb54d0fb6 URL: https://github.com/llvm/llvm-project/commit/eef69021607950487a9e4110851a05abb54d0fb6 DIFF: https://github.com/llvm/llvm-project/commit/eef69021607950487a9e4110851a05abb54d

[PATCH] D70058: clang/Modules: Delay err_module_file_conflict if a diagnostic is in flight

dexonsmith closed this revision. dexonsmith added a comment. Committed as eef69021607950487a9e4110851a05abb54d0fb6 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70058/new/ https://reviews.llvm.org/D70058

[clang] 01782c3 - clang/Modules: Split loop in ReadAST between failable and not

Author: Duncan P. N. Exon Smith Date: 2019-11-11T15:53:48-08:00 New Revision: 01782c3e4df1830d7991e9edfee9119ed41e4c27 URL: https://github.com/llvm/llvm-project/commit/01782c3e4df1830d7991e9edfee9119ed41e4c27 DIFF: https://github.com/llvm/llvm-project/commit/01782c3e4df1830d7991e9edfee9119ed41e

[clang] bfd58fc - clang/Modules: Use range-based for in ASTReader::ReadAST, NFC

Author: Duncan P. N. Exon Smith Date: 2019-11-11T15:53:48-08:00 New Revision: bfd58fc60ff4b0c081b5b489119c3798d3e2b53c URL: https://github.com/llvm/llvm-project/commit/bfd58fc60ff4b0c081b5b489119c3798d3e2b53c DIFF: https://github.com/llvm/llvm-project/commit/bfd58fc60ff4b0c081b5b489119c3798d3e2

[clang] 8e2c192 - clang/Modules: Add missing diagnostics for malformed AST files

Author: Duncan P. N. Exon Smith Date: 2019-11-11T16:00:47-08:00 New Revision: 8e2c192e2af8c760152ba3b28e774dbb1548e4aa URL: https://github.com/llvm/llvm-project/commit/8e2c192e2af8c760152ba3b28e774dbb1548e4aa DIFF: https://github.com/llvm/llvm-project/commit/8e2c192e2af8c760152ba3b28e774dbb1548

[PATCH] D70056: clang/Modules: Split loop in ReadAST between failable and not

dexonsmith closed this revision. dexonsmith added a comment. Committed in bfd58fc60ff4b0c081b5b489119c3798d3e2b53c and 01782c3e4df1830d7991e9edfee9119ed41e4c27

[PATCH] D69869: [clang-tools-extra] fix the check for if '-latomic' is necessary

gokturk added a comment. Let me try my best to explain what's happening. The goal of this check is to determine whether passing `-latomic` is required. Let's start with the code used by `check_working_cxx_atomics64` (https://github.com/llvm/llvm-project/blob/master/llvm/cmake/modules/CheckAtomi

[PATCH] D69766: [Clang][MSVC] Use GetLinkerPath like the other toolchains for consistency

rnk added a comment. In D69766#1739060 , @Ericson2314 wrote: > Reading https://llvm.org/docs/DeveloperPolicy.html it looks like I need to > submit an patch email? Is that true, or can/will someone with perms see the > approval and eventually merge it fro

[PATCH] D70057: clang/Modules: Add missing diagnostics for malformed AST files

dexonsmith closed this revision. dexonsmith added a comment. Committed 8e2c192e2af8c760152ba3b28e774dbb1548e4aa . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70057/new/ https://reviews.llvm.org/D70057 ___

[PATCH] D69962: [CFG] Fix a flaky crash in CFGBlock::getLastCondition().

NoQ added a comment. In D69962#1739440 , @NoQ wrote: > In D69962#1738618 , @Szelethus wrote: > > > Nice catch! Though, wouldn't the memory sanitizer buildbots break on this > > reliably? > > > I kinda hope so; i'll

[clang] c46b3a2 - clang/Modules: Clean up modules on error in ReadAST

Author: Duncan P. N. Exon Smith Date: 2019-11-11T16:36:02-08:00 New Revision: c46b3a2abd38d6fecd389c97dfa7df54af77fdb9 URL: https://github.com/llvm/llvm-project/commit/c46b3a2abd38d6fecd389c97dfa7df54af77fdb9 DIFF: https://github.com/llvm/llvm-project/commit/c46b3a2abd38d6fecd389c97dfa7df54af77

[PATCH] D69959: [C-index] Fix test when using Debug target & MSVC STL

dexonsmith added a comment. In D69959#1741456 , @rnk wrote: > What do you think of making `FrontendOptions::Inputs` be a `SmallVector<*, > 0>`? It's janky and inconsistent with the rest of that struct, but it seems > less invasive in the end. +1, we us

[PATCH] D70055: clang/Modules: Clean up modules on error in ReadAST

dexonsmith closed this revision. dexonsmith added a comment. Committed c46b3a2abd38d6fecd389c97dfa7df54af77fdb9 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70055/new/ https://reviews.llvm.org/D70055 ___

[PATCH] D70063: clang/Modules: Error if ReadASTBlock does not find the main module

bruno added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSerializationKinds.td:78 +def err_module_file_missing_definition : Error< + "module file '%0' is missing the main module's definition">, DefaultFatal; aprantl wrote: > Should this be

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

Meinersbur added inline comments. Comment at: llvm/include/llvm/IR/OpenMPKinds.def:186 +///{ + +#ifndef OMP_IDENT_FLAG JonChesterfield wrote: > jdoerfert wrote: > > Meinersbur wrote: > > > jdoerfert wrote: > > > > JonChesterfield wrote: > > > > > Sharing constant

[PATCH] D70047: [Analyzer] Use a reference in a range-based for

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM but the `&` should bind to the variable, not to the type, so that should be corrected before committing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70101: [X86] Fix the implementation of __readcr3/__writecr3 to work in 64-bit mode

craig.topper added a comment. In D70101#1741452 , @rnk wrote: > What do you think of using `__INTPTR_TYPE__` for this instead? If that > doesn't work, we could define and undefine our own macro to use as a typedef. > The resulting code should be clean en

[PATCH] D70045: [AST] Use an explicit copy in a range-based for

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70045/new/ https://reviews.llvm.org/D70045

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

jdoerfert updated this revision to Diff 228788. jdoerfert marked 2 inline comments as done. jdoerfert added a comment. Create llvm/libFrontend, move code there, make shared library builds work. llvm/IR/ is an unfortunate location as we cannot use llvm utility functions without introducing depende

[PATCH] D70101: [X86] Fix the implementation of __readcr3/__writecr3 to work in 64-bit mode

craig.topper added a comment. So in order to match the long and int behavior, I need two different macros to replace the argument? I think __INTPTR_TYPE__ will return int on 32-bit targets so I can't use that for the long case. But maybe for the __int64? CHANGES SINCE LAST ACTION https://rev

[PATCH] D70094: [clang-tidy] new altera ID dependent backward branch check

Eugene.Zelenko added inline comments. Comment at: clang-tidy/altera/IdDependentBackwardBranchCheck.cpp:106 +if (auto *ChildExpression = dyn_cast(*i)) { + auto Result = hasIdDepVar(ChildExpression); + if (Result) { Please don't use auto when type is

[PATCH] D70047: [Analyzer] Use a reference in a range-based for

NoQ added a comment. Yay thanks, i always forget those :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70047/new/ https://reviews.llvm.org/D70047 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D70063: clang/Modules: Error if ReadASTBlock does not find the main module

dexonsmith marked 2 inline comments as done. dexonsmith added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSerializationKinds.td:78 +def err_module_file_missing_definition : Error< + "module file '%0' is missing the main module's definition">, DefaultFatal;

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert updated this revision to Diff 228792. jdoerfert added a comment. Add cancel_barrier functionality + test, move everything to "Frontend" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69785/new/ https://reviews.llvm.org/D69785 Files: llv

[PATCH] D68682: Clang-tidy fix removals removing all non-blank text from a line should remove the line

poelmanc updated this revision to Diff 228795. poelmanc edited the summary of this revision. poelmanc added a comment. Move isWhitespace and skipNewlines to clang/Basic/CharInfo.h (renaming to isWhitespaceStringRef and skipNewlinesChars to resolve name clashes) and add double-quotes around "/n"

[PATCH] D68682: Clang-tidy fix removals removing all non-blank text from a line should remove the line

poelmanc marked 4 inline comments as done. poelmanc added inline comments. Comment at: clang/lib/AST/CommentLexer.cpp:20 + +// Consider moving this useful function to a more general utility location. +const char *skipNewline(const char *BufferPtr, const char *BufferEnd) { ---

[PATCH] D10833: Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface

tannergooding added a comment. Would it be beneficial for this to be just called `getOpcode`? If it was, it could also be applied to `UnaryOperator::getOpcode`. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10833/new/ https://reviews.llvm.org/D10833 _

[PATCH] D69922: [OpenMP] Use the OpenMP-IR-Builder

jdoerfert updated this revision to Diff 228801. jdoerfert added a comment. Use IRBuilder for cancel barriers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69922/new/ https://reviews.llvm.org/D69922 Files: clang/include/clang/Basic/LangOptions.de

[PATCH] D68362: [libunwind][RISCV] Add 64-bit RISC-V support

mhorne updated this revision to Diff 228799. mhorne marked an inline comment as done. mhorne added a comment. Convert checks for `__riscv_float_abi_double` to `__riscv_flen == 64`. Fix `_LIBUNWIND_HIGHEST_DWARF_REGISTER_RISCV`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68362/new/ h

[PATCH] D68362: [libunwind][RISCV] Add 64-bit RISC-V support

mhorne marked 3 inline comments as done. mhorne added inline comments. Comment at: libunwind/include/__libunwind_config.h:26 #define _LIBUNWIND_HIGHEST_DWARF_REGISTER_SPARC 31 +#define _LIBUNWIND_HIGHEST_DWARF_REGISTER_RISCV 63 luismarques wrote: > The

[PATCH] D69938: [OpenCL] Use __generic addr space when generating internal representation of lambda

rjmccall added a comment. In D69938#1741080 , @Anastasia wrote: > In D69938#1737196 , @rjmccall wrote: > > > It does make logical sense to be able to qualify the call operator of a > > lambda. The lambda always st

[PATCH] D70110: [Driver][FreeBSD] Enable unwind tables on !amd64

cem created this revision. cem added reviewers: dim, emaste. Herald added subscribers: cfe-commits, krytarowski. Herald added a project: clang. There doesn't seem to be much sense in defaulting "on" unwind tables on amd64 and not on other arches. It causes surprising differences between platforms

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

awpandey created this revision. awpandey added reviewers: aprantl, dblaikie, jini.susan.george, SouraVX, alok. awpandey added a project: debug-info. Herald added subscribers: llvm-commits, cfe-commits, ormris, hiraditya. Herald added projects: clang, LLVM. This patch, adds support for DW_AT_alignm

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

djtodoro added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp:803 + if (Tag == dwarf::DW_TAG_typedef && DD->getDwarfVersion() >= 5) { +uint32_t AlignInBytes = DTy->getAlignInBytes(); Please add a comment here. Com

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

djtodoro added a comment. @awpandey Thanks for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70111/new/ https://reviews.llvm.org/D70111 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

<    1   2