[PATCH] D70056: clang/Modules: Split loop in ReadAST between failable and not

[Adrian Prantl via Phabricator via cfe-commits]

aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/lib/Serialization/ASTReader.cpp:4211
+  // hit errors parsing the ASTs at this point.
   for (SmallVectorImpl<ImportedModule>::iterator M = Loaded.begin(),
                                               MEnd = Loaded.end();
----------------
and this?


================
Comment at: clang/lib/Serialization/ASTReader.cpp:4236
+                                              MEnd = Loaded.end();
+       M != MEnd; ++M) {
+    ModuleFile &F = *M->Mod;
----------------
Could this be a range-based for?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70056/new/

https://reviews.llvm.org/D70056



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits