[PATCH] D69520: [libc++] Disallow dynamic -> static span conversions

mclow.lists added inline comments. Comment at: libcxx/test/std/containers/views/span.cons/span.fail.cpp:78 - -// Try to remove const and/or volatile (static -> static) -{ Ok. The comment here is wrong; this is testing dynamic -> static. However, why are you

[PATCH] D69573: [clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly for some operator functions

MyDeveloperDay marked 5 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2105 + if ((Next->isSimpleTypeSpecifier() || Next->is(tok::identifier)) && + Next->Next && Next->Next->is(tok::star)) { +//

[PATCH] D69573: [clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly for some operator functions

MyDeveloperDay updated this revision to Diff 227405. MyDeveloperDay set the repository for this revision to rG LLVM Github Monorepo. MyDeveloperDay added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69573/new/ ht

[PATCH] D69573: [clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly for some operator functions

merge_guards_bot added a comment. Build result: pass - 59827 tests passed, 0 failed and 762 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

AntonBikineev added a comment. In D69435#1729580 , @gribozavr2 wrote: > Alright then. (Although I don't know whether the redeclaration chain always > models that wording in the standard, and what that wording means when we > don't have a linear ordering

Re: [PATCH] D55802: Change CGObjC to use objc intrinsics instead of runtime methods

Hi, I think the assumption that intrinsics can't read any global is, indeed, the problem here. `@llvm.objc.autoreleasePoolPop` may call any number of `-dealloc` methods with arbitrary side effects (though if they cause resurrection then that's undefined behaviour), so there should be no assu

[PATCH] D69657: [AArch64][SVE] Implement several floating-point arithmetic intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rG5ec34dfdf733: [AArch64][SVE] Implement several floating-point arithmetic intrinsics (authored by kmclaughlin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D69233: [OpenCL] Support -fdeclare-opencl-builtins in C++ mode

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69233/new/ https://reviews.llvm.org/D69233 ___

[PATCH] D69242: [Sema] Make helper in TreeTransform.h 'inline' instead of 'static'. NFC

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. I agree. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69242/new/ https://reviews.llvm.org/D69242 ___

[PATCH] D69383: [RISCV] Match GCC `-march`/`-mabi` driver defaults

lenary updated this revision to Diff 227418. lenary added a comment. - Update tests to reflect new defaults Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69383/new/ https://reviews.llvm.org/D69383 Files: clang/docs/ReleaseNotes.rst clang/lib/D

[PATCH] D69518: [Diagnostics] Warn for std::is_constant_evaluated in constexpr mode

davezarzycki added a comment. This broke two stage builds of libc++. Can we revert this until a fix is ready? FAIL: libc++ :: std/utilities/meta/meta.const.eval/is_constant_evaluated.fail.cpp (55845 of 59103) TEST 'libc++ :: std/utilities/meta/meta.const.eval/is_consta

[PATCH] D69706: [Diagnostics] Teach -Wnull-dereference about address_space attribute

xbolva00 created this revision. xbolva00 added reviewers: aaron.ballman, rsmith. xbolva00 added a project: clang. Herald added subscribers: libcxx-commits, christof. Herald added a project: libc++. Clang should not warn for: test.c:2:12: warning: indirection of non-volatile null pointer will be de

[PATCH] D69518: [Diagnostics] Warn for std::is_constant_evaluated in constexpr mode

xbolva00 added a comment. Line 918 Add: self.cxx.addWarningFlagIfSupported('-Wno-constant-evaluated') to libcxx/utils/libcxx/test/config.py Can you please try? cc @EricWF Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69518/new/ https://reviews.

[PATCH] D69706: [Diagnostics] Teach -Wnull-dereference about address_space attribute

xbolva00 added a comment. (mistake) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69706/new/ https://reviews.llvm.org/D69706 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D69707: [AArch64][SVE] Implement additional floating-point arithmetic intrinsics

kmclaughlin created this revision. kmclaughlin added reviewers: sdesmalen, huntergr, dancgr. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a project: LLVM. Adds intrinsics for the following: - ftssel - fcadd, fcmla - fmla, fmls, fnmla, fnmls - fmad, f

[PATCH] D69518: [Diagnostics] Warn for std::is_constant_evaluated in constexpr mode

davezarzycki added a comment. Hi @xbolva00 – Thanks. That does make the libcxx test suite pass. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69518/new/ https://reviews.llvm.org/D69518 ___ cfe-commits

[PATCH] D69518: [Diagnostics] Warn for std::is_constant_evaluated in constexpr mode

xbolva00 added a comment. Thanks! Commited in rGdba83965722b540f6baf43163210943c41e1378a Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69518/new/ https://reviews.llvm.org/D69518

[PATCH] D69498: IR: Invert convergent attribute handling

Anastasia added a comment. In D69498#1725692 , @kariddi wrote: > In D69498#1725528 , @rjmccall wrote: > > > It absolutely makes sense for Clang as a GPU-programming frontend to set > > attributes appropriately when

[PATCH] D14927: clang-format: Add SpaceBeforeTemplateParameterList option

MyDeveloperDay added a comment. This I believe is covered by `SpaceAfterTemplateKeyword` which does the same thing CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14927/new/ https://reviews.llvm.org/D14927 ___ cfe-commits mailing list cfe-co

[clang] 0aed36d - [OpenCL] Support -fdeclare-opencl-builtins in C++ mode

Author: Sven van Haastregt Date: 2019-11-01T13:56:43Z New Revision: 0aed36d261d38c8dbc98bc52be26189e0ce57e30 URL: https://github.com/llvm/llvm-project/commit/0aed36d261d38c8dbc98bc52be26189e0ce57e30 DIFF: https://github.com/llvm/llvm-project/commit/0aed36d261d38c8dbc98bc52be26189e0ce57e30.diff

[PATCH] D69233: [OpenCL] Support -fdeclare-opencl-builtins in C++ mode

This revision was automatically updated to reflect the committed changes. Closed by commit rG0aed36d261d3: [OpenCL] Support -fdeclare-opencl-builtins in C++ mode (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69233/new/ https://

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

ABataev added inline comments. Comment at: clang/include/clang/Basic/OpenMPKinds.def:426-436 +OPENMP_DEFAULTMAP_KIND(aggregate) +OPENMP_DEFAULTMAP_KIND(pointer) // Modifiers for 'defaultmap' clause. +OPENMP_DEFAULTMAP_MODIFIER(alloc) +OPENMP_DEFAULTMAP_MODIFIER(to) +OPENMP_DEF

[PATCH] D69715: NeonEmitter: change Type representation. NFC.

t.p.northover created this revision. t.p.northover added a reviewer: efriedma. Herald added a subscriber: mcrosier. Herald added a project: clang. This has been separated off from D69618 to reduce clutter. Instead of using a sequence of bools to describe whether

[PATCH] D69716: NeonEmitter: remove special 'a' modifier.

t.p.northover created this revision. t.p.northover added a reviewer: efriedma. Herald added a subscriber: mcrosier. Herald added a project: clang. This has been separated off from D69618 to reduce diff clutter, as it really stands on its own. The 'a' modifier is

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

This revision was automatically updated to reflect the committed changes. Closed by commit rGd36a03331026: [clang-tidy] New checker performance-trivially-destructible-check (authored by AntonBikineev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69

[clang-tools-extra] d36a033 - [clang-tidy] New checker performance-trivially-destructible-check

Author: Anton Bikineev Date: 2019-11-01T16:16:49+01:00 New Revision: d36a0333102698a1398971d0717465322b1c5c2c URL: https://github.com/llvm/llvm-project/commit/d36a0333102698a1398971d0717465322b1c5c2c DIFF: https://github.com/llvm/llvm-project/commit/d36a0333102698a1398971d0717465322b1c5c2c.diff

[PATCH] D69574: Remove lazy thread-initialisation

mmalcomson added a comment. Ping @pcc -- does this change to remove lazy thread initialisation look OK? (I'm looking to start upstreaming hwasan instrumentation to GCC soon, and need to know whether GCC must insert the thread initialisation code in function prologues) Repository: rG LLVM Gi

[PATCH] D69632: [libTooling] Add Stencil constructor.

ymandel updated this revision to Diff 227457. ymandel added a comment. renamed free function to avoid overloading a templated function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69632/new/ https://reviews.llvm.org/D69632 Files: clang/include

[PATCH] D69574: Remove lazy thread-initialisation

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69574/new/ https://reviews.llvm.org/D69574 ___ cfe-c

[PATCH] D69613: [libTooling] Simplify type structure of `Stencil`s.

ymandel marked an inline comment as done. ymandel added a comment. In D69613#1729703 , @gribozavr2 wrote: > I see. Some decoupling is desirable, I agree. Maybe move `StencilInterface` > and `Stencil` into a separate header that `RewriteRule` can depend on

[PATCH] D69625: [libTooling] Support implicit coercions in Stencil's `access` combinator.

ymandel added a comment. In D69625#1729702 , @gribozavr2 wrote: > > Which idiom do you think we should encourage, then, for text and > > range-selectors -- the named combinator or the single-argument cat? That is > > You are making a very interesting poin

[PATCH] D69360: [NFC] Refactor representation of materialized temporaries

Tyker updated this revision to Diff 227454. Tyker marked 8 inline comments as done. Tyker added a comment. fixed comments. i will do the other changes later. i also renamed MaterializeTemporaryExpr::GetTemporaryExpr to MaterializeTemporaryExpr::getSubExpr and change all uses of MaterializeTemp

[PATCH] D69638: [NFC] Add SUPPORT_PLUGINS to add_llvm_executable()

daltenty updated this revision to Diff 227461. daltenty added a comment. - Address review comments round 1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69638/new/ https://reviews.llvm.org/D69638 Files: clang/tools/driver/CMakeLists.txt llvm/c

[PATCH] D69638: [NFC] Add SUPPORT_PLUGINS to add_llvm_executable()

daltenty updated this revision to Diff 227463. daltenty marked an inline comment as done. daltenty added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69638/new/ https://reviews.llvm.org/D69638 Files: clang/tools/driver/CMake

[clang] 6e759da - [libTooling] Add Stencil constructor.

Author: Yitzhak Mandelbaum Date: 2019-11-01T11:53:14-04:00 New Revision: 6e759daf2ea891fdd624d68690cdafdadcca11c9 URL: https://github.com/llvm/llvm-project/commit/6e759daf2ea891fdd624d68690cdafdadcca11c9 DIFF: https://github.com/llvm/llvm-project/commit/6e759daf2ea891fdd624d68690cdafdadcca11c9.

[PATCH] D69632: [libTooling] Add Stencil constructor.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6e759daf2ea8: [libTooling] Add Stencil constructor. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69632/new/ https://reviews.llvm.org

[PATCH] D69699: [clang][driver] Add ProfileData to LLVM_LINK_COMPONENTS

vsk added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69699/new/ https://reviews.llvm.org/D69699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D69393: [RFC][DebugInfo] emit user specified address_space in dwarf

probinson added a subscriber: rsmith. probinson added a comment. In D69393#1729772 , @yonghong-song wrote: > During experimenting with linux kernel codes, I found that clang does not > allow address_space attribute for function pointers, specifically, in

[PATCH] D69625: [libTooling] Support implicit coercions in Stencil's `access` combinator.

gribozavr2 added a comment. > Are you suggesting we remove text and selection entirely? Yes! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69625/new/ https://reviews.llvm.org/D69625 ___ cfe-commits ma

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc updated this revision to Diff 227470. mibintc added a comment. Respond to recent code review from @rjmccall ; I modified the test cases and added functions for translating between the LangOptions enumeration and llvm enumeration for rounding-mode and exception-behavior. I wasn't able to

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:133 + +llvm::ConstrainedFPIntrinsic::ExceptionBehavior +CodeGenFunction::ToConstrainedExceptMD(LangOptions::FPExceptionModeKind Kind) { I added these 2 functions, is this what you ha

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

hliao added a comment. kindly PING for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69322/new/ https://reviews.llvm.org/D69322 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D69613: [libTooling] Simplify type structure of `Stencil`s.

ymandel updated this revision to Diff 227473. ymandel added a comment. addressed to comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69613/new/ https://reviews.llvm.org/D69613 Files: clang/include/clang/Tooling/Transformer/Stencil.h clan

[PATCH] D57829: [CUDA][HIP] Disable emitting llvm.linker.options in device compilation

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:389-392 + // The linker_option directives are intended for host compilation. + if (JA.isDeviceOffloading(Action::OFK_Cuda) || + JA.isDeviceOffloading(Action::OFK_HIP)) +Default = false; --

[PATCH] D69613: [libTooling] Simplify type structure of `Stencil`s.

ymandel marked 12 inline comments as done. ymandel added a comment. In D69613#1730238 , @ymandel wrote: > In D69613#1729703 , @gribozavr2 > wrote: > > > I see. Some decoupling is desirable, I agree. Maybe move `Ste

[PATCH] D68781: [OpenCL] Fix address space for const method call from nonconst

svenvh updated this revision to Diff 227476. svenvh retitled this revision from "[OpenCL] Fix addr space conversion check in obj arg initialization" to "[OpenCL] Fix address space for const method call from nonconst". svenvh set the repository for this revision to rC Clang. svenvh added a comment

[PATCH] D69613: [libTooling] Simplify type structure of `Stencil`s.

ymandel updated this revision to Diff 227478. ymandel marked an inline comment as done. ymandel added a comment. remove stray comments; clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69613/new/ https://reviews.llvm.org/D69613 Files:

[clang] 935c84c - [WebAssembly] Add experimental SIMD dot product instruction

Author: Thomas Lively Date: 2019-11-01T10:45:48-07:00 New Revision: 935c84c3c27de4544917216fc2b0557314802202 URL: https://github.com/llvm/llvm-project/commit/935c84c3c27de4544917216fc2b0557314802202 DIFF: https://github.com/llvm/llvm-project/commit/935c84c3c27de4544917216fc2b0557314802202.diff

[PATCH] D69697: [WebAssembly] Add experimental SIMD dot product instruction

This revision was automatically updated to reflect the committed changes. Closed by commit rG935c84c3c27d: [WebAssembly] Add experimental SIMD dot product instruction (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69697/new/ ht

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/include/clang/Basic/OpenMPKinds.def:426-436 +OPENMP_DEFAULTMAP_KIND(aggregate) +OPENMP_DEFAULTMAP_KIND(pointer) // Modifiers for 'defaultmap' clause. +OPENMP_DEFAULTMAP_MODIFIER(alloc) +OPEN

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

ABataev added inline comments. Comment at: clang/include/clang/Basic/OpenMPKinds.def:426-436 +OPENMP_DEFAULTMAP_KIND(aggregate) +OPENMP_DEFAULTMAP_KIND(pointer) // Modifiers for 'defaultmap' clause. +OPENMP_DEFAULTMAP_MODIFIER(alloc) +OPENMP_DEFAULTMAP_MODIFIER(to) +OPENMP_DEF

[PATCH] D68074: [clang-tidy] Add readability-make-member-function-const

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/readability/MakeMemberFunctionConstCheck.cpp:180 +// use((const S*)this); +// (const S*)->f() +// when 'f'

[PATCH] D69184: [libTooling] Introduce general combinator for fixed-value `MatchConsumer`s.

gribozavr2 added a comment. > In fact, it might be a good idea to rename `change` to `changeTo` (WDYT?). I like it. It should combine well with all stencils, not just `text`. > An alternative, is not to introduce a new combinator at all, and just use > Stencils: I think we are converging on th

[PATCH] D69184: [libTooling] Introduce general combinator for fixed-value `MatchConsumer`s.

ymandel added a comment. In D69184#1730523 , @gribozavr2 wrote: > > In fact, it might be a good idea to rename `change` to `changeTo` (WDYT?). > > I like it. It should combine well with all stencils, not just `text`. Agreed. Will do. > > >> An alterna

[PATCH] D69651: [CMake] Add cross ARM toolchain CMake cache file.

vvereschaka updated this revision to Diff 227501. vvereschaka edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69651/new/ https://reviews.llvm.org/D69651 Files: clang/cmake/caches/CrossWinToARMLinux.cmake Index:

[PATCH] D69726: [analyzer] DynamicSize: Store the dynamic size

Charusso created this revision. Charusso added a reviewer: NoQ. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. This patch introduces a way to store the symbolic size and its

[PATCH] D69642: [analyzer] DynamicSize: Simplify the assumption creating of sizes

Charusso abandoned this revision. Charusso added a comment. I think we do not need to create assumptions. However, there is a tiny difference which continues in D69726 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69642/new/ htt

[PATCH] D69726: [analyzer] DynamicSize: Store the dynamic size

Charusso marked an inline comment as done. Charusso added a comment. I do not want to reverse engineer the `MallocChecker` to obtain the size on call basis. The current model without D68725 makes it enough difficult to obtain the size even with this generic map,

[PATCH] D69651: [CMake] Add cross Windows to ARM Linux toolchain CMake cache file.

andreil99 accepted this revision. andreil99 added a comment. This revision is now accepted and ready to land. Thanks, Vlad! Looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69651/new/ https://reviews.llvm.org/D69651

[PATCH] D69651: [CMake] Add cross Windows to ARM Linux toolchain CMake cache file.

gkistanova accepted this revision. gkistanova added a comment. LGTM. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69651/new/ https://reviews.llvm.org/D69651 ___ cfe-commits mailing list cfe

[clang] a264e85 - [CMake] Add cross Windows to ARM Linux toolchain CMake cache file.

Author: Vladimir Vereschaka Date: 2019-11-01T12:40:25-07:00 New Revision: a264e85dd9f99391bedc7f069926bdd8d2f44388 URL: https://github.com/llvm/llvm-project/commit/a264e85dd9f99391bedc7f069926bdd8d2f44388 DIFF: https://github.com/llvm/llvm-project/commit/a264e85dd9f99391bedc7f069926bdd8d2f44388

[PATCH] D69731: [analyzer] CheckerContext: Make the Preprocessor available

Charusso created this revision. Charusso added a reviewer: NoQ. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Charusso added a parent revision: D69726: [analyzer] DynamicSize

[PATCH] D69651: [CMake] Add cross Windows to ARM Linux toolchain CMake cache file.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa264e85dd9f9: [CMake] Add cross Windows to ARM Linux toolchain CMake cache file. (authored by vvereschaka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D696

[PATCH] D69716: NeonEmitter: remove special 'a' modifier.

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69716/new/ https://reviews.llvm.org/D69716 ___

[PATCH] D69731: [analyzer] CheckerContext: Make the Preprocessor available

Charusso marked an inline comment as done. Charusso added a comment. It is needed for my work, and also I have seen other checkers in need of that. Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:195 ASTContext *Ctx; - const Preprocessor &PP; const std

[PATCH] D69599: [analyzer] DynamicSize: Remove 'getSizeInElements()' from store

NoQ added a comment. > This is the first step to mitigate that issue. What's the issue? Comment at: clang/lib/StaticAnalyzer/Core/DynamicSize.cpp:37-39 + const llvm::APSInt *SizeInt = SVB.getKnownValue(State, Size); + if (!SizeInt) +return UnknownVal();

[PATCH] D69662: [Checkers] Avoid using evalCall in StreamChecker.

NoQ added a comment. But why? Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:161 .castAs(); state = state->BindExpr(CE, C.getLocationContext(), RetVal); You're not allowed to do this in `checkPostCall` because other post-call c

[PATCH] D69732: [WIP][LTO] Apply SamplePGO pipeline tunes for ThinLTO pre-link to full LTO

tejohnson created this revision. tejohnson added reviewers: wristow, ormris. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, steven_wu, hiraditya, inglorion, mehdi_amini. Herald added projects: clang, LLVM. There are several modifications to the optimizations performed by the Thi

[PATCH] D69715: NeonEmitter: change Type representation. NFC.

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. I guess the extra checks are due to existing code "accidentally" doing the right thing? Have you verified this is NFC in terms of the generated arm_neon.h etc? LGTM Repository: rG LLV

[PATCH] D69732: [WIP][LTO] Apply SamplePGO pipeline tunes for ThinLTO pre-link to full LTO

tejohnson added a comment. This probably needs to be taken over by someone who cares about full LTO performance (@wristow or @ormris ?). This patch was some cleanup of the full LTO sample PGO pipeline, but has a number of issues I enumerate in the summary. Repository: rG LLVM Github Monorepo

[PATCH] D69726: [analyzer] DynamicSize: Store the dynamic size

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/DynamicSize.h:29-31 +/// \returns The stored dynamic size expression for the region \p MR. +const Expr *getDynamicSizeExpr(ProgramStateRef State, const MemRegion *MR); +

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:133 + +llvm::ConstrainedFPIntrinsic::ExceptionBehavior +CodeGenFunction::ToConstrainedExceptMD(LangOptions::FPExceptionModeKind Kind) { mibintc wrote: > I added these 2 functions, i

[clang] 52ea308 - [NFC]: Removed an implicit capture argument from lambda.

Author: Sourabh Singh Tomar Date: 2019-11-02T01:37:46+05:30 New Revision: 52ea308f705af0a8f5d55e036a64fd2b5e4c2ee6 URL: https://github.com/llvm/llvm-project/commit/52ea308f705af0a8f5d55e036a64fd2b5e4c2ee6 DIFF: https://github.com/llvm/llvm-project/commit/52ea308f705af0a8f5d55e036a64fd2b5e4c2ee6

[PATCH] D69731: [analyzer] CheckerContext: Make the Preprocessor available

NoQ added a comment. Also path-insensitive checkers will probably benefit a lot more from this info. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69731/new/ https://reviews.llvm.org/D69731 ___ cfe-commits mailing li

[PATCH] D69731: [analyzer] CheckerContext: Make the Preprocessor available

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. We probably need this because every time we try to deal with macros we struggle quite a bit. I'm not sure though - because we somehow survived without this for like 10 years. Eg. `BugReporterVisito

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

lewis-revill updated this revision to Diff 227512. lewis-revill added a comment. Herald added a subscriber: sameer.abuasal. Rebased and merged D68644 into this patch - this patch already assumes shrink wrapping support anyway. Repository: rG LLVM Github Monor

[PATCH] D69599: [analyzer] DynamicSize: Remove 'getSizeInElements()' from store

Charusso updated this revision to Diff 227524. Charusso marked 2 inline comments as done. Charusso added a comment. - Fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69599/new/ https://reviews.llvm.org/D69599 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/DynamicSize

[PATCH] D69599: [analyzer] DynamicSize: Remove 'getSizeInElements()' from store

Charusso added a comment. In D69599#1730707 , @NoQ wrote: > > This is the first step to mitigate that issue. > > What's the issue? Well, after I mentioned an issue I have realized the somewhat path-insensitive `getSizeInElements()` does not touch the (v

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc updated this revision to Diff 227527. mibintc added a comment. Recoded ToConstrainedRoundingMD and ToConstrainedExceptionMD as requested by @rjmccall CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731 Files: clang/docs/UsersManual.rst

[PATCH] D69599: [analyzer] DynamicSize: Remove 'getSizeInElements()' from store

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/DynamicSize.cpp:40-48 + if (const llvm::APSInt *SizeInt = SVB.getKnownValue(State, Size)) { +CharUnits RegionSize = CharUnits::fromQuantity(SizeInt->getSExtValue()); + +// If a variable is reinterpreted

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:137 + llvm_unreachable("Unsupported FP Exception Behavior"); +} + Sorry for dragging this out, but is there a reason these need to be member functions on `CodeGenFunction` rather

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc updated this revision to Diff 227532. mibintc added a comment. Made a couple functions static per @rjmccall request Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731 Files: clang/docs/UsersManual.rst clang/includ

[PATCH] D69599: [analyzer] DynamicSize: Remove 'getSizeInElements()' from store

Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/DynamicSize.cpp:40-48 + if (const llvm::APSInt *SizeInt = SVB.getKnownValue(State, Size)) { +CharUnits RegionSize = CharUnits::fromQuantity(SizeInt->getSExtValue()); + +// If a variable is reinterp

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc marked an inline comment as done. mibintc added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:133 + +llvm::ConstrainedFPIntrinsic::ExceptionBehavior +CodeGenFunction::ToConstrainedExceptMD(LangOptions::FPExceptionModeKind Kind) { rjmc

[PATCH] D69726: [analyzer] DynamicSize: Store the dynamic size

Charusso added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/DynamicSize.h:29-31 +/// \returns The stored dynamic size expression for the region \p MR. +const Expr *getDynamicSizeExpr(ProgramStateRef State, const MemRegion *MR); + ---

[PATCH] D69726: [analyzer] DynamicSize: Store the dynamic size

Charusso updated this revision to Diff 227534. Charusso marked 6 inline comments as done. Charusso added a comment. - Fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69726/new/ https://reviews.llvm.org/D69726 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/DynamicSize

[PATCH] D69732: [WIP][LTO] Apply SamplePGO pipeline tunes for ThinLTO pre-link to full LTO

wenlei added a comment. > The comments indicate that this is in part due to issues with > the new PM loop pass manager Wondering how different it is for these loop passes to be enabled for MonoLTO vs ThinLTO? If it's due to problems with the newPM, I guess ThinLTO would have the same problems?

[PATCH] D69731: [analyzer] CheckerContext: Make the Preprocessor available

Charusso added a comment. In D69731#1730784 , @NoQ wrote: > I'm not sure though - because we somehow survived without this for like 10 > years. Eg. `BugReporterVisitors.cpp`: [...] > I'd love to see some actual use before committing. "Teaser": const

[PATCH] D69599: [analyzer] DynamicSize: Remove 'getSizeInElements()' from store

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/DynamicSize.cpp:40-48 + if (const llvm::APSInt *SizeInt = SVB.getKnownValue(State, Size)) { +CharUnits RegionSize = CharUnits::fromQuantity(SizeInt->getSExtValue()); + +// If a variable is reinterpreted

[PATCH] D69731: [analyzer] CheckerContext: Make the Preprocessor available

NoQ added a comment. It sounds like the code is querying the temporary internal state of the preprocessor which is supposed to be queried during preprocessing, not after it. Say, `PP.isMacroDefined("__STDC_LIB_EXT1__")` clearly depends on the location, as a macro can be un-defined and re-define

[clang] 42465f4 - DebugInfo: (NFC) Refactor DWARF version calculation to make a future change (-fdebug-default-version) easier

Author: David Blaikie Date: 2019-11-01T14:56:43-07:00 New Revision: 42465f406bcea5ea06001ccc52ab779120b68e87 URL: https://github.com/llvm/llvm-project/commit/42465f406bcea5ea06001ccc52ab779120b68e87 DIFF: https://github.com/llvm/llvm-project/commit/42465f406bcea5ea06001ccc52ab779120b68e87.diff

[PATCH] D69599: [analyzer] DynamicSize: Remove 'getSizeInElements()' from store

Charusso added a comment. Thanks, now it is cool! Comment at: clang/lib/StaticAnalyzer/Core/DynamicSize.cpp:40-48 + if (const llvm::APSInt *SizeInt = SVB.getKnownValue(State, Size)) { +CharUnits RegionSize = CharUnits::fromQuantity(SizeInt->getSExtValue()); + +// If a

[PATCH] D69599: [analyzer] DynamicSize: Remove 'getSizeInElements()' from store

Charusso updated this revision to Diff 227543. Charusso marked 4 inline comments as done. Charusso added a comment. - Old division swapped by `evalBinOp`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69599/new/ https://reviews.llvm.org/D69599 Files: clang/include/clang/StaticAnalyze

[PATCH] D69638: [NFC] Add SUPPORT_PLUGINS to add_llvm_executable()

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69638/new/ https://reviews.llvm.org/D69638 ___ c

[PATCH] D69540: [analyzer] DynamicSize: Remove 'getExtent()' from regions

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Fantastic, let's land this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69540/new/ https://reviews.llvm.org/D69540 ___ cfe-commits mailing l

[PATCH] D69599: [analyzer] DynamicSize: Remove 'getSizeInElements()' from store

NoQ accepted this revision. NoQ added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/StaticAnalyzer/Core/DynamicSize.cpp:40-48 + if (const llvm::APSInt *SizeInt = SVB.getKnownValue(State, Size)) { +CharUnits RegionSize = CharUnits::fr

[clang] 098d901 - DebugInfo: Let -gdwarf use the toolchain default DWARF version, instead of hardcoded/aliased to -gdwarf-4

Author: David Blaikie Date: 2019-11-01T15:17:51-07:00 New Revision: 098d901bd1be07f60c41450fa4af775b130117b9 URL: https://github.com/llvm/llvm-project/commit/098d901bd1be07f60c41450fa4af775b130117b9 DIFF: https://github.com/llvm/llvm-project/commit/098d901bd1be07f60c41450fa4af775b130117b9.diff

[PATCH] D69731: [analyzer] CheckerContext: Make the Preprocessor available

Charusso added a comment. In D69731#1730899 , @NoQ wrote: > Clang-Tidy's `PPCallbacks` subsystem looks much more realistic. I wanted to make it available from the `AnalysisManager` so that I can obtain the macro definitions once before the analysis star

[clang] 1de2a05 - DebugInfo: Accept -gdwarf even in clang-cl

Author: David Blaikie Date: 2019-11-01T15:36:15-07:00 New Revision: 1de2a05701e73f8ef5914c2f6ea2dcbe617ce18b URL: https://github.com/llvm/llvm-project/commit/1de2a05701e73f8ef5914c2f6ea2dcbe617ce18b DIFF: https://github.com/llvm/llvm-project/commit/1de2a05701e73f8ef5914c2f6ea2dcbe617ce18b.diff

[PATCH] D69599: [analyzer] DynamicSize: Remove 'getSizeInElements()' from store

Charusso updated this revision to Diff 227546. Charusso marked 3 inline comments as done. Charusso added a comment. - Done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69599/new/ https://reviews.llvm.org/D69599 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/DynamicSiz

  1   2   >