ABataev added inline comments.
================ Comment at: clang/include/clang/Basic/OpenMPKinds.def:426-436 +OPENMP_DEFAULTMAP_KIND(aggregate) +OPENMP_DEFAULTMAP_KIND(pointer) // Modifiers for 'defaultmap' clause. +OPENMP_DEFAULTMAP_MODIFIER(alloc) +OPENMP_DEFAULTMAP_MODIFIER(to) +OPENMP_DEFAULTMAP_MODIFIER(from) ---------------- cchen wrote: > ABataev wrote: > > Add some guards in the code, these values must be enabled only for OpenMP > > 5.0, for 4.5 only scalar:tofrom is allowed. Add a test that the error > > messages are emitted for new cases in OpenMP 4.5 > Do you mean that I should add the guards in this file (OpenMPKinds.def) so > that Clang will not even parse those new keywords for OpenMP < 50 or I could > just check the use of those keywords in Sema? > If I should put guards in the .def file, could you give me any hint or point > me to an example? Thanks! No, not in this file, this is just general comment. You need to guard this during semantic analysis Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69204/new/ https://reviews.llvm.org/D69204 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
