[PATCH] D69518: [Diagnostics] Warn for std::is_constant_evaluated in constexpr mode

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticASTKinds.td:334 + "'%0' will always evaluate to 'true' in constexpr context">, + InGroup>; + rsmith wrote: > Looks like you decided not to

[PATCH] D69624: [clangd] Fix namespace aliases in findExplicitReferences

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. This looks good, but it is missing the context. I suppose we were previously not providing any references for namespace aliases, because we were filtering both the alias and the underlying

[PATCH] D69618: NeonEmitter: clean up prototype modifiers

t.p.northover added a comment. > It looks like this patch contains a few other changes, besides the changes to > the prototypes. In particular, the change to CGBuiltin.cpp, and there are a > few new lines in the .td files that don't correspond to anything in the old > versions. Is that accident

[PATCH] D68937: [clangd] Add parameter renaming to define-inline code action

kadircet updated this revision to Diff 227233. kadircet marked an inline comment as done. kadircet added a comment. - Address comments - Get rid of raw string literals inside macro calls, to not break stage1 compilers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

AntonBikineev added a comment. Roman, thanks for reviewing and the ideas. > Can you be more specific what the question is? I meant to ping if anybody has more comments on this patch. Otherwise I would go ahead and submit it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69435/new/ ht

[clang-tools-extra] 71aa3f7 - [clangd] Add parameter renaming to define-inline code action

Author: Kadir Cetinkaya Date: 2019-10-31T09:23:09+01:00 New Revision: 71aa3f7b7e43bf7d2a8a38324b1f9f7b12bbbdfc URL: https://github.com/llvm/llvm-project/commit/71aa3f7b7e43bf7d2a8a38324b1f9f7b12bbbdfc DIFF: https://github.com/llvm/llvm-project/commit/71aa3f7b7e43bf7d2a8a38324b1f9f7b12bbbdfc.dif

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

sylvestre.ledru added a comment. Did you see some significant perf improvements for Chromium? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69435/new/ https://reviews.llvm.org/D69435 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D68937: [clangd] Add parameter renaming to define-inline code action

This revision was automatically updated to reflect the committed changes. Closed by commit rG71aa3f7b7e43: [clangd] Add parameter renaming to define-inline code action (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68937/new/

[PATCH] D68937: [clangd] Add parameter renaming to define-inline code action

merge_guards_bot added a comment. Build result: pass - 59704 tests passed, 0 failed and 762 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D69518: [Diagnostics] Warn for std::is_constant_evaluated in constexpr mode

xbolva00 updated this revision to Diff 227237. xbolva00 added a comment. Fixed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69518/new/ https://reviews.llvm.org/D69518 Files: clang/include/clang/Basic/DiagnosticASTKinds.td cla

[PATCH] D69518: [Diagnostics] Warn for std::is_constant_evaluated in constexpr mode

xbolva00 added a comment. Thanks you for the review and advices! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69518/new/ https://reviews.llvm.org/D69518 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D69518: [Diagnostics] Warn for std::is_constant_evaluated in constexpr mode

This revision was automatically updated to reflect the committed changes. Closed by commit rGb06305e44949: [Diagnostics] Warn for std::is_constant_evaluated in constexpr mode (authored by xbolva00). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69518

[PATCH] D69577: [clang-format] [PR35518] C++17 deduction guides are wrongly formatted

MyDeveloperDay updated this revision to Diff 227241. MyDeveloperDay marked an inline comment as done. MyDeveloperDay set the repository for this revision to rC Clang. MyDeveloperDay added a comment. Address review comments, deduction guides with embedded parens Repository: rC Clang CHANGES SI

[PATCH] D69624: [clangd] Fix namespace aliases in findExplicitReferences

kadircet added a comment. As discussed offline, it might make more sense to fix this in `targetDecls` itself. Considering how the `Alias` is handled for typedefs and usings, it feels like this is a mistake for namespace aliases to be marked in that way. Repository: rG LLVM Github Monorepo C

[clang] 92aa0c2 - [cfi] Add flag to always generate .debug_frame

Author: David Candler Date: 2019-10-31T09:48:30Z New Revision: 92aa0c2dbcb723d102c508f6e7559330b637f912 URL: https://github.com/llvm/llvm-project/commit/92aa0c2dbcb723d102c508f6e7559330b637f912 DIFF: https://github.com/llvm/llvm-project/commit/92aa0c2dbcb723d102c508f6e7559330b637f912.diff LOG:

[PATCH] D67216: [cfi] Add flag to always generate .debug_frame

This revision was automatically updated to reflect the committed changes. Closed by commit rG92aa0c2dbcb7: [cfi] Add flag to always generate .debug_frame (authored by dcandler). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67216/new/ https://review

[PATCH] D69560: [clang-tidy] Add 'cppcoreguidelines-avoid-adjacent-arguments-of-same-type' check

whisperity updated this revision to Diff 227254. whisperity added a comment. - Removed //`This check`// from the documentation comment of the check's class too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69560/new/ https://reviews.llvm.org/D69560 Files: clang-tools-extra/clang-t

[PATCH] D69560: [clang-tidy] Add 'cppcoreguidelines-avoid-adjacent-arguments-of-same-type' check

whisperity marked 11 inline comments as done. whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AdjacentArgumentsOfSameTypeCheck.cpp:488 +void AdjacentArgumentsOfSameTypeCheck::registerMatchers(MatchFinder *Finder) { + if (!getLangOpts

[PATCH] D69560: [clang-tidy] Add 'cppcoreguidelines-avoid-adjacent-arguments-of-same-type' check

whisperity updated this revision to Diff 227253. whisperity added a comment. - Fix some comments, formatting and documentation - Organised test files to be in the same directory as others on the Monorepo structure - Helper functions moved from `namespace (anonymous)` to `static`. - Added test for

[PATCH] D14927: clang-format: Add SpaceBeforeTemplateParameterList option

MyDeveloperDay added inline comments. Comment at: include/clang/Format/Format.h:500 + /// bracket of a template parameter list. + bool SpaceBeforeTemplateParameterList; + I suggest we make this an enumeration ``` enum { Unaltered, Never, Always, } ``` Introdu

[PATCH] D69657: [AArch64][SVE] Implement several floating-point arithmetic intrinsics

kmclaughlin created this revision. kmclaughlin added reviewers: huntergr, sdesmalen, dancgr. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a project: LLVM. Adds intrinsics for the following: - fabd, fadd, fsub & fsubr - fmul, fmulx, fdiv & fdivr - fma

[PATCH] D69649: [clang-format] Fix SpacesInSquareBrackets for Lambdas with Initial "&ref" Parameter

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Thanks for the patch, sorry I must have missed this coming in. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69649/new/ https://reviews.ll

[PATCH] D33944: git-clang-format: Add --cached option to format index

MyDeveloperDay added a comment. Is this revision still relavant, I find it annoying that I have to run git add again on any files that are already added but have been formatted. If you think this is useful and can rebase it perhaps we can go around the review cycle again with a fresh set of eye

[PATCH] D69162: [clangd] Remove using-namespace present inside a namespace.

ilya-biryukov added a comment. One important question about running on the whole TU in all cases. Other than that LG Comment at: clang-tools-extra/clangd/refactor/tweaks/RemoveUsingNamespace.cpp:110 return false; - if (!dyn_cast(TargetDirective->getDeclContext())) -

[PATCH] D69520: [libc++] Disallow dynamic -> static span conversions

jdoerrie added a comment. Thanks Jorg! Given that the status is still "Needs Review", I assume I also still need an LGTM from Marshall, Louis or Eric, right? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69520/new/ https://reviews.llvm.org/D69520

[PATCH] D69624: [clangd] Fix namespace aliases in findExplicitReferences

ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. In D69624#1728377 , @kadircet wrote: > As discussed offline, it might make more sense to fix this in `targetDecls` > itself. Considering how the `Alias` is handled for typedefs

[clang] 4b6597f - Make flang driver stuff work on macOS

Author: Nico Weber Date: 2019-10-31T07:34:32-04:00 New Revision: 4b6597f49896529170fde38f5d5fb46d687e0c71 URL: https://github.com/llvm/llvm-project/commit/4b6597f49896529170fde38f5d5fb46d687e0c71 DIFF: https://github.com/llvm/llvm-project/commit/4b6597f49896529170fde38f5d5fb46d687e0c71.diff LO

[PATCH] D69636: Make flang driver stuff work on macOS

This revision was automatically updated to reflect the committed changes. Closed by commit rG4b6597f49896: Make flang driver stuff work on macOS (authored by thakis). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D67706: [clang][analyzer] Using CallDescription in StreamChecker.

This revision was automatically updated to reflect the committed changes. balazske marked 3 inline comments as done. Closed by commit rG4980c1333fa4: [clang][analyzer] Using CallDescription in StreamChecker. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 2573798 - Build fix after 4b6597f

Author: Nico Weber Date: 2019-10-31T07:43:09-04:00 New Revision: 257379855af245abb6c0fc11331d3f45ab0656dd URL: https://github.com/llvm/llvm-project/commit/257379855af245abb6c0fc11331d3f45ab0656dd DIFF: https://github.com/llvm/llvm-project/commit/257379855af245abb6c0fc11331d3f45ab0656dd.diff LO

[PATCH] D69162: [clangd] Remove using-namespace present inside a namespace.

usaxena95 updated this revision to Diff 227267. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69162/new/ https://reviews.llvm.org/D69162 Files: clang-tools-extra/clangd/refactor/tweaks/RemoveUsingNa

[PATCH] D69657: [AArch64][SVE] Implement several floating-point arithmetic intrinsics

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. Thanks @kmclaughlin, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69657/new/ https://reviews.llvm.org/D69657 ___

[PATCH] D69162: [clangd] Remove using-namespace present inside a namespace.

usaxena95 marked 3 inline comments as done. usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/RemoveUsingNamespace.cpp:179 + + if (ContainingNS) { +for (auto ReDeclNS : ContainingNS->redecls()) ilya-biryukov wrote: > Coul

[PATCH] D68937: [clangd] Add parameter renaming to define-inline code action

thakis added inline comments. Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:1388 // results in arbitrary failures as function body becomes NULL. ExtraArgs.push_back("-fno-delayed-template-parsing"); + for (const auto &Case : Cases) You migh

[PATCH] D68937: [clangd] Add parameter renaming to define-inline code action

thakis added a comment. This is failing on Windows: http://45.33.8.238/win/1481/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68937/new/ https://reviews.llvm.org/D68937 ___ cfe-commits maili

[PATCH] D69162: [clangd] Remove using-namespace present inside a namespace.

merge_guards_bot added a comment. Build result: fail - 33521 tests passed, 1 failed and 463 were skipped. failed: LLVM.tools/llvm-objdump/X86/disassemble-functions.test Log files: console-log.txt , CMakeCache

[clang-tools-extra] 1c66d09 - [clangd] Add fno-delayed-parsing to new define inline tests

Author: Kadir Cetinkaya Date: 2019-10-31T13:22:52+01:00 New Revision: 1c66d09b739a8d9717ba4e9507649bc45ddf7f0d URL: https://github.com/llvm/llvm-project/commit/1c66d09b739a8d9717ba4e9507649bc45ddf7f0d DIFF: https://github.com/llvm/llvm-project/commit/1c66d09b739a8d9717ba4e9507649bc45ddf7f0d.dif

Re: [PATCH] D68937: [clangd] Add parameter renaming to define-inline code action

done. sorry for forgetting about this so soon. On Thu, Oct 31, 2019 at 12:58 PM Nico Weber via Phabricator < revi...@reviews.llvm.org> wrote: > thakis added inline comments. > > > > Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:1388 >// results in arbitrary fa

[clang-tools-extra] 733777a - [clangd] Fix namespace aliases in findExplicitReferences

Author: Ilya Biryukov Date: 2019-10-31T13:35:25+01:00 New Revision: 733777a81662c40960e9298bb59da8c39a14f8d5 URL: https://github.com/llvm/llvm-project/commit/733777a81662c40960e9298bb59da8c39a14f8d5 DIFF: https://github.com/llvm/llvm-project/commit/733777a81662c40960e9298bb59da8c39a14f8d5.diff

[PATCH] D69624: [clangd] Fix namespace aliases in findExplicitReferences

This revision was automatically updated to reflect the committed changes. ilya-biryukov marked an inline comment as done. Closed by commit rG733777a81662: [clangd] Fix namespace aliases in findExplicitReferences (authored by ilya-biryukov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D69263: [clangd] Implement cross-file rename.

ilya-biryukov added a comment. Thanks, mostly LG! The only important comment I have left is about limiting the number of references. Others are NITs. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:219 + // us whether the ref results is completed. + RQuest.Limit =

[PATCH] D68937: [clangd] Add parameter renaming to define-inline code action

thakis added a comment. Tests are happy again after 1c66d09 , thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68937/new/ https://reviews.llvm.org/D68937 ___

[PATCH] D69628: [Clang] Pragma vectorize_width() implies vectorize(enable), take 3

SjoerdMeijer updated this revision to Diff 227273. SjoerdMeijer added a comment. Thanks Michael! - moved the handling of vectorize.enable to 1 place, - that should have also sorted the relative ordering, and duplication of the metadata in some cases, - created a separate file for the new tests,

[PATCH] D69316: [OpenMP 5.0] target update list items need not be contiguous (Sema)

ABataev added a comment. What about codegen tests? Comment at: clang/test/OpenMP/target_update_ast_print.cpp:25 + U marr[10][10][10]; +#pragma omp target update to(marr[2][0:2][0:2]) + It seems to me, the tests are not updated. All non-contiguous tests must pa

[PATCH] D69590: [RISCV] Fix ILP32D lowering for double+double/double+int return types

asb added a comment. Thanks James - won't this still leave problems for structs that need flattening? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69590/new/ https://reviews.llvm.org/D69590 ___ cfe-co

[PATCH] D69263: [clangd] Implement cross-file rename.

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:219 + // us whether the ref results is completed. + RQuest.Limit = 100; + if (auto ID = getSymbolID(RenameDecl)) ilya-biryukov wrote: > Why do we need to limit the number of

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

AntonBikineev added a comment. > Did you see some significant perf improvements for Chromium? I don't see major improvements in browser benchmarks like Speedometer, but in the Blink garbage collector, which queues destructors to be executed later, this change proved to reduce the number of them

[PATCH] D69649: [clang-format] Fix SpacesInSquareBrackets for Lambdas with Initial "&ref" Parameter

mitchell-stellar added a comment. Thanks. Would you mind committing this on my behalf? It seems I wasn't migrated from SVN access to git access. It may take some time to sort out. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69649/new/ https://reviews.llvm.org/

[PATCH] D69263: [clangd] Implement cross-file rename.

hokein updated this revision to Diff 227278. hokein marked 8 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69263/new/ https://reviews.llvm.org/D69263 Files: clang-tools-extra/cla

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

sylvestre.ledru added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69435/new/ https://reviews.llvm.org/D69435 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D69263: [clangd] Implement cross-file rename.

merge_guards_bot added a comment. Build result: pass - 59816 tests passed, 0 failed and 762 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D69662: [Checkers] Avoid using evalCall in StreamChecker.

balazske created this revision. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp. Herald added a project: clang. Use of evalCall is replaced by preCall and postCall. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69662 Files: clang/lib/StaticAnalyzer/Check

[clang] 8d7bd57 - [clang-format] Fix SpacesInSquareBrackets for Lambdas with Initial "&ref" Parameter

Author: Mitchell Balan Date: 2019-10-31T11:08:05-04:00 New Revision: 8d7bd57526486cab9e3daba9934042c405d7946b URL: https://github.com/llvm/llvm-project/commit/8d7bd57526486cab9e3daba9934042c405d7946b DIFF: https://github.com/llvm/llvm-project/commit/8d7bd57526486cab9e3daba9934042c405d7946b.diff

[PATCH] D69649: [clang-format] Fix SpacesInSquareBrackets for Lambdas with Initial "&ref" Parameter

This revision was automatically updated to reflect the committed changes. Closed by commit rG8d7bd5752648: [clang-format] Fix SpacesInSquareBrackets for Lambdas with Initial "&ref"… (authored by mitchell-stellar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

AntonBikineev added a comment. BTW, this very contrived benchmark shows 5x: http://quick-bench.com/sczBi_lVndKut9jOj4UofC0HYew CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69435/new/ https://reviews.llvm.org/D69435 ___ cfe-commits mailing

[PATCH] D69649: [clang-format] Fix SpacesInSquareBrackets for Lambdas with Initial "&ref" Parameter

mitchell-stellar added a comment. Never mind, I got it resolved and pushed. Sorry for the noise. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69649/new/ https://reviews.llvm.org/D69649 ___ cfe-commits mailing list c

[PATCH] D69383: [RISCV] Match GCC `-march`/`-mabi` driver defaults

lenary updated this revision to Diff 227284. lenary added a comment. - More conservative march/mabi defaults on riscv-unknown-elf - Add clang release notes about this change to -march/-mabi Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69383/new/ h

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc updated this revision to Diff 227283. mibintc added a comment. I followed up on some code review remarks from @rjmccall. I dropped the CODEGEN option and fixed some code formatting. I changed the spelling of the enumeration values for RoundingMode and ExceptionMode to match those propose

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

lenary added a comment. I have just updated D69383 . It now defaults to `rv{XLEN}imac` on ELF, rather than `rv{XLEN}gc`. This is to help this multilib issue. In the future, we want to implement MULTILIB_REUSE properly. Hopefully before Clang 10.0.0 is released.

[PATCH] D69664: [Diagnostics] Teach -Wnull-dereference about address_space attribute

xbolva00 created this revision. xbolva00 added reviewers: aaron.ballman, rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang should not warn for: test.c:2:12: warning: indirection of non-volatile null pointer will be deleted, not trap [-Wnull-dereference] re

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc marked 5 inline comments as done. mibintc added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:238 CODEGENOPT(UnsafeFPMath , 1, 0) ///< Allow unsafe floating point optzns. +CODEGENOPT(RoundingFPMath, 1, 0) ///< Rounding floating point

[PATCH] D69664: [Diagnostics] Teach -Wnull-dereference about address_space attribute

xbolva00 updated this revision to Diff 227286. xbolva00 added a comment. Added testcase with typedefed int. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69664/new/ https://reviews.llvm.org/D69664 Files: clang/lib/Sema/SemaExpr.cpp clang/test/

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

xbolva00 added a comment. In D69435#1728674 , @AntonBikineev wrote: > BTW, this very contrived benchmark shows 5x: > http://quick-bench.com/sczBi_lVndKut9jOj4UofC0HYew There is no difference in perf for GCC. CHANGES SINCE LAST ACTION https://review

[PATCH] D69664: [Diagnostics] Teach -Wnull-dereference about address_space attribute

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:486 if (UO->getOpcode() == UO_Deref && -UO->getSubExpr()->IgnoreParenCasts()-> - isNullPointerConstant(S.Context, Expr::NPC_ValueDependentIsNot

[PATCH] D69632: [libTooling] Add Stencil constructor.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69632/new/ https://reviews.llvm.org/D69632

[PATCH] D69666: clang: Fix assert on void pointer arithmetic with address_space

arsenm created this revision. arsenm added reviewers: yaxunl, jdoerfert, Anastasia. Herald added a subscriber: wdng. This attempted to always use the default address space void pointer type instead of preserving the source address space. https://reviews.llvm.org/D69666 Files: clang/lib/CodeGe

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

AntonBikineev added a comment. > There is no difference in perf for GCC. Yes, but that's because gcc still optimizes the call to noinlined function. In the common scenario which this check addresses (destructor defaulted in .cpp file) gcc is not able to optimize the call. CHANGES SINCE LAST A

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

rjmccall added a comment. Yes, thanks, looks a lot better. Just a few tweaks now. Comment at: clang/include/clang/Basic/LangOptions.h:348 VersionTuple getOpenCLVersionTuple() const; + }; Spurious change. Comment at: clang/include/clang/D

[PATCH] D69657: [AArch64][SVE] Implement several floating-point arithmetic intrinsics

kmclaughlin updated this revision to Diff 227299. kmclaughlin added a comment. - Removed duplicate //AdvSIMD_Pred2VectorArg_Intrinsic// class after rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69657/new/ https://reviews.llvm.org/D69657 Files: llvm/include/llvm/IR/IntrinsicsAA

[PATCH] D69577: [clang-format] [PR35518] C++17 deduction guides are wrongly formatted

lichray added a comment. The functionality looks acceptable. Trying to parse the whole thing still looks fragile to me. I expect code owner to take a look at this change. Comment at: clang/lib/Format/TokenAnnotator.cpp:1371 +if (Current.Previous && Current.Previous->is(t

[PATCH] D69673: [clangd] Implement semantic highlightings via findExplicitReferences

ilya-biryukov created this revision. ilya-biryukov added a reviewer: hokein. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. To keep the logic of finding locations of interesting AST nodes in one place. The advantage is better coverage of

[PATCH] D69666: clang: Fix assert on void pointer arithmetic with address_space

yaxunl added a comment. Is the description reversed? This attempts to preserve the source address space instead of always using the default address space for void pointer type. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69666/new/ https://reviews.llvm.org/D69666

[PATCH] D69673: [clangd] Implement semantic highlightings via findExplicitReferences

merge_guards_bot added a comment. Build result: pass - 59818 tests passed, 0 failed and 762 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D69263: [clangd] Implement cross-file rename.

ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:274 +llvm::Expected +renameOutsideFile(const NamedDecl *RenameDecl, llvm::StringRef MainFilePath, + llvm::StringRef NewNa

[PATCH] D69548: Give clang-tidy readability-redundant-string-init a customizable list of string types to fix

gribozavr2 requested changes to this revision. gribozavr2 added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/clang-tidy/readability/RedundantStringInitCheck.cpp:21 +const char DefaultStringNames[] = "basic_string"; + ---

[PATCH] D68923: Don't warn about missing declarations for partial template specializations

aaronpuchert added a comment. Gentle ping. I'm open to suggestions to simplify the condition, but I think templates, partial specializations and instantiations are three different things that we all need to exclude here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D69238: Fix clang-tidy readability-redundant-string-init for c++17/c++2a

gribozavr2 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/RedundantStringInitCheck.cpp:67-70 +// With -std c++14 or earlier (!LangOps.CPlusPlus17), it was sufficient to +// return CtorExpr->getSourceRange(). However, starting with c++17, parsing +//

[PATCH] D69638: [NFC] Add SUPPORT_PLUGINS to add_llvm_executable()

beanz added a comment. A few comments inline. Comment at: clang/tools/driver/CMakeLists.txt:34 ${tablegen_deps} + SUPPORT_PLUGINS ) This is now a behavior change because you're always passing this. You'll want to bring back the conditional statement wit

[PATCH] D69613: [libTooling] Simplify type structure of `Stencil`s.

gribozavr2 added inline comments. Comment at: clang/include/clang/Tooling/Transformer/Stencil.h:57 + /// Constructs a string representation of the StencilInterfacePart. + /// StencilInterfaceParts generated by the `selection` and `run` functions do + /// not have a unique stri

[PATCH] D69573: [clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly for some operator functions

sammccall added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:955 CurrentToken->Previous->isOneOf(TT_BinaryOperator, TT_UnaryOperator, -tok::comma)) +tok::comm

[PATCH] D69238: Fix clang-tidy readability-redundant-string-init for c++17/c++2a

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/RedundantStringInitCheck.cpp:67-70 +// With -std c++14 or earlier (!LangOps.CPlusPlus17), it was sufficient to +// return CtorExpr->getSourceRange(). However, starting with c++17, parsing +

[PATCH] D69577: [clang-format] [PR35518] C++17 deduction guides are wrongly formatted

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1371 +if (Current.Previous && Current.Previous->is(tok::r_paren) && +Current.startsSequence(tok::arrow, tok::identifier, tok::less)) { + // Find the TemplateCloser.

[PATCH] D69577: [clang-format] [PR35518] C++17 deduction guides are wrongly formatted

MyDeveloperDay updated this revision to Diff 227317. MyDeveloperDay marked 4 inline comments as done. MyDeveloperDay added a comment. Add additional test case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69577/new/ https://reviews.llvm.org/D69577 Files: clang/lib/Format/TokenAnnotat

[PATCH] D57829: [CUDA][HIP] Disable emitting llvm.linker.options in device compilation

tra added a comment. Could you, please, give us a bit more context and provide more info for the questions @rjmccall and I asked before? Is the problem specifically because autolink is not supported on device side? Or is disabling autolink just a convoluted way to avoid calling EmitModuleLinkO

[PATCH] D69613: [libTooling] Simplify type structure of `Stencil`s.

ymandel marked 5 inline comments as done. ymandel added a comment. Thanks for the review! I agreed w/ all the comments, just responding early w/ those I had further thoughts/questions on. Comment at: clang/include/clang/Tooling/Transformer/Stencil.h:82 +Stencil makeStencil(Ran

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

gribozavr2 added a comment. LGTM modulo the isFirstDeclComment. Will approve after we resolve that discussion. Comment at: clang-tools-extra/clang-tidy/performance/TriviallyDestructibleCheck.cpp:45 + isDefaulted(), + unless(anyOf(isFirstDecl(), isVirtual(),

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc marked an inline comment as done. mibintc added inline comments. Comment at: clang/include/clang/Driver/Options.td:1152 +def frounding_math : Flag<["-"], "frounding-math">, Group, Flags<[CC1Option]>; +def fno_rounding_math : Flag<["-"], "fno-rounding-math">, Group, Flag

[PATCH] D69678: [CodeGen] Fix invalid llvm.linker.options about pragma detect_mismatch

yaxunl created this revision. yaxunl added reviewers: rjmccall, tra. When a target does not support pragma detect_mismatch, an llvm.linker.options metadata with an empty entry is created, which causes diagnostic in backend since backend expects name/value pair in llvm.linker.options entries. This

[PATCH] D57829: [CUDA][HIP] Disable emitting llvm.linker.options in device compilation

yaxunl added a comment. In D57829#1729094 , @tra wrote: > Could you, please, give us a bit more context and provide more info for the > questions @rjmccall and I asked before? > > Is the problem specifically because autolink is not supported on device sid

[PATCH] D69678: [CodeGen] Fix invalid llvm.linker.options about pragma detect_mismatch

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Seems reasonable. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69678/new/ https://reviews.llvm.org/D69678 ___ cfe-commits mailing l

[PATCH] D57829: [CUDA][HIP] Disable emitting llvm.linker.options in device compilation

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:389-392 + // The linker_option directives are intended for host compilation. + if (JA.isDeviceOffloading(Action::OFK_Cuda) || + JA.isDeviceOffloading(Action::OFK_HIP)) +Default = false; --

[clang] 19f1dc7 - Remove unneeded template alias, causes issues with some MSVC version

Author: Reid Kleckner Date: 2019-10-31T14:20:54-07:00 New Revision: 19f1dc7b527eade11dae9425c420cc9f450393b6 URL: https://github.com/llvm/llvm-project/commit/19f1dc7b527eade11dae9425c420cc9f450393b6 DIFF: https://github.com/llvm/llvm-project/commit/19f1dc7b527eade11dae9425c420cc9f450393b6.diff

[clang] d816d9b - [clang][ScanDeps] Fix issue with multiple commands with the same input.

Author: Michael Spencer Date: 2019-10-31T14:22:01-07:00 New Revision: d816d9bdc585bbf77a7a1c47a7199fd9e0c34402 URL: https://github.com/llvm/llvm-project/commit/d816d9bdc585bbf77a7a1c47a7199fd9e0c34402 DIFF: https://github.com/llvm/llvm-project/commit/d816d9bdc585bbf77a7a1c47a7199fd9e0c34402.dif

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

AntonBikineev marked an inline comment as done. AntonBikineev added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/TriviallyDestructibleCheck.cpp:45 + isDefaulted(), + unless(anyOf(isFirstDecl(), isVirtual(), + ofCla

[PATCH] D69643: [clang][ScanDeps] Fix issue with multiple commands with the same input.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd816d9bdc585: [clang][ScanDeps] Fix issue with multiple commands with the same input. (authored by Bigcheese). Changed prior to commit: https://reviews.llvm.org/D69643?vs=227178&id=227347#toc Repositor

[PATCH] D69237: Refactor getDeclAtPosition() to use SelectionTree + targetDecl()

nridge updated this revision to Diff 227352. nridge marked 12 inline comments as done. nridge added a comment. Address latest comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69237/new/ https://reviews.llvm.org/D69237 Files: clang-tools-ex

[PATCH] D69237: Refactor getDeclAtPosition() to use SelectionTree + targetDecl()

nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1133 + DeclRelationSet Relations = + DeclRelation::TemplatePattern | DeclRelation::Alias; + auto Decls = getDeclAtPosition(AST, SourceLocationBeg, Relations); sammccall wrote: > A

[clang-tools-extra] b6429cd - Refactor getDeclAtPosition() to use SelectionTree + targetDecl()

Author: Nathan Ridge Date: 2019-10-31T17:37:27-04:00 New Revision: b6429cdd65ffa28591c5b0da37244ab66d0b1785 URL: https://github.com/llvm/llvm-project/commit/b6429cdd65ffa28591c5b0da37244ab66d0b1785 DIFF: https://github.com/llvm/llvm-project/commit/b6429cdd65ffa28591c5b0da37244ab66d0b1785.diff

[PATCH] D69626: Fix Microsoft compatibility handling of commas in nested macro expansions.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Based on the comments it looks like you confirmed this matches MSVC's behavior, at least in this regard. I haven't stared at this deeply to think of all the corner cases, though. To Nico's po

[PATCH] D69237: Refactor getDeclAtPosition() to use SelectionTree + targetDecl()

This revision was automatically updated to reflect the committed changes. Closed by commit rGb6429cdd65ff: Refactor getDeclAtPosition() to use SelectionTree + targetDecl() (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69237/new/

  1   2   >