kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
This looks good, but it is missing the context. I suppose we were previously
not providing any references for namespace aliases, because we were filtering
both the alias and the underlying decl?
Could you update the revision summary and/or commit message ?
================
Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:893
+ void foo() {
+ $0^ns::$1^Type $2^a;
+ $3^alias::$4^Type $5^b;
----------------
nit: I suppose this line checks we are not regressing the "non-alias case", but
they are already being tested in previous tests.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69624/new/
https://reviews.llvm.org/D69624
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
