[PATCH] D69520: [libc++] Disallow dynamic -> static span conversions

jdoerrie updated this revision to Diff 226713. jdoerrie added a comment. Formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69520/new/ https://reviews.llvm.org/D69520 Files: libcxx/test/std/containers/views/span.cons/span.pass.cpp Index: libcxx/test/std/containers/views/span.

[PATCH] D69520: [libc++] Disallow dynamic -> static span conversions

jdoerrie updated this revision to Diff 226714. jdoerrie added a comment. Full patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69520/new/ https://reviews.llvm.org/D69520 Files: libcxx/include/span libcxx/test/std/containers/views/span.cons/span.fail.cpp libcxx/test/std/contain

[PATCH] D69498: IR: Invert convergent attribute handling

jdoerfert added a reviewer: JonChesterfield. jdoerfert added a comment. Before we get lost in review details let's make sure we agree that his is the right path. I mean, transition from `convergent` to `noconvergent` (or a similar spelling). I do support this by the way. In D69498#1723606

[clang] f213207 - Lexer::ReadToEndOfLine - fix Token uninitialised value warnings. NFCI.

Author: Simon Pilgrim Date: 2019-10-28T18:28:18Z New Revision: f2132070d9a5a330400744aa14819344d0b44151 URL: https://github.com/llvm/llvm-project/commit/f2132070d9a5a330400744aa14819344d0b44151 DIFF: https://github.com/llvm/llvm-project/commit/f2132070d9a5a330400744aa14819344d0b44151.diff LOG:

Re: Zorg migration to GitHub/monorepo

Hi Diana, It is not clear from your description of what is the problem. Could you elaborate, please? I have looked at the build history closer and see that this build configuration depends on libcxx, libcxxabi, libunwind, llvm projects, and changes to any of these would trigger a build. Depending

[PATCH] D65761: Add Windows Control Flow Guard checks (/guard:cf).

thakis added a comment. All new files added in this patch had dos line endings. I fixed that in e59f7488 but going forward please configure your environment to create new files for LLVM with unix line endings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D69238: Fix clang-tidy readability-redundant-string-init for c++17/c++2a

MyDeveloperDay added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/RedundantStringInitCheck.cpp:50 varDecl(hasType(hasUnqualifiedDesugaredType(recordType( hasDeclaration(cxxRecordDecl(hasName("basic_string")),

[PATCH] D67983: [ObjC] Diagnose implicit type coercion from ObjC 'Class' to object pointer types.

jyknight added a comment. In D67983#1723681 , @rjmccall wrote: > We could probably do a quick check to see if the class informally conforms to > the protocol. `+copyWithZone` seems to be marked unavailable in ARC; not > sure if that would cause problems

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/TriviallyDestructibleCheck.cpp:27 + for (FieldDecl *Field : RecordDecl->fields()) { +const QualType FieldType = Field->getType(); +if (FieldType->isDependentType() || -

[clang] 025166c - [Remarks] Add bitstream to the list of supported formats in clang

Author: Francis Visoiu Mistrih Date: 2019-10-28T13:08:05-07:00 New Revision: 025166cf48002317086db84f3a6eb7a2e2c10df2 URL: https://github.com/llvm/llvm-project/commit/025166cf48002317086db84f3a6eb7a2e2c10df2 DIFF: https://github.com/llvm/llvm-project/commit/025166cf48002317086db84f3a6eb7a2e2c10

[clang] f5094e1 - [Remarks] Fix Sphinx formatting

Author: Francis Visoiu Mistrih Date: 2019-10-28T13:13:39-07:00 New Revision: f5094e182947710f0b8dd4fafd23fd66634a3f19 URL: https://github.com/llvm/llvm-project/commit/f5094e182947710f0b8dd4fafd23fd66634a3f19 DIFF: https://github.com/llvm/llvm-project/commit/f5094e182947710f0b8dd4fafd23fd66634a3

[PATCH] D69215: [DWARF5] Added support for deleted C++ special member functions.

SouraVX added a comment. Hi @aprantl, could you please review these changes, while I rework on the other one. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69215/new/ https://reviews.llvm.org/D69215 ___ cfe-commits mailing list cfe

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc updated this revision to Diff 226738. mibintc added a comment. I adopted the language that @rjmccall recommended for documenting frounding-math., also adding a sentence to describe effects on exception behavior control. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews

[PATCH] D69215: [DWARF5] Added support for deleted C++ special member functions.

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: llvm/docs/SourceLevelDebugging.rst:998 + +There are couple of new DWARF attributes defined to enhance debugging of C++ programs. LLVM can generate (or omit

[PATCH] D69181: [clang-tidy] Adding misc-signal-terminated-thread check

abelkocsis updated this revision to Diff 226746. abelkocsis added a comment. Alias added to //cert// module Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69181/new/ https://reviews.llvm.org/D69181 Files: clang-tools-extra/clang-tidy/bugprone/BadS

[PATCH] D69181: [clang-tidy] Adding misc-signal-terminated-thread check

Eugene.Zelenko added a comment. Will be good idea to mention alias in Release Notes too (in aliases section, in alphabetical order). Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69181/new/ https://reviews.llvm.org/D69181 ___

[PATCH] D68725: [analyzer] MemoryBlockRegion: Generalize AllocaRegion

Charusso added a comment. Thanks for the notes! In D68725#1722136 , @NoQ wrote: > Generally, there's no need to add more information to `MemRegion` and > `SymExpr` objects [...] Well, that was my first idea, then I saw we allow helper-methods inside r

[clang] 85b718f - [Driver] Enable ShadowCallStack, not SafeStack, by default on AArch64 Fuchsia

Author: Leonard Chan Date: 2019-10-28T14:19:38-07:00 New Revision: 85b718f53a3575bca2f1b7fdb1b3aaa6df7c10e3 URL: https://github.com/llvm/llvm-project/commit/85b718f53a3575bca2f1b7fdb1b3aaa6df7c10e3 DIFF: https://github.com/llvm/llvm-project/commit/85b718f53a3575bca2f1b7fdb1b3aaa6df7c10e3.diff

[PATCH] D69533: Thread safety analysis: Peel away NoOp implicit casts in initializers

aaronpuchert created this revision. aaronpuchert added reviewers: aaron.ballman, rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. This happens when someone initializes a variable with guaranteed copy elision and an added const qualifier. Fixes PR43826. Repository:

[PATCH] D69498: IR: Invert convergent attribute handling

rjmccall added a comment. The kind of tracking that you're doing of convergent operations is one example of a basically limitless set of "taint" analyses, of which half a dozen already exist in LLVM. I object to the idea that an arbitrary number of unrelated tests need to be changed every time

[PATCH] D41569: [Concepts] Constraint enforcement and diagnostics

vlad.tsyrklevich added a comment. I noticed in Decl.cpp your change deleted some whitespace that belonged there. Not a big deal, just try to remember to run clang-format-diff when you're submitting for review. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D69498: IR: Invert convergent attribute handling

rjmccall added a comment. If you can come up with a way to make this change that doesn't require changes to non-GPU frontends or tests, I agree that treating functions as convergent by default makes sense for GPU targets. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69498/new/ https:

[PATCH] D67983: [ObjC] Diagnose implicit type coercion from ObjC 'Class' to object pointer types.

rjmccall added a comment. I was thinking that we could walk through the instance methods of the protocol and check whether the class has compatible declarations of class methods. But you're right, of course: we don't actually know what class we're working with, and we'd have to look through `[

[clang] 7cd595d - Revert "Use -fdebug-compilation-dir to form absolute paths in coverage mappings"

Author: Reid Kleckner Date: 2019-10-28T14:40:17-07:00 New Revision: 7cd595df96d5929488063d8ff5cc3b5d800386da URL: https://github.com/llvm/llvm-project/commit/7cd595df96d5929488063d8ff5cc3b5d800386da DIFF: https://github.com/llvm/llvm-project/commit/7cd595df96d5929488063d8ff5cc3b5d800386da.diff

[PATCH] D66712: [Driver] Enable ShadowCallStack, not SafeStack, by default on AArch64 Fuchsia

leonardchan closed this revision. leonardchan added a comment. Manually closed since `git push` didn't seem to automatically close this. Committed under https://github.com/llvm/llvm-project/commit/85b718f53a3575bca2f1b7fdb1b3aaa6df7c10e3. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[clang] 38839d0 - Revert "[Concepts] Constraint Enforcement & Diagnostics"

Author: Vlad Tsyrklevich Date: 2019-10-28T15:00:40-07:00 New Revision: 38839d08b8e165dfaab0fa6acc77e620d6df294c URL: https://github.com/llvm/llvm-project/commit/38839d08b8e165dfaab0fa6acc77e620d6df294c DIFF: https://github.com/llvm/llvm-project/commit/38839d08b8e165dfaab0fa6acc77e620d6df294c.di

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

rjmccall added a comment. Is the exception-strictness of `-frounding-math` actually considered to be specified behavior, or is it just a consequence of the current implementation? There are definitely some optimizations that we can't do under strict FP exceptions that we can still do in princi

[PATCH] D69518: [Diagnostics] Warn for std::is_constant_evaluated in constexpr mode

xbolva00 updated this revision to Diff 226758. xbolva00 added a comment. Support !E. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69518/new/ https://reviews.llvm.org/D69518 Files: clang/include/clang/AST/Expr.h clang/include/clang/Basic/Diagn

[PATCH] D69518: [Diagnostics] Warn for std::is_constant_evaluated in constexpr mode

xbolva00 updated this revision to Diff 226759. xbolva00 added a comment. New tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69518/new/ https://reviews.llvm.org/D69518 Files: clang/include/clang/AST/Expr.h clang/include/clang/Basic/Diagnos

[clang] ad531ff - Revert "[clang] Add no_builtin attribute"

Author: Vlad Tsyrklevich Date: 2019-10-28T15:21:59-07:00 New Revision: ad531fff81a2a266ffed1d7da778cb59c983 URL: https://github.com/llvm/llvm-project/commit/ad531fff81a2a266ffed1d7da778cb59c983 DIFF: https://github.com/llvm/llvm-project/commit/ad531fff81a2a266ffed1d7da778cb59c983.di

Re: [clang] bd87916 - [clang] Add no_builtin attribute

I've reverted this change as it was causing ASan/MSan failures in check-clang, e.g. take a look at the bottom 2 failures here: http://lab.llvm.org:8014/builders/sanitizer-x86_64-linux-bootstrap/builds/124/steps/check-clang%20asan/logs/stdio or here http://lab.llvm.org:8014/builders/sanitizer-x86_64

[PATCH] D68377: [Builtins] Teach Clang about memccpy

xbolva00 updated this revision to Diff 226761. xbolva00 added a comment. Newline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68377/new/ https://reviews.llvm.org/D68377 Files: clang/include/clang/Basic/Builtins.def clang/test/CodeGen/builtin

[PATCH] D68377: [Builtins] Teach Clang about memccpy

This revision was automatically updated to reflect the committed changes. Closed by commit rGdfece0a108a7: [Builtins] Teach Clang about memccpy (authored by xbolva00). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68377/new/ https://reviews.llvm.org

Re: r374837 - [clang] add requirements to -Wa,-W test cases.

+1 to what Nico said/ping on this. Jian - could you see if these tests could be made portable as Nico's suggested? On Mon, Oct 14, 2019 at 3:54 PM Nico Weber via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hm, this means the test can't run on non-linux, so if someone breaks it on > e.g. w

Re: r374844 - Revert "Dead Virtual Function Elimination"

+1/ping on this - Jorge, could you include some details about the reason for the revert & the revision? On Mon, Oct 14, 2019 at 5:06 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi Jorge, > > Please mention the reason for a revert in revert commit messages. Also, > unti

Re: [clang] 9671d1d - [clang]Fixup clang -Werror, , -Wcovered-switch-default build failures

FWIW that probably produces a -Wreturn-type warning because other compilers don't conservatively assume that only the enumerator values can be in an enum variable (rather than all of its representable values). The subsequent -Wreturn-type warning was fixed in 45787e56829f (moving the unreachable to

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

AntonBikineev updated this revision to Diff 226773. AntonBikineev added a comment. Thanks for the suggestions! Added isTriviallyDestructible matcher to utils/Matchers.h. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69435/new/ https://reviews.llvm.org/D69435 Files: clang-tools-extra

Re: r374837 - [clang] add requirements to -Wa,-W test cases.

Hi David, Thanks for the follow up. I already discussed it with Nico over email and addressed his concerns on llvm-svn: 374932. I did not want to spam everyone with all our email exchanges so I did not include the list :). Thanks, Jian On Mon, Oct 28, 2019 at 3:37 PM David Blaikie wrote: > +1

Re: r374837 - [clang] add requirements to -Wa,-W test cases.

Thanks for the details! Generally it's fine to have these discussions on-list, or at least to include a summary reply so it's clear loose ends were tied up. On Mon, Oct 28, 2019 at 4:26 PM Jian Cai wrote: > Hi David, > > Thanks for the follow up. I already discussed it with Nico over email and >

Re: r374837 - [clang] add requirements to -Wa,-W test cases.

Sounds good! Will start doing it. On Mon, Oct 28, 2019 at 4:29 PM David Blaikie wrote: > Thanks for the details! Generally it's fine to have these discussions > on-list, or at least to include a summary reply so it's clear loose ends > were tied up. > > On Mon, Oct 28, 2019 at 4:26 PM Jian Cai

Re: [PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

On Thu, Oct 24, 2019 at 3:24 PM Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > > On Oct 24, 2019, at 3:02 PM, David Blaikie via Phabricator < > revi...@reviews.llvm.org> wrote: > > dblaikie added a comment. > > In D67723#1720509 , @a

[PATCH] D69498: IR: Invert convergent attribute handling

jdoerfert added a comment. @rjmccall Thanks for the quick response! I tried to describe my view below. To avoid confusion on my side, could you maybe describe what you think when/which attribute should be created, derived, and used during the optimization pipeline? In D69498#1724232

Re: [llvm-dev] Zorg migration to GitHub/monorepo

I think what she is referring to was that the build seemed to be triggered by a commit to a project that shouldn't trigger builds on a libcxx bot (i.e. the change was in llvm). I have a somewhat orthogonal but related question. In the past, commits to compiler-rt did not trigger builds on llvm/cla

[clang] 9ecd322 - [NFC] Fix some indentation disturbed in D67368

Author: Reid Kleckner Date: 2019-10-28T17:12:43-07:00 New Revision: 9ecd3225d134541bdfde18a6648edb8b9e048035 URL: https://github.com/llvm/llvm-project/commit/9ecd3225d134541bdfde18a6648edb8b9e048035 DIFF: https://github.com/llvm/llvm-project/commit/9ecd3225d134541bdfde18a6648edb8b9e048035.diff

[PATCH] D69498: IR: Invert convergent attribute handling

arsenm added a comment. I think the question should be what the IR policy is for properties that are required for correctness and not necessarily what most users will use. There's a general trend towards functions being correct by default, and attributes adding optimization possibilities. conve

[clang] dddec1f - [clang][clang-scan-deps] Add -fcxx-modules to test for Darwin.

Author: Michael Spencer Date: 2019-10-28T17:37:25-07:00 New Revision: dddec1f1840b8a019c8c89dd1e7961cf39d845d3 URL: https://github.com/llvm/llvm-project/commit/dddec1f1840b8a019c8c89dd1e7961cf39d845d3 DIFF: https://github.com/llvm/llvm-project/commit/dddec1f1840b8a019c8c89dd1e7961cf39d845d3.dif

[PATCH] D69540: [analyzer] DynamicSize: Remove 'getExtent()' from regions

Charusso created this revision. Charusso added a reviewer: NoQ. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun, mgorny. This patch introduces a placeholder for representing th

[PATCH] D69540: [analyzer] DynamicSize: Remove 'getExtent()' from regions

Charusso marked 3 inline comments as done. Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:880 uint64_t Length = UINT64_MAX; - SVal Extent = Top->getExtent(SVB); + SVal Extent = Top->getMemRegionManager().getStaticSize(Top); if (O

[PATCH] D69543: [WIP][clangd] Add a tweak refactoring to wrap Objective-C string literals in `NSLocalizedString` macros

arphaman created this revision. arphaman added reviewers: jkorous, ilya-biryukov. Herald added subscribers: usaxena95, ributzka, kadircet, dexonsmith, MaskRay, mgorny. Herald added a project: clang. This is a patch to add a refactoring to Clangd that mimics the existing refactoring action in Xco

[PATCH] D69544: [clangd] NFC, reuse the source manager variable in the RawStringLiteral apply method

arphaman created this revision. arphaman added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, ributzka, kadircet, dexonsmith, jkorous, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69544 Files: clang-tools-extra/clangd

[PATCH] D69498: IR: Invert convergent attribute handling

kariddi added a comment. One thing to probably note is that its not only a "target specific" issue, but a language specific issue as well (IMHO). OpenCL, CUDA, SYCL are all languages (to name a few) that have a concept of "convergence" and its not related only to the fact that they mostly run o

Re: [llvm-dev] Zorg migration to GitHub/monorepo

Hello Nemanja, > a commit to a project that shouldn't trigger builds on a libcxx bot (i.e. the > change was in llvm). With all due respect, this does not sound right. I'm not sure how changes in a code a particular bot builds and tests should not trigger builds. In many cases this will lead to f

[PATCH] D69548: Give clang-tidy readability-redundant-string-init a customizable list of string types to fix

poelmanc created this revision. poelmanc added a reviewer: MyDeveloperDay. poelmanc added a project: clang-tools-extra. Herald added subscribers: cfe-commits, mgehre. Herald added a project: clang. This patch adds a feature requested by @MyDeveloperDay at https://reviews.llvm.org/D69238, @MyDevel

[PATCH] D69238: Fix clang-tidy readability-redundant-string-init for c++17/c++2a

poelmanc marked 3 inline comments as done. poelmanc added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/RedundantStringInitCheck.cpp:50 varDecl(hasType(hasUnqualifiedDesugaredType(recordType( hasDeclaration(cxxRecordDecl

<    1   2