[PATCH] D68340: Add AIX toolchain and basic linker functionality

stevewan added a comment. In D68340#1720362 , @Yi-Hong.Lyu wrote: > Seems this commit broke the buildbot > http://lab.llvm.org:8011/builders/ppc64le-lld-multistage-test/builds/6806 @daltenty's patch rG201ed14aea8c

[PATCH] D69406: [clang][ThinLTO] Promote cc1 -fthin_link_bitcode to driver -fthinlto_link_bitcode

ychen created this revision. ychen added reviewers: tejohnson, steven_wu. Herald added subscribers: cfe-commits, dexonsmith, inglorion, mehdi_amini. Herald added a project: clang. A necessary step to let build system caching work for its output. I renamed it to match existing driver options for Th

[clang] ffa214e - [Concepts] Constraint Enforcement & Diagnostics

Author: Saar Raz Date: 2019-10-25T00:19:51+03:00 New Revision: ffa214ef22892d75340dc6720271863901dc2c90 URL: https://github.com/llvm/llvm-project/commit/ffa214ef22892d75340dc6720271863901dc2c90 DIFF: https://github.com/llvm/llvm-project/commit/ffa214ef22892d75340dc6720271863901dc2c90.diff LOG:

[PATCH] D41569: [Concepts] Constraint enforcement and diagnostics

saar.raz closed this revision. saar.raz added a comment. Committed ffa214ef22892d75340dc6720271863901dc2c90 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41569/new/ https://revi

[PATCH] D69389: [hip] Allow the declaration of functions with variadic arguments in HIP.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Perhaps we should rename `-fcuda-allow-variadic-functions` to `-fgpu-allow-variadic-functions` after this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

probinson added a comment. > These experiments are convincing me that, in general, line zero isn't that > helpful for DWARF consumers. If the goal is to get smooth stepping, we may > want to refocus on getting reliable is_stmt bits in the line table. If you mean, it's not useful for identifying

[PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

aprantl added a comment. In D67723#1720353 , @rnk wrote: > In D67723#1717468 , @aprantl wrote: > > > I agree that it would make sense to have a > > `-ginline-info-threshold=<#insns>` or `-gno-small-inline-functions

[PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

aprantl added a comment. tldr: my LGTM still stands. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67723/new/ https://reviews.llvm.org/D67723 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[clang] 70f59b5 - When diagnosing an ambiguity, only note the candidates that contribute

Author: Richard Smith Date: 2019-10-24T14:58:29-07:00 New Revision: 70f59b5bbc84d195b4c7ee1597dcae4e73d3c479 URL: https://github.com/llvm/llvm-project/commit/70f59b5bbc84d195b4c7ee1597dcae4e73d3c479 DIFF: https://github.com/llvm/llvm-project/commit/70f59b5bbc84d195b4c7ee1597dcae4e73d3c479.diff

[PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

dblaikie added a comment. In D67723#1720509 , @aprantl wrote: > In D67723#1720353 , @rnk wrote: > > > In D67723#1717468 , @aprantl wrote: > > > > > I agree that it would make

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

lenary added a comment. In D67508#1720228 , @khchen wrote: > But there is some issue if we set the default rv32 march as `rv32gc`. > Because the default multilib does not include `rv32gc`/`lp32d` in riscv gnu > toolchain, > https://github.com/riscv/r

[PATCH] D69406: [clang][ThinLTO] Promote cc1 -fthin_link_bitcode to driver -fthinlto_link_bitcode

tejohnson added a comment. Thanks. Prefer the old name since it is already in use and since this is for the "thin link" phase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69406/new/ https://reviews.llvm.org/D69406

Re: [PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

> On Oct 24, 2019, at 3:02 PM, David Blaikie via Phabricator > wrote: > > dblaikie added a comment. > > In D67723#1720509 , @aprantl wrote: > >> In D67723#1720353 , @rnk wrote: >> >>> In D67723#1717468

[PATCH] D69406: [clang][ThinLTO] Promote cc1 -fthin_link_bitcode to driver -fthinlto_link_bitcode

ychen updated this revision to Diff 226347. ychen added a comment. Address reviewer's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69406/new/ https://reviews.llvm.org/D69406 Files: clang/include/clang/Driver/CC1Options.td clang/incl

[clang] 9671d1d - [clang]Fixup clang -Werror, , -Wcovered-switch-default build failures

Author: Jinsong Ji Date: 2019-10-24T22:49:17Z New Revision: 9671d1dc1764701824913ecca2b76ab17c33c29e URL: https://github.com/llvm/llvm-project/commit/9671d1dc1764701824913ecca2b76ab17c33c29e DIFF: https://github.com/llvm/llvm-project/commit/9671d1dc1764701824913ecca2b76ab17c33c29e.diff LOG: [c

[PATCH] D69022: [coroutines] Remove assert on CoroutineParameterMoves in Sema::buildCoroutineParameterMoves

rjmccall resigned from this revision. rjmccall added a comment. Despite generally knowing about coroutines and generally knowing about Clang, I actually don't know the Clang coroutine code and can't review this properly. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D69406: [clang][ThinLTO] Promote cc1 -fthin_link_bitcode to driver -fthinlto_link_bitcode

steven_wu accepted this revision. steven_wu added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69406/new/ https://reviews.llvm.org/D69406

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

rjmccall added a comment. Please don't ping for review after a single day. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69322/new/ https://reviews.llvm.org/D69322 ___ cfe-commits mailing list cfe-comm

[clang] 9ab6d82 - [clang-scan-deps] Add basic support for modules.

Author: Michael Spencer Date: 2019-10-24T16:19:11-07:00 New Revision: 9ab6d8236b176bf9dd43741f4d874a8afebed99c URL: https://github.com/llvm/llvm-project/commit/9ab6d8236b176bf9dd43741f4d874a8afebed99c DIFF: https://github.com/llvm/llvm-project/commit/9ab6d8236b176bf9dd43741f4d874a8afebed99c.dif

[PATCH] D68835: [clang-scan-deps] Add basic support for Clang modules.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9ab6d8236b17: [clang-scan-deps] Add basic support for modules. (authored by Bigcheese). Changed prior to commit: https://reviews.llvm.org/D68835?vs=225311&id=226352#toc Repository: rG LLVM Github Mon

[PATCH] D69414: [clang-tidy] Regenerate clang-tidy check list 📋

stephanemoore created this revision. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. stephanemoore added a reviewer: aaron.ballman. stephanemoore added a comment. Please let me know if there are any corrections that are required to the output of `clang-tools-extra

[PATCH] D69415: [CMake] Update Fuchsia build configuration

phosek updated this revision to Diff 226355. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69415/new/ https://reviews.llvm.org/D69415 Files: clang/cmake/caches/Fuchsia-stage2.cmake clang/cmake/caches/Fuchsia.cmake Index: clang/cmake/caches/Fuchsia.cmake =

[PATCH] D69415: [CMake] Update Fuchsia build configuration

phosek created this revision. phosek added a reviewer: leonardchan. Herald added subscribers: cfe-commits, aprantl, mgorny. Herald added a project: clang. phosek updated this revision to Diff 226355. leonardchan accepted this revision. This revision is now accepted and ready to land. This includes

[clang] 7fff716 - [CMake] Update Fuchsia build configuration

Author: Petr Hosek Date: 2019-10-24T16:35:29-07:00 New Revision: 7fff716ec4741f84358a977ddf0cd5ccf448d5c5 URL: https://github.com/llvm/llvm-project/commit/7fff716ec4741f84358a977ddf0cd5ccf448d5c5 DIFF: https://github.com/llvm/llvm-project/commit/7fff716ec4741f84358a977ddf0cd5ccf448d5c5.diff LO

[PATCH] D69414: [clang-tidy] Regenerate clang-tidy check list 📋

stephanemoore added a comment. Please let me know if there are any corrections that are required to the output of `clang-tools-extra/clang-tidy/add_new_check.py`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69414/new/ https://reviews.llvm.org/D6

[PATCH] D69415: [CMake] Update Fuchsia build configuration

This revision was automatically updated to reflect the committed changes. Closed by commit rG7fff716ec474: [CMake] Update Fuchsia build configuration (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69415/new/ https://reviews.llvm

[clang] 6d424a1 - Revert "Recommit "[Clang] Pragma vectorize_width() implies vectorize(enable)""

Author: Jordan Rupprecht Date: 2019-10-24T16:35:45-07:00 New Revision: 6d424a161bf3e52730371da0b9439ed93a8ce406 URL: https://github.com/llvm/llvm-project/commit/6d424a161bf3e52730371da0b9439ed93a8ce406 DIFF: https://github.com/llvm/llvm-project/commit/6d424a161bf3e52730371da0b9439ed93a8ce406.di

Re: r374288 - Recommit "[Clang] Pragma vectorize_width() implies vectorize(enable)"

Reverted in 6d424a161bf3e52730371da0b9439ed93a8ce406 due to the issue described here. Should hopefully be a trivial fix forward. On Tue, Oct 22, 2019 at 2:46 PM Michael Kruse wrote: > Am Mo., 21. Okt. 2019 um 23:44 Uhr schrieb Jordan Rupprecht > : > > At any rate, it sounds like this is not a co

[PATCH] D69297: [ARM][AArch64] Implement __arm_rsrf, __arm_rsrf64, __arm_wsrf & __arm_wsrf64

efriedma added a comment. We have __builtin_bit_cast now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69297/new/ https://reviews.llvm.org/D69297 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D69406: [clang][ThinLTO] Promote cc1 -fthin_link_bitcode to driver -fthinlto_link_bitcode

This revision was automatically updated to reflect the committed changes. Closed by commit rGef7a154d17f2: [clang][ThinLTO] Promote cc1 -fthin_link_bitcode to driver… (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69406/new/ http

[clang] ef7a154 - [clang][ThinLTO] Promote cc1 -fthin_link_bitcode to driver -fthinlto_link_bitcode

Author: Yuanfang Chen Date: 2019-10-24T16:54:45-07:00 New Revision: ef7a154d17f2e38ba3c8bfa33f240b60464e4cc7 URL: https://github.com/llvm/llvm-project/commit/ef7a154d17f2e38ba3c8bfa33f240b60464e4cc7 DIFF: https://github.com/llvm/llvm-project/commit/ef7a154d17f2e38ba3c8bfa33f240b60464e4cc7.diff

[PATCH] D69420: [clang][clang-scan-deps] Add support for extracting full module dependencies.

Bigcheese created this revision. Bigcheese added reviewers: arphaman, kousikk. Bigcheese added a project: clang. Herald added subscribers: tschuett, dexonsmith, mgrang, mgorny. This adds experimental support for extracting a Clang module dependency graph from a compilation database. The output for

[clang] 7af309a - [clang][DependencyScanning] clang-format.

Author: Michael Spencer Date: 2019-10-24T18:28:01-07:00 New Revision: 7af309a4ed1a105315a39af3c77da3a8912b8685 URL: https://github.com/llvm/llvm-project/commit/7af309a4ed1a105315a39af3c77da3a8912b8685 DIFF: https://github.com/llvm/llvm-project/commit/7af309a4ed1a105315a39af3c77da3a8912b8685.dif

[PATCH] D69393: [RFC][DebugInfo] emit user specified address_space in dwarf

probinson added a comment. The DW_AT_address_class attribute is intended to be used for target architectures where a simple address value is ambiguous, and the debugger needs additional information to resolve the ambiguity. The canonical example is something like i386 with its segmented addres

[PATCH] D69393: [RFC][DebugInfo] emit user specified address_space in dwarf

ast added a comment. > The address spaces envisioned by the Linux kernel appear to be more > informational and not descriptive of hardware characteristics. From the kernel pov the `__user` and normal are two different address spaces that must be accessed via different kernel primitives. User ac

[PATCH] D69393: [RFC][DebugInfo] emit user specified address_space in dwarf

yonghong-song added a comment. @probinson Thanks for the input! That is my concern too mixing the user defined and language defined may not be a good idea and may actually cause confusion. This is exactly this RFC for. Let us try a different dwarf encoding and then we can continue to discuss.

[clang] 5a48678 - [hip] Allow the declaration of functions with variadic arguments in HIP.

Author: Michael Liao Date: 2019-10-25T00:39:24-04:00 New Revision: 5a48678a6a1619fada23641a68c2d95ee57806b1 URL: https://github.com/llvm/llvm-project/commit/5a48678a6a1619fada23641a68c2d95ee57806b1 DIFF: https://github.com/llvm/llvm-project/commit/5a48678a6a1619fada23641a68c2d95ee57806b1.diff

[PATCH] D69389: [hip] Allow the declaration of functions with variadic arguments in HIP.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a48678a6a16: [hip] Allow the declaration of functions with variadic arguments in HIP. (authored by hliao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D693

[PATCH] D69237: Refactor getDeclAtPosition() to use SelectionTree + targetDecl()

nridge updated this revision to Diff 226372. nridge marked 4 inline comments as done. nridge added a comment. Removed constructor handling, deferring that to a follow-up Addressed other comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69237/n

[PATCH] D69237: Refactor getDeclAtPosition() to use SelectionTree + targetDecl()

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:147 } + while ((N = N->Parent)) { +if (N->ASTNode.get() || N->ASTNode.get() || sammccall wrote: > nridge wrote: > > This part is a super

[PATCH] D69237: Refactor getDeclAtPosition() to use SelectionTree + targetDecl()

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:139 +// that constructor. FIXME(nridge): this should probably be handled in +// targetDecl() itself. +const CXXConstructorDecl *findCalledConstructor(const Select

[clang] 45787e5 - Fix compilation warning. NFC.

Author: Michael Liao Date: 2019-10-25T01:06:52-04:00 New Revision: 45787e56829f47e45d127882b1cd1821e7022e68 URL: https://github.com/llvm/llvm-project/commit/45787e56829f47e45d127882b1cd1821e7022e68 DIFF: https://github.com/llvm/llvm-project/commit/45787e56829f47e45d127882b1cd1821e7022e68.diff

[PATCH] D69391: Add #pragma clang loop ivdep

YashasAndaluri updated this revision to Diff 226375. YashasAndaluri added a comment. Updated the diff to show context Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69391/new/ https://reviews.llvm.org/D69391 Files: clang/docs/LanguageExtensions.r

[PATCH] D69391: Add #pragma clang loop ivdep

xbolva00 added a comment. "#pragma ivdep" should work too (compatibiluty mode with intel, gcc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69391/new/ https://reviews.llvm.org/D69391 ___ cfe-commits

[PATCH] D67161: [clang,ARM] Initial ACLE intrinsics for MVE.

thakis added inline comments. Comment at: clang/utils/TableGen/CMakeLists.txt:17 NeonEmitter.cpp + MveEmitter.cpp TableGen.cpp nit: These files are listed alphabetically. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

<    1   2