[PATCH] D69022: [coroutines] Remove assert on CoroutineParameterMoves in Sema::buildCoroutineParameterMoves

junparser created this revision. junparser added reviewers: modocache, GorNishanov. Herald added subscribers: cfe-commits, EricWF. Herald added a project: clang. The assertion of CoroutineParameterMoves happens when build coroutine function with arguments multiple time while fails to build promi

Re: [PATCH] D53137: Scalable vector core instruction support + size queries

Hi Graham, It seems you forgot to push the last round of fixes. Just saying :) Cheers, Diana On Tue, 8 Oct 2019 at 16:01, Graham Hunter via Phabricator wrote: > > huntergr added a comment. > > Hmm, forgot to add the last round of minor fixes before committing. Sorry > about that, will push the

[PATCH] D69011: Replace platform-dependent `stat` with `llvm::sys::fs::status`. NFC intended.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Watching for regressions in stat calls sounds really useful. This change is trivially equivalent on linux, but the code path is quite different on windows (I have no idea how ::stat work

[PATCH] D68977: [clangd] Report declaration references in findExplicitReferences.

ilya-biryukov added a comment. Mostly LG, but please take a look at the NITs and the implementation-related comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:415 Optional refInDecl(const Decl *D) { struct Visitor : ConstDeclVisitor { This sho

[PATCH] D68937: [clangd] Add parameter renaming to define-inline code action

ilya-biryukov added a comment. An alternative approach I'm thinking of: After D68977 lands, we could try using `findExplicitReferences` to produce all of these edits: 1. we collect locations of all references and declaration of relevant parameters and template

[PATCH] D69025: [Driver,ARM] Make -mfloat-abi=soft turn off MVE.

simon_tatham created this revision. simon_tatham added a reviewer: dmgreen. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. Since `-mfloat-abi=soft` is taken to mean turning off all uses of the FP registers, it should turn off the MVE vector instructions as wel

[PATCH] D68562: [clangd] Add RemoveUsingNamespace tweak.

usaxena95 updated this revision to Diff 225183. usaxena95 marked 11 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68562/new/ https://reviews.llvm.org/D68562 Files: clang-too

[clang-tools-extra] r374982 - [clangd] Add RemoveUsingNamespace tweak.

Author: usaxena95 Date: Wed Oct 16 02:53:59 2019 New Revision: 374982 URL: http://llvm.org/viewvc/llvm-project?rev=374982&view=rev Log: [clangd] Add RemoveUsingNamespace tweak. Summary: Removes the 'using namespace' under the cursor and qualifies all accesses in the current file. E.g.: using n

[PATCH] D68562: [clangd] Add RemoveUsingNamespace tweak.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/RemoveUsingNamespace.cpp:139 + SourceLocation FirstUsingDirectiveLoc = + SM.getLocForEndOfFile(SM.getMainFileID()); + for (auto *D : AllDirectives) { ilya-biryukov wrote

[PATCH] D68562: [clangd] Add RemoveUsingNamespace tweak.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb62b45412168: [clangd] Add RemoveUsingNamespace tweak. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68562/new/ https://reviews.llv

[PATCH] D68838: [ARM] Fix arm_neon.h with -flax-vector-conversions=none, part 3

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. Yep, thanks again! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68838/new/ https://reviews.llvm.org/D68838

[PATCH] D41569: [Concepts] Constraint enforcement and diagnostics

thakis added a comment. The mangling test fails on Windows: http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/15944 It also fails on ppc64le: http://lab.llvm.org:8011/builders/clang-ppc64le-linux-lnt/builds/21092 Please watch http://lab.llvm.org:8011/console for a bit after landing c

[PATCH] D68969: [clang-format] Remove the dependency on frontend

klimek added a comment. In D68969#1709696 , @MyDeveloperDay wrote: > In D68969#1709321 , @klimek wrote: > > > My intuitive solution would have been to get the char* for the start and > > end-location and then sear

r374985 - Revert 374967 "[Concepts] ConceptSpecializationExprs mangling"

Author: nico Date: Wed Oct 16 03:23:53 2019 New Revision: 374985 URL: http://llvm.org/viewvc/llvm-project?rev=374985&view=rev Log: Revert 374967 "[Concepts] ConceptSpecializationExprs mangling" This reverts commit 5e34ad109ced8dbdea9500ee28180315b2aeba3d. The mangling test fails on Windows: http

[PATCH] D41569: [Concepts] Constraint enforcement and diagnostics

thakis added a comment. reverted in r374985, it wasn't obvious to me how to unbreak the test. Sorry! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41569/new/ https://reviews.llvm.org/D41569 ___ cfe-commits mailing li

r374988 - CGExprConstant - silence static analyzer getAs<> null dereference warning. NFCI.

Author: rksimon Date: Wed Oct 16 03:38:40 2019 New Revision: 374988 URL: http://llvm.org/viewvc/llvm-project?rev=374988&view=rev Log: CGExprConstant - silence static analyzer getAs<> null dereference warning. NFCI. The static analyzer is warning about a potential null dereference, but in these c

r374987 - CGBuiltin - silence static analyzer getAs<> null dereference warnings. NFCI.

Author: rksimon Date: Wed Oct 16 03:38:32 2019 New Revision: 374987 URL: http://llvm.org/viewvc/llvm-project?rev=374987&view=rev Log: CGBuiltin - silence static analyzer getAs<> null dereference warnings. NFCI. The static analyzer is warning about potential null dereferences, but in these cases

r374989 - CGDebugInfo - silence static analyzer dyn_cast<> null dereference warnings. NFCI.

Author: rksimon Date: Wed Oct 16 03:38:49 2019 New Revision: 374989 URL: http://llvm.org/viewvc/llvm-project?rev=374989&view=rev Log: CGDebugInfo - silence static analyzer dyn_cast<> null dereference warnings. NFCI. The static analyzer is warning about potential null dereferences, but in these

r374991 - RewriteModernObjC - silence static analyzer getAs<> null dereference warnings. NFCI.

Author: rksimon Date: Wed Oct 16 03:50:06 2019 New Revision: 374991 URL: http://llvm.org/viewvc/llvm-project?rev=374991&view=rev Log: RewriteModernObjC - silence static analyzer getAs<> null dereference warnings. NFCI. The static analyzer is warning about potential null dereferences, but in thes

[PATCH] D68362: [libunwind][RISCV] Add 64-bit RISC-V support

lenary added inline comments. Comment at: libunwind/src/Registers.hpp:3756 +inline double Registers_riscv::getFloatRegister(int regNum) const { +#ifdef __riscv_float_abi_double + assert(validFloatRegister(regNum)); mhorne wrote: > lenary wrote: > > Is this an AB

[PATCH] D69025: [Driver,ARM] Make -mfloat-abi=soft turn off MVE.

dmgreen added a comment. I do not know this code super well. What happens to the preprocessor in such cases? Does it disable the relevant macros automatically because we've turned off the mve and mve.fp features? Could you add a test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D56612: [clangd] A code action to remove 'using namespace'

ilya-biryukov abandoned this revision. ilya-biryukov added a comment. This was finalized and landed as D68562 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56612/new/ https://reviews.llvm.org/D56612 ___ cfe

[PATCH] D68818: [hip][cuda] Fix the extended lambda name mangling issue.

hliao added a comment. PING for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68818/new/ https://reviews.llvm.org/D68818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D67827: [clangd] Simplify name qualification in DefineInline

ilya-biryukov abandoned this revision. ilya-biryukov added a comment. D66647 was updated to use `findExplicitReferences`, abandoning this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67827/new/ https://

[PATCH] D69025: [Driver,ARM] Make -mfloat-abi=soft turn off MVE.

simon_tatham added a comment. Yes: this change is in the driver, and causes those features to be disabled on the command line to cc1, which responds by not defining `__ARM_FEATURE_MVE`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69025/new/ http

[PATCH] D69025: [Driver,ARM] Make -mfloat-abi=soft turn off MVE.

simon_tatham added a comment. So, as for adding a test ... the test I //have// added here ensures that this combination of driver options leads to `-target-feature -mve` and `-mve.fp` on the cc1 command line, and the existing test `Preprocessor/arm-target-features.c` checks that that in turn le

[PATCH] D68362: [libunwind][RISCV] Add 64-bit RISC-V support

luismarques added inline comments. Comment at: libunwind/src/Registers.hpp:3756 +inline double Registers_riscv::getFloatRegister(int regNum) const { +#ifdef __riscv_float_abi_double + assert(validFloatRegister(regNum)); lenary wrote: > mhorne wrote: > > lenary w

[PATCH] D69025: [Driver,ARM] Make -mfloat-abi=soft turn off MVE.

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Yeah, OK. That makes sense. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69025/new/ https://reviews.llvm.org/D69025 ___

r375001 - [Driver,ARM] Make -mfloat-abi=soft turn off MVE.

Author: statham Date: Wed Oct 16 06:23:39 2019 New Revision: 375001 URL: http://llvm.org/viewvc/llvm-project?rev=375001&view=rev Log: [Driver,ARM] Make -mfloat-abi=soft turn off MVE. Since `-mfloat-abi=soft` is taken to mean turning off all uses of the FP registers, it should turn off the MVE vec

[PATCH] D69025: [Driver,ARM] Make -mfloat-abi=soft turn off MVE.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfdccf28697e5: [Driver,ARM] Make -mfloat-abi=soft turn off MVE. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69025/new/ https://

[PATCH] D69033: [clangd] Improve symbol qualification in DefineInline code action

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. Currently define inline action fully qualifies any names in the function body, which is not optimal and definitely

[PATCH] D68362: [libunwind][RISCV] Add 64-bit RISC-V support

luismarques added inline comments. Comment at: libunwind/src/Registers.hpp:3545 + void setSP(uint64_t value) { _registers[2] = value; } + uint64_t getIP() const { return _registers[1]; } + void setIP(uint64_t value) { _registers[1] = value; } ---

[PATCH] D68937: [clangd] Add parameter renaming to define-inline code action

kadircet added a comment. In D68937#1710634 , @ilya-biryukov wrote: > An alternative approach I'm thinking of: > After D68977 lands, we could try using > `findExplicitReferences` to produce all of these edits: > > 1. we

[PATCH] D68937: [clangd] Add parameter renaming to define-inline code action

kadircet updated this revision to Diff 225209. kadircet marked an inline comment as done. kadircet added a comment. - Accept StringRef for Source in rewriteParameterName instead of a NamedDecl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68937/new/

[PATCH] D69033: [clangd] Improve symbol qualification in DefineInline code action

ilya-biryukov added a comment. We seem to have trouble only in presence of using declarations and using namespace directives. I wonder how complicated it would be to take them into account instead. That would clearly be easier to read, as we'll hit right into the center of the problem. Could y

[PATCH] D69036: [libTooling] Fix r374962: add more Transformer forwarding decls.

ymandel created this revision. ymandel added a reviewer: alexfh. Herald added a project: clang. The move to a new, single namespace in r374962 left out some type definitions from the old namespace and resulted in one naming conflict (`text`). This revision adds aliases for those definitions and r

[libunwind] r374969 - [libunwind][Android] Improve workaround for PIE zero-dlpi_addr bug

Author: rprichard Date: Tue Oct 15 19:38:47 2019 New Revision: 374969 URL: http://llvm.org/viewvc/llvm-project?rev=374969&view=rev Log: [libunwind][Android] Improve workaround for PIE zero-dlpi_addr bug Summary: The workaround added in https://reviews.llvm.org/rL299575 appears to be working aroun

[PATCH] D69036: [libTooling] Fix r374962: add more Transformer forwarding decls.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69036/new/ https://reviews.llvm.org/D69036 ___

r375003 - [libTooling] Fix r374962: add more Transformer forwarding decls.

Author: ymandel Date: Wed Oct 16 07:26:20 2019 New Revision: 375003 URL: http://llvm.org/viewvc/llvm-project?rev=375003&view=rev Log: [libTooling] Fix r374962: add more Transformer forwarding decls. Summary: The move to a new, single namespace in r374962 left out some type definitions from the ol

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from a small nit. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:174 +- The :doc:`hicpp-signed-bitwise + ` now supports `IgnorePositiveIntegerLiterals` + option. `IgnorePosi

[PATCH] D69036: [libTooling] Fix r374962: add more Transformer forwarding decls.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc14f1ea25e05: [libTooling] Fix r374962: add more Transformer forwarding decls. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69036/new

[PATCH] D68028: [clang] Add no_builtin attribute

aaron.ballman added a comment. In D68028#1707931 , @gchatelet wrote: > A gentle ping @aaron.ballman Sorry for the delay, I was traveling for last week. Comment at: clang/include/clang/Basic/AttrDocs.td:4402 +The ``__attribute__((no_bu

[PATCH] D68581: Include leading attributes in DeclStmt's SourceRange

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, assuming the requested test changes are as successful as I expect they will be (doesn't need additional review if the tests pass). Comment at: clang/test

[PATCH] D69043: [RFC] Adding time-trace to LLD?

russell.gallop created this revision. russell.gallop added reviewers: ruiu, pcc, anton-afanasyev. Herald added subscribers: cfe-commits, dexonsmith, MaskRay, hiraditya, arichardson, mehdi_amini, emaste. Herald added a reviewer: espindola. Herald added projects: clang, LLVM. The clang -ftime-trace

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

lewis-revill updated this revision to Diff 225230. lewis-revill added a comment. Disable the save/restore optimization when a function contains tail calls. Address various miscellaneous concerns with the patch. Update tests to include less redundant code when checking cases where save/restore li

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

probinson added a comment. In D68117#1710295 , @dblaikie wrote: > I think the existing feature's perhaps a bit misspecified - because where you > put the DEFAULTED_{in_class,out_of_class} would communicate that without > needing the two values - if you p

[PATCH] D68876: [libTooling] Put all Transformer declarations in a single namespace.

aprantl added a comment. This broke the modular build since some symbols are now ambiguous within the same Clang module.' http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/2646/consoleFull#25217323649ba4694-19c4-4d7e-bec5-911270d8a58c FAILED: tools/clang/lib/Tooling/CMakeFiles/obj.cla

[PATCH] D23934: Add a -ffixed-date-time= flag that sets the initial value of __DATE__, __TIME__, __TIMESTAMP__

Alexander added a comment. What is the status of this issue? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D23934/new/ https://reviews.llvm.org/D23934 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D69033: [clangd] Improve symbol qualification in DefineInline code action

kuhnel added a comment. Build failed during patching: 00:03:00.433 [Phabricator] $ arc patch --diff 225207 --nocommit --nobranch --conduit-uri=https://reviews.llvm.org 00:03:01.736 INFO Base commit is not in local repository; trying to fetch. 00:03:02.694 00:03:02.694 00:0

[PATCH] D68937: [clangd] Add parameter renaming to define-inline code action

kuhnel added a comment. Build failed as patch failed to apply: 00:00:06.098 Checking patch clang-tools-extra/trunk/clangd/FindTarget.h... 00:00:06.100 error: clang-tools-extra/trunk/clangd/FindTarget.h: does not exist in index 00:00:06.100 Checking patch clang-tools-extra/trunk/clangd/Find

r375012 - [DWARF5] Added support for DW_AT_noreturn attribute to be emitted for

Author: adrian Date: Wed Oct 16 09:30:38 2019 New Revision: 375012 URL: http://llvm.org/viewvc/llvm-project?rev=375012&view=rev Log: [DWARF5] Added support for DW_AT_noreturn attribute to be emitted for C++ class member functions. Patch by Sourabh Singh Tomar! Differential Revision: https://revi

[PATCH] D23934: Add a -ffixed-date-time= flag that sets the initial value of __DATE__, __TIME__, __TIMESTAMP__

Alexander added inline comments. Comment at: lib/Frontend/CompilerInvocation.cpp:2252 + TM.tm_isdst = -1; + mktime(&TM); + Opts.FixedDateTime = TM; efriedma wrote: > Does using mktime like this depend on the local timezone? Since the return value o

[PATCH] D68697: [DWARF5] Added support for DW_AT_noreturn attribute to be emitted for C++ class member functions.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa9cfde1f6ab5: [DWARF5] Added support for DW_AT_noreturn attribute to be emitted for C++ class… (authored by aprantl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D68876: [libTooling] Put all Transformer declarations in a single namespace.

ymandel added a comment. This should be fixed by r375003. Please let me know if that's not the case. In D68876#1711227 , @aprantl wrote: > This broke the modular build since some symbols are now ambiguous within the > same Clang module.' > > http://green

r375017 - [OPENMP]Use different addresses for zeroed thread_id/bound_id.

Author: abataev Date: Wed Oct 16 09:59:01 2019 New Revision: 375017 URL: http://llvm.org/viewvc/llvm-project?rev=375017&view=rev Log: [OPENMP]Use different addresses for zeroed thread_id/bound_id. When the parallel region is called directly in the sequential region, the zeroed tid/bound id are us

[PATCH] D63131: arm64_32: implement the desired ABI for the ILP32 triple.

t.p.northover updated this revision to Diff 225259. t.p.northover added a comment. Updating diff. How target features are handled changed slightly upstream. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63131/new/ https://reviews.llvm.org/D63131 F

[PATCH] D69017: Include sanitize blacklist and other extra deps as part of scan-deps output

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm. Jan may want to take a look as I believe he was looking at a related issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69017/new/

r375022 - Tag CFI-generated data structures with "#pragma clang section" attributes.

Author: dmikulin Date: Wed Oct 16 10:51:40 2019 New Revision: 375022 URL: http://llvm.org/viewvc/llvm-project?rev=375022&view=rev Log: Tag CFI-generated data structures with "#pragma clang section" attributes. Differential Revision: https://reviews.llvm.org/D68808 Added: cfe/trunk/test/CodeG

[PATCH] D68410: [AttrDocs] document always_inline

lebedev.ri requested changes to this revision. lebedev.ri added a comment. This revision now requires changes to proceed. I think partial (but not wrong!) docs is better than no docs whatsoever, so i'd be inclined to proceed with this. I, too, not really convinced that actual explicit rules shoul

[PATCH] D68808: Tag CFI-generated data structures with "#pragma clang section" attributes.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe2692b3bc032: Tag CFI-generated data structures with "#pragma clang section" attributes. (authored by dmikulin). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLV

r375026 - [OPENMP]Allow priority clause in combined task-based directives.

Author: abataev Date: Wed Oct 16 11:09:37 2019 New Revision: 375026 URL: http://llvm.org/viewvc/llvm-project?rev=375026&view=rev Log: [OPENMP]Allow priority clause in combined task-based directives. The expression of the priority clause must be captured in the combined task-based directives, like

r375027 - Fix darwin-ld-lto test for some speical path

Author: steven_wu Date: Wed Oct 16 11:12:41 2019 New Revision: 375027 URL: http://llvm.org/viewvc/llvm-project?rev=375027&view=rev Log: Fix darwin-ld-lto test for some speical path Fix the test by not assuming the prefix path of the temp directory can be matched by a regex. rdar://problem/562591

[PATCH] D69060: [Sema][Typo Correction] Fix another infinite loop on ambiguity

dgoldman created this revision. dgoldman added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. See also: D67515 - For the given call expression we would end up repeatedly trying to transform the same expression over and

[PATCH] D66712: [Driver] Enable ShadowCallStack, not SafeStack, by default on AArch64 Fuchsia

mcgrathr added a comment. It's time to land this now. Can one of you commit it for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66712/new/ https://reviews.llvm.org/D66712 ___ cfe-commits mailing

[PATCH] D67545: [clang-tidy] Added DefaultOperatorNewCheck.

lebedev.ri requested changes to this revision. lebedev.ri added a comment. This revision now requires changes to proceed. (outstanding unaddressed review notes) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67545/new/ https://reviews.llvm.org/D6754

[PATCH] D66712: [Driver] Enable ShadowCallStack, not SafeStack, by default on AArch64 Fuchsia

mcgrathr updated this revision to Diff 225273. mcgrathr added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66712/new/ https://reviews.llvm.org/D66712 Files: clang/lib/Driver/ToolChains/Fuchsia.cpp clang/test/Driver/fuchsia.

[PATCH] D68876: [libTooling] Put all Transformer declarations in a single namespace.

aprantl added a comment. It looks like it's still failing: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/2649/console Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68876/new/ https://reviews.llvm.org/D68876 __

[PATCH] D69062: Resolve LWG issue 2426

zoecarver created this revision. zoecarver added reviewers: mclow.lists, EricWF, ldionne, rsmith. Herald added subscribers: libcxx-commits, cfe-commits, dexonsmith, christof. Herald added projects: clang, libc++. This patch checks that `expected` is loaded before it is used. Libc++ already does t

[PATCH] D69062: Resolve LWG issue 2426

ldionne requested changes to this revision. ldionne added a comment. This revision now requires changes to proceed. If we want to mark the LWG issue as being resolved for libc++, I think the test should be moved to the libc++ test suite. Otherwise, we're only assessing that libc++ implements LWG

[PATCH] D68876: [libTooling] Put all Transformer declarations in a single namespace.

ymandel added a comment. In D68876#1711576 , @aprantl wrote: > It looks like it's still failing: > http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/2649/console That line was fixed in the revision I mentioned: https://reviews.llvm.org/rL375003

[PATCH] D68914: [clang-format] Remove duplciate code from Invalid BOM detection

dexonsmith added a comment. In D68914#1710407 , @owenpan wrote: > I did a quick search of the LLVM code base and found dozens of `const > StringRef &`, including the `Twine` API >

r375031 - Replace platform-dependent `stat` with `llvm::sys::fs::status`. NFC intended.

Author: vsapsai Date: Wed Oct 16 12:12:34 2019 New Revision: 375031 URL: http://llvm.org/viewvc/llvm-project?rev=375031&view=rev Log: Replace platform-dependent `stat` with `llvm::sys::fs::status`. NFC intended. Reviewers: bruno, sammccall Reviewed By: sammccall Subscribers: jkorous, dexonsmith

[PATCH] D69011: Replace platform-dependent `stat` with `llvm::sys::fs::status`. NFC intended.

vsapsai added a comment. Thanks for the review! If `fs::status` behaviour is sufficiently different on Windows, it is worth fixing because I believe majority of non-Windows developers expect them to work in the same way. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69011/new/ https:/

[PATCH] D69011: Replace platform-dependent `stat` with `llvm::sys::fs::status`. NFC intended.

This revision was automatically updated to reflect the committed changes. Closed by commit rG930ada91ce8f: Replace platform-dependent `stat` with `llvm::sys::fs::status`. NFC intended. (authored by vsapsai). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D47111: : Implement monotonic_buffer_resource.

Quuxplusone marked 11 inline comments as done. Quuxplusone added inline comments. Comment at: include/experimental/memory_resource:427 +static _LIBCPP_CONSTEXPR const size_t __default_buffer_capacity = 1024; +static _LIBCPP_CONSTEXPR const size_t __default_buffer_alignmen

[PATCH] D68818: [hip][cuda] Fix the extended lambda name mangling issue.

rsmith added a comment. Broadly, I think it's reasonable to number additional lambda expressions in CUDA compilations. However: - This is (in theory) an ABI break on the host side, as it changes the lambda numbering in inline functions and function templates and the like. That could be mitigat

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

dblaikie added a comment. In D68117#1711154 , @probinson wrote: > In D68117#1710295 , @dblaikie wrote: > > > I think the existing feature's perhaps a bit misspecified - because where > > you put the DEFAULTED_{in_c

[clang-tools-extra] r375039 - [clangd] Add the missing dependency on `clangLex`.

Author: hliao Date: Wed Oct 16 13:22:54 2019 New Revision: 375039 URL: http://llvm.org/viewvc/llvm-project?rev=375039&view=rev Log: [clangd] Add the missing dependency on `clangLex`. Modified: clang-tools-extra/trunk/clangd/refactor/tweaks/CMakeLists.txt clang-tools-extra/trunk/clangd/too

[PATCH] D68818: [hip][cuda] Fix the extended lambda name mangling issue.

hliao marked an inline comment as done. hliao added a comment. In D68818#1711698 , @rsmith wrote: > Broadly, I think it's reasonable to number additional lambda expressions in > CUDA compilations. However: > > - This is (in theory) an ABI break on the hos

[PATCH] D53768: Add VerboseOutputStream to CompilerInstance

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. Herald added a subscriber: wdng. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53768/new/ https://reviews.llvm.org/D53768 ___ cfe-c

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev abandoned this revision. sdmitriev added a comment. All three parts have been committed, so I am abandoning the original patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64943/new/ https://reviews.llvm.org/D64943 ___ cfe-commi

[PATCH] D31130: B32239 clang-tidy should not warn about array to pointer decay on system macros

fiesh added a comment. Herald added a subscriber: wuzish. Ping! Am I correct in that basically everything's done here and this has been lingering ever since? It would be great if the change could make it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31130/new/ https://reviews.llvm.o

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

apazos added a comment. Thanks Lewis, the runs are looking good, no failures, and good code size savings (average 3%) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62686/new/ https://reviews.llvm.org/D62686 _

[PATCH] D31130: B32239 clang-tidy should not warn about array to pointer decay on system macros

lebedev.ri added a comment. The description only says what the patch does, not why this is the desired behavior. Also, this is now under a wrong license. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31130/new/ https://reviews.llvm.org/D31130

[PATCH] D68028: [clang] Add no_builtin attribute

rsmith added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:9508-9510 + // FIXME: We should really be doing this in SemaDeclAttr.cpp::handleNoBuiltin + // but there is a bug with FunctionDecl::isThisDeclarationADefinition() which + // always returns false before Sema

[PATCH] D68028: [clang] Add no_builtin attribute

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:9508-9510 + // FIXME: We should really be doing this in SemaDeclAttr.cpp::handleNoBuiltin + // but there is a bug with FunctionDecl::isThisDeclarationADefinition() which + // always returns false befo

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

probinson added a comment. In D68117#1711714 , @dblaikie wrote: > In D68117#1711154 , @probinson wrote: > > > (@dblaikie Aside regarding noreturn, the original DWARF proposal was for a > > debugger wanting to know

[PATCH] D68835: [clang-scan-deps] Add basic support for Clang modules.

Bigcheese updated this revision to Diff 225311. Bigcheese added a comment. Added .i, .ii, .mi, and .mmi as files to minimize. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68835/new/ https://reviews.llvm.org/D68835 Files: lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cp

[PATCH] D68818: [hip][cuda] Fix the extended lambda name mangling issue.

rjmccall added a comment. I agree with Richard's suggestion of just numbering all the lambdas in both modes if that's viable. Comment at: clang/include/clang/AST/DeclCXX.h:587-590 +unsigned NumExplicitCaptures : 12; + +/// Has known `internal` linkage. +unsigned Ha

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

rjmccall added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:203 + // Floating point exceptions are not handled: fp exceptions are masked. + FPEB_Ignore, // This is the default + // Optimizer will avoid transformations that may raise exceptions that

[PATCH] D69072: [OpenCL] Added doc to describe OpenCL support

Anastasia created this revision. Anastasia added reviewers: svenvh, mantognini, neil.hickey. Herald added subscribers: ebevhan, yaxunl. https://reviews.llvm.org/D69072 Files: clang/docs/OpenCLSupport.rst Index: clang/docs/OpenCLSupport.rst =

[PATCH] D68554: [clang-format] Proposal for clang-format to give compiler style warnings

MyDeveloperDay added a subscriber: hans. MyDeveloperDay added a comment. In D68554#1709316 , @sylvestre.ledru wrote: > @MyDeveloperDay I think it should be added to the release notes. it is a > great new changes for clang format (it would have made my li

[PATCH] D68969: [clang-format] Remove the dependency on frontend

MyDeveloperDay updated this revision to Diff 225320. MyDeveloperDay added a comment. Remove need to split lines or search for `\n` General Algorithm 1. take Location of Replacement line and column 2. make a new SourceLocation of line and column =0 (beginning of that replacement line) 3. make a

[PATCH] D68028: [clang] Add no_builtin attribute

rsmith added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:9508-9510 + // FIXME: We should really be doing this in SemaDeclAttr.cpp::handleNoBuiltin + // but there is a bug with FunctionDecl::isThisDeclarationADefinition() which + // always returns false before Sema

[PATCH] D68528: [Implicit Modules] Add -cc1 option -fmodules-strict-hash which includes search paths and diagnostics.

Bigcheese updated this revision to Diff 225326. Bigcheese marked an inline comment as done. Bigcheese added a comment. Fixed spelling and updated comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68528/new/ https://reviews.llvm.org/D68528 Files: include/clang/Driver/CC1Options.t

[PATCH] D69017: Include sanitize blacklist and other extra deps as part of scan-deps output

jkorous accepted this revision. jkorous added a comment. Looks great! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69017/new/ https://reviews.llvm.org/D69017 ___ cfe-commits mailing list cfe-c

[clang-tools-extra] r375058 - [lit] Fix another test case that r374652 missed

Author: jdenny Date: Wed Oct 16 16:58:58 2019 New Revision: 375058 URL: http://llvm.org/viewvc/llvm-project?rev=375058&view=rev Log: [lit] Fix another test case that r374652 missed Modified: clang-tools-extra/trunk/test/clang-include-fixer/merge.test Modified: clang-tools-extra/trunk/test/cl

[PATCH] D66827: Add support for MS qualifiers __ptr32, __ptr64, __sptr, __uptr.

akhuang added a comment. @DarkShadow44 Thanks for finding this bug! I haven't had time to look at this for a while but will start working on it soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66827/new/ https://reviews.llvm.org/D66827 _

r375063 - [Concepts] ConceptSpecializationExprs mangling

Author: saar.raz Date: Wed Oct 16 17:16:01 2019 New Revision: 375063 URL: http://llvm.org/viewvc/llvm-project?rev=375063&view=rev Log: [Concepts] ConceptSpecializationExprs mangling Implement mangling for CSEs to match regular template-ids. Reviewed as part of D41569

[PATCH] D67321: Respect CLANG_LINK_CLANG_DYLIB=ON in libclang and c-index-test

aaronpuchert added a comment. @beanz Could you have a look again? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67321/new/ https://reviews.llvm.org/D67321 ___ cfe-commits mailing list cfe-commits@lists

  1   2   >