[PATCH] D63932: [GlobalDCE] Dead Virtual Function Elimination

sylvestre.ledru added a comment. @ostannard Maybe you could add that to the release notes? Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63932/new/ https://reviews.llvm.org/D63932 ___ cfe-commi

r374864 - [Format] Add machine-readable SPDX license ID to clang-format.el

Author: sammccall Date: Tue Oct 15 00:25:18 2019 New Revision: 374864 URL: http://llvm.org/viewvc/llvm-project?rev=374864&view=rev Log: [Format] Add machine-readable SPDX license ID to clang-format.el Modified: cfe/trunk/tools/clang-format/clang-format.el Modified: cfe/trunk/tools/clang-form

[PATCH] D68914: [clang-format] Remove duplciate code from Invalid BOM detection

owenpan added inline comments. Comment at: clang/include/clang/Basic/SourceManager.h:232 +// nullptr +static const char *getInvalidBOM(StringRef BufStr); }; klimek wrote: > owenpan wrote: > > Can you make the parameter `const`? > StringRef is inherentl

[PATCH] D68914: [clang-format] Remove duplciate code from Invalid BOM detection

owenpan added a comment. Here are some `const StringRef &` examples . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68914/new/ https://reviews.llvm.org/D68914 ___

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

steakhal added a comment. I think this patch is ok. Although there are remarks: - I think the current implementation of the taint filtering functions does not follow the expected semantics. Now the modelling would remove taint before calling the function (//pre statement//). One might expect t

[PATCH] D68914: [clang-format] Remove duplciate code from Invalid BOM detection

klimek added a comment. In D68914#1709002 , @owenpan wrote: > Here are some `const StringRef &` examples > . StringRef already is a const pointe

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

vladimir.plyashkun updated this revision to Diff 224976. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68694/new/ https://reviews.llvm.org/D68694 Files: clang-tools-extra/clang-tidy/hicpp/SignedBitwiseCheck.cpp clang-tools-extra/clang-tidy/hicpp/

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

vladimir.plyashkun added a comment. In D68694#1706204 , @JonasToth wrote: > > Do you know who is responsible for it? Because i haven't worked with > > documentation before and don't know what i need to do to update it. > > The files reside in `clang-tools

[PATCH] D68977: [clangd] Report declaration references in findExplicitReferences.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68977 Files: clang-tools-extra/clangd/FindTarget.cpp

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille added a comment. Some benchmarks, running the python performance suite from recompiled cpython build, one built with `-O2` (baseline) and one built with `-O2 -fstack-clash-protection` (protection). Surprisingly enough, the stack protection makes the code faster in various scen

[PATCH] D68978: [clangd] Propagate main context into ClangdServer

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Currently clangd initializes the ClangdServer lazily during onInitialize request, and it results in pro

r374876 - Fix uninitialized variable warnings. NFCI.

Author: rksimon Date: Tue Oct 15 03:23:05 2019 New Revision: 374876 URL: http://llvm.org/viewvc/llvm-project?rev=374876&view=rev Log: Fix uninitialized variable warnings. NFCI. Modified: cfe/trunk/lib/AST/ASTImporter.cpp Modified: cfe/trunk/lib/AST/ASTImporter.cpp URL: http://llvm.org/viewv

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

lewis-revill added a comment. In D62686#1708792 , @apazos wrote: > Yes Eli thanks for pointing out there are more scenarios that can fail. > It looks like the best solution is to permit both flags on, but then bail > out from doing this transformation i

[PATCH] D68978: [clangd] Propagate main context into ClangdServer

merge_guards_bot added a comment. Bulid results are available at http://results.llvm-merge-guard.org/Phabricator-35 See http://jenkins.llvm-merge-guard.org/job/Phabricator/35/ for more details. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68978

[PATCH] D68977: [clangd] Report declaration references in findExplicitReferences.

merge_guards_bot added a comment. Bulid results are available at http://results.llvm-merge-guard.org/Phabricator-36 See http://jenkins.llvm-merge-guard.org/job/Phabricator/36/ for more details. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68977

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille added a comment. > For maintenance reasons, I'd really prefer it if we could find a way to reuse > the existing code that calls an external stack probe function. What do you > think about taking a look at X86RetpolineThunks.cpp and doing something > similar to that? Basically,

[PATCH] D68407: [RISCV] Use compiler-rt if no GCC installation detected

lenary requested changes to this revision. lenary added a comment. This revision now requires changes to proceed. Please can you add a test for riscv32 and riscv64 without libgcc? I also think you want to be smarter about detecting the need/request for libgcc. Look for `AddRunTimeLibs` in clang/

[PATCH] D63607: [clang][driver] Add basic --driver-mode=flang support for fortran

peterwaller-arm added a comment. Friendly ping to everybody watching. I'd like to get this in soon if possible. Hal - do you think this is close to being accepted? Note that I consider this "the beginning" rather than "the end", since there will be more functionality to add piecewise before thi

[PATCH] D68981: [clangd] Use our own relation kind.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Move the RelationKind from Serialization.h to Relation.h. This patch doesn't introduce any breaking changes. Repository:

[PATCH] D68981: [clangd] Use our own relation kind.

merge_guards_bot added a comment. Bulid results are available at http://results.llvm-merge-guard.org/Phabricator-37 See http://jenkins.llvm-merge-guard.org/job/Phabricator/37/ for more details. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68981

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

lewis-revill added inline comments. Comment at: llvm/test/CodeGen/RISCV/saverestore.ll:348 + +; Check that functions with varargs do not use save/restore code + luismarques wrote: > Maybe for these tests just put a -NOT check that __riscv_save_ isn't called? Than

[PATCH] D68554: [clang-format] Proposal for clang-format to give compiler style warnings

sylvestre.ledru added a comment. @MyDeveloperDay I think it should be added to the release notes. it is a great new changes for clang format (it would have made my life at Mozilla much easier ;) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68554/

[PATCH] D68969: [clang-format] Remove the dependency on frontend

klimek added a comment. My intuitive solution would have been to get the char* for the start and end-location and then search forward and backwards for \n. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68969/new/ https://reviews.llvm.org/D68969 __

r374882 - [Concepts] Concept Specialization Expressions

Author: saar.raz Date: Tue Oct 15 04:48:58 2019 New Revision: 374882 URL: http://llvm.org/viewvc/llvm-project?rev=374882&view=rev Log: [Concepts] Concept Specialization Expressions Part of C++20 Concepts implementation effort. Added Concept Specialization Expressions that are created when a conc

[PATCH] D68792: [Alignment] Migrate Attribute::getWith(Stack)Alignment

courbet accepted this revision. courbet added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/IR/Core.cpp:2792 + Attribute AlignAttr = + Attribute::getWithAlignment(Call->getContext(), llvm::Align(align)); Call->addAttribute(index,

[PATCH] D68792: [Alignment] Migrate Attribute::getWith(Stack)Alignment

gchatelet updated this revision to Diff 225006. gchatelet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68792/new/ https://reviews.llvm.org/D68792 Files: clang/lib/CodeGen/CGCall.cpp llvm/include/llvm/IR/Att

[PATCH] D68792: [Alignment] Migrate Attribute::getWith(Stack)Alignment

gchatelet updated this revision to Diff 225010. gchatelet added a comment. - Fix naming collision Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68792/new/ https://reviews.llvm.org/D68792 Files: clang/lib/CodeGen/CGCall.cpp llvm/include/llvm/IR

r374884 - [Alignment] Migrate Attribute::getWith(Stack)Alignment

Author: gchatelet Date: Tue Oct 15 05:56:24 2019 New Revision: 374884 URL: http://llvm.org/viewvc/llvm-project?rev=374884&view=rev Log: [Alignment] Migrate Attribute::getWith(Stack)Alignment Summary: This is patch is part of a series to introduce an Alignment type. See this thread for context: h

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille added a comment. Another test run on an x264 encoder (source: https://openbenchmarking.org/test/pts/x264) Compiled with -O2 and with or without -fstack-clash-protection; Run without threads (`x265 --pools 1 -F 1 ./Bosphorus_1920x1080_120fps_420_8bit_YUV.y4m /dev/null`) **Cla

[PATCH] D68792: [Alignment] Migrate Attribute::getWith(Stack)Alignment

This revision was automatically updated to reflect the committed changes. Closed by commit rGb65fa483058f: [Alignment] Migrate Attribute::getWith(Stack)Alignment (authored by gchatelet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68792/new/ https

[PATCH] D68818: [hip][cuda] Fix the extended lambda name mangling issue.

hliao added a comment. PING for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68818/new/ https://reviews.llvm.org/D68818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[clang-tools-extra] r374885 - [clang-tools-extra] Fix overzealous linking of dylib to clangTidy

Author: mgorny Date: Tue Oct 15 06:05:38 2019 New Revision: 374885 URL: http://llvm.org/viewvc/llvm-project?rev=374885&view=rev Log: [clang-tools-extra] Fix overzealous linking of dylib to clangTidy Fix accidentally making clangTidy library link to dylib. This causes libclang.so to also link to

[PATCH] D68927: [clang-tools-extra] Fix overzealous linking of dylib to clangTidy

mgorny added a comment. Sure but what doc? The non-existing one of `clang_target_link_libraries`? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68927/new/ https://reviews.llvm.org/D68927 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D68927: [clang-tools-extra] Fix overzealous linking of dylib to clangTidy

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c9bd1657cbd: [clang-tools-extra] Fix overzealous linking of dylib to clangTidy (authored by mgorny). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D68927: [clang-tools-extra] Fix overzealous linking of dylib to clangTidy

sylvestre.ledru added a comment. In that function https://github.com/llvm/llvm-project/blob/5fd467feb813eefe3558da434cb038213582/clang/cmake/modules/AddClang.cmake#L180 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68927/new/ https://reviews.l

[PATCH] D68981: [clangd] Use our own relation kind.

hokein updated this revision to Diff 225017. hokein added a comment. update a style comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68981/new/ https://reviews.llvm.org/D68981 Files: clang-tools-extra/clangd/XRefs.cpp clang-tools-extra/c

[PATCH] D68927: [clang-tools-extra] Fix overzealous linking of dylib to clangTidy

mgorny added a comment. In D68927#1709395 , @sylvestre.ledru wrote: > In that function > https://github.com/llvm/llvm-project/blob/5fd467feb813eefe3558da434cb038213582/clang/cmake/modules/AddClang.cmake#L180 I'm not really sure what you mean me to

[PATCH] D68981: [clangd] Use our own relation kind.

merge_guards_bot added a comment. Bulid results are available at http://results.llvm-merge-guard.org/Phabricator-38 See http://jenkins.llvm-merge-guard.org/job/Phabricator/38/ for more details. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68981

[PATCH] D68862: [ARM] Allocatable Global Register Variables for ARM

carwil added a comment. In D68862#1708132 , @chill wrote: > In D68862#1708079 , @carwil wrote: > > > > IMHO, since reserved registes are per-function, this strongly suggests > > > implementation as function attribu

[PATCH] D68981: [clangd] Use our own relation kind.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/MemIndex.h:72 // A map from (subject, predicate) pair to objects. - llvm::DenseMap, std::vector> + llvm::DenseMap, std::vector> Relations; can we rather use `uint8_t` in here i

[PATCH] D68978: [clangd] Propagate main context into ClangdServer

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Otherwise LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68978/new/ https://reviews.llvm.org/D68978 _

[PATCH] D68978: [clangd] Propagate main context into ClangdServer

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:463 + // Server, CDB, etc. + llvm::Optional MainContext; + MainContext.emplace(BackgroundContext.clone()); As discussed offline: I think it'd be clearer to put this in a

[PATCH] D68978: [clangd] Propagate main context into ClangdServer

kadircet updated this revision to Diff 225027. kadircet marked an inline comment as done. kadircet added a comment. - Move context swapping next to server creation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68978/new/ https://reviews.llvm.org/D6

[clang-tools-extra] r374892 - [clangd] Propagate main context into ClangdServer

Author: kadircet Date: Tue Oct 15 07:20:52 2019 New Revision: 374892 URL: http://llvm.org/viewvc/llvm-project?rev=374892&view=rev Log: [clangd] Propagate main context into ClangdServer Summary: Currently clangd initializes the ClangdServer lazily during onInitialize request, and it results in pro

r374893 - [AST] Remove unused Sema includes to fix a cyclic dependency from Sema to AST

Author: d0k Date: Tue Oct 15 07:23:05 2019 New Revision: 374893 URL: http://llvm.org/viewvc/llvm-project?rev=374893&view=rev Log: [AST] Remove unused Sema includes to fix a cyclic dependency from Sema to AST Modified: cfe/trunk/lib/AST/ExprCXX.cpp Modified: cfe/trunk/lib/AST/ExprCXX.cpp URL:

[PATCH] D68362: [libunwind][RISCV] Add 64-bit RISC-V support

lenary added a comment. One query, but this patch is starting to look good. I'm not a libunwind expert - it would be good to have one of the libunwind contributors look over this patch yet. Can you add one as a reviewer? Comment at: libunwind/src/Registers.hpp:3677 + case UN

r374895 - Reapply: [Modules][PCH] Hash input files content

Author: bruno Date: Tue Oct 15 07:23:55 2019 New Revision: 374895 URL: http://llvm.org/viewvc/llvm-project?rev=374895&view=rev Log: Reapply: [Modules][PCH] Hash input files content Summary: When files often get touched during builds, the mtime based validation leads to different problems in impli

[PATCH] D68978: [clangd] Propagate main context into ClangdServer

This revision was automatically updated to reflect the committed changes. Closed by commit rG9d66247e9b78: [clangd] Propagate main context into ClangdServer (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68978/new/ https://rev

[PATCH] D68981: [clangd] Use our own relation kind.

hokein updated this revision to Diff 225034. hokein marked 4 inline comments as done. hokein added a comment. Herald added subscribers: llvm-commits, dexonsmith. Herald added a project: LLVM. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D68981: [clangd] Use our own relation kind.

hokein added inline comments. Comment at: clang-tools-extra/clangd/index/MemIndex.h:72 // A map from (subject, predicate) pair to objects. - llvm::DenseMap, std::vector> + llvm::DenseMap, std::vector> Relations; kadircet wrote: > can we rather use `ui

[PATCH] D68978: [clangd] Propagate main context into ClangdServer

merge_guards_bot added a comment. Bulid results are available at http://results.llvm-merge-guard.org/Phabricator-39 See http://jenkins.llvm-merge-guard.org/job/Phabricator/39/ for more details. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68978

[PATCH] D67763: [Clang FE] Recognize -mnop-mcount CL option

jonpa added a reviewer: bkramer. jonpa added a comment. @Benjamin: I see that you removed the option that I am now putting back, so perhaps you could take a look and see if this patch looks ok? Thanks. /Jonas CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67763/new/ https://reviews.llvm

[PATCH] D68981: [clangd] Use our own relation kind.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/MemIndex.cpp:95 LookupRequest LookupReq; -auto It = Relations.find(std::make_pair(Subject, Req.Predicate)); +auto It = Relations.find(std::make_pair(Subject, (uint8_t)Req.Predicate)); if

r374899 - Revert 374882 "[Concepts] Concept Specialization Expressions"

Author: nico Date: Tue Oct 15 07:46:39 2019 New Revision: 374899 URL: http://llvm.org/viewvc/llvm-project?rev=374899&view=rev Log: Revert 374882 "[Concepts] Concept Specialization Expressions" This reverts commit ec87b003823d63f3342cf648f55a134c1522e612. The test fails on Windows, see e.g. http:/

[PATCH] D68981: [clangd] Use our own relation kind.

hokein updated this revision to Diff 225037. hokein marked 5 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68981/new/ https://reviews.llvm.org/D68981 Files: clang-tools-extra/cla

[PATCH] D68978: [clangd] Propagate main context into ClangdServer

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.h:135 + // Since initialization of CDBs and ClangdServer is done lazily, the following + // context captures the one used while creating ClangdLSPServer and passes it N

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX added a comment. In D68117#1708115 , @dblaikie wrote: > In D68117#1708114 , @SouraVX wrote: > > > In D68117#1707680 , @dblaikie > > wrote: > > > > > In D68117#170757

[PATCH] D68981: [clangd] Use our own relation kind.

hokein updated this revision to Diff 225039. hokein added a comment. fix a missing static_cast. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68981/new/ https://reviews.llvm.org/D68981 Files: clang-tools-extra/clangd/XRefs.cpp clang-tools-extr

[clang-tools-extra] r374901 - [clangd][NFC] Update comments to use triple-slashes

Author: kadircet Date: Tue Oct 15 07:59:08 2019 New Revision: 374901 URL: http://llvm.org/viewvc/llvm-project?rev=374901&view=rev Log: [clangd][NFC] Update comments to use triple-slashes Modified: clang-tools-extra/trunk/clangd/ClangdLSPServer.h Modified: clang-tools-extra/trunk/clangd/Clang

[PATCH] D68981: [clangd] Use our own relation kind.

merge_guards_bot added a comment. Bulid results are available at http://results.llvm-merge-guard.org/Phabricator-40 See http://jenkins.llvm-merge-guard.org/job/Phabricator/40/ for more details. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68981

[PATCH] D68981: [clangd] Use our own relation kind.

hokein updated this revision to Diff 225041. hokein added a comment. more static_cast Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68981/new/ https://reviews.llvm.org/D68981 Files: clang-tools-extra/clangd/XRefs.cpp clang-tools-extra/clangd/i

[PATCH] D68981: [clangd] Use our own relation kind.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68981/new/ https://reviews.llvm.org/D68981 ___

[PATCH] D67159: [clang] New __attribute__((__clang_arm_mve_alias)).

simon_tatham added a comment. Thanks for the review! (I expect to leave this uncommitted until I have enough other patches approved to make it actually useful, and then commit them all together.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67159

[PATCH] D68981: [clangd] Use our own relation kind.

merge_guards_bot added a comment. Bulid results are available at http://results.llvm-merge-guard.org/Phabricator-41 See http://jenkins.llvm-merge-guard.org/job/Phabricator/41/ for more details. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68981

r374903 - [Concepts] Concept Specialization Expressions

Author: saar.raz Date: Tue Oct 15 08:24:26 2019 New Revision: 374903 URL: http://llvm.org/viewvc/llvm-project?rev=374903&view=rev Log: [Concepts] Concept Specialization Expressions Part of C++20 Concepts implementation effort. Added Concept Specialization Expressions that are created when a conc

[PATCH] D68981: [clangd] Use our own relation kind.

merge_guards_bot added a comment. Bulid results are available at http://results.llvm-merge-guard.org/Phabricator-43 See http://jenkins.llvm-merge-guard.org/job/Phabricator/43/ for more details. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68981

[PATCH] D68697: [DWARF5] Added support for DW_AT_noreturn attribute to be emitted for C++ class member functions.

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. LGTM with updated testcase, thanks! Comment at: llvm/test/DebugInfo/X86/noreturn_cpp11.ll:59 -attributes #0 = { noreturn } +attributes #0 = { noinline noreturn optnone uw

[PATCH] D68981: [clangd] Use our own relation kind.

merge_guards_bot added a comment. Bulid results are available at http://results.llvm-merge-guard.org/Phabricator-42 See http://jenkins.llvm-merge-guard.org/job/Phabricator/42/ for more details. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68981

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille updated this revision to Diff 225049. serge-sans-paille added a comment. Get rid of static mapping + update test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/ https://reviews.llvm.org/D68720 Files: clang/docs/R

r374907 - [Concepts] Remove unused and illegal Sema includes from ExprCXX.cpp

Author: saar.raz Date: Tue Oct 15 08:49:29 2019 New Revision: 374907 URL: http://llvm.org/viewvc/llvm-project?rev=374907&view=rev Log: [Concepts] Remove unused and illegal Sema includes from ExprCXX.cpp Fixing accidental includes introduced in 374903 Modified: cfe/trunk/lib/AST/ExprCXX.cpp

[PATCH] D68697: [DWARF5] Added support for DW_AT_noreturn attribute to be emitted for C++ class member functions.

SouraVX updated this revision to Diff 225052. SouraVX added a comment. Thanks Adrian for review! Addressing your review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68697/new/ https://reviews.llvm.org/D68697 Files: clang/lib/CodeGen/CGDebugInfo.cpp llvm/test/DebugInfo/X8

[PATCH] D68697: [DWARF5] Added support for DW_AT_noreturn attribute to be emitted for C++ class member functions.

SouraVX marked 2 inline comments as done. SouraVX added inline comments. Comment at: llvm/test/DebugInfo/X86/noreturn_cpp11.ll:59 -attributes #0 = { noreturn } +attributes #0 = { noinline noreturn optnone uwtable "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-ca

[PATCH] D68697: [DWARF5] Added support for DW_AT_noreturn attribute to be emitted for C++ class member functions.

SouraVX marked an inline comment as done. SouraVX added a comment. In D68697#1709680 , @SouraVX wrote: > Thanks Adrian for review! > Addressing your review comments. Could you please commit these changes for me, Thanks! CHANGES SINCE LAST ACTION htt

[PATCH] D68391: [RISCV] Improve sysroot computation if no GCC install detected

lenary added a comment. In D68391#1694622 , @edward-jones wrote: > Rebased and added tests > > I've made this use the Triple from the driver rather than the parsed LLVM > triple, this means the Triple doesn't get normalized which seems like more > desir

[PATCH] D68818: [hip][cuda] Fix the extended lambda name mangling issue.

tra added a comment. @rsmith Richard, could you take a look, please? Lambdas, mangling, ODR rules & ABI scare me. :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68818/new/ https://reviews.llvm.org/D68818 _

[PATCH] D68818: [hip][cuda] Fix the extended lambda name mangling issue.

hliao added a comment. In D68818#1709688 , @tra wrote: > @rsmith Richard, could you take a look, please? Lambdas, mangling, ODR rules > & ABI scare me. :-) @tra thanks for promoting the review. This patch is quite critical to support extended lambda in

[PATCH] D68554: [clang-format] Proposal for clang-format to give compiler style warnings

MyDeveloperDay added a comment. In D68554#1709316 , @sylvestre.ledru wrote: > @MyDeveloperDay I think it should be added to the release notes. it is a > great new changes for clang format (it would have made my life at Mozilla > much easier ;) I agree

[PATCH] D68969: [clang-format] Remove the dependency on frontend

MyDeveloperDay added a comment. In D68969#1709321 , @klimek wrote: > My intuitive solution would have been to get the char* for the start and > end-location and then search forward and backwards for \n. I may need to, it feels slow for large files which

[PATCH] D67985: CFI: wrong type passed to llvm.type.test with multiple inheritance devirtualization

This revision was automatically updated to reflect the committed changes. Closed by commit rG034badb312be: CFI: wrong type passed to llvm.type.test with multiple inheritance… (authored by dmikulin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67985

r374909 - CFI: wrong type passed to llvm.type.test with multiple inheritance devirtualization.

Author: dmikulin Date: Tue Oct 15 09:32:50 2019 New Revision: 374909 URL: http://llvm.org/viewvc/llvm-project?rev=374909&view=rev Log: CFI: wrong type passed to llvm.type.test with multiple inheritance devirtualization. Differential Revision: https://reviews.llvm.org/D67985 Added: cfe/trunk

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

probinson added a comment. In D68117#1709557 , @SouraVX wrote: > Hi David, > I did some digging about DW_AT_defaulted and stuff, not much of a success > but. Here's what I found -- http://dwarfstd.org/Issues.php?type=closed4 -- > here it;s still marke

[PATCH] D68997 [Modules] Allow searching for prebuilt implicit modules

Hello, This is a proposal to allow searching for "implicit modules" in the prebuilt module cache paths. https://reviews.llvm.org/D68997 The current command-line options for prebuilt modules do not allow to easily maintain and use multiple versions of modules. B

[PATCH] D68997: Allow searching for prebuilt implicit modules.

arames created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. arames edited the summary of this revision. arames added reviewers: bruno, rsmith. Herald added a subscriber: dexonsmith. The behavior is controlled by the `-fprebuilt-implicit-modules` option, and

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

khchen marked 2 inline comments as done. khchen added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:1521 + {"rv32i", "ilp32"},{"rv32im", "ilp32"}, {"rv32iac", "ilp32"}, + {"rv32imac", "ilp32"}, {"rv32imafc", "ilp32f"}, {"rv64i", "lp64"}, +

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

khchen updated this revision to Diff 225068. khchen edited the summary of this revision. khchen added a comment. @lenary Sorry, I don't have the plan to support `MULTILIB_REUSE` now. But if it's necessary to support it, I can do it later. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6

[PATCH] D69000: [clang-tidy] new check: modernize-deprecated-iterator-base

nick created this revision. nick added a reviewer: alexfh. nick added a project: clang-tools-extra. Herald added subscribers: cfe-commits, kristof.beyls, xazax.hun, mgorny. Herald added a project: clang. Finds deprecated in C++17 inheritance from `std::iterator` and replaces it with type aliases.

[PATCH] D55125: [clang-tidy] Fix a false positive in misc-redundant-expression check

aaron.ballman added a comment. In D55125#1704397 , @dkrupp wrote: > @aaron.ballman could you please commit? > I don't have commit access. Thx. I'm happy to do so, but the patch does not apply cleanly to trunk. Can you rebase? (Sorry for the delayed on

r374926 - Reland [Driver] Fix -working-directory issues

Author: jkorous Date: Tue Oct 15 10:51:59 2019 New Revision: 374926 URL: http://llvm.org/viewvc/llvm-project?rev=374926&view=rev Log: Reland [Driver] Fix -working-directory issues Don't change the default VFS in Driver, update tests & reland. This reverts commit 999f8a7416f8edc54ef92e715fd23c532

r374929 - Fix Driver/working-directory.c test

Author: jkorous Date: Tue Oct 15 11:04:18 2019 New Revision: 374929 URL: http://llvm.org/viewvc/llvm-project?rev=374929&view=rev Log: Fix Driver/working-directory.c test Accidentally committed debug print. Modified: cfe/trunk/test/Driver/working-directory.c Modified: cfe/trunk/test/Driver/w

r374932 - [clang] refactor -Wa,-W test cases.

Author: jcai19 Date: Tue Oct 15 11:17:08 2019 New Revision: 374932 URL: http://llvm.org/viewvc/llvm-project?rev=374932&view=rev Log: [clang] refactor -Wa,-W test cases. Remove REQUIRES and only keep the clang driver tests, since the assembler are already tested with -Wa,--no-warn. This way we cou

r374934 - Added support for "#pragma clang section relro="

Author: dmikulin Date: Tue Oct 15 11:31:10 2019 New Revision: 374934 URL: http://llvm.org/viewvc/llvm-project?rev=374934&view=rev Log: Added support for "#pragma clang section relro=" Differential Revision: https://reviews.llvm.org/D68806 Modified: cfe/trunk/docs/LanguageExtensions.rst c

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

apazos added a comment. > Is it worth trying to disallow tail call optimization completely if this flag > is enabled? I'm not sure what GCC does exactly. but this seems to be the > behaviour. I had reported above that I have already run that test: with "-fno-optimize-sibling-calls -msave-re

[PATCH] D68806: Relro is missing from the original "#pragma clang section" implementation.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf14642f2f185: Added support for "#pragma clang section relro=" (authored by dmikulin). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo C

r374936 - Fix as-w-option.c on Windows where no assembler exists

Author: rnk Date: Tue Oct 15 11:39:41 2019 New Revision: 374936 URL: http://llvm.org/viewvc/llvm-project?rev=374936&view=rev Log: Fix as-w-option.c on Windows where no assembler exists Modified: cfe/trunk/test/Driver/as-w-option.c Modified: cfe/trunk/test/Driver/as-w-option.c URL: http://ll

r374938 - [Concept] Associated Constraints Infrastructure

Author: saar.raz Date: Tue Oct 15 11:44:06 2019 New Revision: 374938 URL: http://llvm.org/viewvc/llvm-project?rev=374938&view=rev Log: [Concept] Associated Constraints Infrastructure Add code to correctly calculate the associated constraints of a template (no enforcement yet). D41284 on Phabrica

[PATCH] D66733: [analyzer] Add a checker option to detect nested dead stores

steakhal added a comment. Thank you guys the responses. I cannot agree more. The sole reason why this option exists is that if you scroll back in the git blame of that line, you would find a commit, which removed this warning for this exact scenario. Possibly due to some seemingly false positive

[PATCH] D68346: [clang-format] Add new option to add spaces around conditions

mitchell-stellar requested changes to this revision. mitchell-stellar added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Format/Format.h:1955 + /// \endcode + bool SpacesInConditionalStatement; + Nitpick: this

[PATCH] D69000: [clang-tidy] new check: modernize-deprecated-iterator-base

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/DeprecatedIteratorBaseCheck.cpp:93 +// TODO: Is there a way to get the location without lexer gymnastics? +auto Colon = findPreviousTokenKind(R.getBegin(), SM, LangOpts, tok::colon);

r374942 - [OPENMP]Allow final clause in combined task-based directives.

Author: abataev Date: Tue Oct 15 12:37:05 2019 New Revision: 374942 URL: http://llvm.org/viewvc/llvm-project?rev=374942&view=rev Log: [OPENMP]Allow final clause in combined task-based directives. The condition of the final clause must be captured in the combined task-based directives, like 'parall

r374943 - [OPENMP]Fix comments/params, NFC.

Author: abataev Date: Tue Oct 15 12:51:30 2019 New Revision: 374943 URL: http://llvm.org/viewvc/llvm-project?rev=374943&view=rev Log: [OPENMP]Fix comments/params, NFC. Modified: cfe/trunk/include/clang/AST/OpenMPClause.h Modified: cfe/trunk/include/clang/AST/OpenMPClause.h URL: http://llvm.

  1   2   >