owenpan added inline comments.
================ Comment at: clang/include/clang/Basic/SourceManager.h:232 + // nullptr + static const char *getInvalidBOM(StringRef BufStr); }; ---------------- klimek wrote: > owenpan wrote: > > Can you make the parameter `const`? > StringRef is inherently const though, right? I think the added const is > confusing. Oops! I meant `const StringRef &`: ``` static const char *getInvalidBOM(const StringRef &BufStr); ``` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68914/new/ https://reviews.llvm.org/D68914 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
