[PATCH] D68682: Clang-tidy fix removals removing all non-blank text from a line should remove the line

jonathanmeier added a comment. In D68682#1702025 , @poelmanc wrote: > In D68682#1700908 , @Eugene.Zelenko > wrote: > > > You may be interested to also look on PR43583 related to > > readability-redundant-member-in

[PATCH] D40221: [clang-format] Parse blocks in braced lists

klimek added inline comments. Comment at: lib/Format/UnwrappedLineParser.cpp:1324 + nextToken(); + if (!Style.isCpp()) { +// Blocks are only supported in C++ and Objective-C. benhamilton wrote: > Style: Remove curly braces for one-line if blocks. > Isn't t

[PATCH] D68767: [clang-format] NFC - Move functionality into functions to help code structure

owenpan added inline comments. Comment at: clang/tools/clang-format/ClangFormat.cpp:245 +// Returns an invalid BOM +static const char *hasInValidBOM(StringRef BufStr) { + // Check to see if the buffer has a UTF Byte Order Mark (BOM). owenpan wrote: > This code w

r374527 - Insert module constructors in a module pass

Author: vitalybuka Date: Fri Oct 11 01:47:03 2019 New Revision: 374527 URL: http://llvm.org/viewvc/llvm-project?rev=374527&view=rev Log: Insert module constructors in a module pass Summary: If we insert them from function pass some analysis may be missing or invalid. Fixes PR42877. Reviewers: eu

[PATCH] D68862: [ARM] Allocatable Global Register Variables for ARM

anwel created this revision. anwel added reviewers: carwil, amilendra_arm, phosek, michaelplatings, efriedma. anwel added projects: LLVM, clang. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. This patch combines two earlier patches aiming at providing the same suppo

[PATCH] D56003: [RFC] [CFE] Allocatable Global Register Variables for ARM

carwil abandoned this revision. carwil added a comment. Superseded by https://reviews.llvm.org/D68862. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56003/new/ https://reviews.llvm.org/D56003 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D61663: [clang-format] Fix a JavaScript import order bug.

MyDeveloperDay added a comment. Are you waiting for someone to land this? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61663/new/ https://reviews.llvm.org/D61663 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D68074: [clang-tidy] Add readability-make-member-function-const

gribozavr added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-make-member-function-const.rst:10 +The check conservatively tries to preserve logical costness in favor of +physical costness. The only operations on ``this`` that this check consid

[PATCH] D68554: [clang-format] Proposal for clang-format to give compiler style warnings

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg Comment at: clang/tools/clang-format/ClangFormat.cpp:293 +// Returns an invalid BOM +static const char *hasInValidBOM(StringRef BufStr) { I'd name this

[PATCH] D16066: [clang-format] Add BeforeWhileInDoWhile BraceWrapping option

MyDeveloperDay added a comment. This change need unit tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D16066/new/ https://reviews.llvm.org/D16066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[PATCH] D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154)

ilya-biryukov added a comment. In D67901#1704639 , @nridge wrote: > I like how we went from using heuristics, to not using heuristics, to using > heuristics again :) > > But admittedly, the new heuristics are more accurate because they're based on > phas

[PATCH] D68862: [ARM] Allocatable Global Register Variables for ARM

SjoerdMeijer added a comment. Bit of a drive-by comment, but I can't say I am big fan of all the string matching on the register names. Not sure if this is a fair comment, because I haven't looked closely at it yet, but could we use more the `ARM::R[0-9]` values more? Perhaps that's difficult f

[PATCH] D66049: [analyzer] PR41729: Fix some false positives and improve strlcat and strlcpy modeling

dkrupp added a comment. Thanks for the reviews! Could you pls commit this for me? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66049/new/ https://reviews.llvm.org/D66049 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

vladimir.plyashkun updated this revision to Diff 224557. vladimir.plyashkun added a comment. Provide additional option to preserve current inspection behaviour Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68694/new/ https://reviews.llvm.org/D68694

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

vladimir.plyashkun added a comment. @aaron.ballman @JonasToth Thanks, i agree too! I've prepared new revision with additional option to preserve old inspection behaviour. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68694/new/ https://reviews.llvm

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

lebedev.ri added inline comments. Comment at: clang-tools-extra/clang-tidy/hicpp/SignedBitwiseCheck.cpp:23-24 +: ClangTidyCheck(Name, Context), + IgnorePositiveIntegerLiterals( + Options.getLocalOrGlobal("IgnorePositiveIntegerLiterals", false)) {} +

[PATCH] D67550: [AArch64][SVE] Implement unpack intrinsics

kmclaughlin updated this revision to Diff 224558. kmclaughlin added a comment. Removed unused //SDPatternOperator op// from sve_int_perm_unpk class CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67550/new/ https://reviews.llvm.org/D67550 Files: include/llvm/IR/IntrinsicsAArch64.td l

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

JonasToth added a comment. The new switch needs documentation as well, and maybe even a note in the release notes (as it is publicly discussed as issue?). Otherwise I am fine with the changes! Comment at: clang-tools-extra/test/clang-tidy/hicpp-signed-bitwise-integer-literals

Re: r374133 - [c++20] Implement most of P1152R4.

Hi Richard, This breaks libcxx and libcxxabi my local stage two build bot (Fedora 31 x86_64). Is this expected? Can we revert this? FAIL: libc++ :: std/utilities/meta/meta.rel/is_invocable.pass.cpp (55505 of 58603) TEST 'libc++ :: std/utilities/meta/meta.rel/is_invocable.p

[PATCH] D67550: [AArch64][SVE] Implement unpack intrinsics

kmclaughlin marked 2 inline comments as done. kmclaughlin added inline comments. Comment at: lib/Target/AArch64/SVEInstrFormats.td:836 class sve_int_perm_unpk sz16_64, bits<2> opc, string asm, -ZPRRegOp zprty1, ZPRRegOp zprty2> +ZP

[PATCH] D68845: Don't emit unwanted constructor calls in co_return statements

aaronpuchert planned changes to this revision. aaronpuchert added a comment. In D51741#1702038 , @Quuxplusone wrote: > Both of these should first do overload resolution for one parameter of type > `MoveOnly&&`, and then, only if that overload resolution f

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

vladimir.plyashkun marked an inline comment as done. vladimir.plyashkun added inline comments. Comment at: clang-tools-extra/clang-tidy/hicpp/SignedBitwiseCheck.cpp:23-24 +: ClangTidyCheck(Name, Context), + IgnorePositiveIntegerLiterals( + Options.getLocalOrGlob

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

lebedev.ri added inline comments. Comment at: clang-tools-extra/clang-tidy/hicpp/SignedBitwiseCheck.cpp:23-24 +: ClangTidyCheck(Name, Context), + IgnorePositiveIntegerLiterals( + Options.getLocalOrGlobal("IgnorePositiveIntegerLiterals", false)) {} +

[PATCH] D68807: [ClangTidy] Separate tests for infrastructure and checkers

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. I agree that the test/clang-tidy directory has become hard to navigate. Splitting tests for checks and for infrastructure seems reasonable to me. I personally don't care about specific directo

r374539 - Dead Virtual Function Elimination

Author: ostannard Date: Fri Oct 11 04:59:55 2019 New Revision: 374539 URL: http://llvm.org/viewvc/llvm-project?rev=374539&view=rev Log: Dead Virtual Function Elimination Currently, it is hard for the compiler to remove unused C++ virtual functions, because they are all referenced from vtables, wh

[PATCH] D63932: [GlobalDCE] Dead Virtual Function Elimination

This revision was automatically updated to reflect the committed changes. Closed by commit rG9f6a873268e1: Dead Virtual Function Elimination (authored by ostannard). Changed prior to commit: https://reviews.llvm.org/D63932?vs=218363&id=224568#toc Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D68807: [ClangTidy] Separate tests for infrastructure and checkers

This revision was automatically updated to reflect the committed changes. Closed by commit rG885c559369fe: [ClangTidy] Separate tests for infrastructure and checkers (authored by gribozavr). Changed prior to commit: https://reviews.llvm.org/D68807?vs=224378&id=224569#toc Repository: rG LLVM

r374543 - [MS ABI]: Fix mangling function arguments for template types to be compatible with MSVC

Author: nico Date: Fri Oct 11 05:27:51 2019 New Revision: 374543 URL: http://llvm.org/viewvc/llvm-project?rev=374543&view=rev Log: [MS ABI]: Fix mangling function arguments for template types to be compatible with MSVC MS name mangling supports cache for first 10 distinct function arguments. Th

[PATCH] D68099: [MS ABI]: Fix mangling function arguments for template types to be compatible with MSVC

This revision was automatically updated to reflect the committed changes. Closed by commit rGb95713784a3c: [MS ABI]: Fix mangling function arguments for template types to be compatible… (authored by thakis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D14927: clang-format: Add SpaceBeforeTemplateParameterList option

MyDeveloperDay added a comment. This revision would require unit tests to proceed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14927/new/ https://reviews.llvm.org/D14927 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D68862: [ARM] Allocatable Global Register Variables for ARM

chill added a comment. TBH, I quite dislike the creeping abuse of `SubtargetFeature`s as code generation options. cf. Target.td:1477 //===--===// // SubtargetFeature - A characteristic of the chip set. // IMHO, since r

[PATCH] D68862: [ARM] Allocatable Global Register Variables for ARM

chill added inline comments. Comment at: clang/lib/Basic/Targets/ARM.cpp:902 + std::vector &Features = getTargetOpts().Features; + std::string SearchFeature = "+reserve-" + RegName.str(); + for (std::string &Feature : Features) { SjoerdMeijer wrote: > I was po

[PATCH] D56345: [clang-format] Assert that filenames are not empty

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Thanks for the patch, I'm sorry it's taken so long sometimes items get lost...This looks to still be relevant, I think you'll need to rebase but it LGTM $ clang-format --ass

[PATCH] D68824: Fix __builtin_assume_aligned with too large values.

erichkeane marked 5 inline comments as done. erichkeane added subscribers: majnemer, aaron.ballman. erichkeane added a comment. In D68824#1704942 , @rsmith wrote: > This seems to be missing a CodeGen test for what IR we generate on an > overly-large align

[clang-tools-extra] r374549 - [ClangTidy] Separate tests for infrastructure and checkers, fixup

Author: gribozavr Date: Fri Oct 11 06:16:49 2019 New Revision: 374549 URL: http://llvm.org/viewvc/llvm-project?rev=374549&view=rev Log: [ClangTidy] Separate tests for infrastructure and checkers, fixup Renamed a file that I missed in r374540. Added: clang-tools-extra/trunk/test/clang-tidy/ch

[PATCH] D68818: [hip][cuda] Fix the extended lambda name mangling issue.

hliao added a comment. PING for review, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68818/new/ https://reviews.llvm.org/D68818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D68862: [ARM] Allocatable Global Register Variables for ARM

SjoerdMeijer added inline comments. Comment at: clang/lib/Basic/Targets/ARM.cpp:902 + std::vector &Features = getTargetOpts().Features; + std::string SearchFeature = "+reserve-" + RegName.str(); + for (std::string &Feature : Features) { chill wrote: > SjoerdMe

[PATCH] D67160: [clang, ARM] Default to -fno-lax-vector-conversions in ARM v8.1-M.

simon_tatham added a comment. Hmmm. I take your point, and so I backed out my local version of this patch in order to try to solve the problem a different way in overload resolution. But in fact overloading on different vector types already seems to work fine: my in-progress patch series still

[PATCH] D67216: [cfi] Add flag to always generate .debug_frame

dcandler updated this revision to Diff 224581. dcandler retitled this revision from "[cfi] Add flag to always generate call frame information" to "[cfi] Add flag to always generate .debug_frame". dcandler edited the summary of this revision. dcandler added reviewers: rengolin, joerg. dcandler adde

[PATCH] D27377: clang-format: Support the Java 8 'default' method modifier

MyDeveloperDay added a comment. While reviewing old revisions either not landed or unreviewed I stumbled across this accepted review. Looking at the current code I think its not needed anymore. Perhaps if we merge your test in with the current trunk we can determine if this is still needed C

[PATCH] D68682: Clang-tidy fix removals removing all non-blank text from a line should remove the line

gribozavr added a comment. > I guess here's the high-level question: should all removals that remove all > non-blank text from a line also delete the line? I see your point, but as https://llvm.org/PR43583 shows, we have a much larger problem: textual replacements don't compose. So, whatever we

[PATCH] D68682: Clang-tidy fix removals removing all non-blank text from a line should remove the line

Eugene.Zelenko added a comment. In D68682#1705505 , @jonathanmeier wrote: > In D68682#1702025 , @poelmanc wrote: > > > In D68682#1700908 , > > @Eugene.Zelenko wrote: > > >

[clang-tools-extra] r374551 - Updated add_new_check.py to create checker tests in the new directory

Author: gribozavr Date: Fri Oct 11 06:46:55 2019 New Revision: 374551 URL: http://llvm.org/viewvc/llvm-project?rev=374551&view=rev Log: Updated add_new_check.py to create checker tests in the new directory Modified: clang-tools-extra/trunk/clang-tidy/add_new_check.py Modified: clang-tools-ex

r374552 - [libTooling] Change Stencil equality to use `toString()`

Author: ymandel Date: Fri Oct 11 07:02:03 2019 New Revision: 374552 URL: http://llvm.org/viewvc/llvm-project?rev=374552&view=rev Log: [libTooling] Change Stencil equality to use `toString()` Summary: Removes the `isEqual` method from StencilPartInterface and modifies equality to use the string re

[PATCH] D68825: [libTooling] Change Stencil equality to use `toString()`

This revision was automatically updated to reflect the committed changes. Closed by commit rGcf2438ec1309: [libTooling] Change Stencil equality to use `toString()` (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68825/new/ https

[PATCH] D68795: [libTooling] Move `RewriteRule` abstraction into its own header and impl.

ymandel added a comment. updated title & description to match the changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68795/new/ https://reviews.llvm.org/D68795 ___ cfe-commits mailing list cfe-comm

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

Tyker updated this revision to Diff 224588. Tyker added a comment. improve performance in a bad case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63960/new/ https://reviews.llvm.org/D63960 Files: clang/include/clang/AST/DeclCXX.h clang/include/clang/AST/Expr.h clang/include/clan

[PATCH] D68162: [analyzer][MallocChecker][NFC] Communicate the allocation family to auxiliary functions with parameters

Szelethus added a comment. I forgot to emphasise that the entire point of the patch was to get rid of `getAllocationFamily`, at least the way it used to work, because it was a mess and prevented me from moving forward with changing things to a `CallDescriptionMap`. In D68162#1693110

[PATCH] D67706: [clang][analyzer] Using CallDescription in StreamChecker.

balazske added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67706/new/ https://reviews.llvm.org/D67706 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

r374558 - [libTooling] Move `RewriteRule` abstraction into its own header and impl.

Author: ymandel Date: Fri Oct 11 07:43:46 2019 New Revision: 374558 URL: http://llvm.org/viewvc/llvm-project?rev=374558&view=rev Log: [libTooling] Move `RewriteRule` abstraction into its own header and impl. Summary: Move the `RewriteRule` class and related declarations into its own set of files

[PATCH] D68795: [libTooling] Move `RewriteRule` abstraction into its own header and impl.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe38c36b7b0ab: [libTooling] Move `RewriteRule` abstraction into its own header and impl. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

r374562 - Reland r374450 with Richard Smith's comments and test fixed.

Author: erichkeane Date: Fri Oct 11 07:59:44 2019 New Revision: 374562 URL: http://llvm.org/viewvc/llvm-project?rev=374562&view=rev Log: Reland r374450 with Richard Smith's comments and test fixed. The behavior from the original patch has changed, since we're no longer allowing LLVM to just ignor

[PATCH] D67706: [clang][analyzer] Using CallDescription in StreamChecker.

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:288-290 + SymbolRef Sym = RetVal.getAsSymbol(); + stateNotNull = stateNotNull->set(Sym, StreamState::getOpened()); + stateNull = stateNull->set(Sym, StreamState::getOpenFailed());

[PATCH] D67551: [AArch64][SVE] Implement sdot and udot (lane) intrinsics

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67551/new/ https://reviews.llvm.org/D67551 ___ cfe-commits mailing list cfe-com

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

vladimir.plyashkun marked 2 inline comments as done. vladimir.plyashkun added inline comments. Comment at: clang-tools-extra/clang-tidy/hicpp/SignedBitwiseCheck.cpp:23-24 +: ClangTidyCheck(Name, Context), + IgnorePositiveIntegerLiterals( + Options.getLocalOrGlob

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

vladimir.plyashkun updated this revision to Diff 224597. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68694/new/ https://reviews.llvm.org/D68694 Files: clang-tools-extra/clang-tidy/hicpp/SignedBitwiseCheck.cpp clang-tools-extra/clang-tidy/hicpp/

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

vladimir.plyashkun added a comment. In D68694#1705668 , @JonasToth wrote: > The new switch needs documentation as well, and maybe even a note in the > release notes (as it is publicly discussed as issue?). Do you know who is responsible for it? Because

[PATCH] D67156: [Analyzer] Debug Checkers for Container and Iterator Inspection

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. This is amazing, thanks!! LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67156/new/ https://reviews.llvm.org/D67156 ___ cfe-c

[PATCH] D68746: [Clang][OpenMP Offload] Move offload registration code to the wrapper

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:74 + IntegerType *getSizeTTy() { +switch (M.getDataLayout().getPointerTypeSize(Type::getInt8PtrTy(C))) { +case 4u: -

[PATCH] D67706: [clang][analyzer] Using CallDescription in StreamChecker.

balazske marked 3 inline comments as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:288-290 + SymbolRef Sym = RetVal.getAsSymbol(); + stateNotNull = stateNotNull->set(Sym, StreamState::getOpened()); + stateNull = stateNull

[PATCH] D67551: [AArch64][SVE] Implement sdot and udot (lane) intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rGee0a0a34646f: [AArch64][SVE] Implement sdot and udot (lane) intrinsics (authored by kmclaughlin). Herald added a subscriber: hiraditya. Herald added a project: LLVM. Changed prior to commit: https://rev

[PATCH] D68746: [Clang][OpenMP Offload] Move offload registration code to the wrapper

ABataev added inline comments. Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:74 + IntegerType *getSizeTTy() { +switch (M.getDataLayout().getPointerTypeSize(Type::getInt8PtrTy(C))) { +case 4u: sdmitriev wrote: > grokos wrote: > > s

r374569 - Fix test failure with 374562 on Hexagon

Author: erichkeane Date: Fri Oct 11 09:30:45 2019 New Revision: 374569 URL: http://llvm.org/viewvc/llvm-project?rev=374569&view=rev Log: Fix test failure with 374562 on Hexagon __builtin_assume_aligned takes a size_t which is a 32 bit int on hexagon. Thus, the constant gets converted to a 32 bit

[PATCH] D68876: [libTooling] Group all Transformer combinators in a single namespace.

ymandel created this revision. ymandel added a reviewer: gribozavr. Herald added a project: clang. This revision introduces a new namespace, `clang::tooling::transformer`, to hold the combinators that together compose the embedded "DSL" provided by Transformer. It moves all Transformer-related co

[PATCH] D68876: [libTooling] Group all Transformer combinators in a single namespace.

gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land. WDYT about `clang::transformer`? I don't see much point in the intermediate namespace. However, LGTM either way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

r374571 - Update clang module map for new excluded .def file.

Author: rsmith Date: Fri Oct 11 10:00:34 2019 New Revision: 374571 URL: http://llvm.org/viewvc/llvm-project?rev=374571&view=rev Log: Update clang module map for new excluded .def file. Modified: cfe/trunk/include/clang/module.modulemap Modified: cfe/trunk/include/clang/module.modulemap URL:

Re: r374449 - Add -fgnuc-version= to control __GNUC__ and other GCC macros

It's cool we finally have a flag for this, but overloading its meaning with the =0 behavior seems a bit strange to me. Maybe we should have a separate -fno-gnu-extensions for that part instead? On Thu, Oct 10, 2019 at 5:02 PM Reid Kleckner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Au

[PATCH] D68746: [Clang][OpenMP Offload] Move offload registration code to the wrapper

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68746/new/ https://reviews.llvm.org/D68746 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D68877: [AArch64][SVE] Implement masked load intrinsics

kmclaughlin created this revision. kmclaughlin added reviewers: huntergr, rovka, greened. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a project: LLVM. kmclaughlin added a parent revision: D47775: [AArch64][SVE] Add SPLAT_VECTOR ISD Node. Adds suppor

[PATCH] D68876: [libTooling] Group all Transformer combinators in a single namespace.

ymandel added a comment. In D68876#1706131 , @gribozavr wrote: > WDYT about `clang::transformer`? I don't see much point in the intermediate > namespace. However, LGTM either way. Thanks for the review. I prefer `clang::transformer` but wasn't sure abou

r374573 - [clang][IFS] Fixing assert in clang interface stubs for enums, records, typedefs

Author: zer0 Date: Fri Oct 11 10:24:11 2019 New Revision: 374573 URL: http://llvm.org/viewvc/llvm-project?rev=374573&view=rev Log: [clang][IFS] Fixing assert in clang interface stubs for enums, records, typedefs The clang IFS ASTConsumer was asserting on enums, records (struct definitions in C),

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille updated this revision to Diff 224606. serge-sans-paille added a comment. Ensure the distance between two probes is at max PAGE_SIZE. Use Calls as free probes. Fix alignment for dynamic alloca This passes the llvm-test suite, and thanks to the use of calls, no inserted probe are

[PATCH] D68845: Don't emit unwanted constructor calls in co_return statements

Quuxplusone added a subscriber: lewissbaker. Quuxplusone added a comment. One more test to add: struct Widget { task foo() && { co_return *this; // IIUC this should call return_value(Widget&), not return_value(Widget&&) } }; Comment at: clang/lib/Se

[PATCH] D68859: Fixing crash in clang IFS for enum, record, and typedef decls.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe3388c42f39b: [clang][IFS] Fixing assert in clang interface stubs for enums, records, typedefs (authored by plotfi). Changed prior to commit: https://reviews.llvm.org/D68859?vs=224547&id=224629#toc Rep

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

JonasToth added a comment. > Do you know who is responsible for it? Because i haven't worked with > documentation before and don't know what i need to do to update it. The files reside in `clang-tools-extra/docs/ReleaseNotes.rst` and `clang-tools-extra/docs/clang-tidy/checks/hicpp-signed-bitwis

[PATCH] D47111: : Implement monotonic_buffer_resource.

strager added inline comments. Comment at: include/experimental/memory_resource:427 +static _LIBCPP_CONSTEXPR const size_t __default_buffer_capacity = 1024; +static _LIBCPP_CONSTEXPR const size_t __default_buffer_alignment = 16; + Nit: Why isn't `__defaul

[PATCH] D47111: : Implement monotonic_buffer_resource.

strager added inline comments. Comment at: include/experimental/memory_resource:433 +char *__cur_; +size_t __align_; +size_t __allocation_size() { > Eric suggests replacing size_t __align_ with uint8_t __log2_align_. I'm > amenable to thi

r374580 - Suppress false-positive -Wdeprecated-volatile warning from __is_*_assignable(volatile T&, U).

Author: rsmith Date: Fri Oct 11 10:59:09 2019 New Revision: 374580 URL: http://llvm.org/viewvc/llvm-project?rev=374580&view=rev Log: Suppress false-positive -Wdeprecated-volatile warning from __is_*_assignable(volatile T&, U). Modified: cfe/trunk/lib/Sema/SemaExprCXX.cpp cfe/trunk/test/S

[PATCH] D68876: [libTooling] Group all Transformer combinators in a single namespace.

ymandel added a comment. I'm now starting to doubt the split into transformer (for combinators) and tooling (for the type decls). I checked and `ast_matchers` contains both. What do you think of my just putting all of the Transformer types + combis in the single `clang::transformer` namespace

r374581 - [Stats] Convert some ad-hoc header search stats to ALWAYS_ENABLED_STATISTIC.

Author: vsapsai Date: Fri Oct 11 11:22:34 2019 New Revision: 374581 URL: http://llvm.org/viewvc/llvm-project?rev=374581&view=rev Log: [Stats] Convert some ad-hoc header search stats to ALWAYS_ENABLED_STATISTIC. rdar://problem/55715134 Reviewers: dsanders, bogner, rtereshin Reviewed By: dsanders

[PATCH] D68876: [libTooling] Group all Transformer combinators in a single namespace.

gribozavr added a comment. > What do you think of my just putting all of the Transformer types + combis in > the single clang::transformer namespace? That would make sense to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68876/new/ https://re

[PATCH] D68876: [libTooling] Put all Transformer declarations in a single namespace.

ymandel updated this revision to Diff 224650. ymandel added a comment. moved all decls to clang::transformer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68876/new/ https://reviews.llvm.org/D68876 Files: clang/include/clang/Tooling/Transformer

Attention bot owners

Hello all bots owners, As all of you know we move to github monorepo very soon now. We are actively working on the buildbot to prepare a solution to switch from SVN to github when time comes. It would require some activity on your bots. At this point it is clear that you would need to * Make su

[PATCH] D68876: [libTooling] Put all Transformer declarations in a single namespace.

ymandel updated this revision to Diff 224651. ymandel edited the summary of this revision. ymandel added a comment. fix using decl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68876/new/ https://reviews.llvm.org/D68876 Files: clang/include/cla

[PATCH] D68876: [libTooling] Put all Transformer declarations in a single namespace.

ymandel updated this revision to Diff 224653. ymandel added a comment. remove stray newline and include. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68876/new/ https://reviews.llvm.org/D68876 Files: clang/include/clang/Tooling/Transformer/Matc

[PATCH] D68882: [test] Fix test failure

ctetreau created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The version mismatch symbol is version 9 on 32 bit android. Since this test isn't actually testing any android specific functionality, we force the target triple to x86_64-unknown-unknown in orde

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

JamesNagurne added a comment. Our team maintains a downstream embedded ARM clang distribution and some tests from this commit have begun to fail for us. For a number of these tests, there was a REQUIRES: x86-registered-target at the top, which has now been removed. Specifically, externstatic.c,

[PATCH] D68884: Add support to -Wa,-W in clang

jcai19 created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. jcai19 added a reviewer: bcain. jcai19 added subscribers: nickdesaulniers, manojgupta, llozano. jcai19 updated this revision to Diff 224663. jcai19 added a comment. Fix typos. Currently clang doe

[PATCH] D68884: Add support to -Wa,-W in clang

jcai19 updated this revision to Diff 224663. jcai19 added a comment. Fix typos. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68884/new/ https://reviews.llvm.org/D68884 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/as-w-option

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi marked an inline comment as done. plotfi added a comment. In D63978#1706420 , @JamesNagurne wrote: > Our team maintains a downstream embedded ARM clang distribution and some > tests from this commit have begun to fail for us. > For a number of th

[PATCH] D68884: Add support to -Wa,-W in clang

jcai19 updated this revision to Diff 224664. jcai19 added a comment. Update test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68884/new/ https://reviews.llvm.org/D68884 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/as-

[PATCH] D68885: Add a Ranges field to Diagnostic struct

compositeprimes created this revision. compositeprimes added reviewers: clang, clang-tools-extra. compositeprimes added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. Part 1 of the change: The goal is instead of dropping all the ranges associated with a Diagnostic whe

[PATCH] D68887: Copy the Ranges field from the Diagnostic when creating the ClangTidyError

compositeprimes created this revision. compositeprimes added a reviewer: clang-tools-extra. compositeprimes added a project: clang-tools-extra. Herald added subscribers: cfe-commits, mgehre. Herald added a project: clang. Part 2 of the change: The goal is instead of dropping all the ranges associa

r374593 - Release notes: Add the option WarnForDeadNestedAssignments

Author: sylvestre Date: Fri Oct 11 13:33:43 2019 New Revision: 374593 URL: http://llvm.org/viewvc/llvm-project?rev=374593&view=rev Log: Release notes: Add the option WarnForDeadNestedAssignments https://reviews.llvm.org/D66733 Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/doc

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

JamesNagurne added a comment. In D63978#1706448 , @plotfi wrote: > In D63978#1706420 , @JamesNagurne > wrote: > > > Our team maintains a downstream embedded ARM clang distribution and some > > tests from this comm

[PATCH] D66733: [analyzer] Add a checker option to detect nested dead stores

sylvestre.ledru added a comment. I added it to the release notes here : https://reviews.llvm.org/rC374593 I am wondering if the option( WarnForDeadNestedAssignments ) to disable it is really necessary? I haven't seen any false positive while deadstore has some. Repository: rL LLVM CHANGES SI

[PATCH] D68849: [Parse] Don't speculatively parse an identifier in the wrong context.

rsmith added a comment. It looks like it's not actually all that complex to defer building the expression until we're ready to consume the annotation. I've got a mostly-complete patch for that, and I'd like to try finishing that before we add workarounds. Repository: rC Clang CHANGES SINCE

[PATCH] D67985: CFI: wrong type passed to llvm.type.test with multiple inheritance devirtualization

dmikulin added a comment. @pcc : poke CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67985/new/ https://reviews.llvm.org/D67985 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[PATCH] D67985: CFI: wrong type passed to llvm.type.test with multiple inheritance devirtualization

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67985/new/ https://reviews.llvm.org/D67985 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D68682: Clang-tidy fix removals removing all non-blank text from a line should remove the line

poelmanc added a comment. In D68682#1705865 , @Eugene.Zelenko wrote: > In D68682#1705505 , @jonathanmeier > wrote: > > > In D68682#1702025 , @poelmanc > > wrote: > > > > >

  1   2   >