vladimir.plyashkun marked an inline comment as done. vladimir.plyashkun added inline comments.
================ Comment at: clang-tools-extra/clang-tidy/hicpp/SignedBitwiseCheck.cpp:23-24 + : ClangTidyCheck(Name, Context), + IgnorePositiveIntegerLiterals( + Options.getLocalOrGlobal("IgnorePositiveIntegerLiterals", false)) {} + ---------------- lebedev.ri wrote: > i'm not sure this should look for a global option with such name? I think that this method is common and used in so many inspections. For example this [[ https://clang.llvm.org/extra/clang-tidy/checks/readability-inconsistent-declaration-parameter-name.html | check ]] also have option called `IgnoreMacros` which is retrieved in same way (by calling getLocalOrGlobal method) Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68694/new/ https://reviews.llvm.org/D68694 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits