[PATCH] D68193: In openFileForRead don't cache erroneous entries if the error relates to them being directories. Add tests.

dexonsmith added a comment. Sorry for bouncing you around, but I just had a look at the other user of `createFileEntry` and I think the right thing to do is to somehow share the code between `DependencyScanningWorkerFilesystem::status` and this. I suggest splitting a function out of `status` (

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

rsmith added a comment. Very cool, this is an elegant approach. Comment at: clang/include/clang/Basic/DiagnosticASTKinds.td:57 +def note_consteval_address_accessible : Note< + "%select{pointer|reference}0 on a consteval declaration " + "is not a constant expression">; ---

r373272 - Fix crash on value-dependent delete-expressions.

Author: rsmith Date: Mon Sep 30 15:55:27 2019 New Revision: 373272 URL: http://llvm.org/viewvc/llvm-project?rev=373272&view=rev Log: Fix crash on value-dependent delete-expressions. We used to miscompute the 'value-dependent' bit, and would crash if we tried to evaluate a delete expression that s

[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

thakis added a comment. /Brepro seems orthogonal to me. If you only pass relative paths and -no-canonical-prefixes then the embedded path is relative and doesn't impeded determinism. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65543/new/ https:

[PATCH] D68251: [clang-tidy] Fix module registry name and description for Darwin clang-tidy module.

mwyman created this revision. mwyman added reviewers: stephanemoore, benhamilton, gribozavr. mwyman added projects: clang, clang-tools-extra, LLVM. Herald added subscribers: cfe-commits, xazax.hun. When creating the module, must have copy-pasted from the misc module, and forgotten to update the n

[PATCH] D68252: [Stats] Add ALWAYS_ENABLED_STATISTIC enabled regardless of LLVM_ENABLE_STATS.

vsapsai created this revision. vsapsai added reviewers: dsanders, bogner, rtereshin. Herald added subscribers: ributzka, dexonsmith, jkorous, hiraditya. Herald added a project: LLVM. The intended usage is to measure relatively expensive operations. So the cost of the statistic is negligible compar

[PATCH] D68252: [Stats] Add ALWAYS_ENABLED_STATISTIC enabled regardless of LLVM_ENABLE_STATS.

vsapsai added a comment. On release build with assertions disabled and LLVM_ENABLE_STATS being 0 the impact on the compile time is the following Metric: compile_time Programoutput0jM4H6 output_KEgWj diff test-suite...tTests/2003-05-07-VarArgs.

[PATCH] D64991: [analyzer][WIP] Implement a primitive reaching definitions analysis

Szelethus updated this revision to Diff 222514. Szelethus added a comment. I'm starting to be really happy with the current direction! I think I'll start splitting this up soon, I'm confident that the current interface (after some polishing) is general enough to develop incrementally. - Introdu

r373275 - Fix Driver/modules.cpp test to work when build directory name contains '.s'

Author: tstellar Date: Mon Sep 30 16:42:17 2019 New Revision: 373275 URL: http://llvm.org/viewvc/llvm-project?rev=373275&view=rev Log: Fix Driver/modules.cpp test to work when build directory name contains '.s' Reviewers: dyung, rsmith, hansw Subscribers: mati865, mgorny, cfe-commits Tags: #cla

[PATCH] D66176: Fix Driver/modules.cpp test to work when build directory name contains '.s'

This revision was automatically updated to reflect the committed changes. Closed by commit rL373275: Fix Driver/modules.cpp test to work when build directory name contains '.s' (authored by tstellar, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pr

r373276 - [c++20] Fix crash when constant-evaluating an assignment with a

Author: rsmith Date: Mon Sep 30 17:07:14 2019 New Revision: 373276 URL: http://llvm.org/viewvc/llvm-project?rev=373276&view=rev Log: [c++20] Fix crash when constant-evaluating an assignment with a reference member access on its left-hand side. Modified: cfe/trunk/lib/AST/ExprConstant.cpp

[PATCH] D65917: [clang-tidy] Added check for the Google style guide's category method naming rule.

stephanemoore added a comment. (sorry for the delay 😅) > The difference is that the exemption list would be per-project, created by > whoever turns on the check for the project. I was assuming that this checker > would be turned on by each team, rather than globally, and that part of doing > s

[PATCH] D38479: Make -mgeneral-regs-only more like GCC's

george.burgess.iv updated this revision to Diff 222525. george.burgess.iv marked 6 inline comments as done. george.burgess.iv added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Addressed feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D38479: Make -mgeneral-regs-only more like GCC's

george.burgess.iv added a comment. > Does this have any significant impact on -fsyntax-only performance? I'm sure there are pathological cases where this hurts perf, but my intuition tells me that we won't get bitten badly by any of them in the real world. It should be a branch per cast + full

r373279 - During constant evaluation, handle CXXBindTemporaryExprs for

Author: rsmith Date: Mon Sep 30 17:41:16 2019 New Revision: 373279 URL: http://llvm.org/viewvc/llvm-project?rev=373279&view=rev Log: During constant evaluation, handle CXXBindTemporaryExprs for array-of-class types, not just for class types. Modified: cfe/trunk/lib/AST/ExprConstant.cpp cf

r373281 - [c++20] Add a C++20 version of the existing turing machine test.

Author: rsmith Date: Mon Sep 30 17:47:41 2019 New Revision: 373281 URL: http://llvm.org/viewvc/llvm-project?rev=373281&view=rev Log: [c++20] Add a C++20 version of the existing turing machine test. Unlike the C++11 version, this one uese mutable state and dynamic allocation instead of a carefully

[PATCH] D67739: [WebAssembly] Let users know that wasm64 does not exist

tlively abandoned this revision. tlively added a comment. Closing in favor of D68254 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67739/new/ https://reviews.llvm.org/D67739

r373289 - Don't elide the use of the thread wrapper for a thread_local constinit

Author: rsmith Date: Mon Sep 30 18:23:23 2019 New Revision: 373289 URL: http://llvm.org/viewvc/llvm-project?rev=373289&view=rev Log: Don't elide the use of the thread wrapper for a thread_local constinit variable with non-trivial destruction. We still need to invoke the thread wrapper to trigger

<    1   2