dexonsmith added a comment. Sorry for bouncing you around, but I just had a look at the other user of `createFileEntry` and I think the right thing to do is to somehow share the code between `DependencyScanningWorkerFilesystem::status` and this. I suggest splitting a function out of `status` (called `getOrCreateFileSystemEntry`?) that returns a `CachedFileSystemEntry` (or an error).
The fix I just asked you to make (to only call `stat` once) could be done on `getOrCreateFileSystemEntry` as a follow-up, using `std::unique_ptr<llvm::vfs::File>` and changing `getFileEntry` to take that instead of a filename. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68193/new/ https://reviews.llvm.org/D68193 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
