[clang-tools-extra] r370004 - Fix clangd's IndexAction for FileSkipped API update

Author: arphaman Date: Mon Aug 26 18:36:00 2019 New Revision: 370004 URL: http://llvm.org/viewvc/llvm-project?rev=370004&view=rev Log: Fix clangd's IndexAction for FileSkipped API update Modified: clang-tools-extra/trunk/clangd/index/IndexAction.cpp Modified: clang-tools-extra/trunk/clangd/i

[PATCH] D66765: [analyzer] (Urgent!) Add 9.0.0. release notes.

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. I approve the patch and i don't see anything obvious that we're missing out (@Szelethus, your GSoC isn't on by default back in 9.0, only in master, right?). I guess we should really try harder to fi

[PATCH] D66328: [DebugInfo] Add debug location to dynamic atexit destructor

aganea updated this revision to Diff 217298. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66328/new/ https://reviews.llvm.org/D66328 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDeclCXX.cpp test/CodeGenCXX/debug-info-atexit-stub.cpp test/CodeGenCXX/debug-info-destroy-helper.

[PATCH] D66328: [DebugInfo] Add debug location to dynamic atexit destructor

aganea reopened this revision. aganea added a reviewer: hans. aganea added a comment. This revision is now accepted and ready to land. Re-opening this because the previous commit broke Chromium. - Added a new test `debug-info-dest

[PATCH] D62739: AMDGPU: Always emit amdgpu-flat-work-group-size

arsenm updated this revision to Diff 217301. arsenm added a comment. Make lower bound 1, although this is a behavior change CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62739/new/ https://reviews.llvm.org/D62739 Files: lib/CodeGen/TargetInfo.cpp test/CodeGenOpenCL/amdgpu-attrs.cl

[PATCH] D64811: Warn when NumParams overflows

rjmccall added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:6233 + + } else if (RequiresArg) Diag(Tok, diag::err_argument_required_after_attribute); The re-indentation here is wrong. Comment at: clang/lib/Sema/SemaDeclCXX.

[PATCH] D65744: [PR42707][OpenCL] Fix addr space deduction for auto

rjmccall added a comment. In D65744#1629055 , @Anastasia wrote: > In D65744#1627589 , @rjmccall wrote: > > > I see. Is the deduction rule recursive or something, where a pointer to > > pointer is inferred to point

[PATCH] D59922: [Attributor] Deduce "no-capture" argument attribute

jdoerfert updated this revision to Diff 217306. jdoerfert added a comment. rebase and update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59922/new/ https://reviews.llvm.org/D59922 Files: llvm/include/llvm/Transforms/IPO/Attributor.h ll

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

rjmccall added inline comments. Comment at: clang/docs/UsersManual.rst:1299 +.. option:: -fp-model=[values] + This should be something like `-fp-model=`. Square brackets mean optional elements in these docs. Comment at: clang/docs/UsersManu

[PATCH] D66360: Expose constructing a virtual method dispatch through the include/clang/CodeGen APIs.

rjmccall added inline comments. Comment at: include/clang/CodeGen/SwiftCallingConv.h:190 +llvm::FunctionType *type, +llvm::IRBuilderBase *builder); + This isn't the ri

[PATCH] D66782: SourceManager: Prefer Optional over MemoryBuffer*

dexonsmith created this revision. dexonsmith added reviewers: arphaman, Bigcheese, rsmith. Herald added subscribers: llvm-commits, ributzka, kadircet, jkorous, hiraditya. Herald added a reviewer: martong. Herald added a reviewer: shafik. Herald added a project: LLVM. Change the APIs in SourceManag

[PATCH] D66783: [clang-doc] Use llvm::createStringError and canonicalize error messages

MaskRay created this revision. MaskRay added reviewers: DiegoAstiazaran, juliehockett, jakehehrlich. Herald added a project: clang. Herald added a subscriber: cfe-commits. MaskRay updated this revision to Diff 217310. MaskRay added a comment. Herald added subscribers: kadircet, arphaman. Fix a few

[PATCH] D66783: [clang-doc] Use llvm::createStringError and canonicalize error messages

MaskRay updated this revision to Diff 217310. MaskRay added a comment. Herald added subscribers: kadircet, arphaman. Fix a few other places Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66783/new/ https://reviews.llvm.org/D66783 Files: clang-doc/

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

nickdesaulniers added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3451 +const std::vector &warnings = + Res.getDiagnosticOpts().Warnings; The indentation here looks funny. Can you please run `git-clang-format` and commit the cha

Re: r369830 - NFC: Rename some sanitizer related lifetime checks

Hi Vitaly, Thanks for fixing this! And I’m sorry about accidentally disabling the test entirely by adding “REQUIRES: assertions” instead of “REQUIRES: asserts”. Dave > On Aug 27, 2019, at 1:10 AM, Vitaly Buka wrote: > > fixed with r369992 > > On Mon, Aug 26, 2019 at 1:16 PM Vitaly Buka

[clang-tools-extra] r370022 - Revert "[clangd] Release notes" (wrong branch)

Author: sammccall Date: Mon Aug 26 23:58:05 2019 New Revision: 370022 URL: http://llvm.org/viewvc/llvm-project?rev=370022&view=rev Log: Revert "[clangd] Release notes" (wrong branch) This reverts commit 51029e5c153bd33efa015e2ec35b60247d046ce4. Modified: clang-tools-extra/trunk/docs/ReleaseN

[PATCH] D66662: [clang-format] [PR43100] clang-format C# support does not add a space between "using" and paren

owenpan added a comment. The patch would have no effect if the `using` statement is not in a block, but that would probably be against C# syntax. Please see my comments about the test cases. Otherwise, LGTM. Comment at: clang/unittests/Format/FormatTestCSharp.cpp:168 +TEST_

<    1   2   3