NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land.
I approve the patch and i don't see anything obvious that we're missing out (@Szelethus, your GSoC isn't on by default back in 9.0, only in master, right?). I guess we should really try harder to fill it in with every patch that deserves it. ================ Comment at: clang/docs/ReleaseNotes.rst:235 + +- New checker: 'optin.osx.OSObjectCStyleCast' to find C-style casts of OSObjects + ---------------- "of XNU libkern OSObjects", so that it sounded less esoteric :/ ================ Comment at: clang/docs/ReleaseNotes.rst:237-238 + +- New package: 'apiModeling.llvm' contains modeling checkers to improve the + accuracy of reports on LLVM's codebase. + ---------------- NoQ wrote: > "On LLVM's **own** codebase" :) > > @Charusso: I think we need to cherry-pick all of our latest patches to this > checker to 9.0 because otherwise it'll be crashing with the > `isValidBaseClass()` assertion. >>! In D66765#1645726, @Szelethus wrote: > Please note that LLVM 9.0.0-final is due on the 28th of August. Mmm, most likely too late. ================ Comment at: clang/docs/ReleaseNotes.rst:251 + + - ``-analyzer-checker-help-alpha``: The list of incomplet and inkorrekt + checkers not yet advised to be turned on. ---------------- xbolva00 wrote: > Please fix this I think this was supposed to be a joke but i don't insist^^ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66765/new/ https://reviews.llvm.org/D66765 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
