[PATCH] D66267: [analyzer] TrackConstraintBRVisitor: Do not track unknown values

Szelethus added a comment. In D66267#1632164 , @NoQ wrote: > In D66267#1630728 , @Szelethus wrote: > > > Shouldn't we just delete this entire visitor altogether and merge it into > > ConditionBRVisitor (like, event

[PATCH] D65907: Introduce FileEntryRef and use it when handling includes to report correct dependencies when the FileManager is reused across invocations

Bigcheese requested changes to this revision. Bigcheese added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Basic/SourceManager.h:1024 + Optional getFileEntryRefForID(FileID FID) const { +bool MyInvalid = false; +const Sr

[clang-tools-extra] r369063 - [clang-doc] Fix bitcode writer for access specifiers

Author: diegoastiazaran Date: Thu Aug 15 16:04:27 2019 New Revision: 369063 URL: http://llvm.org/viewvc/llvm-project?rev=369063&view=rev Log: [clang-doc] Fix bitcode writer for access specifiers Bitcode writer was not emitting the corresponding record for the Access attribute of a FunctionInfo.

[PATCH] D66151: [clang-doc] Fix bitcode writer

This revision was automatically updated to reflect the committed changes. Closed by commit rL369063: [clang-doc] Fix bitcode writer for access specifiers (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D66267: [analyzer] TrackConstraintBRVisitor: Do not track unknown values

Charusso marked an inline comment as done. Charusso added a comment. @Szelethus pointed out well. My patch is about nullability, and it is perfect. The bug report you made is about deduplication rather than nullability. The fact is we fail to call the deduplication function: `eventsDescribeSame

[clang-tools-extra] r369065 - [clang-doc] Fix use of source-root flag

Author: diegoastiazaran Date: Thu Aug 15 16:20:42 2019 New Revision: 369065 URL: http://llvm.org/viewvc/llvm-project?rev=369065&view=rev Log: [clang-doc] Fix use of source-root flag The value, if any, of --source-root flag was not being used. This has been fixed and the logic was moved to the Cla

[PATCH] D66268: [clang-doc] Fix use of source-root flag

This revision was automatically updated to reflect the committed changes. Closed by commit rL369065: [clang-doc] Fix use of source-root flag (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revi

[PATCH] D59922: [Attributor] Deduce "no-capture" argument attribute

jdoerfert updated this revision to Diff 215498. jdoerfert added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59922/new/ https://reviews.llvm.org/D59922 Files: llvm/include/llvm/Transforms/IPO/Attributor.h llvm/lib/Analysis/C

[clang-tools-extra] r369068 - [clang-doc] Sort index elements case insensitive

Author: diegoastiazaran Date: Thu Aug 15 16:32:12 2019 New Revision: 369068 URL: http://llvm.org/viewvc/llvm-project?rev=369068&view=rev Log: [clang-doc] Sort index elements case insensitive Implement logic to compare the references of the index case insensitive. Differential revision: https://r

[PATCH] D66299: [clang-doc] Sort index elements case insensitive

This revision was automatically updated to reflect the committed changes. Closed by commit rL369068: [clang-doc] Sort index elements case insensitive (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: htt

[PATCH] D59922: [Attributor] Deduce "no-capture" argument attribute

jdoerfert updated this revision to Diff 215504. jdoerfert added a comment. Extracted CaptureTracking changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59922/new/ https://reviews.llvm.org/D59922 Files: llvm/include/llvm/Transforms/IPO/Attribu

[PATCH] D66267: [analyzer] TrackConstraintBRVisitor: Do not track unknown values

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1898-1900 + // If the contents are symbolic and null, find out when they became null. + if (V.getAsLocSymbol(/*IncludeBaseRegions=*/true)) +if (LVState->isNull(V).

[PATCH] D63889: Check possible warnings on global initializers for reachability

rsmith added inline comments. Comment at: clang/include/clang/Sema/Sema.h:1684-1686 + void pushDeclForInitializer(Decl *D) { DeclForInitializer.push_back(D); } + + void popDeclForInitializer() { DeclForInitializer.pop_back(); } I don't think a simple list of th

[PATCH] D66238: [clang-doc] Serialize inherited attributes and methods

DiegoAstiazaran updated this revision to Diff 215506. DiegoAstiazaran added a comment. Rebase to master CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66238/new/ https://reviews.llvm.org/D66238 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeW

[PATCH] D66186: [Sema] Don't warn on printf('%hd', [char]) (PR41467)

Nathan-Huckleberry added a comment. As far as I can tell this case was just overlooked. The original commit adding this change https://reviews.llvm.org/rG0208793e41018ac168412a3da8b2fba70aba9716 only allows chars to int and chars to chars. Another commit ignores typing of chars https://reviews.

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth created this revision. paulkirth added reviewers: phosek, leonardchan, jakehehrlich, mcgrathr. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, mgorny. Herald added projects: clang, LLVM. paulkirth added a parent revision: D65300: [clang] [CodeGen] clang-misexpect prototyp

[clang-tools-extra] r369075 - [clang-doc] Serialize inherited attributes and methods

Author: diegoastiazaran Date: Thu Aug 15 17:10:49 2019 New Revision: 369075 URL: http://llvm.org/viewvc/llvm-project?rev=369075&view=rev Log: [clang-doc] Serialize inherited attributes and methods clang-doc now serializes the inherited attributes and methods, not only the name of the base class.

[PATCH] D66238: [clang-doc] Serialize inherited attributes and methods

This revision was automatically updated to reflect the committed changes. Closed by commit rL369075: [clang-doc] Serialize inherited attributes and methods (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts

Szelethus added a comment. You seem to have diffed against your latest local commit, rather than against trunk (or master, if you use the monorepo). Phabricator isn't smart enough to put two and two together, and only displays the uploaded diff (though one has to admit, its doing a damn good jo

[PATCH] D66325: [analyzer] CastValueChecker: Store the dynamic types in DynamicTypeMap

Charusso created this revision. Charusso added reviewers: NoQ, xazax.hun. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Charusso added a comment. Charusso added a parent revis

[PATCH] D66325: [analyzer] CastValueChecker: Store the dynamic types in DynamicTypeMap

Charusso added a comment. @xazax.hun It is somehow performance critical code as we have too many casts in the LLVM. I would really appreciate it if you could review it. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66325/new/ https://reviews.llvm.org/D66325 _

[PATCH] D66042: [analyzer] Analysis: Silence checkers

Charusso updated this revision to Diff 215518. Charusso marked 10 inline comments as done. Charusso added a comment. - Rebased. - Added the remaining FIXME. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66042/new/ https://reviews.llvm.org/D66042 Files: clang-tools-extra/clang-tidy/Cl

[PATCH] D66042: [analyzer] Analysis: Silence checkers

Charusso added a comment. Thanks for the reviews! Comment at: clang/lib/Frontend/CompilerInvocation.cpp:483-504 + if (!AnOpts.RawSilencedCheckersAndPackages.empty()) { +std::vector Checkers = +AnOpts.getRegisteredCheckers(/*IncludeExperimental=*/true); +std::ve

[PATCH] D66269: [clang-tidy] Migrate objc-forbidden-subclassing to use isDerivedFrom 🚛

This revision was automatically updated to reflect the committed changes. Closed by commit rL369076: [clang-tidy] Migrate objc-forbidden-subclassing to use isDerivedFrom 🚛 (authored by stephanemoore, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pr

[clang-tools-extra] r369078 - [analyzer] Analysis: Silence checkers

Author: charusso Date: Thu Aug 15 18:53:14 2019 New Revision: 369078 URL: http://llvm.org/viewvc/llvm-project?rev=369078&view=rev Log: [analyzer] Analysis: Silence checkers Summary: This patch introduces a new `analyzer-config` configuration: `-analyzer-config silence-checkers` which could be use

r369078 - [analyzer] Analysis: Silence checkers

Author: charusso Date: Thu Aug 15 18:53:14 2019 New Revision: 369078 URL: http://llvm.org/viewvc/llvm-project?rev=369078&view=rev Log: [analyzer] Analysis: Silence checkers Summary: This patch introduces a new `analyzer-config` configuration: `-analyzer-config silence-checkers` which could be use

[PATCH] D66042: [analyzer] Analysis: Silence checkers

This revision was automatically updated to reflect the committed changes. Closed by commit rL369078: [analyzer] Analysis: Silence checkers (authored by Charusso, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.

[PATCH] D66267: [analyzer] TrackConstraintBRVisitor: Do not track unknown values

Charusso updated this revision to Diff 215525. Charusso marked an inline comment as done. Charusso added a comment. - Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66267/new/ https://reviews.llvm.org/D66267 Files: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp clang

[PATCH] D66328: [DebugInfo] Add debug location to dynamic atexit destructor

aganea created this revision. aganea added reviewers: rnk, aprantl. aganea added a project: clang. Previously, when clang was compiled with -DLLVM_ENABLE_ASSERTIONS=ON, the attached test was yielding: inlinable function call in a function with debug info must have a !dbg location call voi

[PATCH] D66270: [clang-tidy] Migrate objc-super-self to use isDerivedFrom 🚛

This revision was automatically updated to reflect the committed changes. Closed by commit rL369081: [clang-tidy] Migrate objc-super-self to use isDerivedFrom 🚛 (authored by stephanemoore, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to comm

[PATCH] D66298: [clang-doc] Fix records in global namespace

DiegoAstiazaran updated this revision to Diff 215537. DiegoAstiazaran marked 2 inline comments as done. DiegoAstiazaran added a comment. Fix tests that were going to fail in Windows. Fix tests broken after rebasing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66298/new/ https://review

[PATCH] D66332: [clang-format] Fix the bug that joins template closer and > or >>

owenpan created this revision. owenpan added reviewers: sammccall, MyDeveloperDay, klimek, djasper. Herald added a project: clang. Herald added a subscriber: cfe-commits. Also fixes a buggy test case. See PR42404 Repository: rC Clang https://reviews.llvm.org/D66332 Files: clang/lib/Format

[PATCH] D66092: [CodeGen] Generate constrained fp intrinsics depending on FPOptions

sepavloff added a comment. > The thing that makes the IR semantically incomplete is that there is nothing > there to prevent incorrect code motion of the non-constrained operations. > Consider this case: > > if (someCondition) { > #pragma clang fp rounding(downward) > fesetround(FE_DO

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

lebedev.ri added reviewers: lebedev.ri, vsk. lebedev.ri added a comment. This is marked as child revision of D65300 but it seems like they both add the same logic, just into different components, D65300 to clang, this to llvm. I

<    1   2