[PATCH] D64475: [clangd] Duplicate lines of semantic highlightings sent removed.

hokein accepted this revision. hokein added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1125 +Old = std::move(FileToHighlightings[File]); +FileToHighlightings[File] = Highlightings; + } ilya-biryukov wrote: > jvikstrom wrote

r367520 - Delay emitting dllexport explicitly defaulted members until the class is fully parsed (PR40006)

Author: hans Date: Thu Aug 1 01:01:09 2019 New Revision: 367520 URL: http://llvm.org/viewvc/llvm-project?rev=367520&view=rev Log: Delay emitting dllexport explicitly defaulted members until the class is fully parsed (PR40006) This is similar to r245139, but that only addressed dllexported class

[PATCH] D65511: Delay emitting dllexport explicitly defaulted members until the class is fully parsed (PR40006)

This revision was automatically updated to reflect the committed changes. hans marked an inline comment as done. Closed by commit rL367520: Delay emitting dllexport explicitly defaulted members until the class is fully… (authored by hans, committed by ). Herald added a project: LLVM. Herald added

[clang-tools-extra] r367521 - [clangd] Duplicate lines of semantic highlightings sent removed.

Author: jvikstrom Date: Thu Aug 1 01:08:44 2019 New Revision: 367521 URL: http://llvm.org/viewvc/llvm-project?rev=367521&view=rev Log: [clangd] Duplicate lines of semantic highlightings sent removed. Summary: Added a class for diffing highlightings and removing duplicate lines. Integrated into

[PATCH] D64475: [clangd] Duplicate lines of semantic highlightings sent removed.

This revision was automatically updated to reflect the committed changes. Closed by commit rL367521: [clangd] Duplicate lines of semantic highlightings sent removed. (authored by jvikstrom, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to com

[PATCH] D65527: Avoid assemble step in verbose-output-quoting.c

hans added a comment. Sorry, I should have caught this in the original review. Normally tests in Driver/ use the -### flag. That way it doesn't invoke the frontend at all, it just shows how it would invoke it. Would that work for this test also? Repository: rG LLVM Github Monorepo CHANGES

Re: r367323 - [COFF][ARM64] Reorder handling of aarch64 MSVC builtins

Merged to release_90 in r367525. On Tue, Jul 30, 2019 at 5:32 PM David Major via cfe-commits wrote: > > Author: dmajor > Date: Tue Jul 30 08:32:49 2019 > New Revision: 367323 > > URL: http://llvm.org/viewvc/llvm-project?rev=367323&view=rev > Log: > [COFF][ARM64] Reorder handling of aarch64 MSVC b

Re: r367305 - [Driver] Define _FILE_OFFSET_BITS=64 on Solaris

Merged to release_90 in r367527. On Tue, Jul 30, 2019 at 12:37 PM Rainer Orth via cfe-commits wrote: > > Author: ro > Date: Tue Jul 30 03:38:41 2019 > New Revision: 367305 > > URL: http://llvm.org/viewvc/llvm-project?rev=367305&view=rev > Log: > [Driver] Define _FILE_OFFSET_BITS=64 on Solaris > >

[PATCH] D65387: [clangd] Add a callback mechanism for handling responses from client.

hokein added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:266 elog("No reply to message {0}({1})", Method, ID); assert(false && "must reply to all calls!"); (*this)(llvm::make_error("server failed to reply",

Re: [clang-tools-extra] r367521 - [clangd] Duplicate lines of semantic highlightings sent removed.

It seems to have made this buildbot sad: http://lab.llvm.org:8011/builders/clang-cmake-armv8-lnt/builds/10968 On Thu, Aug 1, 2019 at 10:07 AM Johan Vikstrom via cfe-commits wrote: > > Author: jvikstrom > Date: Thu Aug 1 01:08:44 2019 > New Revision: 367521 > > URL: http://llvm.org/viewvc/llvm-pr

[PATCH] D65517: [Preprocessor] Always discard body of #define if we failed to parse it

ilya-biryukov updated this revision to Diff 212754. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Update a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65517/new/ https://reviews.llvm.org/D65517 Files:

Re: r367387 - [Fix] Customize warnings for missing built-in types

Merged to release_90 in r367528. On Wed, Jul 31, 2019 at 7:15 AM Johannes Doerfert via cfe-commits wrote: > > Author: jdoerfert > Date: Tue Jul 30 22:16:38 2019 > New Revision: 367387 > > URL: http://llvm.org/viewvc/llvm-project?rev=367387&view=rev > Log: > [Fix] Customize warnings for missing bu

[PATCH] D65562: Move LangStandard*, InputKind::Language to Basic

ro created this revision. ro added reviewers: rsmith, rnk. Herald added subscribers: fedor.sergeev, Anastasia, mgorny, jyknight. Herald added a reviewer: bollu. Herald added a project: clang. This patch is a prerequisite for using `LangStandard` from `Driver` in https://reviews.llvm.org/D64793.

[clang-tools-extra] r367529 - [clangd] Fix buildbot failure from ambigous ArrayRef ctor

Author: jvikstrom Date: Thu Aug 1 02:08:41 2019 New Revision: 367529 URL: http://llvm.org/viewvc/llvm-project?rev=367529&view=rev Log: [clangd] Fix buildbot failure from ambigous ArrayRef ctor Modified: clang-tools-extra/trunk/clangd/SemanticHighlighting.cpp Modified: clang-tools-extra/trun

r367530 - [Preprocessor] Always discard body of #define if we failed to parse it

Author: ibiryukov Date: Thu Aug 1 02:10:37 2019 New Revision: 367530 URL: http://llvm.org/viewvc/llvm-project?rev=367530&view=rev Log: [Preprocessor] Always discard body of #define if we failed to parse it Summary: Preivously we would only discard it if we failed to parse parameter lists. If we

[PATCH] D65517: [Preprocessor] Always discard body of #define if we failed to parse it

This revision was automatically updated to reflect the committed changes. Closed by commit rL367530: [Preprocessor] Always discard body of #define if we failed to parse it (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D65564: Improve raw_ostream so that you can "write" colors using operator<

ruiu created this revision. ruiu added reviewers: MaskRay, grimar. Herald added subscribers: cfe-commits, thopre, gbedwell, aheejin, hiraditya, arichardson, sbc100, emaste. Herald added a reviewer: espindola. Herald added a reviewer: andreadb. Herald added projects: clang, LLVM. 1. raw_ostream su

[PATCH] D64793: [Driver] Properly use values-X[ca].o, values-xpg[46].o on Solaris

ro marked 5 inline comments as done. ro added a comment. In D64793#1604877 , @jyknight wrote: > > I fear it is necessary: at least it matches documented behaviour of both > > the Sun/Oracle Studio compilers and gcc. > > I will defer to your opinion here.

[PATCH] D65387: [clangd] Add a callback mechanism for handling responses from client.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:266 elog("No reply to message {0}({1})", Method, ID); assert(false && "must reply to all calls!"); (*this)(llvm::make_error("server failed to reply", -

[PATCH] D65445: [CrossTU] Handle case when no USR could be generated during Decl search.

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM! Please proceed and commit! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65445/new/ https://reviews.llvm.org/D65445 __

[PATCH] D64793: [Driver] Properly use values-X[ca].o, values-xpg[46].o on Solaris

ro updated this revision to Diff 212763. ro marked 2 inline comments as done. ro added a comment. Updated patch to make use of the move to `Basic`. Tested on top of that one on `x86_64-pc-solaris2.11`, `sparcv9-sun-solaris2.11`, and `x86_64-pc-linux-gnu`. Repo

[PATCH] D65445: [CrossTU] Handle case when no USR could be generated during Decl search.

martong added a comment. In D65445#1608277 , @balazske wrote: > Probably this is a problem case too but only if the `f` or `i` has an > initializer expression and really no USR is generated for `f` or `i`. But > what I have found is that there is a `VarD

[PATCH] D65517: [Preprocessor] Always discard body of #define if we failed to parse it

ilya-biryukov added a subscriber: hans. ilya-biryukov added a comment. @hans, could you please merge rL367530 into the release? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65517/new/ https://reviews.llvm.org/D65517 __

[PATCH] D65517: [Preprocessor] Always discard body of #define if we failed to parse it

hans added a comment. In D65517#1609902 , @ilya-biryukov wrote: > @hans, could you please merge rL367530 > into the release? Sure! Let's have it bake in trunk for a bit, and then I'll merge it. Repository: rL LL

[PATCH] D65564: Improve raw_ostream so that you can "write" colors using operator<

grimar added a comment. It looks good to me. A minor nit is inlined. Comment at: clang/tools/diagtool/TreeView.cpp:30 - TreePrinter(llvm::raw_ostream &out) - : out(out), ShowColors(hasColors(out)), Internal(false) {} - - void setColor(llvm::raw_ostream::Colors Color) {

[clang-tools-extra] r367541 - [clangd] Add missing braces to completion tests. NFC

Author: ibiryukov Date: Thu Aug 1 04:05:06 2019 New Revision: 367541 URL: http://llvm.org/viewvc/llvm-project?rev=367541&view=rev Log: [clangd] Add missing braces to completion tests. NFC Modified: clang-tools-extra/trunk/clangd/unittests/CodeCompleteTests.cpp Modified: clang-tools-extra/tr

[PATCH] D65564: Improve raw_ostream so that you can "write" colors using operator<

MaskRay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65564/new/ https://reviews.llvm.org/D65564 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D65517: [Preprocessor] Always discard body of #define if we failed to parse it

ilya-biryukov added a comment. SG, just wanted to make sure it's on your list ;-) Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65517/new/ https://reviews.llvm.org/D65517 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D65556: Phabricator D49466

lebedev.ri added a comment. Please fix patch title and description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65556/new/ https://reviews.llvm.org/D65556 ___ cfe-commits mailing list cfe-commits@list

r367545 - [Parser] Change parameter type from int to enum

Author: sepavloff Date: Thu Aug 1 04:46:28 2019 New Revision: 367545 URL: http://llvm.org/viewvc/llvm-project?rev=367545&view=rev Log: [Parser] Change parameter type from int to enum Some parser functions accept argument of type unsigned while it is actually of type DeclSpec::TST. No functional

[PATCH] D65406: [Parser] Change parameter type from int to enum

This revision was automatically updated to reflect the committed changes. Closed by commit rL367545: [Parser] Change parameter type from int to enum (authored by sepavloff, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://re

[PATCH] D64753: [CrossTU][NFCI] Refactor loadExternalAST function

gamesh411 updated this revision to Diff 212788. gamesh411 added a comment. Specify the exact meaning of successful storage Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64753/new/ https://reviews.llvm.org/D64753 Files: clang/include/clang/CrossT

[PATCH] D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure

teemperor added a comment. The error handling in LLDB seems fine to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65534/new/ https://reviews.llvm.org/D65534 ___ cfe-commits mailing list cfe-commits

[PATCH] D65510: [clangd] Fix implicit template instatiations appearing as topLevelDecls.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/ClangdUnit.cpp:68 + if (const auto *TD = dyn_cast(D)) +return TD->getTemplateSpecializationKind() == TSK_ImplicitInstantiation; + return false; hokein wrote: > ilya-biryukov wrote: >

[PATCH] D65525: [clangd] Add new helpers to make tweak tests scale better. Convert most tests. NFC

ilya-biryukov added a comment. Neat, thanks for the cleanup! A few suggestions from me, no major comments. Comment at: clang-tools-extra/clangd/unittests/TweakTesting.cpp:74 +return true; + llvm::consumeError(PrepareResult.takeError()); + return false; Ma

[PATCH] D65387: [clangd] Add a callback mechanism for handling responses from client.

hokein updated this revision to Diff 212794. hokein marked 2 inline comments as done. hokein edited the summary of this revision. hokein added a comment. Herald added a subscriber: jfb. - adjust ReplyOnce assertion logic - add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D65192: [Sema] Disable some enabled-by-default -Wparentheses diagnostics

aaron.ballman added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:5654-5656 def warn_addition_in_bitshift : Warning< "operator '%0' has lower precedence than '%1'; " + "'%1' will be evaluated first">, InGroup, DefaultIgnore; MaskRay

r367557 - [RISCV] Add FreeBSD targets

Author: lenary Date: Thu Aug 1 06:14:30 2019 New Revision: 367557 URL: http://llvm.org/viewvc/llvm-project?rev=367557&view=rev Log: [RISCV] Add FreeBSD targets Reviewers: asb Reviewed By: asb Subscribers: simoncook, s.egerton, lenary, psnobl, benna, mhorne, emaste, kito-cheng, shiva0217, rogf

[PATCH] D57795: [RISCV] Add FreeBSD targets

This revision was automatically updated to reflect the committed changes. Closed by commit rL367557: [RISCV] Add FreeBSD targets (authored by lenary, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D57795?v

[PATCH] D65387: [clangd] Add a callback mechanism for handling responses from client.

hokein updated this revision to Diff 212796. hokein added a comment. some tweaks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65387/new/ https://reviews.llvm.org/D65387 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-extra/cla

[PATCH] D65572: Fix static linking failure with --unwindlib=libunwind

raj.khem created this revision. raj.khem added a reviewer: rengolin. raj.khem added a project: clang. Herald added subscribers: cfe-commits, jfb. when trying to use llvm libunwind via clang driver option --unwindlib and using -static together, linking fails with missing symbols libunwind/src/R

[PATCH] D65573: Add User docs for ASTImporter

martong created this revision. martong added reviewers: a_sidorin, shafik, gamesh411, balazske. Herald added subscribers: cfe-commits, Szelethus, arphaman, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a project: clang. This document includes the description of the ASTImporter

[PATCH] D65574: Added hack to prevent toHalfOpenFileRange assertion fail

SureYeaah created this revision. SureYeaah added reviewers: sammccall, kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, ilya-biryukov. Herald added a project: clang. - Still need to investigate why this is happening. - Fixes the crash described at https://github.com/clangd/clang

[PATCH] D64753: [CrossTU][NFCI] Refactor loadExternalAST function

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Please do the commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64753/new/ https://reviews.llvm.org/D64753 __

[PATCH] D65572: Fix static linking failure with --unwindlib=libunwind

rengolin added reviewers: compnerd, mstorsjo, jroelofs, theraven. rengolin added a comment. This is a tricky one which may vary depending on the libraries available on different systems. Which toolchain is this? Can you add more context? Repository: rC Clang CHANGES SINCE LAST ACTION https

[PATCH] D48357: [RISCV] Remove duplicated logic when determining the target ABI

lenary added a comment. Herald added subscribers: s.egerton, Jim, benna, psnobl, MaskRay. Given we now have support for the floating-point ABIs, can you rebase and update this patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48357/new/ https://reviews.llvm.org/D48357 ___

[PATCH] D65192: [Sema] Disable some enabled-by-default -Wparentheses diagnostics

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:5654-5656 def warn_addition_in_bitshift : Warning< "operator '%0' has lower precedence than '%1'; " + "'%1' will be evaluated first">, InGroup, Def

[PATCH] D64232: [analyzer] Prune calls to functions with linear CFGs that return a non-zero constrained value

Szelethus updated this revision to Diff 212801. Szelethus added a comment. Use `size() == 3` instead if `isLinear()`, add a related test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64232/new/ https://reviews.llvm.org/D64232 Files: clang/lib/StaticAnalyzer/Core/BugReporterVisi

[PATCH] D63932: [GlobalDCE] Dead Virtual Function Elimination

ostannard added a comment. > Partial linking will indeed prevent dropping the virtual functions, but it > should not prevent clearing the pointer to the virtual function in the > vtable. The linker should then be able to drop the virtual function body as > part of `--gc-sections` during the fin

[PATCH] D65287: [analyzer][CFG] Don't track the condition of asserts

Szelethus updated this revision to Diff 212803. Szelethus marked 10 inline comments as done. Szelethus added a comment. Fixes according to reviewer comments! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65287/new/ https://reviews.llvm.org/D65287 Files: clang/include/clang/Analysis/C

[PATCH] D65287: [analyzer][CFG] Don't track the condition of asserts

Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1753-1755 + // It so happens that CFGBlock::getTerminatorCondition returns 'A' for block + // B1, 'A && B' for B2, and 'A && B || C' fo

[PATCH] D65575: [analyzer] Mention whether an event is about a condition in a bug report part 1

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, Charusso, baloghadamsoftware, dcoughlin, rnkovacs. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. Can't add much mo

[PATCH] D65379: [analyzer][NFC] Refactoring BugReporter.cpp P2.: Clean up the construction of bug paths and finding a valid report

Szelethus updated this revision to Diff 212806. Szelethus marked 2 inline comments as done. Szelethus added a comment. clang-format, rephrase the comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65379/new/ https://reviews.llvm.org/D65379 Files: clang/include/clang/StaticAnalyze

[PATCH] D65381: [analyzer][NFC] Refactoring BugReporter.cpp P3.: std::shared_pointer -> PathDiagnosticPieceRef

Szelethus updated this revision to Diff 212807. Szelethus marked 5 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65381/new/ https://reviews.llvm.org/D65381 Files: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h clang/include/clang/St

[PATCH] D65382: [analyzer][NFC] Refactoring BugReporter.cpp P4.: If it can be const, make it const

Szelethus updated this revision to Diff 212808. Szelethus added a comment. Don't return `ProgramStateManager` and `SValBuilder` by const reference. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65382/new/ https://reviews.llvm.org/D65382 Files: clang/include/clang/Analysis/AnalysisDec

[PATCH] D65577: [ASTImporter] Import default expression of param before creating the param.

balazske created this revision. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp. Herald added a reviewer: martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. The default expression of a parameter variable should be import

[PATCH] D65381: [analyzer][NFC] Refactoring BugReporter.cpp P3.: std::shared_pointer -> PathDiagnosticPieceRef

Szelethus added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:244 + const ExplodedNode *N, + const CFGBlock *srcBlk, +

[PATCH] D65578: [analyzer][NFC] Make sure that the BugReport is not modified during the construction of non-visitor pieces

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, baloghadamsoftware, Charusso, dcoughlin, rnkovacs. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. I feel this is ki

r367565 - Add support for openSUSE RISC-V triple

Author: lenary Date: Thu Aug 1 07:23:56 2019 New Revision: 367565 URL: http://llvm.org/viewvc/llvm-project?rev=367565&view=rev Log: Add support for openSUSE RISC-V triple Reviewers: asb Reviewed By: asb Subscribers: lenary, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, zzheng,

[PATCH] D65578: [analyzer][NFC] Make sure that the BugReport is not modified during the construction of non-visitor pieces

Szelethus updated this revision to Diff 212811. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65578/new/ https://reviews.llvm.org/D65578 Files: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h

[PATCH] D65456: [OpenCL] Add generic type handling for builtin functions

Anastasia added inline comments. Comment at: clang/lib/Sema/OpenCLBuiltins.td:51 -// Helper class to store type access qualifiers (volatile, const, ...). -class Qualifier { - string QualName = _QualName; Are the qualifiers added elsewhere? Com

[PATCH] D54214: [RISCV] Set triple based on -march flag

simoncook updated this revision to Diff 212772. simoncook added a comment. Herald added subscribers: s.egerton, lenary, Jim, benna, psnobl. Herald added a project: clang. Rebase on top of tree. I've noticed that without this flag calling riscv32-unknown-elf-clang -march=rv64i will still produce

[PATCH] D54214: [RISCV] Set triple based on -march flag

lenary added a comment. What happens if I pass `clang -march=rv32i -target riscv64-unknown-elf`? Should we care about the ordering of `-march` vs `-target`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54214/new/ https://reviews.llvm.org/D54214

[PATCH] D63497: Add support for openSUSE RISC-V triple

This revision was automatically updated to reflect the committed changes. Closed by commit rL367565: Add support for openSUSE RISC-V triple (authored by lenary, committed by ). Herald added a subscriber: s.egerton. Changed prior to commit: https://reviews.llvm.org/D63497?vs=206423&id=212814#toc

[PATCH] D54214: [RISCV] Set triple based on -march flag

simoncook added a comment. In D54214#1609967 , @lenary wrote: > What happens if I pass `clang -march=rv32i -target riscv64-unknown-elf`? > Should we care about the ordering of `-march` vs `-target`? Currently this patch makes the output be generated for

[PATCH] D63497: Add support for openSUSE RISC-V triple

lenary added a comment. Thanks @schwab, sorry we took so long to merge your patch, but it's merged now! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63497/new/ https://reviews.llvm.org/D63497 ___ cfe-commits mailing

[PATCH] D65579: Don't try emitting dllexported explicitly defaulted non-trivial ctors twice during explicit template instantiation definition (PR42857)

hans created this revision. hans added a reviewer: rnk. Trying to emit the definition twice triggers an assert. https://reviews.llvm.org/D65579 Files: clang/lib/Sema/SemaDeclCXX.cpp clang/test/CodeGenCXX/dllexport.cpp Index: clang/test/CodeGenCXX/dllexport.cpp

Re: [clang-tools-extra] r366545 - [clangd] Handle windows line endings in QueryDriver

Merged to release_90 in r367571. On Fri, Jul 19, 2019 at 11:07 AM Kadir Cetinkaya via cfe-commits wrote: > > Author: kadircet > Date: Fri Jul 19 02:08:22 2019 > New Revision: 366545 > > URL: http://llvm.org/viewvc/llvm-project?rev=366545&view=rev > Log: > [clangd] Handle windows line endings in Q

[PATCH] D65341: [OpenMP] Add support for close map modifier in Clang

gtbercea updated this revision to Diff 212821. gtbercea added a comment. - Improve test. - Add tests from previous patch. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65341/new/ https://reviews.llvm.org/D65341 Files: lib/CodeGen/CGOpenMPRuntime.cpp test/Ope

[PATCH] D64811: Warn when NumParams overflows

rjmccall added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:6673 + // Avoid exceeding the maximum function parameters + // See https://bugs.llvm.org/show_bug.cgi?id=19607 + if (ParamInfo.size() > Type::getMaxNumParams()) { Mordante wrote: > rjmcc

r367574 - Rename two clang tests from .cc to .cpp.

Author: nico Date: Thu Aug 1 08:06:57 2019 New Revision: 367574 URL: http://llvm.org/viewvc/llvm-project?rev=367574&view=rev Log: Rename two clang tests from .cc to .cpp. clang/test/lit.cfg.py doesn't list .cc as test extension, so these tests never ran. Tweak one of the two tests to actually p

[PATCH] D65341: [OpenMP] Add support for close map modifier in Clang

gtbercea added a comment. @Hahnfeld I have merged the tests from the previous patch as per Alexey's suggestion - with minor changes to make them pass. Let me know if this now addresses your previous comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65341/n

[PATCH] D65341: [OpenMP] Add support for close map modifier in Clang

ABataev accepted this revision. ABataev added a comment. LG Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65341/new/ https://reviews.llvm.org/D65341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

r367575 - [Parser] Use special definition for pragma annotations

Author: sepavloff Date: Thu Aug 1 08:15:10 2019 New Revision: 367575 URL: http://llvm.org/viewvc/llvm-project?rev=367575&view=rev Log: [Parser] Use special definition for pragma annotations Previously pragma annotation tokens were described as any other annotations in TokenKinds.def. This change

[PATCH] D65405: [Parser] Use special definition for pragma annotations

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL367575: [Parser] Use special definition for pragma annotations (authored by sepavloff, committed by ). Herald added a proj

[PATCH] D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure

thakis added a comment. Nice! This makes https://bugs.llvm.org/show_bug.cgi?id=42524#c3 easier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65534/new/ https://reviews.llvm.org/D65534 ___ cfe-commits

[PATCH] D65577: [ASTImporter] Import default expression of param before creating the param.

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM, though I have some comments. Comment at: clang/test/Analysis/Inputs/ctu-other.cpp:135 + +struct DefParmContext { + static const int I; Perhaps we co

[PATCH] D65341: [OpenMP] Add support for close map modifier in Clang

kkwli0 added a comment. Looks fine to me. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65341/new/ https://reviews.llvm.org/D65341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D63932: [GlobalDCE] Dead Virtual Function Elimination

ostannard updated this revision to Diff 212833. ostannard added a comment. - Add LTOPostLink metadata, instead of internalising vcall visibility at LTO time Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63932/new/ https://reviews.llvm.org/D63932

[PATCH] D65192: [Sema] Disable some enabled-by-default -Wparentheses diagnostics

aaron.ballman added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:5654-5656 def warn_addition_in_bitshift : Warning< "operator '%0' has lower precedence than '%1'; " + "'%1' will be evaluated first">, InGroup, DefaultIgnore; MaskRay

[PATCH] D65582: IR: accept and print numbered %N names for function args

jyknight added a comment. Herald added a subscriber: wuzish. +1 for doing this. I started looking at fixing this when I modified the printer to print proper labels for numbered basic-blocks (instead of comments), but I didn't do so because of the amount of test churn was off-putting. I think th

[PATCH] D65564: Improve raw_ostream so that you can "write" colors using operator<

andreadb accepted this revision. andreadb added a comment. This revision is now accepted and ready to land. LGTM too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65564/new/ https://reviews.llvm.org/D65564 __

[PATCH] D63907: [clang-scan-deps] Implementation of dependency scanner over minimized sources

aganea added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:84 +DependencyScanningFilesystemSharedCache() { + NumShards = 8; + CacheShards = llvm::make_unique(NumShards); arphaman wrote: > aganea wrote: >

[PATCH] D65341: [OpenMP] Add support for close map modifier in Clang

Hahnfeld removed a reviewer: Hahnfeld. Hahnfeld added inline comments. This revision is now accepted and ready to land. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:7695 Flags &= ~(OMP_MAP_TO | OMP_MAP_FROM | OMP_MAP_ALWAYS | - OMP_MAP_DELETE

[PATCH] D65577: [ASTImporter] Import default expression of param before creating the param.

shafik added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:3859 ToTypeSourceInfo, D->getStorageClass(), /*DefaultArg*/ nullptr)) return ToParm; This should be `DefaultArg` now?

[PATCH] D65587: [analyzer] StackFrameContext: Add NodeBuilderContext::blockCount() to its profile

Charusso created this revision. Charusso added a reviewer: NoQ. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, zzheng, szepet, baloghadamsoftware, xazax.hun. With this addition we can distinguish between `StackSpa

[PATCH] D65587: [analyzer] StackFrameContext: Add NodeBuilderContext::blockCount() to its profile

Charusso marked 2 inline comments as done. Charusso added inline comments. Comment at: clang/include/clang/Analysis/AnalysisDeclContext.h:486 const StackFrameContext *getStackFrame(AnalysisDeclContext *Ctx, - LocationContext const *Paren

[PATCH] D65573: Add User docs for ASTImporter

aprantl added a comment. Thanks, the extra documentation is highly appreciated! Comment at: clang/docs/LibASTImporter.rst:19 +``ASTContext`` holds long-lived AST nodes (such as types and decls) that can be referred to throughout the semantic analysis of a file. +There are case

[PATCH] D65582: IR: accept and print numbered %N names for function args

jdoerfert resigned from this revision. jdoerfert added a comment. I like the idea but I am not the right person to review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65582/new/ https://reviews.llvm.org/D65582 _

[PATCH] D65589: [clang] Fix mismatched args constructing AddressSpaceAttr.

AntonBikineev created this revision. AntonBikineev added reviewers: rsmith, klimek. AntonBikineev added a project: clang. Interestingly enough, but this wasn't caught in tests. I wonder if it's possible to write a test case for it. Repository: rC Clang https://reviews.llvm.org/D65589 Files:

[PATCH] D65589: [clang] Fix mismatched args constructing AddressSpaceAttr.

lebedev.ri added a comment. This really needs a test, likely an astdump-one will show it. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65589/new/ https://reviews.llvm.org/D65589 ___ cfe-commits mailing list cfe-comm

[PATCH] D65591: [AST] Add a flag indicating if any subexpression had errors

ilya-biryukov created this revision. ilya-biryukov added a reviewer: rsmith. Herald added a subscriber: jfb. Herald added a project: clang. ilya-biryukov added a child revision: D65592: [Parser] Avoid spurious 'missing template' error in presence of typos. The only subexpression that is considere

[PATCH] D65592: [Parser] Avoid spurious 'missing template' error in presence of typos

ilya-biryukov created this revision. ilya-biryukov added a reviewer: rsmith. Herald added a project: clang. ilya-biryukov added a parent revision: D65591: [AST] Add a flag indicating if any subexpression had errors. Suppress those diagnostics if lhs of a member expression contains errors. Typo co

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

Manikishan added a comment. In D64695#1606256 , @rdwampler wrote: > In D64695#1605676 , @Manikishan > wrote: > > > In D64695#1590948 , @Manikishan > > wrote: > > > > > In D

[PATCH] D65579: Don't try emitting dllexported explicitly defaulted non-trivial ctors twice during explicit template instantiation definition (PR42857)

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm yeesh. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65579/new/ https://reviews.llvm.org/D65579 ___ cfe-commits mailing list cfe-commits

[PATCH] D65341: [OpenMP] Add support for close map modifier in Clang

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:7695 Flags &= ~(OMP_MAP_TO | OMP_MAP_FROM | OMP_MAP_ALWAYS | - OMP_MAP_DELETE); + OMP_MAP_DELETE |

[PATCH] D65543: Use library basenames when autolinking on Windows

rnk added a comment. I'll look into that. I also noticed that check-ubsan fails. I think we should also change clang's driver to add this libpath when it invokes the linker, so that this works transparently when using the GCC-style driver. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D65582: IR: accept and print numbered %N names for function args

rnk added a comment. This is awesome! Thanks for doing the test updates. As I read it, LLVM will still read old-style IR just fine, which seems nice. I think it would be worth noting this in the 10.0 release notes, since it will affect someone upgrading a frontend as you mention. Otherwise, I

[PATCH] D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure

harlanhaskins updated this revision to Diff 212860. harlanhaskins marked 8 inline comments as done. harlanhaskins added a comment. Updated in response to feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65534/new/ https://reviews.llvm.org/D65

[PATCH] D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure

harlanhaskins marked 6 inline comments as done and an inline comment as not done. harlanhaskins added inline comments. Comment at: clang/lib/ARCMigrate/FileRemapper.cpp:156 + auto newE = FileMgr->getFile(tempPath); + if (newE) { +remap(origFE, *newE); -

  1   2   >