[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

lebedev.ri added a comment. In D64695#1585772 , @Manikishan wrote: > In D64695#1585754 , @rdwampler wrote: > > > I am not quite sure why this change is required to sort the headers for > > NetBSD, you can set the p

[PATCH] D64753: [CrossTU][NFCI] Refactor loadExternalAST function

gamesh411 created this revision. gamesh411 added a reviewer: martong. Herald added subscribers: cfe-commits, Szelethus, dkrupp, rnkovacs. Herald added a project: clang. Refactor loadExternalAST method of CrossTranslationUnitContext in order to reduce maintenance burden and so that features are eas

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

Manikishan added a comment. In D64695#1585835 , @lebedev.ri wrote: > In D64695#1585772 , @Manikishan > wrote: > > > In D64695#1585754 , @rdwampler > > wrote: > > > > > I am

[PATCH] D64671: [clang-tidy] New check: misc-init-local-variables

jpakkane marked 2 inline comments as done. jpakkane added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/InitLocalVariablesCheck.cpp:21 + Finder->addMatcher( + varDecl(unless(hasInitializer(anything(.bind("vardecl"), this); +} alexfh wro

[PATCH] D64754: [clangd] Added highlighting for the targets in typedefs.

jvikstrom created this revision. jvikstrom added reviewers: hokein, sammccall, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. In `typedef int A` the `A` was not highlighted previously. This patch gives `A` the same kind o

[PATCH] D64518: [LibTooling] Relax Transformer to allow rewriting macro expansions

ilya-biryukov added a comment. This clearly increases the utility of the library, but also seems to add corner cases that the library won't handle (see the comment about unittests for an example). WDYT about those? Are they important, should we support producing warnings in those cases to let t

[PATCH] D64678: [Sema] Fix -Wuninitialized for struct assignment from GNU C statement expression

nickdesaulniers added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:10890 +if (cast(OrigDecl)->getType()->isRecordType() && +dyn_cast_or_null(E)) { + return; Should just be `dyn_cast(E)`? http://llvm.org/docs/ProgrammersManual.html#the

r366084 - Use unique_ptr instead of manual delete in one place. No behavior change.

Author: nico Date: Mon Jul 15 10:12:08 2019 New Revision: 366084 URL: http://llvm.org/viewvc/llvm-project?rev=366084&view=rev Log: Use unique_ptr instead of manual delete in one place. No behavior change. Modified: cfe/trunk/lib/Driver/Compilation.cpp Modified: cfe/trunk/lib/Driver/Compilati

r366085 - Use a unique_ptr instead of manual memory management for CustomDiagInfo

Author: nico Date: Mon Jul 15 10:20:34 2019 New Revision: 366085 URL: http://llvm.org/viewvc/llvm-project?rev=366085&view=rev Log: Use a unique_ptr instead of manual memory management for CustomDiagInfo Modified: cfe/trunk/include/clang/Basic/DiagnosticIDs.h cfe/trunk/lib/Basic/Diagnostic

r366088 - Use a unique_ptr instead of manual memory management for LineTable

Author: nico Date: Mon Jul 15 10:27:46 2019 New Revision: 366088 URL: http://llvm.org/viewvc/llvm-project?rev=366088&view=rev Log: Use a unique_ptr instead of manual memory management for LineTable Modified: cfe/trunk/include/clang/Basic/SourceManager.h cfe/trunk/lib/Basic/SourceManager.c

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

nickdesaulniers added a comment. In D64666#1583792 , @xbolva00 wrote: > I had duplicated warning for C++11+ - my new warning and C++11’s narrowing > warning. Why would narrowing be C++11 specific? I would think that narrowing applies anywhere integrals

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63048/new/ https://reviews.llvm.org/D63048 ___ cfe-commits mailing

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. I verified the conversion values are correct in the precise warnings in the test cases. From that perspective, and the rest of the code LGTM. Please wait for review from an

[PATCH] D64678: [Sema] Fix -Wuninitialized for struct assignment from GNU C statement expression

Nathan-Huckleberry updated this revision to Diff 209905. Nathan-Huckleberry marked 3 inline comments as done. Nathan-Huckleberry added a comment. - Change cast type Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64678/new/ https://reviews.llvm.org/D

[PATCH] D64062: Remove __VERSION__

rnk added a comment. In D64062#1584219 , @saugustine wrote: > This revision breaks python 2.7.16 builds, which are still supported by > upstream python for a few more months. I'm preparing a revert. > > The file is getcompiler.c: I just want to point ou

[PATCH] D64678: [Sema] Fix -Wuninitialized for struct assignment from GNU C statement expression

Nathan-Huckleberry marked 3 inline comments as done. Nathan-Huckleberry added inline comments. Comment at: clang/test/Sema/warn-uninitialized-statement-expression.c:21 +struct widget z = my_widget; // expected-warning{{variable 'my_widget' is uninitialized when used within i

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

rdwampler added a comment. > Sorry, my mistake I meant that I have added Regex for priorities while > sorting and If I am not wrong I think IncludeCategories are used while > Regrouping after sorting the Includes. In addition to that in my case I have > to sort the includes In a particular ord

[PATCH] D61634: [clang/llvm] Allow efficient implementation of libc's memory functions in C/C++

tejohnson added a comment. In D61634#1515176 , @tejohnson wrote: > In D61634#1512020 , @gchatelet wrote: > > > AFAIU here is a coarse plan of what needs to happen > > > > 1. Add a `no-builtin` clang function attribu

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

xbolva00 added a subscriber: aaron.ballman. xbolva00 added a comment. Probably @aaron.ballman would like to review this too.. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64666/new/ https://reviews.llvm.org/D64666 ___ cfe-commits mailing l

r366091 - Update __VERSION__ to remove the hardcoded 4.2.1 version

Author: sylvestre Date: Mon Jul 15 10:47:22 2019 New Revision: 366091 URL: http://llvm.org/viewvc/llvm-project?rev=366091&view=rev Log: Update __VERSION__ to remove the hardcoded 4.2.1 version Summary: Just like in https://reviews.llvm.org/D56803 for -dumpversion Reviewers: rnk Reviewed By: rnk

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

This revision was automatically updated to reflect the committed changes. Closed by commit rL366091: Update __VERSION__ to remove the hardcoded 4.2.1 version (authored by sylvestre, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANG

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

scanon requested changes to this revision. scanon added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Sema/SemaChecking.cpp:11429 + S.Context.getFloatTypeSemantics(QualType(TargetBT, 0))); +TargetFloatValue.convertFromAPInt

[PATCH] D64762: [AST] Treat semantic form of InitListExpr as implicit code in traversals

ilya-biryukov created this revision. ilya-biryukov added a reviewer: gribozavr. Herald added a subscriber: kadircet. Herald added a project: clang. In particular, do not traverse the semantic form shouldVisitImplicitCode() returns false. This simplifies the common case of traversals, avoiding the

[PATCH] D64672: [X86] Prevent passing vectors of __int128 as in llvm IR

wristow added a comment. > Do we need to keep the old behavior on platforms where clang is the de facto > compiler? I know we (PlayStation) will want to keep the old behavior. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64672/new/ https://reviews.llvm.org/D64672 _

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

SureYeaah updated this revision to Diff 209922. SureYeaah added a comment. Added fix for selecting the callExpr of a MemberExpr/Function DeclRefExpr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64717/new/ https://reviews.llvm.org/D64717 Files:

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

manojgupta added a comment. @dankm are you still working on this patch? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49466/new/ https://reviews.llvm.org/D49466 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64744: Loop #pragma tail_predicate

Meinersbur added a comment. IMHO, this loops like an option of a particular transformation, not an independent pragma. E.g. #pragma clang loop vectorize(enable) vectorize_remainder(predicated) There could be multiple choices for how to execute remainder iterations, e.g. instead of an epilogu

[PATCH] D64232: [analyzer] Prune calls to functions with linear CFGs that return a non-zero constrained value

Szelethus marked 2 inline comments as done. Szelethus added inline comments. Comment at: clang/test/Analysis/track-control-dependency-conditions.cpp:185 return true; return coin(); // tracking-note{{Returning value}} } NoQ wrote: > Szelethus wrote: > > T

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

MyDeveloperDay added a comment. I appreciate what you've done to make this patch less duplicated code..but now you've almost got to the point where being able to control it all via configuration. I'm with @rdwampler I think you should be able to extend the include categories...and then this be

[PATCH] D64742: Allow using -ftrivial-auto-var-init=zero in C mode without extra flags

jfb added a comment. A lots of folks from the original discussion insisted on this as a compromise. I'd like to make sure they see and approve of this, they might have requests for e.g. specific performance numbers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D63062: [clang-format] Added New Style Rule: BitFieldDeclarationsOnePerLine

MyDeveloperDay added inline comments. Comment at: unittests/Format/FormatTest.cpp:3671 + ); +} MyDeveloperDay wrote: > please add a test with comments (it will get logged) > > > ``` > unsigned int baz : 11, /*motor control flags*/ > add

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

ziangwan updated this revision to Diff 209928. ziangwan marked an inline comment as done. ziangwan edited the summary of this revision. ziangwan added a comment. Update diff. 1. Adopt CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64666/new/ https://reviews.llvm.org/D64666 Files: cla

[PATCH] D63062: [clang-format] Added New Style Rule: BitFieldDeclarationsOnePerLine

Manikishan marked 5 inline comments as done. Manikishan added inline comments. Comment at: unittests/Format/FormatTest.cpp:3671 + ); +} MyDeveloperDay wrote: > MyDeveloperDay wrote: > > please add a test with comments (it will get logged) > > > > > > ``` >

[PATCH] D63062: [clang-format] Added New Style Rule: BitFieldDeclarationsOnePerLine

Manikishan marked an inline comment as done. Manikishan added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:2921 + Right.is(tok::identifier) && (Right.Next->is(tok::colon))) + return true; if (Right.NewlinesBefore > 1 && Style.MaxEmptyLinesToKeep > 0) --

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

Manikishan updated this revision to Diff 209933. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64695/new/ https://reviews.llvm.org/D64695 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/Format.cpp unittests/Format/SortInclu

[PATCH] D61479: Finish "Adapt -fsanitize=function to SANITIZER_NON_UNIQUE_TYPEINFO"

vsk added a comment. Looks reasonable to me -- mind waiting for another +1 on this to be safe? @eugenis, any thoughts? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61479/new/ https://reviews.llvm.org/D61479 ___ cfe-commits mailing list cf

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

Manikishan added a comment. In D64695#1586157 , @MyDeveloperDay wrote: > I appreciate what you've done to make this patch less duplicated code..but > now you've almost got to the point where being able to control it all via > configuration. > > I'm with

[PATCH] D64765: [OPENMP]Add support for analysis of firstprivate variables.

ABataev created this revision. ABataev added a reviewer: NoQ. Herald added subscribers: jdoerfert, guansong. Herald added a project: clang. Firstprivate variables are the variables, for which the private copies must be created in the OpenMP regions and must be initialized with the original values.

[PATCH] D61479: Finish "Adapt -fsanitize=function to SANITIZER_NON_UNIQUE_TYPEINFO"

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM, but please update the summary: An alternative would be to disallow -fsanitize=function ... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61479/new/ https://reviews.llvm.org

[PATCH] D64765: [OPENMP]Add support for analysis of firstprivate variables.

ABataev marked 2 inline comments as done. ABataev added inline comments. Comment at: lib/Analysis/CFG.cpp:4749 // bidirectional, so we need to create temp vector. - for (Stmt *S : llvm::reverse(llvm::to_vector<8>( - OMPExecutableDirective::used_clauses_children(D->c

r366123 - ARM MTE stack sanitizer.

Author: eugenis Date: Mon Jul 15 13:02:23 2019 New Revision: 366123 URL: http://llvm.org/viewvc/llvm-project?rev=366123&view=rev Log: ARM MTE stack sanitizer. Add "memtag" sanitizer that detects and mitigates stack memory issues using armv8.5 Memory Tagging Extension. It is similar in principle

[PATCH] D64169: ARM MTE stack sanitizer.

This revision was automatically updated to reflect the committed changes. Closed by commit rL366123: ARM MTE stack sanitizer. (authored by eugenis, committed by ). Changed prior to commit: https://reviews.llvm.org/D64169?vs=209578&id=209936#toc Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D64274: [analyzer] VirtualCallChecker overhaul.

Szelethus added a comment. In D64274#1574086 , @NoQ wrote: > Hmm, wait, i don't really break backwards compatibility. Fridays... //Ackchyually//, it doesn't per se break anything, but will result in CodeChecker no longer enabling `optin.cplusplus.Virtu

[PATCH] D64274: [analyzer] VirtualCallChecker overhaul.

Szelethus added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:562 + HelpText<"Check virtual function calls during construction/destruction">, Documentation; Szelethus wrote: > Szelethus wrote: > > `Dependencies<[PureVi

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

Szelethus added a comment. I don't see obvious red flags strictly regarding the analyzer! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64454/new/ https://reviews.llvm.org/D64454 ___ cfe-commits mailin

[PATCH] D63279: [Analyzer] Unroll for-loops where the upper boundary is a variable with know value

Szelethus requested changes to this revision. Szelethus added inline comments. This revision now requires changes to proceed. Comment at: lib/StaticAnalyzer/Core/LoopUnrolling.cpp:214-216 + const Expr *BoundExpr = CondOp->getLHS()->IgnoreParenImpCasts(); + if (BoundExpr == Matc

[PATCH] D61879: WIP: Prototype of DSE optimizations for -ftrivial-auto-var-init

vitalybuka updated this revision to Diff 209942. vitalybuka added a comment. Rebase only Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61879/new/ https://reviews.llvm.org/D61879 Files: clang/test/CodeGenCXX/union-tbaa2.cpp llvm/include/llvm/In

[PATCH] D62525: [Analyzer] Add new visitor to the iterator checkers

Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:1099 reportOutOfRangeBug("Iterator decremented ahead of its valid range.", LHS, -C, N); +C, N, Pos, false); } `/*P

[PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

shafik added a comment. This LGTM now but I will wait for @teemperor to take a look at it. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp:620 if (predicate(decl->getKind())) { if (log) { I think a comment on the `predica

[PATCH] D64610: [clang] allow -fthinlto-index= without -x ir

inglorion updated this revision to Diff 209948. inglorion added a comment. Fix typo pointed out by MaskRay (thanks!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64610/new/ https://reviews.llvm.org/D64610 Files: clang/include/clang/Basic/Diagno

r366127 - [clang] allow -fthinlto-index= without -x ir

Author: inglorion Date: Mon Jul 15 13:51:44 2019 New Revision: 366127 URL: http://llvm.org/viewvc/llvm-project?rev=366127&view=rev Log: [clang] allow -fthinlto-index= without -x ir Summary: Previously, passing -fthinlto-index= to clang required that bitcode files be explicitly marked by -x ir. Th

[PATCH] D64610: [clang] allow -fthinlto-index= without -x ir

This revision was automatically updated to reflect the committed changes. inglorion marked an inline comment as done. Closed by commit rL366127: [clang] allow -fthinlto-index= without -x ir (authored by inglorion, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commit

[PATCH] D64537: [WebAssembly] Implement thread-local storage (local-exec model)

quantum updated this revision to Diff 209953. quantum marked 16 inline comments as done. quantum added a comment. Deal with review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64537/new/ https://reviews.llvm.org/D64537 Files: clang/in

[PATCH] D64537: [WebAssembly] Implement thread-local storage (local-exec model)

quantum added inline comments. Comment at: lld/test/wasm/data-segments.ll:7 ; RUN: wasm-ld -no-gc-sections --no-entry --shared-memory --max-memory=131072 %t.atomics.o -o %t.atomics.wasm -; RUN: obj2yaml %t.atomics.wasm | FileCheck %s --check-prefix ACTIVE +; RUN: obj2yaml %t.at

[PATCH] D64274: [analyzer] VirtualCallChecker overhaul.

Szelethus added a comment. Also, shouldn't we add this to the release notes? In general, it's be around time to sort it out (might do that myself before the new branch). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64274/new/ https://reviews.llvm.org/D64274

[PATCH] D64458: add -fthinlto-index= option to clang-cl

inglorion updated this revision to Diff 209954. inglorion added a comment. Simplified after rebasing on top of r366127. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64458/new/ https://reviews.llvm.org/D64458 Files: clang/include/clang/Driver/Op

[PATCH] D64772: Allow for vendor prefixes in a list test

lanza created this revision. Herald added subscribers: cfe-commits, fedor.sergeev. Herald added a project: clang. Preprocessor/init.c contains a line that explicitly checks for the string __VERSION__ "Clang{{.*}} It's valid to have a toolchain configured to emit a vendor prefix before the word C

[PATCH] D64537: [WebAssembly] Implement thread-local storage (local-exec model)

quantum updated this revision to Diff 209966. quantum added a comment. Fix duplicate end function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64537/new/ https://reviews.llvm.org/D64537 Files: clang/include/clang/Basic/BuiltinsWebAssembly.def

[PATCH] D64458: add -fthinlto-index= option to clang-cl

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm too, since now this is just whitelisting a clang flag for clang-cl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64458/new/ https://reviews.llvm

r366137 - [DirectoryWatcher][NFC][test] Add typedef for enum

Author: jkorous Date: Mon Jul 15 15:11:28 2019 New Revision: 366137 URL: http://llvm.org/viewvc/llvm-project?rev=366137&view=rev Log: [DirectoryWatcher][NFC][test] Add typedef for enum Modified: cfe/trunk/unittests/DirectoryWatcher/DirectoryWatcherTest.cpp Modified: cfe/trunk/unittests/Direc

r366138 - [DirectoryWatcher][test] Relax test assumptions

Author: jkorous Date: Mon Jul 15 15:11:51 2019 New Revision: 366138 URL: http://llvm.org/viewvc/llvm-project?rev=366138&view=rev Log: [DirectoryWatcher][test] Relax test assumptions Workaround for FSEvents sometimes sending notifications for events that happened before DirectoryWatcher was create

[PATCH] D64775: [Format/ObjC] Avoid breaking between unary operators and ObjC method invocations

benhamilton created this revision. benhamilton added reviewers: krasimir, djasper, sammccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. Test Plan: New tests added. Ran tests with: % ninja FormatTests && ./tools/clang/unittests/Format/FormatTests Confirmed tests

[PATCH] D64458: add -fthinlto-index= option to clang-cl

pcc added a comment. I think it's a little unfortunate that we're continuing to go down the road of letting users pass more flags to the ThinLTO backend action, but I won't stand in the way here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64458

[PATCH] D64537: [WebAssembly] Implement thread-local storage (local-exec model)

dschuff added a comment. The `offset` field of a segment can be a constant expression which can be a `global.get` of an imported global. So we could have an imported global `__tls_base` which is different for

[PATCH] D56353: Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer' with '-mframe-pointer'

ychen marked an inline comment as done and an inline comment as not done. ychen added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:845 + if (Args.hasArg(OPT_pg)) +Opts.setFramePointer(CodeGenOptions::FP_All); + MaskRay wrote: > I gu

[PATCH] D64537: [WebAssembly] Implement thread-local storage (local-exec model)

dschuff added a comment. Another high-level question (based just on reading the CL description): The TLS-size intrinsic is per-function, does that mean that the tls-init function is called for every function? are there just multiple TLS sections per object file? Repository: rG LLVM Github M

[PATCH] D56353: Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer' with '-mframe-pointer'

ychen updated this revision to Diff 209973. ychen marked an inline comment as not done. ychen edited the summary of this revision. ychen added a comment. - Make `FramePointerKind` enum class. - Replace two if-else-if blocks to switch statements. Repository: rG LLVM Github Monorepo CHANGES SIN

r366141 - [clang-fuzzer] Remove 'setUseOrcMCJITReplacement(false)' call.

Author: lhames Date: Mon Jul 15 15:27:57 2019 New Revision: 366141 URL: http://llvm.org/viewvc/llvm-project?rev=366141&view=rev Log: [clang-fuzzer] Remove 'setUseOrcMCJITReplacement(false)' call. The default value for this option (UseMCJITReplacement) is already false, and OrcMCJITReplacement is

r366143 - [OpenCL] Make TableGen'd builtin tables and helper functions static

Author: tstellar Date: Mon Jul 15 15:34:19 2019 New Revision: 366143 URL: http://llvm.org/viewvc/llvm-project?rev=366143&view=rev Log: [OpenCL] Make TableGen'd builtin tables and helper functions static Reviewers: Pierre, Anastasia Reviewed By: Anastasia Subscribers: yaxunl, cfe-commits Tags:

[PATCH] D64608: [OpenCL] Make TableGen'd builtin tables and helper functions static

This revision was automatically updated to reflect the committed changes. Closed by commit rL366143: [OpenCL] Make TableGen'd builtin tables and helper functions static (authored by tstellar, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to c

[PATCH] D64537: [WebAssembly] Implement thread-local storage (local-exec model)

quantum added a comment. In D64537#1586577 , @dschuff wrote: > Another high-level question (based just on reading the CL description): The > TLS-size intrinsic is per-function, does that mean that the tls-init function > is called for every function? are

r366146 - add -fthinlto-index= option to clang-cl

Author: inglorion Date: Mon Jul 15 15:50:04 2019 New Revision: 366146 URL: http://llvm.org/viewvc/llvm-project?rev=366146&view=rev Log: add -fthinlto-index= option to clang-cl Summary: This adds a -fthinlto-index= option to clang-cl, which allows it to be used to drive ThinLTO backend passes. Thi

[PATCH] D64458: add -fthinlto-index= option to clang-cl

This revision was automatically updated to reflect the committed changes. Closed by commit rL366146: add -fthinlto-index= option to clang-cl (authored by inglorion, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.ll

[PATCH] D64083: [OpenCL][Sema] Improve address space support for blocks

rjmccall added a comment. Sounds good. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64083/new/ https://reviews.llvm.org/D64083 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[PATCH] D62584: [OpenCL][PR42033] Deducing addr space with template parameter types

rjmccall added a comment. In D62584#1585091 , @Anastasia wrote: > In D62584#1583340 , @rjmccall wrote: > > > Oh, yes, it definitely can't be done to class types. I suppose we should > > just forget about it. > > >

[PATCH] D61838: [Sema] Suppress additional warnings for C's zero initializer

Lekensteyn added a comment. @al3xtjames I was about to commit this but noticed that some others check whether `getInit(0)` is NULL or not before proceeding. Should that be done here as well? If not, why? See for example "Harden InitListExpr::isStringLiteralInit() against getInit() returning nu

r366152 - [DirectoryWatcher][linux] Fix for older kernels

Author: jkorous Date: Mon Jul 15 16:14:00 2019 New Revision: 366152 URL: http://llvm.org/viewvc/llvm-project?rev=366152&view=rev Log: [DirectoryWatcher][linux] Fix for older kernels IN_EXCL_UNLINK exists since Linux 2.6.36 Differential Revision: https://reviews.llvm.org/D64764 Modified: cfe

r366153 - Revert "[NewPM] Port Sancov"

Author: leonardchan Date: Mon Jul 15 16:18:31 2019 New Revision: 366153 URL: http://llvm.org/viewvc/llvm-project?rev=366153&view=rev Log: Revert "[NewPM] Port Sancov" This reverts commit 5652f35817f07b16f8b3856d594cc42f4d7ee29c. Removed: cfe/trunk/test/CodeGen/sancov-new-pm.c Modified: c

[PATCH] D64762: [AST] Treat semantic form of InitListExpr as implicit code in traversals

gribozavr added a comment. Please add tests to `llvm/tools/clang/unittests/Tooling/RecursiveASTVisitorTests/`. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:2332 S->isSemanticForm() ? S->getSyntacticForm() : S, Queue)); TRY_TO(TraverseSynOrSemInitListExpr

[PATCH] D63961: [clangd][xpc] pass the LSP value using data instead of string

jkorous added a comment. I'd add a test with non-empty non-LSP dictionary to specifically test that we're ignoring the content. I like const-correctness but that's up to you. Otherwise LGTM. Comment at: clang-tools-extra/clangd/unittests/xpc/ConversionTests.cpp:34 +TEST(JsonX

[PATCH] D64772: Allow for vendor prefixes in a list test

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Yeah, that makes sense, the common path uses `{{.*}}` as the value itself is uninteresting. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64772/new/ https

[PATCH] D61838: [Sema] Suppress additional warnings for C's zero initializer

al3xtjames updated this revision to Diff 209994. al3xtjames marked an inline comment as done. al3xtjames added a comment. Added null check for `getInit(0)` Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61838/new/ https://reviews.llvm.org/D61838 Files: clang/li

r366155 - Temporarily Revert "fix unnamed fiefield issue and add tests for __builtin_preserve_access_index intrinsic"

Author: echristo Date: Mon Jul 15 16:49:31 2019 New Revision: 366155 URL: http://llvm.org/viewvc/llvm-project?rev=366155&view=rev Log: Temporarily Revert "fix unnamed fiefield issue and add tests for __builtin_preserve_access_index intrinsic" The commit had tests that would only work with names

[PATCH] D64776: [WebAssembly] Compile all TLS on Emscripten as local-exec

quantum updated this revision to Diff 209997. quantum added a comment. Undo compressing the previous diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64776/new/ https://reviews.llvm.org/D64776 Files: llvm/lib/Target/WebAssembly/WebAssemblyISe

Re: r366076 - fix unnamed fiefield issue and add tests for __builtin_preserve_access_index intrinsic

Just wanted to let you know I've temporarily reverted this here: echristo@jhereg ~/s/llvm-project> git llvm push Pushing 1 commit: ba7decf8c91 Temporarily Revert "fix unnamed fiefield issue and add tests for __builtin_preserve_access_index intrinsic" Sendingcfe/trunk/lib/CodeGen/CGExpr.c

[PATCH] D64776: [WebAssembly] Compile all TLS on Emscripten as local-exec

quantum updated this revision to Diff 209996. quantum added a comment. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. Change to use TODO instead of XXX Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64776/new/ https://rev

[PATCH] D64780: Disallow most calling convention attributes on PS4.

Sunil_Srivastava created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We wish to disable most calling convention attributes for PS4, allowing just cdecl (and the equivalent sysv_abi on PS4), which are default. Repository: rC Clang https://reviews.llvm

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 8PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r366157 - Temporarily revert "add -fthinlto-index= option to clang-cl"

Author: echristo Date: Mon Jul 15 17:02:40 2019 New Revision: 366157 URL: http://llvm.org/viewvc/llvm-project?rev=366157&view=rev Log: Temporarily revert "add -fthinlto-index= option to clang-cl" This is causing testsuite failures on (at least) darwin release+asserts. This reverts commit r366146

Re: r366146 - add -fthinlto-index= option to clang-cl

Hi Bob, I've temporarily reverted this here: echristo@jhereg ~/s/llvm-project> git llvm push Pushing 1 commit: 1dbd2f85903 Temporarily revert "add -fthinlto-index= option to clang-cl" Sendingcfe/trunk/include/clang/Driver/Options.td Deleting cfe/trunk/test/Driver/cl-thinlto-backen

[PATCH] D61838: [Sema] Suppress additional warnings for C's zero initializer

Lekensteyn accepted this revision. Lekensteyn added a comment. Thanks, I'll push once the build and test pass. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61838/new/ https://reviews.llvm.org/D61838 ___ cfe-commits

Re: r366076 - fix unnamed fiefield issue and add tests for __builtin_preserve_access_index intrinsic

HI, Eric, No problem! I just tried the following cmake (removing -DLLVM_ENABLE_ASSERTIONS=ON which is used in my previous build) cmake -G "Unix Makefiles" -DLLVM_TARGETS_TO_BUILD="BPF;X86" \ -DCMAKE_C_COMPILER=/llvm8/bin/clang \ -DCMAKE_CXX_COMPILER=/llvm8/bin/clang++ \ -DLLVM_TEMPO

Re: r366076 - fix unnamed fiefield issue and add tests for __builtin_preserve_access_index intrinsic

I'm going to cheat and make Nick do it :) -eric On Mon, Jul 15, 2019 at 5:12 PM Yonghong Song wrote: > > HI, Eric, > > No problem! > > I just tried the following cmake (removing -DLLVM_ENABLE_ASSERTIONS=ON which > is used in my previous build) > > cmake -G "Unix Makefiles" -DLLVM_TARGETS_TO_BUI

[PATCH] D64780: Disallow most calling convention attributes on PS4.

probinson added reviewers: rnk, rjmccall. probinson added a comment. This has my blessing as PS4 code owner, but I'd like other eyes on it with respect to how we've gone about it. + rnk, rjmccall as the most likely suspects. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D64772: Allow for vendor prefixes in a list test

lanza updated this revision to Diff 210004. lanza added a comment. rebase Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64772/new/ https://reviews.llvm.org/D64772 Files: test/Preprocessor/init.c Index: test/Preprocessor/init.c ===

[PATCH] D64772: Allow for vendor prefixes in a list test

This revision was automatically updated to reflect the committed changes. Closed by commit rL366159: Allow for vendor prefixes in a list test (authored by lanza, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D64537: [WebAssembly] Implement thread-local storage (local-exec model)

aheejin added a comment. Where should we call `__wasm_init_tls`, in case within a library? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64537/new/ https://reviews.llvm.org/D64537 ___ cfe-commits maili

r366163 - [Sema] Suppress additional warnings for C's zero initializer

Author: lekensteyn Date: Mon Jul 15 18:13:36 2019 New Revision: 366163 URL: http://llvm.org/viewvc/llvm-project?rev=366163&view=rev Log: [Sema] Suppress additional warnings for C's zero initializer Summary: D28148 relaxed some checks for assigning { 0 } to a structure for all C standards, but it

[PATCH] D61838: [Sema] Suppress additional warnings for C's zero initializer

This revision was automatically updated to reflect the committed changes. Closed by commit rL366163: [Sema] Suppress additional warnings for C's zero initializer (authored by Lekensteyn, committed by ). Herald added a project: LLVM. Changed prior to commit: https://reviews.llvm.org/D61838?vs=20

[PATCH] D64537: [WebAssembly] Implement thread-local storage (local-exec model)

quantum added a comment. In D64537#1586809 , @aheejin wrote: > Where should we call `__wasm_init_tls`, in case within a library? Dynamic libraries are not supported by the local-exec TLS model. Support will be implemented later. The idea is that we'll h

<    1   2   3   >