[PATCH] D64564: Loop pragma parsing. NFC.

SjoerdMeijer marked an inline comment as done. SjoerdMeijer added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:1015 + .Default(""); + assert(Str.size() && "Unexpected pragma name"); + return Str; I guess this does behave slightly d

[clang-tools-extra] r365773 - [clangd] Add priorities to background index queue, extract to separate class

Author: sammccall Date: Thu Jul 11 06:34:38 2019 New Revision: 365773 URL: http://llvm.org/viewvc/llvm-project?rev=365773&view=rev Log: [clangd] Add priorities to background index queue, extract to separate class Reviewers: kadircet Subscribers: mgorny, ilya-biryukov, MaskRay, jkorous, arphaman,

[PATCH] D64504: Various minor tweaks to CLCompatOptions.td

thakis closed this revision. thakis added a comment. r365721 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64504/new/ https://reviews.llvm.org/D64504 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D64400: [OpenCL][PR42390] Deduce addr space for templ specialization

Anastasia updated this revision to Diff 209205. Anastasia added a comment. - Moved addr space inference of pointee type into template instantiation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64400/new/ https://reviews.llvm.org/D64400 Files: lib/Sema/TreeTransform.h test/SemaOpe

[clang-tools-extra] r365776 - [clangd][QueryDriver] Use language from underlying database if possible

Author: kadircet Date: Thu Jul 11 06:47:46 2019 New Revision: 365776 URL: http://llvm.org/viewvc/llvm-project?rev=365776&view=rev Log: [clangd][QueryDriver] Use language from underlying database if possible Reviewers: sammccall Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, cfe-commits

[PATCH] D64565: [clangd] Don't run the prepare for tweaks that are disabled.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Previously, we ran the prepare, even for the tweaks that are disabled. Repository: rG LLVM Github Monorepo https://re

[PATCH] D64489: [clangd][QueryDriver] Use language from underlying database if possible

This revision was automatically updated to reflect the committed changes. Closed by commit rL365776: [clangd][QueryDriver] Use language from underlying database if possible (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

r365777 - Added mapping for pointers captured in Lambdas in OpenMP target regions,

Author: abataev Date: Thu Jul 11 06:54:26 2019 New Revision: 365777 URL: http://llvm.org/viewvc/llvm-project?rev=365777&view=rev Log: Added mapping for pointers captured in Lambdas in OpenMP target regions, by David Truby. Summary: This adds a zero length array section mapping for each pointer ca

[PATCH] D64400: [OpenCL][PR42390] Deduce addr space for templ specialization

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: lib/Sema/SemaType.cpp:7421 + // - template specialization as addr space in template argument doesn't + // affect specialization. + (T->isDependentType() && (!T->isPointerType

[PATCH] D64558: Added mapping for pointers captured in Lambdas in OpenMP target regions

This revision was automatically updated to reflect the committed changes. Closed by commit rL365777: Added mapping for pointers captured in Lambdas in OpenMP target regions, (authored by ABataev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[clang-tools-extra] r365778 - [clangd] Remove an extra ";", NFC

Author: hokein Date: Thu Jul 11 06:58:56 2019 New Revision: 365778 URL: http://llvm.org/viewvc/llvm-project?rev=365778&view=rev Log: [clangd] Remove an extra ";", NFC Modified: clang-tools-extra/trunk/clangd/index/Background.h Modified: clang-tools-extra/trunk/clangd/index/Background.h URL:

[PATCH] D64562: [clangd] Fixed toHalfOpenFileRange

sammccall added a comment. Thanks for fixing this, this stuff is such a tangled web. Logic seems great, so just style/test nits. Comment at: clang-tools-extra/clangd/SourceCode.cpp:261 + if (!Lexer::getRawToken(Loc, TheTok, SM, LangOpts)) { +if (TheTok.is(tok::greatergrea

[PATCH] D64562: [clangd] Fixed toHalfOpenFileRange

kadircet added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:252 -llvm::Optional toHalfOpenFileRange(const SourceManager &Mgr, +// FIXME: Here we check whether the token at the location is a greatergreater +// (>>) token and consider it as a single greate

[PATCH] D64083: [OpenCL][Sema] Improve address space support for blocks

Anastasia added inline comments. Comment at: cfe/trunk/lib/Sema/SemaExprCXX.cpp:4229 +LangAS AddrSpaceR = +RHSType->getAs()->getPointeeType().getAddressSpace(); +CastKind Kind = rjmccall wrote: > Anastasia wrote: > > rjmccall wrote: > > > All of t

[PATCH] D64565: [clangd] Don't run the prepare for tweaks that are disabled.

hokein updated this revision to Diff 209216. hokein added a comment. Simplify the code further based on offline discussion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64565/new/ https://reviews.llvm.org/D64565 Files: clang-tools-extra/clangd/

[PATCH] D64565: [clangd] Don't run the prepare for tweaks that are disabled.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.h:136 -/// Returns true if the StringRef is a tweak that should be enabled -std::function TweakFilter = [](llvm::StringRef TweakToSearch) {return true;}; +/// Returns true if the

r365786 - [OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP programs.

Author: abataev Date: Thu Jul 11 07:54:17 2019 New Revision: 365786 URL: http://llvm.org/viewvc/llvm-project?rev=365786&view=rev Log: [OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP programs. Summary: Some OpenMP clauses rely on the values of the variables. If the variab

[PATCH] D64356: [OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP programs.

This revision was automatically updated to reflect the committed changes. Closed by commit rL365786: [OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP… (authored by ABataev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D64565: [clangd] Don't run the prepare for tweaks that are disabled.

hokein updated this revision to Diff 209223. hokein marked 3 inline comments as done. hokein added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64565/new/ https://reviews.llvm.org/D64565 Files: clang-tools-extra/cla

[PATCH] D64565: [clangd] Don't run the prepare for tweaks that are disabled.

hokein added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.h:136 -/// Returns true if the StringRef is a tweak that should be enabled -std::function TweakFilter = [](llvm::StringRef TweakToSearch) {return true;}; +/// Returns true if the String

[PATCH] D64475: [clangd] Duplicate lines of semantic highlightings sent removed.

jvikstrom updated this revision to Diff 209225. jvikstrom marked 5 inline comments as done. jvikstrom added a comment. Made diffing function shorter, added multiple previous highlighting entries. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64475/n

[PATCH] D64543: [Docs] Add standardized header links to analyzer doc

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. Woohoo! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64543/new/ https://reviews.llvm.org/D64543 __

[PATCH] D64475: [clangd] Duplicate lines of semantic highlightings sent removed.

jvikstrom updated this revision to Diff 209228. jvikstrom added a comment. Removed unused code snippets. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64475/new/ https://reviews.llvm.org/D64475 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[PATCH] D64537: [WebAssembly] Implement thread-local storage for non-PIC cases

aheejin added a comment. Nice! Then where should we call `__wasm_init_tls`, in case within a library? Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:33 +// Thread-local storage +TARGET_BUILTIN(__builtin_wasm_tls_size, "z", "nc", "bulk-memory") +

[PATCH] D64475: [clangd] Duplicate lines of semantic highlightings sent removed.

jvikstrom marked an inline comment as done. jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:172 + const HighlightingToken &Rhs) { + return Lhs.R.start.line == Rhs.R.start.line + ? Lhs.R.start

r365789 - Fix a few 'no newline at end of file' warnings that Xcode emits

Author: nico Date: Thu Jul 11 08:26:45 2019 New Revision: 365789 URL: http://llvm.org/viewvc/llvm-project?rev=365789&view=rev Log: Fix a few 'no newline at end of file' warnings that Xcode emits (Xcode even has a snazzy "Fix" button, but clicking that inserts two newlines. So close!) Modified:

[PATCH] D64329: [Clangd] Fixed SelectionTree bug for macros

SureYeaah updated this revision to Diff 209229. SureYeaah added a comment. Changed a breaking test in ExtractVariable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64329/new/ https://reviews.llvm.org/D64329 Files: clang-tools-extra/clangd/Select

[PATCH] D64543: [Docs] Add standardized header links to analyzer doc

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Do you need someone to commit on your behalf? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64543/new/ https://reviews.llvm.org/D64543 ___

[PATCH] D64539: [clang-doc] Add stylesheet to generated html docs

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:242 + // Generate css stylesheet + if (Format == "html") { On second thought, can you create a virtual method to the Generator along the lines of `Generator::cr

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

aaron.ballman added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/gen-static-analyzer-docs.py:2-3 +""" +Generates documentation based off the available static analyzers checks +References Checkers.td to determine what checks exist +""" Ad

[PATCH] D62855: [clangd] Implementation of auto type expansion.

kuhnel updated this revision to Diff 209234. kuhnel marked 3 inline comments as done. kuhnel added a comment. pair programming with Sam, fixed final issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62855/new/ https://reviews.llvm.org/D62855

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1948 +def RequiresDesignator : InheritableAttr { + let Spellings = [Clang<"requires_designator">]; + let Subjects = SubjectList<[Record]>; Hmm, after making this suggestion, I no

[clang-tools-extra] r365792 - [clangd] Implementation of auto type expansion.

Author: sammccall Date: Thu Jul 11 09:04:18 2019 New Revision: 365792 URL: http://llvm.org/viewvc/llvm-project?rev=365792&view=rev Log: [clangd] Implementation of auto type expansion. Add a tweak for clangd to replace an auto keyword to the deduced type. This way a user can declare something wit

[PATCH] D64565: [clangd] Don't run the prepare for tweaks that are disabled.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/ClangdServer.h:138 +std::function TweakFilter = [](const Tweak &T) { + return true; // always enabled all tweaks. +

[PATCH] D62855: [clangd] Implementation of auto type expansion.

This revision was automatically updated to reflect the committed changes. Closed by commit rL365792: [clangd] Implementation of auto type expansion. (authored by sammccall, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://re

[PATCH] D64569: [OpenCL] Improve destructor support in C++ for OpenCL

mantognini created this revision. Herald added subscribers: cfe-commits, Anastasia, yaxunl. Herald added a project: clang. This patch does mainly three things: 1. It fixes a false positive error detection in Sema that is similar to D62156 . The error happens when

[clang-tools-extra] r365793 - [clangd] Consume llvm::Error in test after r365792

Author: sammccall Date: Thu Jul 11 09:22:50 2019 New Revision: 365793 URL: http://llvm.org/viewvc/llvm-project?rev=365793&view=rev Log: [clangd] Consume llvm::Error in test after r365792 Modified: clang-tools-extra/trunk/clangd/unittests/XRefsTests.cpp Modified: clang-tools-extra/trunk/clang

[clang-tools-extra] r365794 - [clangd] Avoid template in Task constructor, hopefully fix MSVC build

Author: sammccall Date: Thu Jul 11 09:26:53 2019 New Revision: 365794 URL: http://llvm.org/viewvc/llvm-project?rev=365794&view=rev Log: [clangd] Avoid template in Task constructor, hopefully fix MSVC build Modified: clang-tools-extra/trunk/clangd/index/Background.h Modified: clang-tools-extr

[PATCH] D64294: [Driver] Consolidate shouldUseFramePointer() and shouldUseLeafFramePointer()

ychen accepted this revision. ychen added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64294/new/ https://reviews.llvm.org/D64294 ___ cfe-commits mail

[PATCH] D64569: [OpenCL] Improve destructor support in C++ for OpenCL

mantognini added reviewers: Anastasia, rjmccall. mantognini marked 6 inline comments as done. mantognini added inline comments. Comment at: clang/lib/CodeGen/CGClass.cpp:2016 CGF.EmitCXXDestructorCall(dtor, Dtor_Complete, /*for vbase*/ false, -/*Del

[PATCH] D64564: Loop pragma parsing. NFC.

Meinersbur added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:1009 static std::string PragmaLoopHintString(Token PragmaName, Token Option) { - std::string PragmaString; - if (PragmaName.getIdentifierInfo()->getName() == "loop") { -PragmaString = "clang loop

[PATCH] D64573: [Syntax] Allow to mutate syntax trees

ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added a subscriber: mgorny. Herald added a project: clang. ilya-biryukov added a parent revision: D63835: [Syntax] Add nodes for most common statements. This patch adds facilities to mutate the syntax trees and

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

compnerd added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1948 +def RequiresDesignator : InheritableAttr { + let Spellings = [Clang<"requires_designator">]; + let Subjects = SubjectList<[Record]>; aaron.ballman wrote: > Hmm, after making thi

r365797 - [Docs] Add standardized header links to analyzer doc

Author: nathan-huckleberry Date: Thu Jul 11 10:12:05 2019 New Revision: 365797 URL: http://llvm.org/viewvc/llvm-project?rev=365797&view=rev Log: [Docs] Add standardized header links to analyzer doc Summary: Header links should have some standard form so clang tidy docs can easily reference them.

[PATCH] D64543: [Docs] Add standardized header links to analyzer doc

This revision was automatically updated to reflect the committed changes. Closed by commit rL365797: [Docs] Add standardized header links to analyzer doc (authored by Nathan-Huckleberry, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

emmettneyman updated this revision to Diff 209256. emmettneyman added a comment. Small changes: adding `auto` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64380/new/ https://reviews.llvm.org/D64380 Files: clang/include/clang/Basic/Attr.td cla

r365798 - [CodeGen] NVPTX: Switch from atomic.load.add.f32 to atomicrmw fadd

Author: d0k Date: Thu Jul 11 10:44:11 2019 New Revision: 365798 URL: http://llvm.org/viewvc/llvm-project?rev=365798&view=rev Log: [CodeGen] NVPTX: Switch from atomic.load.add.f32 to atomicrmw fadd Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp cfe/trunk/test/CodeGen/builtins-nvptx-ptx50.cu

r365799 - [HIP] Add GPU arch gfx1010, gfx1011, and gfx1012

Author: yaxunl Date: Thu Jul 11 10:50:09 2019 New Revision: 365799 URL: http://llvm.org/viewvc/llvm-project?rev=365799&view=rev Log: [HIP] Add GPU arch gfx1010, gfx1011, and gfx1012 Differential Revision: https://reviews.llvm.org/D64364 Modified: cfe/trunk/include/clang/Basic/Cuda.h cfe/

[PATCH] D64537: [WebAssembly] Implement thread-local storage for non-PIC cases

quantum updated this revision to Diff 209258. quantum added a comment. Add error for non-local-exec TLS models. Fix unit tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64537/new/ https://reviews.llvm.org/D64537 Files: clang/include/clang/B

[PATCH] D62413: [OpenCL][PR41727] Prevent ICE on global dtors

rjmccall added inline comments. Comment at: lib/CodeGen/CGDeclCXX.cpp:132 + Argument = CGM.getTargetCodeGenInfo().performAddrSpaceCast( + CGM, Addr.getPointer(), SrcAS, LangAS::opencl_global, DestTy); Anastasia wrote: > rjmccall wrote: > > rjmccal

[PATCH] D64364: [HIP] Add GPU arch gfx1010, gfx1011, and gfx1012

This revision was automatically updated to reflect the committed changes. Closed by commit rL365799: [HIP] Add GPU arch gfx1010, gfx1011, and gfx1012 (authored by yaxunl, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revi

[PATCH] D61479: Finish "Adapt -fsanitize=function to SANITIZER_NON_UNIQUE_TYPEINFO"

vsk added a comment. This looks reasonable to me. I'd prefer to disallow -fsanitize=function in combination with -fsanitize-minimal-runtime, as I'm not sure it's appropriate for the minimal runtime to handle SANITIZER_NON_UNIQUE_TYPEINFO incorrectly. If this has already been discussed elsewhere

<    1   2   3