[PATCH] D63082: [Diagnostics] Added support for -Wint-in-bool-context

xbolva00 added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63082/new/ https://reviews.llvm.org/D63082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D64289: [OpenMP] Fix 128-bit long double support on target

ABataev added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8515 "%0 is not supported on this target">; +def err_type_not_equivalent : Error< + "%0 is not equivalent between host and target">; No, this message shall tell someth

[PATCH] D64289: [OpenMP] Fix 128-bit long double support on target

jdenny added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1596 << Ty << E->getSourceRange(); + if (Ty->isRealFloatingType()) { +llvm::APFloatBase::Semantics Sem = llvm::APFloatBase::SemanticsToEnum( ABataev wrote: > Why do we need all

[PATCH] D64289: [OpenMP] Fix 128-bit long double support on target

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1596 << Ty << E->getSourceRange(); + if (Ty->isRealFloatingType()) { +llvm::APFloatBase::Semantics Sem = llvm::APFloatBase::SemanticsToEnum( jdenny wrote: > ABataev wrote: > >

[PATCH] D64289: [OpenMP] Fix 128-bit long double support on target

jdenny added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1596 << Ty << E->getSourceRange(); + if (Ty->isRealFloatingType()) { +llvm::APFloatBase::Semantics Sem = llvm::APFloatBase::SemanticsToEnum( ABataev wrote: > jdenny wrote: > > A

[PATCH] D64289: [OpenMP] Fix 128-bit long double support on target

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1596 << Ty << E->getSourceRange(); + if (Ty->isRealFloatingType()) { +llvm::APFloatBase::Semantics Sem = llvm::APFloatBase::SemanticsToEnum( jdenny wrote: > ABataev wrote: > >

[PATCH] D64289: [OpenMP] Fix 128-bit long double support on target

jdenny added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1596 << Ty << E->getSourceRange(); + if (Ty->isRealFloatingType()) { +llvm::APFloatBase::Semantics Sem = llvm::APFloatBase::SemanticsToEnum( ABataev wrote: > jdenny wrote: > > A

[PATCH] D64289: [OpenMP] Fix 128-bit long double support on target

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1596 << Ty << E->getSourceRange(); + if (Ty->isRealFloatingType()) { +llvm::APFloatBase::Semantics Sem = llvm::APFloatBase::SemanticsToEnum( jdenny wrote: > ABataev wrote: > >

[PATCH] D64289: [OpenMP] Fix 128-bit long double support on target

jdenny added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1596 << Ty << E->getSourceRange(); + if (Ty->isRealFloatingType()) { +llvm::APFloatBase::Semantics Sem = llvm::APFloatBase::SemanticsToEnum( ABataev wrote: > jdenny wrote: > > A

[PATCH] D61467: [Rewrite] Extend to further accept CharSourceRange

thakis added inline comments. Comment at: cfe/trunk/unittests/Rewrite/CMakeLists.txt:12 clangRewrite + clangTooling ) This makes RewriteTests depend on clangTooling, and in follow-ups on clangFrontend and clangSerialization. Rewrite used to depend on basi

[PATCH] D64289: [OpenMP] Fix 128-bit long double support on target

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1596 << Ty << E->getSourceRange(); + if (Ty->isRealFloatingType()) { +llvm::APFloatBase::Semantics Sem = llvm::APFloatBase::SemanticsToEnum( jdenny wrote: > ABataev wrote: > >

[PATCH] D61467: [Rewrite] Extend to further accept CharSourceRange

jdenny added inline comments. Comment at: cfe/trunk/unittests/Rewrite/CMakeLists.txt:12 clangRewrite + clangTooling ) thakis wrote: > This makes RewriteTests depend on clangTooling, and in follow-ups on > clangFrontend and clangSerialization. Rewrite used

[PATCH] D64289: [OpenMP] Fix 128-bit long double support on target

jdenny abandoned this revision. jdenny added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1596 << Ty << E->getSourceRange(); + if (Ty->isRealFloatingType()) { +llvm::APFloatBase::Semantics Sem = llvm::APFloatBase::SemanticsToEnum( ABat

[PATCH] D64276: [ItaniumMangle] Replace useFloat128ManglingForLongDouble() with getManglingForLongDouble() and getManglingForFloat128()

MaskRay updated this revision to Diff 208294. MaskRay edited the summary of this revision. MaskRay removed a subscriber: wuzish. MaskRay added a comment. "U10__float128" -> "u9__ieee128" This is the new mangled type in gcc>8.1 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D64289: [OpenMP] Fix 128-bit long double support on target

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1596 << Ty << E->getSourceRange(); + if (Ty->isRealFloatingType()) { +llvm::APFloatBase::Semantics Sem = llvm::APFloatBase::SemanticsToEnum( jdenny wrote: > ABataev wrote: > >

[PATCH] D64289: [OpenMP] Fix 128-bit long double support on target

jdenny added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1596 << Ty << E->getSourceRange(); + if (Ty->isRealFloatingType()) { +llvm::APFloatBase::Semantics Sem = llvm::APFloatBase::SemanticsToEnum( ABataev wrote: > jdenny wrote: > > A

[PATCH] D63960: [C++20] Add consteval-specifique semantic

Tyker added a comment. ping @rsmith Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63960/new/ https://reviews.llvm.org/D63960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[PATCH] D64078: [ASTImporter] Fix structural ineq of lambdas with different sloc

a_sidorin added a comment. Hi Gabor, it is a nice design question if source locations can participate in structural match or not. The comparison tells us that the same code written in different files is not structurally equivalent and I cannot agree with it. They can be not the same, but their

[PATCH] D64075: [ASTImporter] Fix structural eq of lambdas

a_sidorin added a comment. Hi Gabor, The patch looks good, but it looks to me that it has a relation to https://reviews.llvm.org/D64078 that is kind of questionable to me. Let's delay landing this patch until the fix direction is clear. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D62484: [ASTImporter] Added visibility context check for EnumDecl.

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62484/new/ https://reviews.llvm.org/D62484 ___ cfe-com

[PATCH] D60461: [ASTImporter] Import TemplateParameterLists in function templates.

a_sidorin added a comment. Post-LGTM :) Comment at: lib/AST/ASTImporter.cpp:2789 + if (Num == 0) +return Error::success(); + SmallVector ToTPLists(Num); Please add a newline after return. Comment at: lib/AST/ASTImporter.cpp:2796 +el

[PATCH] D63894: [CXX] Exercise all paths through these tests

probinson added a comment. Ping. This is pretty straightforward, the only question is whether we want to preserve these older-dialect tests or rip them out. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63894/new/ https://reviews.llvm.org/D63894 _

[PATCH] D64301: Use `ln -n` to prevent forming a symlink cycle, instead of rm'ing the source

thakis created this revision. thakis added a reviewer: rnk. This is a better fix for the problem fixed in r334972. Also remove the rm'ing of the symlink destination that was there to clean up the bots -- it's over a year later, bots should be happy now. https://reviews.llvm.org/D64301 Files:

[clang-tools-extra] r365288 - [clangd] Encapsulate fields in dex token. NFC

Author: sammccall Date: Sun Jul 7 19:37:06 2019 New Revision: 365288 URL: http://llvm.org/viewvc/llvm-project?rev=365288&view=rev Log: [clangd] Encapsulate fields in dex token. NFC Modified: clang-tools-extra/trunk/clangd/index/dex/PostingList.h clang-tools-extra/trunk/clangd/index/dex/T

[clang-tools-extra] r365289 - [clangd] Avoid slow ostreams in URI conversion.

Author: sammccall Date: Sun Jul 7 19:46:21 2019 New Revision: 365289 URL: http://llvm.org/viewvc/llvm-project?rev=365289&view=rev Log: [clangd] Avoid slow ostreams in URI conversion. This speeds up some hot paths significantly (e.g. dex::generateProximityURIs by a third or so) Modified: cl

[PATCH] D64305: [clangd] Add path mappings functionality

wwagner19 created this revision. wwagner19 added reviewers: sammccall, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, mgorny. Herald added a project: clang. Add path mappings to clangd which translate file URIs on inbound and outbound LSP messages. Th

[PATCH] D64305: [clangd] Add path mappings functionality

wwagner19 marked 2 inline comments as done. wwagner19 added a comment. Herald added a subscriber: ormris. Hey, This is my first proposed change to LLVM, so sorry if I messed anything up. The proposed changes here follow from discussion on clangd-dev (from janruary

[PATCH] D63497: Add support for openSUSE RISC-V triple

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. Herald added a subscriber: lenary. LGTM, thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63497/new/ https://reviews.llvm.org/D63497

[PATCH] D64276: [ItaniumMangle] Refactor long double/__float128 mangling and fix the mangled code

MaskRay updated this revision to Diff 208313. MaskRay retitled this revision from "[ItaniumMangle] Replace useFloat128ManglingForLongDouble() with getManglingForLongDouble() and getManglingForFloat128()" to "[ItaniumMangle] Refactor long double/__float128 mangling and fix the mangled code". Mask

[PATCH] D64277: [X86][PowerPC] Support -mlong-double-128

MaskRay updated this revision to Diff 208314. MaskRay added a comment. Rebase Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64277/new/ https://reviews.llvm.org/D64277 Files: include/clang/Driver/Options.td lib/Basic/TargetInfo.cpp lib/Basic/Targets/PPC.cpp

[PATCH] D64305: [clangd] Add path mappings functionality

sammccall added a comment. Thanks for putting this together. Overall it looks pretty good! Main issues to address are: - file path handling should manage windows paths and have tests for this - the lit test can be simplified quite a lot I think Comment at: clang-tools-extra

[PATCH] D64283: [PowerPC] Support -mabi=ieeelongdouble and -mabi=ibmlongdouble

MaskRay updated this revision to Diff 208315. MaskRay edited the summary of this revision. MaskRay added a comment. Herald added subscribers: krytarowski, emaste. Update description. Fix the mangled code: U10__float128 -> u9__ieee128 Repository: rC Clang CHANGES SINCE LAST ACTION https://r

[PATCH] D64307: [clangd] Add a missing early return in getTypeHierarchy()

nridge created this revision. nridge added a reviewer: sammccall. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D64307 Files: clang-tools-extra/clangd/XR

[PATCH] D64308: [clangd] Implement typeHierarchy/resolve for subtypes

nridge created this revision. nridge added a reviewer: sammccall. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This allows the client to resolve subtypes one level at a time. For supertypes, this is not necessary, beca

[PATCH] D64308: [clangd] Implement typeHierarchy/resolve for subtypes

nridge added a comment. This was an oversight on my part: I forgot that, when we didn't implement typeHierarchy/resolve, it was only supertypes that didn't need it; subtypes do. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64308/new/ https://revi