[PATCH] D62830: [WebAssembly] Support Leak Sanitizer on Emscripten

2019-06-04 Thread Guanzhong Chen via Phabricator via cfe-commits
quantum added a comment. LSan is supposed to be linked in to replace some C library functions, and does not change the generated LLVM IR code, so there is nothing to actually test in LLVM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62830/new/

[PATCH] D62621: [LibTooling] Add insert/remove convenience functions for creating `ASTEdit`s.

2019-06-04 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel marked an inline comment as done. ymandel added a comment. Thanks for the review. In D62621#1528714 , @ilya-biryukov wrote: > Are there any corner cases with handling whitespace that we might want to > handle or document them if we don't handle

[PATCH] D62445: [test] Fix plugin tests

2019-06-04 Thread Nathan Chancellor via Phabricator via cfe-commits
nathanchance added inline comments. Comment at: cfe/trunk/lib/Analysis/plugins/CMakeLists.txt:1 +if(LLVM_ENABLE_PLUGINS) + add_subdirectory(SampleAnalyzer) I think this should have a dependency on `CLANG_ENABLE_STATIC_ANALYZER` like in `clang/test/CMakeLists.tx

[PATCH] D62445: [test] Fix plugin tests

2019-06-04 Thread Don Hinton via Phabricator via cfe-commits
hintonda marked an inline comment as done. hintonda added inline comments. Comment at: cfe/trunk/lib/Analysis/plugins/CMakeLists.txt:1 +if(LLVM_ENABLE_PLUGINS) + add_subdirectory(SampleAnalyzer) nathanchance wrote: > I think this should have a dependency on `CLA

[PATCH] D62873: Avoid building analyzer plugins if CLANG_ENABLE_STATIC_ANALYZER is OFF

2019-06-04 Thread Dimitry Andric via Phabricator via cfe-commits
dim created this revision. dim added reviewers: hintonda, dcoughlin, NoQ. Herald added subscribers: dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware, mgorny. Herald added a project: clang. Attempting to build clang with CLANG_ENABLE_STATIC_ANALYZER=OFF fails after rC362328

[PATCH] D48680: Add missing visibility annotation for __base

2019-06-04 Thread Peter Collingbourne via Phabricator via cfe-commits
pcc added a comment. Here's a standalone reproducer for the problem: $ cat exe.cpp #include std::function f(); int main() { f()(); } $ cat dso.cpp #include __attribute__((visibility("default"))) std::function f() { return [](){}; } $ ~/l3/ra-cmake/bin/clang+

[PATCH] D62873: Avoid building analyzer plugins if CLANG_ENABLE_STATIC_ANALYZER is OFF

2019-06-04 Thread Kristina Brooks via Phabricator via cfe-commits
kristina added a comment. Experienced the same, updated my test build configuration to always force `CLANG_ENABLE_STATIC_ANALYZER` to On when building with tests. Maybe it's worth adding a warning about when Clang tests are being built? Repository: rC Clang CHANGES SINCE LAST ACTION https

[PATCH] D62873: Avoid building analyzer plugins if CLANG_ENABLE_STATIC_ANALYZER is OFF

2019-06-04 Thread Nathan Chancellor via Phabricator via cfe-commits
nathanchance added a comment. Thanks for the quick fix, looks good to me! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62873/new/ https://reviews.llvm.org/D62873 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

r362545 - Introduce Value::stripPointerCastsSameRepresentation

2019-06-04 Thread Johannes Doerfert via cfe-commits
Author: jdoerfert Date: Tue Jun 4 13:21:46 2019 New Revision: 362545 URL: http://llvm.org/viewvc/llvm-project?rev=362545&view=rev Log: Introduce Value::stripPointerCastsSameRepresentation This patch allows current users of Value::stripPointerCasts() to force the result of the function to have th

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

2019-06-04 Thread David Goldman via Phabricator via cfe-commits
dgoldman updated this revision to Diff 203011. dgoldman added a comment. - Move if empty check back Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62648/new/ https://reviews.llvm.org/D62648 Files: lib/Sema/SemaExprCXX.cpp test/Sema/typo-correction-recursive.c

[PATCH] D60233: [clang-scan-deps] initial outline of the tool that runs preprocessor to find dependencies over a JSON compilation database

2019-06-04 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman updated this revision to Diff 203012. arphaman marked 7 inline comments as done. arphaman added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60233/new/ https://reviews.llvm.org/D60233 Files: clang/test/ClangScanDeps/Inputs/regular_cdb.jso

[PATCH] D62830: [WebAssembly] Support Leak Sanitizer on Emscripten

2019-06-04 Thread Heejin Ahn via Phabricator via cfe-commits
aheejin added a comment. I see. Do you want me to commit this, or you are gonna get a commit access? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62830/new/ https://reviews.llvm.org/D62830 ___ cfe-com

[PATCH] D62830: [WebAssembly] Support Leak Sanitizer on Emscripten

2019-06-04 Thread Guanzhong Chen via Phabricator via cfe-commits
quantum added a comment. It's not urgent, so I am willing to wait a day or two for commit access. If I still can't get access by then, I'll ask someone else to commit this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62830/new/ https://reviews.l

[PATCH] D60583: [AArch64] Implement Vector Funtion ABI name mangling.

2019-06-04 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert reopened this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Why/Where did we decide to clobber the attribute list with "non-existent function names"? This seems to me like an ad-hoc implementation of the RFC that is currently discussed but commi

[PATCH] D60583: [AArch64] Implement Vector Funtion ABI name mangling.

2019-06-04 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. In D60583#1529878 , @jdoerfert wrote: > Why/Where did we decide to clobber the attribute list with "non-existent > function names"? > > This seems to me like an ad-hoc implementation of the RFC that is currently > discussed but c

[PATCH] D60583: [AArch64] Implement Vector Funtion ABI name mangling.

2019-06-04 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. In D60583#1529882 , @ABataev wrote: > In D60583#1529878 , @jdoerfert wrote: > > > Why/Where did we decide to clobber the attribute list with "non-existent > > function names"? > > > > Thi

[PATCH] D60583: [AArch64] Implement Vector Funtion ABI name mangling.

2019-06-04 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. In D60583#1529885 , @jdoerfert wrote: > In D60583#1529882 , @ABataev wrote: > > > In D60583#1529878 , @jdoerfert > > wrote: > > > > > Why/Where did

[PATCH] D60583: [AArch64] Implement Vector Funtion ABI name mangling.

2019-06-04 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli added a comment. In D60583#1529878 , @jdoerfert wrote: > Why/Where did we decide to clobber the attribute list with "non-existent > function names"? > I don't think an attribute list like this: > `attributes #1 = { "_ZGVsM2v_foo" "_ZGVsM32v_

r362551 - Convert MemberExpr creation and serialization to work the same way as

2019-06-04 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Jun 4 14:29:28 2019 New Revision: 362551 URL: http://llvm.org/viewvc/llvm-project?rev=362551&view=rev Log: Convert MemberExpr creation and serialization to work the same way as most / all other Expr subclasses. Modified: cfe/trunk/include/clang/AST/Expr.h cfe/tru

[PATCH] D62623: Reduce memory consumption of coverage dumps

2019-06-04 Thread serge via Phabricator via cfe-commits
serge-sans-paille added inline comments. Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:1393 + size_t CoverageMappingSize = 0; + for (auto &S : CoverageMappings) { +CoverageMappingSize += S.size(); vsk wrote: > It doesn't look like the CoverageMapping

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

2019-06-04 Thread serge via Phabricator via cfe-commits
serge-sans-paille updated this revision to Diff 203029. serge-sans-paille added a comment. - make it possible for client code to speicify the registration function for new PM, thanks @philip.pfaffe for the hint. @Meinersbur this should be ok now. CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module.

2019-06-04 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr marked an inline comment as done. gribozavr added inline comments. Comment at: clang-tools-extra/test/clang-tidy/android-cloexec-pipe2.cpp:20 + pipe2(pipefd, O_NONBLOCK); + // CHECK-MESSAGES: :[[@LINE-1]]:27: warning: 'pipe2' should use O_CLOEXEC where possible [andr

r362555 - [Analysis] Only build Analysis plugins when CLANG_ENABLE_STATIC_ANALYZER is enabled.

2019-06-04 Thread Don Hinton via cfe-commits
Author: dhinton Date: Tue Jun 4 15:07:40 2019 New Revision: 362555 URL: http://llvm.org/viewvc/llvm-project?rev=362555&view=rev Log: [Analysis] Only build Analysis plugins when CLANG_ENABLE_STATIC_ANALYZER is enabled. Fixes bug introduced in r362328. Thanks to Nathan Chancellor for reporting t

[PATCH] D62445: [test] Fix plugin tests

2019-06-04 Thread Don Hinton via Phabricator via cfe-commits
hintonda marked an inline comment as done. hintonda added inline comments. Comment at: cfe/trunk/lib/Analysis/plugins/CMakeLists.txt:1 +if(LLVM_ENABLE_PLUGINS) + add_subdirectory(SampleAnalyzer) hintonda wrote: > nathanchance wrote: > > I think this should have

[PATCH] D62873: Avoid building analyzer plugins if CLANG_ENABLE_STATIC_ANALYZER is OFF

2019-06-04 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. In D62873#1529800 , @nathanchance wrote: > Thanks for the quick fix, looks good to me! Ah, sorry, just saw this. I just committed r362555 that addresses this. Repository: rC Clang CHANGES SINCE LAST ACTION https://revie

[Diffusion] rL358949: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

2019-06-04 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. /cfe/trunk/lib/Driver/ToolChains/PPCLinux.cpp:26 I'm not particularly concerned about the scoping of the work; however, the `ppc_wrappers` directory is not at all indicative of that scoping. It neither indicates the scope in terms of purpose (provid

[PATCH] D62623: Reduce memory consumption of coverage dumps

2019-06-04 Thread Vedant Kumar via Phabricator via cfe-commits
vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:1393 + size_t CoverageMappingSize = 0; + for (auto &S : CoverageMappings) { +CoverageMappingSize += S.size(); -

[PATCH] D62883: [analyzer] Track conditions of terminator statements on which the reported node depends on

2019-06-04 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus created this revision. Szelethus added reviewers: NoQ, dcoughlin, a.sidorin, baloghadamsoftware, xazax.hun, Charusso, rnkovacs. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, szepet, whisperity. Szelethus added a

[PATCH] D62873: Avoid building analyzer plugins if CLANG_ENABLE_STATIC_ANALYZER is OFF

2019-06-04 Thread Don Hinton via Phabricator via cfe-commits
hintonda accepted this revision. hintonda added a comment. This revision is now accepted and ready to land. LGTM... Comment at: test/CMakeLists.txt:122 -if (CLANG_ENABLE_STATIC_ANALYZER) - if (LLVM_ENABLE_PLUGINS) -list(APPEND CLANG_TEST_DEPS - SampleAnalyzerPlugin

[PATCH] D62780: msabi: Fix exponential mangling time for even more contrived inputs

2019-06-04 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/lib/AST/MicrosoftMangle.cpp:819-823 ArgBackRefMap::iterator Found = TemplateArgBackReferences.find(ND); if (Found == TemplateArgBackReferences.end(

[PATCH] D62873: Avoid building analyzer plugins if CLANG_ENABLE_STATIC_ANALYZER is OFF

2019-06-04 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added inline comments. Comment at: lib/Analysis/plugins/CMakeLists.txt:1 -if(LLVM_ENABLE_PLUGINS) +if(LLVM_ENABLE_PLUGINS AND CLANG_ENABLE_STATIC_ANALYZER) add_subdirectory(SampleAnalyzer) Is this file a thing? `lib/Analysis/plugins/CMakeLists.txt`?

r362560 - msabi: Fix exponential mangling time for even more contrived inputs

2019-06-04 Thread Nico Weber via cfe-commits
Author: nico Date: Tue Jun 4 16:27:40 2019 New Revision: 362560 URL: http://llvm.org/viewvc/llvm-project?rev=362560&view=rev Log: msabi: Fix exponential mangling time for even more contrived inputs This is a follow-up to r362293 which fixed exponential time needed for mangling certain templates.

[PATCH] D62780: msabi: Fix exponential mangling time for even more contrived inputs

2019-06-04 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL362560: msabi: Fix exponential mangling time for even more contrived inputs (authored by nico, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commi

[PATCH] D59744: Fix i386 ABI "__m64" type bug

2019-06-04 Thread Kamil Rytarowski via Phabricator via cfe-commits
krytarowski added a comment. In D59744#1529218 , @mgorny wrote: > In D59744#1529182 , @krytarowski > wrote: > > > In D59744#1527412 , @wxiao3 wrote: > > > > > Consider other

[PATCH] D62885: [analyzer] Add werror flag for analyzer warnings

2019-06-04 Thread Keno Fischer via Phabricator via cfe-commits
loladiro created this revision. loladiro added a reviewer: NoQ. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. We're using the clang static analyzer together with a n

r362562 - PR42111: Use guarded initialization for thread-local variables with

2019-06-04 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Jun 4 17:04:33 2019 New Revision: 362562 URL: http://llvm.org/viewvc/llvm-project?rev=362562&view=rev Log: PR42111: Use guarded initialization for thread-local variables with unordered initialization and internal linkage. We'll run their initializers once on each referen

[PATCH] D62873: Avoid building analyzer plugins if CLANG_ENABLE_STATIC_ANALYZER is OFF

2019-06-04 Thread Don Hinton via Phabricator via cfe-commits
hintonda added inline comments. Comment at: lib/Analysis/plugins/CMakeLists.txt:1 -if(LLVM_ENABLE_PLUGINS) +if(LLVM_ENABLE_PLUGINS AND CLANG_ENABLE_STATIC_ANALYZER) add_subdirectory(SampleAnalyzer) Szelethus wrote: > Is this file a thing? `lib/Analysis/plugins

[PATCH] D62883: [analyzer] Track conditions of terminator statements on which the reported node depends on

2019-06-04 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus marked an inline comment as done. Szelethus added a comment. For the test files where plist files have changed: (note to self: there has **got to be** a better way to show this off) F9062068: track_cond_undef_value_param_before.html F9062011: track_

r362563 - Factor out duplicated code building a MemberExpr and marking it

2019-06-04 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Jun 4 17:21:47 2019 New Revision: 362563 URL: http://llvm.org/viewvc/llvm-project?rev=362563&view=rev Log: Factor out duplicated code building a MemberExpr and marking it referenced. Modified: cfe/trunk/include/clang/Sema/Sema.h cfe/trunk/lib/Sema/SemaExprCXX.cpp

[PATCH] D62873: Avoid building analyzer plugins if CLANG_ENABLE_STATIC_ANALYZER is OFF

2019-06-04 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus accepted this revision. Szelethus added a comment. I seem to have missed out on previous commits that moved analyzer plugins around -- would you mind adding `[analyzer]` to the revision names that affect the Static Analyzer? Many of us are automatically subscribed to such patches. In

[PATCH] D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module.

2019-06-04 Thread Jian Cai via Phabricator via cfe-commits
jcai19 marked an inline comment as done. jcai19 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/android-cloexec-pipe2.cpp:17 + +void warning1() { + int pipefd[2]; gribozavr wrote: > `warning1`, `warning2` is better than `a` and `b`, but we c

[PATCH] D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module.

2019-06-04 Thread Jian Cai via Phabricator via cfe-commits
jcai19 updated this revision to Diff 203050. jcai19 added a comment. Update test function names. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62049/new/ https://reviews.llvm.org/D62049 Files: clang-tools-extra/clang-tidy/android/AndroidTidyModu

[PATCH] D61467: [Rewrite] Extend to further accept CharSourceRange

2019-06-04 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61467/new/ https://reviews.llvm.org/D61467 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D62885: [analyzer] Add werror flag for analyzer warnings

2019-06-04 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. Interesting. Let's also have a link to your cfe-dev letter: http://lists.llvm.org/pipermail/cfe-dev/2019-June/062495.html So, you'd like to make this a frontend flag in order not to expose it to "regular" end users? Or was it because, well, every other flag we have is

[PATCH] D62441: [analyzer] NFC: Introduce a convenient CallDescriptionMap class.

2019-06-04 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. This is why I love unit tests so much, you get the learn a lot about how things work! Thanks! The idea for the patch is great, can't wait to get rid of the mess we have in `MallocChecke

[PATCH] D62556: [analyzer] NFC: CallDescription: Implement describing C library functions.

2019-06-04 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. I like the idea, but will need more time to get familiar with `CallEvent` to formally accept. > When matching C standard library functions in the checker, it's easy to > forget that they are often implemented as macros that are expanded to > compiler builtins. Such b

[PATCH] D62557: [analyzer] Modernize CStringChecker to use CallDescriptions.

2019-06-04 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus accepted this revision. Szelethus added a comment. That's beautiful *-* Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62557/new/ https://reviews.llvm.org/D62557 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D62885: [analyzer] Add werror flag for analyzer warnings

2019-06-04 Thread Keno Fischer via Phabricator via cfe-commits
loladiro marked an inline comment as done. loladiro added a comment. > So, you'd like to make this a frontend flag in order not to expose it to > "regular" end users? Or was it because, well, every other flag we have is a > frontend flag? Little bit of both? We already need to pass a bunch of `

[PATCH] D62873: Avoid building analyzer plugins if CLANG_ENABLE_STATIC_ANALYZER is OFF

2019-06-04 Thread Don Hinton via Phabricator via cfe-commits
hintonda added a comment. In D62873#1530197 , @Szelethus wrote: > I seem to have missed out on previous commits that moved analyzer plugins > around -- would you mind adding `[analyzer]` to the revision names that > affect the Static Analyzer? Many of us

r362571 - Initial support for vectorization using MASSV (IBM MASS vector library)

2019-06-04 Thread Nemanja Ivanovic via cfe-commits
Author: nemanjai Date: Tue Jun 4 18:57:57 2019 New Revision: 362571 URL: http://llvm.org/viewvc/llvm-project?rev=362571&view=rev Log: Initial support for vectorization using MASSV (IBM MASS vector library) Part 2 (the Clang portion) of D59881. This patch (first of two patches) enables the vecto

r362574 - [analyzer] exploded-graph-rewriter: Pick up python from cmake in tests.

2019-06-04 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Tue Jun 4 19:09:29 2019 New Revision: 362574 URL: http://llvm.org/viewvc/llvm-project?rev=362574&view=rev Log: [analyzer] exploded-graph-rewriter: Pick up python from cmake in tests. This should fix NetBSD buildbots. Modified: cfe/trunk/test/Analysis/exploded-graph-r

r362575 - [analyzer] exploded-graph-rewriter: Add the missing license header!

2019-06-04 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Tue Jun 4 19:09:49 2019 New Revision: 362575 URL: http://llvm.org/viewvc/llvm-project?rev=362575&view=rev Log: [analyzer] exploded-graph-rewriter: Add the missing license header! Modified: cfe/trunk/utils/analyzer/exploded-graph-rewriter.py Modified: cfe/trunk/utils/

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

2019-06-04 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ marked an inline comment as done. NoQ added a comment. In D62638#1529170 , @krytarowski wrote: > This commit breaks the NetBSD buildbot node. rC362574 . Comment at: cfe/trunk/utils/analyzer/explo

[PATCH] D62888: [NewPM] Port Sancov

2019-06-04 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan created this revision. leonardchan added reviewers: fedor.sergeev, philip.pfaffe, chandlerc. leonardchan added a project: clang. Herald added subscribers: hiraditya, eraman. Herald added a project: LLVM. This patch contains a port of SanitizerCoverage to the new pass manager. This one

[PATCH] D62883: [analyzer] Track conditions of terminator statements on which the reported node depends on

2019-06-04 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Yay, this thing really works! > Now, whether this change is any good is practically impossible to tell > without evaluation on production code, so I'll get back with that once I > gather some data. Yes. This patch deserves some data on how much have reports grown in length

r362580 - [Clang] Disable new PM for tests that use optimization level -O1, -O2 and -O3

2019-06-04 Thread Petr Hosek via cfe-commits
Author: phosek Date: Tue Jun 4 20:17:11 2019 New Revision: 362580 URL: http://llvm.org/viewvc/llvm-project?rev=362580&view=rev Log: [Clang] Disable new PM for tests that use optimization level -O1, -O2 and -O3 Tests that use -O1, -O2 and -O3 would often produce different results with the new pas

[PATCH] D58375: [Clang] Disable new PM for tests that use optimization level -O1, -O2 and -O3

2019-06-04 Thread Petr Hosek via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL362580: [Clang] Disable new PM for tests that use optimization level -O1, -O2 and -O3 (authored by phosek, committed by ).

[Diffusion] rL358949: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

2019-06-04 Thread Zixuan Wu via Phabricator via cfe-commits
wuzish added inline comments. /cfe/trunk/lib/Driver/ToolChains/PPCLinux.cpp:26 @hubert.reinterpretcast Thanks for your advice. I think the name `ppc_wrappers` is accurate to describe its meaning that wrapping the headers under standard library path or standard header search path. (Headers in li

r362581 - Add __FILE_NAME__ to ReleaseNotes. NFC

2019-06-04 Thread Kristina Brooks via cfe-commits
Author: kristina Date: Tue Jun 4 20:47:02 2019 New Revision: 362581 URL: http://llvm.org/viewvc/llvm-project?rev=362581&view=rev Log: Add __FILE_NAME__ to ReleaseNotes. NFC Added it under C language changes as a nonstandard extension for the time being. Modified: cfe/trunk/docs/ReleaseNote

[PATCH] D60583: [AArch64] Implement Vector Funtion ABI name mangling.

2019-06-04 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. In D60583#1529937 , @fpetrogalli wrote: > In D60583#1529878 , @jdoerfert wrote: > > > Why/Where did we decide to clobber the attribute list with "non-existent > > function names"? > > > T

Network issues in LLVM Lab

2019-06-04 Thread Galina Kistanova via cfe-commits
Hello everyone, Many of you may noticed yesterday issues with the production LLVM buildbot, and yesterday and today issues with the staging LLVM buildbot. The problems were because of problems with the outside connection. All the problems have been resolved. The production buildbot woks normally

[PATCH] D62839: [WIP] [clangd] Index API and implementations for relations

2019-06-04 Thread Nathan Ridge via Phabricator via cfe-commits
nridge updated this revision to Diff 203072. nridge added a comment. Fill in BackgroundIndex and Dex implementations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62839/new/ https://reviews.llvm.org/D62839 Files: clang-tools-extra/clangd/index/B

[PATCH] D62839: [clangd] Index API and implementations for relations

2019-06-04 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added a comment. Ok, this is probably ready for a first round of review now. I know I should add new test cases to at least DexTests and BackgroundIndexTests, I'll do this in the next version of the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D58880: [WIP] [clangd] Type hierarchy subtypes

2019-06-04 Thread Nathan Ridge via Phabricator via cfe-commits
nridge updated this revision to Diff 203073. nridge added a comment. Rebased onto D62839 and predecessors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58880/new/ https://reviews.llvm.org/D58880 Files: clang-too

[PATCH] D62621: [LibTooling] Add insert/remove convenience functions for creating `ASTEdit`s.

2019-06-04 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. In D62621#1529691 , @ymandel wrote: > Thanks for the review. > > Good questions. The answer to both is that it depends on the `RangeSelec

r362584 - Reduce memory consumption of coverage dumps

2019-06-04 Thread Serge Guelton via cfe-commits
Author: serge_sans_paille Date: Tue Jun 4 23:35:10 2019 New Revision: 362584 URL: http://llvm.org/viewvc/llvm-project?rev=362584&view=rev Log: Reduce memory consumption of coverage dumps Avoiding an intermediate join operation removes the need for an intermediate buffer that may be quite large,

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

2019-06-04 Thread serge via Phabricator via cfe-commits
serge-sans-paille updated this revision to Diff 203086. serge-sans-paille added a comment. - get Rid of the constraint on initializePasses : it can be registered suing a static constructor, no need to clutter the API with it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D62623: Reduce memory consumption of coverage dumps

2019-06-04 Thread serge via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG4cd07dbeec98: Reduce memory consumption of coverage dumps (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62623/new/ https://

r362585 - [CMake][Fuchsia] Use libc++ ABIv2 for the first stage build

2019-06-04 Thread Petr Hosek via cfe-commits
Author: phosek Date: Tue Jun 4 23:58:41 2019 New Revision: 362585 URL: http://llvm.org/viewvc/llvm-project?rev=362585&view=rev Log: [CMake][Fuchsia] Use libc++ ABIv2 for the first stage build This also unifies flags between macOS and Linux builds. Modified: cfe/trunk/cmake/caches/Fuchsia.cm

<    1   2