r362062 - [AST] asm goto labels don't have constraints, don't try to copy them.

Author: d0k Date: Thu May 30 00:21:08 2019 New Revision: 362062 URL: http://llvm.org/viewvc/llvm-project?rev=362062&view=rev Log: [AST] asm goto labels don't have constraints, don't try to copy them. Found by asan. Modified: cfe/trunk/lib/AST/Stmt.cpp Modified: cfe/trunk/lib/AST/Stmt.cpp UR

[libunwind] r362065 - [CMake] Use find_package(LLVM) instead of LLVMConfig

Author: phosek Date: Thu May 30 00:34:39 2019 New Revision: 362065 URL: http://llvm.org/viewvc/llvm-project?rev=362065&view=rev Log: [CMake] Use find_package(LLVM) instead of LLVMConfig This addresses an issues introduced in r362047. Differential Revision: https://reviews.llvm.org/D62640 Modifi

r362067 - asm goto: fix out-of-bounds read of Constraints after rC362045

Author: maskray Date: Thu May 30 01:03:02 2019 New Revision: 362067 URL: http://llvm.org/viewvc/llvm-project?rev=362067&view=rev Log: asm goto: fix out-of-bounds read of Constraints after rC362045 When parsing goto labels, Names and Exprs are expanded but Constraints is not, this may cause a out-

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

dgoldman created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As Typo Resolution can create new TypoExprs while resolving typos, it is necessary to recurse through the expression to search for more typos. This should fix the assertion failure in `clang::Se

[PATCH] D62623: Reduce memory consumption of coverage dumps

serge-sans-paille added a comment. @kwk: looks like you're still compiling with clang-7, this patch is to be applied on the master version of LLVM/clang, then you can install it and use it to recompile llvm/lld with coverage info. Does it make sense to you? Repository: rG LLVM Github Monore

[PATCH] D60763: Prototype OpenCL BIFs using Tablegen

AlexeySotkin added inline comments. Comment at: clang/include/clang/Basic/OpenCLBuiltins.td:298-302 +def write_imagef : Builtin<"write_imagef", +[void_t, + image2d_WO_t, + VectorType, +

r362076 - Fix MSVC "not all control paths return a value" warning.

Author: rksimon Date: Thu May 30 02:39:45 2019 New Revision: 362076 URL: http://llvm.org/viewvc/llvm-project?rev=362076&view=rev Log: Fix MSVC "not all control paths return a value" warning. Modified: cfe/trunk/include/clang/Basic/ObjCRuntime.h Modified: cfe/trunk/include/clang/Basic/ObjCRun

Re: r362067 - asm goto: fix out-of-bounds read of Constraints after rC362045

Is this still necessary after r362062? On Thu, May 30, 2019 at 10:00 AM Fangrui Song via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: maskray > Date: Thu May 30 01:03:02 2019 > New Revision: 362067 > > URL: http://llvm.org/viewvc/llvm-project?rev=362067&view=rev > Log: > asm goto: f

r362079 - Revert "asm goto: fix out-of-bounds read of Constraints after rC362045"

Author: maskray Date: Thu May 30 03:05:52 2019 New Revision: 362079 URL: http://llvm.org/viewvc/llvm-project?rev=362079&view=rev Log: Revert "asm goto: fix out-of-bounds read of Constraints after rC362045" It was fixed by rC362062. Modified: cfe/trunk/lib/Parse/ParseStmtAsm.cpp Modified: cf

Re: r362067 - asm goto: fix out-of-bounds read of Constraints after rC362045

You beat me to it.. Reverted On Thu, May 30, 2019 at 5:41 PM Benjamin Kramer wrote: > Is this still necessary after r362062? > > On Thu, May 30, 2019 at 10:00 AM Fangrui Song via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: maskray >> Date: Thu May 30 01:03:02 2019 >> New Revi

[PATCH] D60499: [ASTImporter] Various source location and range import fixes.

balazske added a comment. It looks like that the same test can be applied as in D60463 but check only the first line of the AST dump. The first line contains information about the actual Decl only. This checks less than checking the full AST dump but finds some

r362085 - Fix Wdocumentation warning. NFCI.

Author: rksimon Date: Thu May 30 03:44:36 2019 New Revision: 362085 URL: http://llvm.org/viewvc/llvm-project?rev=362085&view=rev Log: Fix Wdocumentation warning. NFCI. Modified: cfe/trunk/include/clang/StaticAnalyzer/Core/CheckerManager.h Modified: cfe/trunk/include/clang/StaticAnalyzer/Core

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

Charusso added a comment. Sorry for that much rewrite request but in a script language you have to name your stuff properly or you will be completely lost. I have not written a single Python class yet, but trust me. I really like that `DotDumpVisitor` semantic, but it would be a lot better at

Re: r361329 - [c++20] P1330R0: permit simple-assignments that change the active member

On 22/05/2019 01:15, Richard Smith via cfe-commits wrote: Author: rsmith Date: Tue May 21 16:15:20 2019 New Revision: 361329 URL: http://llvm.org/viewvc/llvm-project?rev=361329&view=rev Log: [c++20] P1330R0: permit simple-assignments that change the active member of a union within constant expre

[PATCH] D60748: Fix i386 struct and union parameter alignment

joerg added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:1501 +// +// Exclude other System V OS (e.g Darwin, PS4 and FreeBSD) since we don't +// want to spend any effort dealing with the ramifications of ABI breaks. krytarowski wrote: > Dar

[PATCH] D62580: [OpenCL] Use long instead of long long in x86 builtins

Anastasia added a comment. Do you think it's possible to add a test? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62580/new/ https://reviews.llvm.org/D62580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D62654: [Docs] Modernize references to macOS

jryans created this revision. jryans added a reviewer: JDevlieghere. Herald added subscribers: llvm-commits, libcxx-commits, lldb-commits, cfe-commits, arphaman, christof, mgorny. Herald added projects: clang, LLDB, libc++, LLVM. This updates all places in documentation that refer to "Mac OS X",

r362087 - [OpenCL] Support logical vector operators in C++ mode

Author: svenvh Date: Thu May 30 05:35:19 2019 New Revision: 362087 URL: http://llvm.org/viewvc/llvm-project?rev=362087&view=rev Log: [OpenCL] Support logical vector operators in C++ mode Support logical operators on vectors in C++ for OpenCL mode, to preserve backwards compatibility with OpenCL C

[PATCH] D62588: [OpenCL] Support logical vector operators in C++ mode

This revision was automatically updated to reflect the committed changes. Closed by commit rL362087: [OpenCL] Support logical vector operators in C++ mode (authored by svenvh, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[PATCH] D61743: New clang option -MD-filter=prefix to filter files from make dependencies

mibintc abandoned this revision. mibintc added a comment. I'll modify this to be a cc1 only option, there doesn't seem to be community interest. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61743/new/ https://reviews.llvm.org/D61743 ___ c

[PATCH] D62657: [OpenCL] Fix OpenCL/SPIR version metadata

Anastasia created this revision. Anastasia added a reviewer: svenvh. Herald added subscribers: ebevhan, yaxunl. C++ is derived from OpenCL v2.0 therefore set the versions to the same. In the future we might need to add extra version for CXX. https://reviews.llvm.org/D62657 Files: lib/CodeGen

[PATCH] D62654: [Docs] Modernize references to macOS

mclow.lists added a comment. I'm fine with the libc++ changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62654/new/ https://reviews.llvm.org/D62654 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D62658: [analyzer] print() JSONify: ExplodedNode revision

Charusso created this revision. Charusso added reviewers: NoQ, xazax.hun, ravikandhadai, baloghadamsoftware, Szelethus. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet. Revert node-ID removal. Repository:

[PATCH] D62657: [OpenCL] Fix OpenCL/SPIR version metadata

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62657/new/ https://reviews.llvm.org/D62657 ___ cfe-commits mailing list cfe-commits@

Re: r361997 - [analyzer] print() JSONify: getNodeLabel implementation

Hi Csaba, The test dump_egraph.cpp appears to be flaky on Windows. For example here: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/26183 . C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\tools\clang\test\Analysis\dump_egraph

Re: r361997 - [analyzer] print() JSONify: getNodeLabel implementation

Hey! When it fails, could you provide the DOT dump? The path is: llvm-project/build/tools/clang/test/Analysis/Output/dump_egraph.cpp.tmp.dot Thanks, Csaba. On Thu, May 30, 2019 at 4:00 PM Russell Gallop wrote: > Hi Csaba, > > The test dump_egraph.cpp appears to be flaky on Windows. For example

[PATCH] D43576: Solution to fix PR27066 - Redefinition with same mangled name as another definition (dllexport and uuid)

zahiraam added a comment. A review please :-) Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43576/new/ https://reviews.llvm.org/D43576 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D62035: [AST] const-ify ObjC inherited class search

jyknight added a comment. I don't really have much to say about this, and the patch is probably fine, but I do note that most of the other accessors on this class also return mutable objects. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62035/new/ https://revi

Re: r361997 - [analyzer] print() JSONify: getNodeLabel implementation

Hi Csaba, Failing example attached. Note that the output is different every time so there is potentially more than one failure mode. Thanks Russ On Thu, 30 May 2019 at 15:05, Csaba Dabis wrote: > Hey! > > When it fails, could you provide the DOT dump? The path > is: > llvm-project/build/tools

r362096 - [ARM] Add CLI support for Armv8.1-M and MVE

Author: sjoerdmeijer Date: Thu May 30 07:22:26 2019 New Revision: 362096 URL: http://llvm.org/viewvc/llvm-project?rev=362096&view=rev Log: [ARM] Add CLI support for Armv8.1-M and MVE Given the existing infrastructure in LLVM side for +fp and +fp.dp, this is more or less trivial, needing only one

[PATCH] D60699: [ARM] add CLI support for 8.1-M and MVE.

This revision was automatically updated to reflect the committed changes. Closed by commit rL362096: [ARM] Add CLI support for Armv8.1-M and MVE (authored by SjoerdMeijer, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[PATCH] D62665: Fix constexpr __builtin_*_overflow issue when unsigned->signed operand.

erichkeane created this revision. erichkeane added reviewers: eli.friedman, efriedma, craig.topper. As reported here https://bugs.llvm.org/show_bug.cgi?id=42000, it was possible to get the constexpr version of __builtin_*_overflow to give the wrong answer. This was because when extending the oper

[PATCH] D50256: [Analyzer] [WIP] Basic support for multiplication and division in the constraint manager (for == and != only)

baloghadamsoftware updated this revision to Diff 202191. baloghadamsoftware added a comment. Herald added a subscriber: Charusso. Multipliers limited to less or equal to 255. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50256/new/ https://reviews.llvm.org/D50256 Files: include/clang

r362098 - [analyzer] print() JSONify chain: Fix build-bot breaks

Author: charusso Date: Thu May 30 07:48:43 2019 New Revision: 362098 URL: http://llvm.org/viewvc/llvm-project?rev=362098&view=rev Log: [analyzer] print() JSONify chain: Fix build-bot breaks Summary: Printing out a map structure different in different environments so that this patch generalize the

[PATCH] D49074: [Analyzer] [WIP] Basic support for multiplication and division in the constraint manager

baloghadamsoftware updated this revision to Diff 202192. baloghadamsoftware removed a reviewer: george.karpenkov. baloghadamsoftware added a comment. Herald added a subscriber: Charusso. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49074/new/ https://reviews.llvm.org/D49074 F

[PATCH] D62156: [Sema][PR41730] Diagnose addr space mismatch while constructing objects

Anastasia updated this revision to Diff 202193. Anastasia marked 3 inline comments as done. Anastasia added a comment. - Improved diagnostic - Added more comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62156/new/ https://reviews.llvm.org/D62156 Files: include/clang/Basic/Diagn

[PATCH] D62156: [Sema][PR41730] Diagnose addr space mismatch while constructing objects

Anastasia marked 4 inline comments as done. Anastasia added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:8229 + if (FTI.hasMethodTypeCVRUQualifiers()) { +FTI.MethodQualifiers->forEachCVRUQualifier( [&](DeclSpec::TQ TypeQual, StringRef QualName, SourceLocati

Re: r361997 - [analyzer] print() JSONify: getNodeLabel implementation

Thanks you! Fixed by https://github.com/llvm/llvm-project/commit/17604c3486cbe7c27cadac1757cd0a9109a92792 On Thu, May 30, 2019 at 4:16 PM Russell Gallop wrote: > Hi Csaba, > > Failing example attached. Note that the output is different every time so > there is potentially more than one failure

Re: r361997 - [analyzer] print() JSONify: getNodeLabel implementation

On Thu, May 30, 2019 at 5:48 PM Csaba Dabis via cfe-commits wrote: > > Thanks you! > > Fixed by > https://github.com/llvm/llvm-project/commit/17604c3486cbe7c27cadac1757cd0a9109a92792 The non-determinism is still there though, so this isn't correct fix. > On Thu, May 30, 2019 at 4:16 PM Russell G

[PATCH] D62525: [Analyzer] Add new visitor to the iterator checkers

baloghadamsoftware added a comment. In D62525#1519868 , @NoQ wrote: > In D62525#1519475 , > @baloghadamsoftware wrote: > > > Before someone asks: `NoteTag`s are not applicable here since invalidation > > and reach

[PATCH] D62525: [Analyzer] Add new visitor to the iterator checkers

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:281-282 + + // `FoundChange` becomes true when we find the statement the results in the + // current state of the iterator.

r362100 - Follow up of r362096

Author: sjoerdmeijer Date: Thu May 30 08:04:06 2019 New Revision: 362100 URL: http://llvm.org/viewvc/llvm-project?rev=362100&view=rev Log: Follow up of r362096 The new tests were failing, because I missed dependent patch D60697. I have removed the failing cases for now, which I will restore once

[PATCH] D60463: [ASTImporter] Add check for correct import of source locations.

balazske updated this revision to Diff 202197. balazske added a comment. New patch and check the first line of AST dump only. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60463/new/ https://reviews.llvm.org/D60463 Files: unittests/AST/ASTImporterFixtures.cpp

[PATCH] D60463: [ASTImporter] Add check for correct import of source locations.

balazske added a comment. In the current state there are failing AST tests. This test can be added after the problems are fixed. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60463/new/ https://reviews.llvm.org/D60463 _

r362101 - [analyzer] print() JSONify chain: Fix possible build-bot breaks

Author: charusso Date: Thu May 30 08:15:57 2019 New Revision: 362101 URL: http://llvm.org/viewvc/llvm-project?rev=362101&view=rev Log: [analyzer] print() JSONify chain: Fix possible build-bot breaks Summary: Printing constructing_objects could be non-deterministic as it is a map. Modified: c

r362102 - [OpenCL] Fix OpenCL/SPIR version metadata in C++ mode.

Author: stulova Date: Thu May 30 08:18:07 2019 New Revision: 362102 URL: http://llvm.org/viewvc/llvm-project?rev=362102&view=rev Log: [OpenCL] Fix OpenCL/SPIR version metadata in C++ mode. C++ is derived from OpenCL v2.0 therefore set the versions identically. Differential Revision: https://revi

Re: r361997 - [analyzer] print() JSONify: getNodeLabel implementation

Hm, the first `CHECK: constructing_objects` contains only one element, which is fine, the second `CHECK: constructing_objects` has two, which could be non-determinism, but surprisingly it is worked as excepted. Because of the edge-case I have changed my mind: https://github.com/llvm/llvm-project/co

Re: r361997 - [analyzer] print() JSONify: getNodeLabel implementation

I think we're still talking past each other. I'm saying that *any* commit that does not fix the underlying nondeterminizm, but only hides it by deleting tests that showed that said determinism exists in the first place, is not a fix. Roman. On Thu, May 30, 2019 at 6:14 PM Csaba Dabis wrote: > >

Re: r361997 - [analyzer] print() JSONify: getNodeLabel implementation

Hi Csaba, I see what Roman means. Output should be deterministic for given input (unless there is a very good reason not to (e.g. timing or deliberate randomness)). You can check whether the output is the same with a script like below. It looks like the node numbers are different every time. Is t

[PATCH] D62622: [CMake] Provide an option to use relative paths in debug info

aprantl added a comment. I like LLVM_USE_RELATIVE_PATHS_IN_DEBUG_INFO. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62622/new/ https://reviews.llvm.org/D62622 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

r362106 - Revert "clang support gnu asm goto."

Author: erichkeane Date: Thu May 30 08:38:02 2019 New Revision: 362106 URL: http://llvm.org/viewvc/llvm-project?rev=362106&view=rev Log: Revert "clang support gnu asm goto." This reverts commit 954ec09aed4f2be04bb5f4e10dbb4ea8bd19ef9a. Reverting due to test failures as requested by Jennifer Yu.

Re: r361997 - [analyzer] print() JSONify: getNodeLabel implementation

I have not said there is determinism to print out a map as Static Analyzer cannot provide that. We have no plans to make it deterministic, as it is just dumping out the ExplodedGraph in JSON format, which is an internal stuff. This non-deterministic behaviour has been seen first only some days ago

[PATCH] D62435: Add Attribute NoThrow as an Exception Specifier Type

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from some minor nits. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2789 InGroup; +def warn_nothrow_attribute_ignored : Warning<"nothrow attribute conflicts with" + " exception sp

[PATCH] D62688: [Analyzer] Iterator Checkers - Model `empty()` method of containers

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: NoQ, Szelethus. baloghadamsoftware added a project: clang. Herald added subscribers: Charusso, gamesh411, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity. Modeling of the `empty()` method

[PATCH] D60763: Prototype OpenCL BIFs using Tablegen

svenvh added inline comments. Comment at: clang/include/clang/Basic/OpenCLBuiltins.td:298-302 +def write_imagef : Builtin<"write_imagef", +[void_t, + image2d_WO_t, + VectorType, +

[PATCH] D62654: [Docs] Modernize references to macOS

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62654/new/ https://reviews.llvm.org/D62654 ___

[PATCH] D60748: Fix i386 struct and union parameter alignment

jyknight added a comment. I don't think this was correct (where by "correct", there, I mean "what GCC does", as this patch is intended to match GCC behavior). I think this change may well break more cases than it fixes, so IMO, this should be reverted, until it's implemented properly. Consider

r362113 - [Docs] Modernize references to macOS

Author: jryans Date: Thu May 30 09:46:22 2019 New Revision: 362113 URL: http://llvm.org/viewvc/llvm-project?rev=362113&view=rev Log: [Docs] Modernize references to macOS Summary: This updates all places in documentation that refer to "Mac OS X", "OS X", etc. to instead use the modern name "macOS"

[libunwind] r362113 - [Docs] Modernize references to macOS

Author: jryans Date: Thu May 30 09:46:22 2019 New Revision: 362113 URL: http://llvm.org/viewvc/llvm-project?rev=362113&view=rev Log: [Docs] Modernize references to macOS Summary: This updates all places in documentation that refer to "Mac OS X", "OS X", etc. to instead use the modern name "macOS"

[PATCH] D62690: Modify StepsLeft counter behaivior for constexprs

wasiher created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When I was trying to remove limits from constexpr steps (I wanted to give compiler as much time as it it needs), I found -fconstexpr-steps option. Naively i decided that -fconstexpr-steps=-1 is

[PATCH] D62435: Add Attribute NoThrow as an Exception Specifier Type

erichkeane marked 6 inline comments as done. erichkeane added inline comments. Comment at: clang/include/clang/Sema/DeclSpec.h:1547 + bool hasAttr(ParsedAttr::Kind Kind) const { +return llvm::find_if(getAttrs(), [Kind](const ParsedAttr &P) { aaron.ballman

r362119 - Add Attribute NoThrow as an Exception Specifier Type

Author: erichkeane Date: Thu May 30 10:31:54 2019 New Revision: 362119 URL: http://llvm.org/viewvc/llvm-project?rev=362119&view=rev Log: Add Attribute NoThrow as an Exception Specifier Type In response to https://bugs.llvm.org/show_bug.cgi?id=33235, it became clear that the current mechanism of h

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim updated this revision to Diff 202237. hctim marked 7 inline comments as done. hctim added a comment. - Updated from Matt's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61923/new/ https://reviews.llvm.org/D61923 Files: clang/runt

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim added inline comments. Comment at: compiler-rt/lib/gwp_asan/tests/driver.cpp:14 + return RUN_ALL_TESTS(); +} morehouse wrote: > hctim wrote: > > morehouse wrote: > > > Can we just link with gtest_main instead of having this? > > Unfortunately not easily. `

[PATCH] D62693: Support codesigning bundles and forcing

beanz created this revision. beanz added reviewers: jkorous, bogner. Herald added subscribers: kadircet, arphaman, dexonsmith, ilya-biryukov, mgorny. Herald added projects: clang, LLVM. Clangd's framework is assembled by copying binaries from the lib and bin directories into a bundle shape. This

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

Anastasia added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1017 + let LangOpts = [SYCL]; + let Documentation = [Undocumented]; +} Undocumented -> SYCLKernelDocs Comment at: clang/include/clang/Basic/AttrDocs.td:269 + + us

[PATCH] D62693: Support codesigning bundles and forcing

bogner accepted this revision. bogner added a comment. This revision is now accepted and ready to land. Seems straightforward enough Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62693/new/ https://reviews.llvm.org/D62693 ___

[PATCH] D62550: [coroutines][PR41909] Don't build dependent coroutine statements for generic lambda

GorNishanov accepted this revision. GorNishanov added a comment. This revision is now accepted and ready to land. LGTM! Thank you for the fix Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62550/new/ https://reviews.llvm.org/D62550 _

[PATCH] D62657: [OpenCL] Fix OpenCL/SPIR version metadata

This revision was automatically updated to reflect the committed changes. Closed by commit rC362102: [OpenCL] Fix OpenCL/SPIR version metadata in C++ mode. (authored by stulova, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D62657?vs=202169&id=

[PATCH] D62654: [Docs] Modernize references to macOS

This revision was automatically updated to reflect the committed changes. Closed by commit rL362113: [Docs] Modernize references to macOS (authored by jryans, committed by ). Changed prior to commit: https://reviews.llvm.org/D62654?vs=202161&id=202247#toc Repository: rL LLVM CHANGES SINCE L

[PATCH] D62435: Add Attribute NoThrow as an Exception Specifier Type

This revision was automatically updated to reflect the committed changes. erichkeane marked 2 inline comments as done. Closed by commit rL362119: Add Attribute NoThrow as an Exception Specifier Type (authored by erichkeane, committed by ). Herald added a project: LLVM. Herald added a subscriber: l

r362129 - Reapply: LLVM IR: update Clang tests for byval being a typed attribute.

Author: tnorthover Date: Thu May 30 11:49:19 2019 New Revision: 362129 URL: http://llvm.org/viewvc/llvm-project?rev=362129&view=rev Log: Reapply: LLVM IR: update Clang tests for byval being a typed attribute. Since byval is now a typed attribute it gets sorted slightly differently by LLVM when th

[PATCH] D60499: [ASTImporter] Various source location and range import fixes.

shafik requested changes to this revision. shafik added a comment. This revision now requires changes to proceed. Actually I was mistaken, we can see the difference for `EnumDecl` and `ClassTemplateSpecializationDecl` as well. For `EnumDecl` before: EnumDecl 0x7fd0ae884800 col:6 referenced B

[PATCH] D62665: Fix constexpr __builtin_*_overflow issue when unsigned->signed operand.

efriedma added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:9457 + LHS = APSInt(LHS.isSigned() ? LHS.sextOrSelf(MaxBits) + : LHS.zextOrSelf(MaxBits), !IsSigned); Can you just write `LHS = AP

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

morehouse accepted this revision. morehouse added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61923/new/ https://reviews.llvm.org/D61923 _

[PATCH] D62665: Fix constexpr __builtin_*_overflow issue when unsigned->signed operand.

erichkeane marked an inline comment as done. erichkeane added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:9457 + LHS = APSInt(LHS.isSigned() ? LHS.sextOrSelf(MaxBits) + : LHS.zextOrSelf(MaxBits), !IsSigned)

[PATCH] D62574: Initial draft of target-configurable address spaces.

Anastasia added a comment. > This patch does not address the issue with the accessors > on Qualifiers (isAddressSpaceSupersetOf, compatiblyIncludes), > because I don't know how to solve it without breaking a ton of > rather nice encapsulation. Either, every mention of compatiblyIncludes > must

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

rsmith added inline comments. Comment at: lib/Sema/SemaExprCXX.cpp:7713-7714 + // Add the newly created typos to the TypoExprs list, even if they + // failed to apply. This allows them to be reaped although they won't + // emit any diagnostic. +

[PATCH] D62665: Fix constexpr __builtin_*_overflow issue when unsigned->signed operand.

erichkeane updated this revision to Diff 202268. erichkeane marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62665/new/ https://reviews.llvm.org/D62665 Files: clang/lib/AST/ExprConstant.cpp clang/test/SemaCXX/builtins-overflow.cpp Index: clang/test/Se

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim updated this revision to Diff 202275. hctim added a comment. Merged with tip-of-tree in preparation for submit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61923/new/ https://reviews.llvm.org/D61923 Files: clang/runtime/CMakeLists.txt

r362138 - [GWP-ASan] Mutex implementation [2].

Author: hctim Date: Thu May 30 12:45:32 2019 New Revision: 362138 URL: http://llvm.org/viewvc/llvm-project?rev=362138&view=rev Log: [GWP-ASan] Mutex implementation [2]. Summary: See D60593 for further information. This patch pulls out the mutex implementation and the required definitions file. W

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

This revision was automatically updated to reflect the committed changes. Closed by commit rL362138: [GWP-ASan] Mutex implementation [2]. (authored by hctim, committed by ). Herald added a subscriber: delcypher. Changed prior to commit: https://reviews.llvm.org/D61923?vs=202275&id=202276#toc R

[PATCH] D62696: AMDGPU: Use AMDGPU toolchain for other OSes

arsenm created this revision. arsenm added a reviewer: yaxunl. Herald added subscribers: t-tye, tpr, dstuttard, nhaehnle, wdng, jvesely, kzhuravl. This would need more work to actually support them, but this is less wrong than the default. https://reviews.llvm.org/D62696 Files: lib/Driver/Dr

r362140 - Mark test as requiring an ARM target.

Author: dyung Date: Thu May 30 13:02:51 2019 New Revision: 362140 URL: http://llvm.org/viewvc/llvm-project?rev=362140&view=rev Log: Mark test as requiring an ARM target. Modified: cfe/trunk/test/Driver/armv8.1m.main.s Modified: cfe/trunk/test/Driver/armv8.1m.main.s URL: http://llvm.org/view

[PATCH] D62697: AMDGPU: Disable errno by default

arsenm created this revision. arsenm added a reviewer: yaxunl. Herald added subscribers: t-tye, tpr, dstuttard, nhaehnle, wdng, jvesely, kzhuravl. https://reviews.llvm.org/D62697 Files: lib/Driver/ToolChains/AMDGPU.h test/Driver/fast-math.c Index: test/Driver/fast-math.c ==

Re: r361997 - [analyzer] print() JSONify: getNodeLabel implementation

Hi all, I'm perfectly fine with reducing this test case to only test the `conj_$3\{int, LC3, no stmt, #1\}` part and drop everything else, because that's what i've been testing when i originally introduced this test. The lack of determinism here indeed only affects our own self-debugging fa

r362147 - [c++2a] Fix assertion failure if we would walk over more than one level

Author: rsmith Date: Thu May 30 13:45:12 2019 New Revision: 362147 URL: http://llvm.org/viewvc/llvm-project?rev=362147&view=rev Log: [c++2a] Fix assertion failure if we would walk over more than one level of derived-to-base conversion path when implicitly starting union subobject lifetimes in cons

Re: r361329 - [c++20] P1330R0: permit simple-assignments that change the active member

On Thu, 30 May 2019 at 04:31, Stephan Bergmann via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On 22/05/2019 01:15, Richard Smith via cfe-commits wrote: > > Author: rsmith > > Date: Tue May 21 16:15:20 2019 > > New Revision: 361329 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=361329

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim added a comment. Looks like this broke an autoconf bot . Have submitted rL362149 , which should hopefully fix the issue. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D62665: Fix constexpr __builtin_*_overflow issue when unsigned->signed operand.

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62665/new/ https://reviews.llvm.org/D62665 ___ cfe-commits mailing list cfe-commi

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:326 +self._dump('Program point:') +self._dump('' + '') Charusso wrote: > I would create a table-buil

[PATCH] D62635: Add enums as global variables in the IR metadata.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm That was... easier and more painless than I would've imagined. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62635/new/ https://reviews.llvm.org

r362157 - Fix constexpr __builtin_*_overflow issue when unsigned->signed operand.

Author: erichkeane Date: Thu May 30 14:35:32 2019 New Revision: 362157 URL: http://llvm.org/viewvc/llvm-project?rev=362157&view=rev Log: Fix constexpr __builtin_*_overflow issue when unsigned->signed operand. As reported here https://bugs.llvm.org/show_bug.cgi?id=42000, it was possible to get the

[PATCH] D62665: Fix constexpr __builtin_*_overflow issue when unsigned->signed operand.

This revision was automatically updated to reflect the committed changes. Closed by commit rL362157: Fix constexpr __builtin_*_overflow issue when unsigned->signed operand. (authored by erichkeane, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prio

r362160 - [Remarks][NFC] Move the serialization to lib/Remarks

Author: thegameg Date: Thu May 30 14:45:59 2019 New Revision: 362160 URL: http://llvm.org/viewvc/llvm-project?rev=362160&view=rev Log: [Remarks][NFC] Move the serialization to lib/Remarks Separate the remark serialization to YAML from the LLVM Diagnostics. This adds a new serialization abstracti

[PATCH] D62622: [CMake] Provide an option to use relative paths in debug info

phosek updated this revision to Diff 202310. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62622/new/ https://reviews.llvm.org/D62622 Files: clang/cmake/caches/Fuchsia-stage2.cmake llvm/cmake/modules/HandleLLVMOptions.cmake llvm/cmake/modules/LLVMExternalProjectUtils.cmake llvm/r

[PATCH] D62622: [CMake] Provide an option to use relative paths in debug info

phosek added a comment. In D62622#1523269 , @aprantl wrote: > I like LLVM_USE_RELATIVE_PATHS_IN_DEBUG_INFO. Done CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62622/new/ https://reviews.llvm.org/D62622 __

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim added a comment. Looks like this also broke an armv8 bot, due to a maximum number of threads issue. Have filed rL362163 to attempt to fix. If that doesn't work, I'll just disable the test for armv8. Repository: rL LLVM CHANGES SINCE LAST ACTION ht

r362166 - Add enums as global variables in the IR metadata.

Author: akhuang Date: Thu May 30 15:04:11 2019 New Revision: 362166 URL: http://llvm.org/viewvc/llvm-project?rev=362166&view=rev Log: Add enums as global variables in the IR metadata. Summary: Keeps track of the enums that were used by saving them as DIGlobalVariables, since CodeView emits debug

[PATCH] D62635: Add enums as global variables in the IR metadata.

This revision was automatically updated to reflect the committed changes. Closed by commit rL362166: Add enums as global variables in the IR metadata. (authored by akhuang, committed by ). Changed prior to commit: https://reviews.llvm.org/D62635?vs=202079&id=202312#toc Repository: rL LLVM C

  1   2   >