shafik requested changes to this revision. shafik added a comment. This revision now requires changes to proceed.
Actually I was mistaken, we can see the difference for `EnumDecl` and `ClassTemplateSpecializationDecl` as well. For `EnumDecl` before: EnumDecl 0x7fd0ae884800 <line:2:1, col:6> col:6 referenced B After: EnumDecl 0x7fa703882600 <line:2:1, line:6:1> line:2:6 referenced B For `ClassTemplateSpecializationDecl` before: ClassTemplateSpecializationDecl 0x7f8c338846a0 <line:4:1, line:5:7> col:7 class A definition after: ClassTemplateSpecializationDecl 0x7fca150832a0 <line:4:1, line:7:1> line:5:7 class A definition So once we have tests similar to D61140 <https://reviews.llvm.org/D61140> I would feel good about this change. Especially since it is not clear when the other changes will be in and tests are important to guard against regressions. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60499/new/ https://reviews.llvm.org/D60499 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
