[PATCH] D62115: fix a issue that clang is incompatible with gcc with -H option.

skan added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62115/new/ https://reviews.llvm.org/D62115 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D60748: Fix i386 struct and union parameter alignment

wxiao3 added a comment. Ok for merge now? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60748/new/ https://reviews.llvm.org/D60748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

Re: [PATCH] D37035: Implement __builtin_LINE() et. al. to support source location capture.

* The alignment check can be removed, and I'll do so tomorrow if someone doesn't beat me to it. On Tue, May 28, 2019 at 1:54 AM Eric Fiselier wrote: > The alignment check can just be removed. > > On Mon., May 27, 2019, 7:57 p.m. Ulrich Weigand via Phabricator, < > revi...@reviews.llvm.org> wrote

Re: [PATCH] D62391: [CodeComplete] Complete 'return true/false' in boolean functions

I don't think it's related. All the changes are in code completion code, which is not run during normal compiles. On Tue, May 28, 2019 at 2:36 AM Mike Lothian via Phabricator < revi...@reviews.llvm.org> wrote: > FireBurn added a comment. > > Could this commit be causing the following build failur

[PATCH] D62391: [CodeComplete] Complete 'return true/false' in boolean functions

FireBurn added a comment. Sorry for the noise, I'll do a bisect Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62391/new/ https://reviews.llvm.org/D62391 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[clang-tools-extra] r361798 - [clangd] Rename -run-synchronously to -sync

Author: ibiryukov Date: Tue May 28 02:20:57 2019 New Revision: 361798 URL: http://llvm.org/viewvc/llvm-project?rev=361798&view=rev Log: [clangd] Rename -run-synchronously to -sync Modified: clang-tools-extra/trunk/clangd/test/delimited-input-comment-at-the-end.test clang-tools-extra/trunk

[clang-tools-extra] r361800 - [clangd] Never end command-line flag description with a period. NFC

Author: ibiryukov Date: Tue May 28 02:31:27 2019 New Revision: 361800 URL: http://llvm.org/viewvc/llvm-project?rev=361800&view=rev Log: [clangd] Never end command-line flag description with a period. NFC For consistency. Not having a period at the end is much more common and seems to be the prefe

[PATCH] D61497: [clangd] Introduce a structured hover response

kadircet updated this revision to Diff 201628. kadircet added a comment. - clang-format Definition Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61497/new/ https://reviews.llvm.org/D61497 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp cla

[PATCH] D60691: [ARM] Replace fp-only-sp and d16 with fp64 and d32.

simon_tatham marked an inline comment as done. simon_tatham added inline comments. Comment at: llvm/test/MC/ARM/armv8.3a-js.s:16 // REQ-V83: error: instruction requires: armv8.3a -// REQ-FP: error: instruction requires: FPARMv8 +// REQ-FP: error: invalid instruction

[PATCH] D62514: [CodeComplete] Set preferred type for qualified-id

ilya-biryukov created this revision. ilya-biryukov added a reviewer: kadircet. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D62514 Files: clang/include/clang/Sema/Sema.h clang/lib/Parse/ParseExprCXX.cpp clang/lib/Sema/SemaCodeComplete.cpp

[clang-tools-extra] r361803 - [clangd] Introduce a structured hover response

Author: kadircet Date: Tue May 28 03:29:58 2019 New Revision: 361803 URL: http://llvm.org/viewvc/llvm-project?rev=361803&view=rev Log: [clangd] Introduce a structured hover response Summary: Change ClangdServer layer to output a structured response for Hover, which can be rendered by client accor

[PATCH] D61497: [clangd] Introduce a structured hover response

This revision was automatically updated to reflect the committed changes. Closed by commit rL361803: [clangd] Introduce a structured hover response (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revi

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

Anastasia added a comment. In D60455#1518178 , @bader wrote: > In D60455#1513499 , @Anastasia wrote: > > > //**Design question**//: since you are not aware what functions are to be > > run on a device while parsing

[PATCH] D62515: [clangd] Compute expected type for templates

ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D62515 Files: clang-tools-extra/clangd/ExpectedTypes.cpp

[PATCH] D62367: [X86] VP2INTERSECT clang

RKSimon added inline comments. Comment at: lib/Headers/avx512vlvp2intersectintrin.h:39 + +static __inline__ void __DEFAULT_FN_ATTRS256 +_mm256_2intersect_epi32(__m256i __a, __m256i __b, __mmask8 *__m0, __mmask8 *__m1) { craig.topper wrote: > xiangzhangllvm wrote

[PATCH] D62479: [Analyzer] Replace `CXXSelfAssignmentBRVisitor` with `NoteTags`

Szelethus accepted this revision. Szelethus added a comment. I love this. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62479/new/ https://reviews.llvm.org/D62479 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D62404: [clang-tidy] Fix null pointer dereference in readability-identifier-naming

markstegeman added a comment. Great. Can someone commit this for me? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62404/new/ https://reviews.llvm.org/D62404 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D62404: [clang-tidy] Fix null pointer dereference in readability-identifier-naming

hokein accepted this revision. hokein added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:804 +if (const auto *Typedef = TypePtr->getAs()) { + addUsage(NamingCheckFailures, Typedef->getDecl(), +

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

Fznamznon added inline comments. Comment at: clang/test/SemaSYCL/device-attributes-on-non-sycl.cpp:1 +// RUN: %clang_cc1 -fsyntax-only -fsycl-is-device -verify %s +// Now pretend that we're compiling regular C++ file without SYCL mode enabled. Anastasia wrote: >

[PATCH] D62514: [CodeComplete] Set preferred type for qualified-id

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm. one irrelevant question though, it looks like most of the calls to `ResultBuilder::setPreferredType` performs a `!isNull` check before hand. should we perform this check imp

[PATCH] D62367: [X86] VP2INTERSECT clang

xiangzhangllvm marked an inline comment as done. xiangzhangllvm added inline comments. Comment at: lib/Headers/avx512vlvp2intersectintrin.h:39 + +static __inline__ void __DEFAULT_FN_ATTRS256 +_mm256_2intersect_epi32(__m256i __a, __m256i __b, __mmask8 *__m0, __mmask8 *__m1) { ---

[clang-tools-extra] r361809 - [clang-tidy] Fix null pointer dereference in readability-identifier-naming

Author: hokein Date: Tue May 28 04:54:01 2019 New Revision: 361809 URL: http://llvm.org/viewvc/llvm-project?rev=361809&view=rev Log: [clang-tidy] Fix null pointer dereference in readability-identifier-naming Summary: readability-identifier-naming causes a null pointer dereference when checking a

[PATCH] D62404: [clang-tidy] Fix null pointer dereference in readability-identifier-naming

This revision was automatically updated to reflect the committed changes. Closed by commit rL361809: [clang-tidy] Fix null pointer dereference in readability-identifier-naming (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

Fznamznon updated this revision to Diff 201641. Fznamznon added a comment. Applied comments from @Anastasia - Added documentation for sycl_kernel function - Added comments to Sema.h - Added -std=c++11 to test run lines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

r361811 - Re-commit r357452 (take 2): "SimplifyCFG SinkCommonCodeFromPredecessors: Also sink function calls without used results (PR41259)"

Author: hans Date: Tue May 28 05:19:38 2019 New Revision: 361811 URL: http://llvm.org/viewvc/llvm-project?rev=361811&view=rev Log: Re-commit r357452 (take 2): "SimplifyCFG SinkCommonCodeFromPredecessors: Also sink function calls without used results (PR41259)" This was reverted in r360086 as it

Re: [PATCH] D62133: test/CodeGen/builtin-stackaddress.c duplicates test/CodeGen/2004-02-13-BuiltinFrameReturnAddress.c

Ping? On Mon, May 20, 2019 at 1:43 PM A. Skrobov via Phabricator wrote: > > t.yomitch created this revision. > t.yomitch added reviewers: efriedma, echristo, ddunbar. > Herald added a subscriber: kristina. > Herald added a project: clang. > > Repository: > rC Clang > > https://reviews.llvm.org/

r361818 - [Analyzer] Replace `CXXSelfAssignmentBRVisitor` with `NoteTags`

Author: baloghadamsoftware Date: Tue May 28 06:07:09 2019 New Revision: 361818 URL: http://llvm.org/viewvc/llvm-project?rev=361818&view=rev Log: [Analyzer] Replace `CXXSelfAssignmentBRVisitor` with `NoteTags` The `cplusplus.SelfAssignment` checker has a visitor that is added to every `BugReport`

[PATCH] D62479: [Analyzer] Replace `CXXSelfAssignmentBRVisitor` with `NoteTags`

This revision was automatically updated to reflect the committed changes. Closed by commit rC361818: [Analyzer] Replace `CXXSelfAssignmentBRVisitor` with `NoteTags` (authored by baloghadamsoftware, committed by ). Changed prior to commit: https://reviews.llvm.org/D62479?vs=201494&id=201645#toc

[PATCH] D61742: [Driver][Windows] Add dependent lib argument for profile instr generate

russell.gallop added a subscriber: ruiu. russell.gallop added a comment. > Hello, this embeds an absolute path into the generated .obj file, which means > the output now is no longer deterministic (since it depends on the absolute > path to clang_rt.profile-x86_64.lib). Yes, it embeds the absol

[PATCH] D62522: [clang-tidy] Verify fix description for misc-unused-using-decl.

hokein created this revision. hokein added a reviewer: gribozavr. Herald added a subscriber: xazax.hun. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D62522 Files: clang-tools-extra/test/clang-tidy/misc-unused-using-decls.cpp Index: clang-tools

[clang-tools-extra] r361823 - [clangd] Compute expected type for templates

Author: ibiryukov Date: Tue May 28 06:56:21 2019 New Revision: 361823 URL: http://llvm.org/viewvc/llvm-project?rev=361823&view=rev Log: [clangd] Compute expected type for templates Reviewers: sammccall Reviewed By: sammccall Subscribers: MaskRay, jkorous, arphaman, kadircet, cfe-commits Tags:

[PATCH] D62515: [clangd] Compute expected type for templates

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE361823: [clangd] Compute expected type for templates (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D62515?vs=201632&id=201656#toc Repository: rCTE Clang

[PATCH] D62523: Add release note entries for recent typo correction changes

thakis created this revision. thakis added a reviewer: hans. Herald added a project: LLVM. https://reviews.llvm.org/D62523 Files: clang/docs/ReleaseNotes.rst lld/docs/ReleaseNotes.rst Index: lld/docs/ReleaseNotes.rst === --- ll

r361824 - Add release note entries for recent typo correction changes

Author: nico Date: Tue May 28 07:04:48 2019 New Revision: 361824 URL: http://llvm.org/viewvc/llvm-project?rev=361824&view=rev Log: Add release note entries for recent typo correction changes Differential Revision: https://reviews.llvm.org/D62523 Modified: cfe/trunk/docs/ReleaseNotes.rst Mod

[PATCH] D60691: [ARM] Replace fp-only-sp and d16 with fp64 and d32.

simon_tatham marked 4 inline comments as done. simon_tatham added inline comments. Comment at: llvm/lib/Target/ARM/ARMSubtarget.h:587 bool hasVFP2() const { return HasVFPv2; } bool hasVFP3() const { return HasVFPv3; } ostannard wrote: > Are the old functi

[PATCH] D62523: Add release note entries for recent typo correction changes

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Looks great, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62523/new/ https://reviews.llvm.org/D62523 ___ cfe-commits mailing list c

[PATCH] D62523: Add release note entries for recent typo correction changes

This revision was automatically updated to reflect the committed changes. Closed by commit rLLD361824: Add release note entries for recent typo correction changes (authored by nico, committed by ). Changed prior to commit: https://reviews.llvm.org/D62523?vs=201657&id=201659#toc Repository: r

[PATCH] D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files

shixiao marked 2 inline comments as done. shixiao added a comment. > Could you please run this check over LLVM and give a short report of your > finding? I would imagine that there is a lot of duplication, given the > include-heavy nature of big c++ code bases. Sure. I'll run it and report back

[PATCH] D60691: [ARM] Replace fp-only-sp and d16 with fp64 and d32.

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. There already was consensus that this is was a good change, and also that we don't care about auto-upgrading. With the last minor comments addressed, this looks good I think. Perha

[PATCH] D62524: [clang-tidy] Fix description for misc-definitions-in-headers.

hokein created this revision. hokein added a reviewer: gribozavr. Herald added a subscriber: xazax.hun. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D62524 Files: clang-tools-extra/clang-tidy/misc/DefinitionsInHeadersCheck.cpp clang-tools-extr

[PATCH] D62525: [Analyzer] Add new visitor to the iterator checkers

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: NoQ, Szelethus. baloghadamsoftware added a project: clang. Herald added subscribers: Charusso, gamesh411, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity. Iterator bugs such as dereferenc

[PATCH] D62523: Add release note entries for recent typo correction changes

ruiu added a comment. LGTM Repository: rLLD LLVM Linker CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62523/new/ https://reviews.llvm.org/D62523 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[PATCH] D61742: [Driver][Windows] Add dependent lib argument for profile instr generate

thakis added a comment. After some more reading, it looks like passing `-no-canonical-prefixes` makes this path relative, and as long as compiles and links run from the same CWD things will work and be path-independent. So I think this is all good. Sorry about the false alarm! (Maybe we should

[PATCH] D62524: [clang-tidy] Fix description for misc-definitions-in-headers.

gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/misc/DefinitionsInHeadersCheck.cpp:133 +<< IsFullSpec << FD; +diag(FD->getLocation(), /*FixDescription=*/"make

r361829 - [CodeComplete] Consistently break after '{' in multi-line patterns

Author: ibiryukov Date: Tue May 28 07:33:16 2019 New Revision: 361829 URL: http://llvm.org/viewvc/llvm-project?rev=361829&view=rev Log: [CodeComplete] Consistently break after '{' in multi-line patterns Summary: Completion can return multi-line patterns in some cases, e.g. for (<#init#>; <#c

[PATCH] D62405: [CodeComplete] Consistently break after '{' in multi-line patterns

This revision was automatically updated to reflect the committed changes. Closed by commit rC361829: [CodeComplete] Consistently break after '{' in multi-line patterns (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D62405?vs=201274&id=201666#toc Repos

[PATCH] D62514: [CodeComplete] Set preferred type for qualified-id

ilya-biryukov added a comment. In D62514#1518941 , @kadircet wrote: > thanks, lgtm. > > one irrelevant question though, it looks like most of the calls to > `ResultBuilder::setPreferredType` performs a `!isNull` check before hand. > should we perform thi

[PATCH] D62527: [clangd] Remove the whitelist std symbols in CanonicalIncludes.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. These symbols have been included via StdSymbolMap.inc. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D

[clang-tools-extra] r361833 - [clang-tidy] Verify fix description for misc-unused-using-decl.

Author: hokein Date: Tue May 28 07:47:39 2019 New Revision: 361833 URL: http://llvm.org/viewvc/llvm-project?rev=361833&view=rev Log: [clang-tidy] Verify fix description for misc-unused-using-decl. Reviewers: gribozavr Subscribers: xazax.hun, cfe-commits Tags: #clang Differential Revision: http

[PATCH] D61467: [Rewrite] Extend to further accept CharSourceRange

jdenny added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61467/new/ https://reviews.llvm.org/D61467 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D59407: [clangd] Add RelationSlab

kadircet added a comment. btw, I believe you have enough good quality patches to apply for commit access. Are there any obstacles that is keeping you from applying? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59407/new/ https://reviews.llvm.org/

[PATCH] D62522: [clang-tidy] Verify fix description for misc-unused-using-decl.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE361833: [clang-tidy] Verify fix description for misc-unused-using-decl. (authored by hokein, committed by ). Changed prior to commit: https://reviews.llvm.org/D62522?vs=201654&id=201669#toc Repositor

[PATCH] D62524: [clang-tidy] Fix description for misc-definitions-in-headers.

hokein updated this revision to Diff 201670. hokein marked an inline comment as done. hokein added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62524/new/ https://reviews.llvm.org/D62524 Files: clang-tools-extra/clan

[clang-tools-extra] r361834 - [clang-tidy] Fix description for misc-definitions-in-headers.

Author: hokein Date: Tue May 28 07:50:42 2019 New Revision: 361834 URL: http://llvm.org/viewvc/llvm-project?rev=361834&view=rev Log: [clang-tidy] Fix description for misc-definitions-in-headers. Reviewers: gribozavr Subscribers: xazax.hun, cfe-commits Tags: #clang Differential Revision: https:

[PATCH] D62524: [clang-tidy] Fix description for misc-definitions-in-headers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL361834: [clang-tidy] Fix description for misc-definitions-in-headers. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D62435: Add Attribute NoThrow as an Exception Specifier Type

erichkeane updated this revision to Diff 201673. erichkeane marked 5 inline comments as done. erichkeane added a comment. Added warning + other comments from @aaron.ballman The exception state was further along than I expected, so I was able to make the warning better than I thought! CHANGES S

r361838 - [CodeComplete] Set preferred type for qualified-id

Author: ibiryukov Date: Tue May 28 08:21:03 2019 New Revision: 361838 URL: http://llvm.org/viewvc/llvm-project?rev=361838&view=rev Log: [CodeComplete] Set preferred type for qualified-id Reviewers: kadircet Reviewed By: kadircet Subscribers: cfe-commits Tags: #clang Differential Revision: htt

[PATCH] D62514: [CodeComplete] Set preferred type for qualified-id

This revision was automatically updated to reflect the committed changes. Closed by commit rL361838: [CodeComplete] Set preferred type for qualified-id (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[PATCH] D62507: [Dominators] PR42041: Skip nullpointer successors

kuhar added inline comments. Comment at: clang/include/clang/Analysis/Analyses/Dominators.h:190 +clang::CFGBlock *N, std::integral_constant) { + auto RChildren = reverse(children(N)); + ResultTy Ret(RChildren.begin(), RChildren.end()); Shouldn't one of the

[clang-tools-extra] r361841 - [clangd] Place cursor better after completing patterns

Author: ibiryukov Date: Tue May 28 08:33:37 2019 New Revision: 361841 URL: http://llvm.org/viewvc/llvm-project?rev=361841&view=rev Log: [clangd] Place cursor better after completing patterns Summary: By producing the $0 marker in the snippets at the last placeholder. This produces nicer results i

[PATCH] D62389: [clangd] Place cursor better after completing patterns

This revision was automatically updated to reflect the committed changes. Closed by commit rL361841: [clangd] Place cursor better after completing patterns (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: htt

[PATCH] D62507: [Dominators] PR42041: Skip nullpointer successors

Szelethus updated this revision to Diff 201679. Szelethus added a comment. Correctly use `reverse(children(N))` and `inverse_children(N)`, based on the original code: template struct ChildrenGetter { using ResultTy = SmallVector; static ResultTy Get(NodePtr N, std::integral_const

[PATCH] D62507: [Dominators] PR42041: Skip nullpointer successors

kuhar accepted this revision. kuhar added a comment. This revision is now accepted and ready to land. Thanks, I think this is a much better solution than directly hacking on DomTreeBuilder. Note that every time you ask DomTree about a `nullptr` CFG node, it understands it as a request for a vir

[PATCH] D61742: [Driver][Windows] Add dependent lib argument for profile instr generate

russell.gallop added a comment. > it looks like passing -no-canonical-prefixes makes this path relative Do you see this working? I tried writing a test and it doesn't appear to work for me. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61742/new/ https://review

[PATCH] D61742: [Driver][Windows] Add dependent lib argument for profile instr generate

thakis added a comment. It seems to work for me from what I can tell: $ out/gn/bin/clang-cl /c -fprofile-instr-generate /TC /dev/null -### -no-canonical-prefixes 2>&1 | grep -o 'dependent-lib=[^"]*' dependent-lib=libcmt dependent-lib=oldnames dependent-lib=out/gn/lib/clang/9.0.0/lib/wind

[PATCH] D60691: [ARM] Replace fp-only-sp and d16 with fp64 and d32.

This revision was automatically updated to reflect the committed changes. Closed by commit rC361845: [ARM] Replace fp-only-sp and d16 with fp64 and d32. (authored by statham, committed by ). Changed prior to commit: https://reviews.llvm.org/D60691?vs=201658&id=201691#toc Repository: rC Clang

r361845 - [ARM] Replace fp-only-sp and d16 with fp64 and d32.

Author: statham Date: Tue May 28 09:13:20 2019 New Revision: 361845 URL: http://llvm.org/viewvc/llvm-project?rev=361845&view=rev Log: [ARM] Replace fp-only-sp and d16 with fp64 and d32. Those two subtarget features were awkward because their semantics are reversed: each one indicates the _lack_ o

[clang-tools-extra] r361846 - [clangd] Fix test output for r361841

Author: ibiryukov Date: Tue May 28 09:28:27 2019 New Revision: 361846 URL: http://llvm.org/viewvc/llvm-project?rev=361846&view=rev Log: [clangd] Fix test output for r361841 Modified: clang-tools-extra/trunk/clangd/unittests/CodeCompleteTests.cpp Modified: clang-tools-extra/trunk/clangd/unitt

[PATCH] D62419: [LibTooling] Add `before` and `after` selectors for selecting point-ranges relative to nodes.

ilya-biryukov accepted this revision. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/Tooling/Refactoring/RangeSelector.cpp:124 +return CharSourceRange::getCharRange(

Re: [clang-tools-extra] r361841 - [clangd] Place cursor better after completing patterns

This broke buildbots due to a failing test. r361846 should fit it. Sorry for the inconvenience. On Tue, May 28, 2019 at 5:30 PM Ilya Biryukov via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ibiryukov > Date: Tue May 28 08:33:37 2019 > New Revision: 361841 > > URL: http://llvm.org/

[PATCH] D62225: [clang][NewPM] Fixing -O0 tests that are broken under new PM

efriedma added a comment. Are the behavior differences between the newpm alwaysinliner and the oldpm alwaysinliner intentional? Specifically, the differences in pass remarks, and the differences in the treatment of the alwaysinline attribute seem suspect. (I'm not that interested in the diffe

[PATCH] D61742: [Driver][Windows] Add dependent lib argument for profile instr generate

rnk added a comment. I was going to suggest that maybe what we should do is just embed the basename, i.e. `/nodefaultlib:clang_rt.profile-x86_64.lib`, and then we just ask users to add one `/libpath:` flag to their linker invocation. That saves users from having to come up with a mapping from t

[PATCH] D50147: clang-format: support external styles

Typz updated this revision to Diff 201693. Typz marked 3 inline comments as done. Typz added a comment. Herald added subscribers: ormris, mgorny. - Rebased - Adapt styles search path to platform conventions - Allow customizing search path at compile time - Allow overriding search path at runtime t

[PATCH] D62005: [libunwind] [test] Fix inferring source paths

mgorny added a comment. Ping. Could somebody review this, please? It's blocking NetBSD buildbot for quite some time already. Repository: rUNW libunwind CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62005/new/ https://reviews.llvm.org/D62005 ___

[PATCH] D62035: [AST] const-ify ObjC inherited class search

adamjernst added a comment. @beng (hello!!) I've spotted you reviewing some Objective-C clang stuff … can you review, or do you have advice on a qualified reviewer? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62035/new/ https://reviews.llvm.org/D62035 _

[PATCH] D58920: [Modules][PR39287] Consolidate multiple std's

modocache added a comment. @rsmith, what do you think of the patch as-is? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58920/new/ https://reviews.llvm.org/D58920 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D62525: [Analyzer] Add new visitor to the iterator checkers

baloghadamsoftware added a comment. Before someone asks: `NoteTag`s are not applicable here since invalidation and reaching one end of the range happens in many different places. This is also true for container emptiness. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D62533: Build with _XOPEN_SOURCE defined on AIX

daltenty created this revision. daltenty added reviewers: hubert.reinterpretcast, xingxue, andusy. daltenty added projects: LLVM, clang. Herald added subscribers: llvm-commits, cfe-commits, jsji, mgorny. It is useful to build with _XOPEN_SOURCE defined on AIX, enabling X/Open and POSIX compatibili

[PATCH] D62035: [AST] const-ify ObjC inherited class search

beng added a comment. Thanks! @jyknight might want to take a look (this seems fine to me though). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62035/new/ https://reviews.llvm.org/D62035 ___ cfe-commits mailing list

[PATCH] D62167: CodeView - add static data members to global variable debug info.

rnk added subscribers: manmanren, probinson. rnk added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4385 +// Use the global scope for static members. +DContext = getContextDescriptor( + cast(CGM.getContext().getTranslationUnitDecl()), TheCU); -

[PATCH] D60748: Fix i386 struct and union parameter alignment

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Yes, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60748/new/ https://reviews.llvm.org/D60748 ___ cfe-commits mailing list cfe

[PATCH] D62333: Fix unresolved symbols when linking tools/clang/unittests/Tooling/ToolingTests

quantum marked 2 inline comments as done. quantum added inline comments. Comment at: cfe/trunk/unittests/Tooling/CMakeLists.txt:4 Support TestingSupport ) thakis wrote: > The library is already up here. Why do we need it twice? We don't. It's removed in

[PATCH] D61742: [Driver][Windows] Add dependent lib argument for profile instr generate

russell.gallop added a comment. > I was going to suggest that maybe what we should do is just embed the > basename, i.e. /nodefaultlib:clang_rt.profile-x86_64.lib ... Do you mean /defaultlib:clang_rt.profile-x86_64.lib? > ... and then we just ask users to add one /libpath: flag to their linker

[PATCH] D61742: [Driver][Windows] Add dependent lib argument for profile instr generate

rnk added a comment. In D61742#1519539 , @russell.gallop wrote: > > I was going to suggest that maybe what we should do is just embed the > > basename, i.e. /nodefaultlib:clang_rt.profile-x86_64.lib ... > > Do you mean /defaultlib:clang_rt.profile-x86_64

[PATCH] D61742: [Driver][Windows] Add dependent lib argument for profile instr generate

thakis added a comment. Since this seems to work with no-canonical-prefixes, I think this is good as-is since people who want build path independent builds need that flag anyway. (At least if Russel can reproduce it working with no-canonical-prefixes; not sure why it wouldn't.) Repository:

[PATCH] D61974: [ObjC] Fix encoding of ObjC pointer types that are pointers to typedefs

ahatanak added a comment. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61974/new/ https://reviews.llvm.org/D61974 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D62538: [clangd] Add hidden tweaks to dump AST/selection.

sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, mgorny. Herald added a project: clang. This introduces a few new concepts: - tweaks have an Intent (they don't all advertise as refactorings) -

r361859 - Driver: support `/Zc:char8_t` and `/Zc:char8_t-`

Author: compnerd Date: Tue May 28 11:26:00 2019 New Revision: 361859 URL: http://llvm.org/viewvc/llvm-project?rev=361859&view=rev Log: Driver: support `/Zc:char8_t` and `/Zc:char8_t-` Update the `cl` emulation to support the `/Zc:char8_t[-]?` options as per the MSVC 2019.1 toolset. These are ali

[PATCH] D62493: [Driver] Always use Unix-style paths in the Darwin driver

rnk added a comment. So, there's nothing wrong, functionally speaking, with what we do today, right? It's just inconvenient to test. The difficulty of testing the driver has been a long standing problem. I think we might want to instead invent some new kind of alternative to `-###` for writing

[PATCH] D48680: Add missing visibility annotation for __base

manojgupta added a comment. Herald added a subscriber: libcxx-commits. Hi Peter and Marshall, Yunlian has moved to a different project. Can you let me know what is missing in this patch so that it can be submitted. Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D61974: [ObjC] Fix encoding of ObjC pointer types that are pointers to typedefs

rjmccall added inline comments. Comment at: lib/AST/ASTContext.cpp:6975 -isa(PointeeTy.getTypePtr()) && -!Options.EncodePointerToObjCTypedef()) { - // Another historical/compatibility reason. Is this option dead now? Repository: rC Clang

[PATCH] D62413: [OpenCL][PR41727] Prevent ICE on global dtors

rjmccall added inline comments. Comment at: lib/CodeGen/CGDeclCXX.cpp:132 + Argument = CGM.getTargetCodeGenInfo().performAddrSpaceCast( + CGM, Addr.getPointer(), SrcAS, LangAS::opencl_global, DestTy); Should this code be conditional to OpenCL? An

[clang-tools-extra] r361867 - [OpenMP] Set pragma start loc to `#pragma` loc

Author: jdenny Date: Tue May 28 12:27:19 2019 New Revision: 361867 URL: http://llvm.org/viewvc/llvm-project?rev=361867&view=rev Log: [OpenMP] Set pragma start loc to `#pragma` loc This patch adjusts `PragmaOpenMPHandler` to set the location of `tok::annot_pragma_openmp` to the `#pragma` location

[PATCH] D61509: [OpenMP] Set pragma start loc to `#pragma` loc

This revision was automatically updated to reflect the committed changes. Closed by commit rL361867: [OpenMP] Set pragma start loc to `#pragma` loc (authored by jdenny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://review

[PATCH] D62533: Build with _XOPEN_SOURCE defined on AIX

hubert.reinterpretcast added inline comments. Comment at: llvm/CMakeLists.txt:862 +# Build with _XOPEN_SOURCE on AIX, as stray macros in _ALL_SOURCE mode tend to +# break things. In this case we need to enable the LARGE FILE API as well +if (UNIX AND ${CMAKE_SYSTEM_NAME} MATCHES

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous updated this revision to Diff 201744. jkorous added a comment. Remove DirectoryWatcher::Event::EventKind::Added CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58418/new/ https://reviews.llvm.org/D58418 Files: clang/include/clang/DirectoryWatcher/DirectoryWatcher.h clang/lib/

[PATCH] D62525: [Analyzer] Add new visitor to the iterator checkers

NoQ added a comment. In D62525#1519475 , @baloghadamsoftware wrote: > Before someone asks: `NoteTag`s are not applicable here since invalidation > and reaching one end of the range happens in many different places. This is > also true for container empt

[PATCH] D61809: [BPF] Preserve debuginfo array/union/struct type/access index

yonghong-song added a comment. @rsmith @eli.friedman Do you have any comments on the clang intrinsic interface in this patch and the llvm intrinsics interface at https://reviews.llvm.org/D61810? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61809/new/ https://r

[PATCH] D48680: Add missing visibility annotation for __base

ldionne added a comment. What I don't understand is under which circumstances this changes anything, since we don't export `__base` from the dylib, and implicit instantiations of `__base` don't cause it to be exported. Can you please provide a sample program where this changes what's exported,

[PATCH] D59253: [AIX][libcxx] AIX system headers need stdint.h and inttypes.h to be re-enterable when macro _STD_TYPES_T is defined

xingxue updated this revision to Diff 201746. xingxue added a comment. Updated comments explaining the scenario of the changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59253/new/ https://reviews.llvm.org/D59253 Files: clang/lib/Headers/int

  1   2   >