simon_tatham marked 4 inline comments as done. simon_tatham added inline comments.
================ Comment at: llvm/lib/Target/ARM/ARMSubtarget.h:587 bool hasVFP2() const { return HasVFPv2; } bool hasVFP3() const { return HasVFPv3; } ---------------- ostannard wrote: > Are the old functions still used anywhere? If they are not used (much), I > think it would be better to just have one set of functions for the base FPU > version, and check hasFP64 and hasD32 where needed, to avoid the rick of > using the wrong version of these functions. Indeed, it turned out the old functions weren't used anywhere at all. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60691/new/ https://reviews.llvm.org/D60691 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits