r361664 - [Analyzer] Checker for non-determinism caused by iteration of unordered container of pointers

Author: mgrang Date: Fri May 24 12:24:08 2019 New Revision: 361664 URL: http://llvm.org/viewvc/llvm-project?rev=361664&view=rev Log: [Analyzer] Checker for non-determinism caused by iteration of unordered container of pointers Summary: Added a checker for non-determinism caused by iterating unor

[PATCH] D59279: [Analyzer] Checker for non-determinism caused by iteration of unordered container of pointers

This revision was automatically updated to reflect the committed changes. Closed by commit rL361664: [Analyzer] Checker for non-determinism caused by iteration of unordered… (authored by mgrang, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior t

[PATCH] D59402: Fix-it hints for -Wmissing-{prototypes,variable-declarations}

aaronpuchert marked an inline comment as done. aaronpuchert added a comment. In D59402#1516482 , @rsmith wrote: > In D59402#1516479 , @aaronpuchert > wrote: > > > In D59402#1516432

[PATCH] D59402: Fix-it hints for -Wmissing-{prototypes,variable-declarations}

aaronpuchert added a comment. In D59402#1516567 , @aaronpuchert wrote: > If that is wrong, then my reading is that fix-it hints for warnings must > always be applied to a note, because the recovery must be a no-op. Not true, because some warnings provi

[PATCH] D62419: [LibTooling] Add `before` and `after` selectors for selecting point-ranges relative to nodes.

ymandel created this revision. ymandel added a reviewer: ilya-biryukov. Herald added a project: clang. The `before` and `after` selectors allow users to specify a zero-length range -- a point -- at the relevant location in an AST-node's source. Point ranges can be useful, for example, to insert a

[PATCH] D62420: Rename clangToolingRefactor to clangToolingRefactoring for consistency with its directory

thakis created this revision. thakis added a reviewer: rsmith. Herald added subscribers: llvm-commits, kadircet, arphaman, jkorous, mgorny. Herald added a project: LLVM. See "[cfe-dev] The name of clang/lib/Tooling/Refactoring". https://reviews.llvm.org/D62420 Files: clang-tools-extra/clang-a

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

rsmith accepted this revision. rsmith marked an inline comment as done. rsmith added a comment. Looks good with a few largely-mechanical changes. Comment at: include/clang/Basic/DiagnosticParseKinds.td:30 "GNU-style inline assembly is disabled">; -def err_asm_goto_not_suppor

[PATCH] D62279: Use LTO capable linker

winksaville added a comment. So this compiles and as such improves on what we currently have and as such I think it should be merged, although there maybe other solutions. It still fails `ninja stage2-check-all` with the gtest problem which @beanz is working on resolving. Repository: rG LLVM

[PATCH] D59402: Fix-it hints for -Wmissing-{prototypes,variable-declarations}

rsmith added a comment. In D59402#1516589 , @aaronpuchert wrote: > Perhaps we could clarify in the docs that fix-it hints on warnings are > appropriate only if they don't change anything except suppressing the warning. That sounds like a great idea. Do

[PATCH] D61472: [X86FixupLEAs] Turn optIncDec into a generic two address LEA optimizer. Support LEA64_32r properly.

craig.topper added a comment. In D61472#1515994 , @spatel wrote: > I haven't looked closely at the series of transforms that gets us here, so > let me ask: would it be more efficient to produce the add/inc/dec machine > instructions directly rather than

[PATCH] D61970: [CodeGen][ObjC] Call objc_autoreleaseReturnValue and objc_retainAutoreleasedReturnValue instead of objc_autorelease and objc_retain in MRR

ahatanak abandoned this revision. ahatanak added a comment. This isn't the right way to make a call to `objc_autorelease` a tail call, so I'm closing this for now. If we decide to convert calls to `objc_autorelease` and `objc_retain` to calls to `objc_autoreleaseReturnValue` and `objc_retainAut

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous updated this revision to Diff 201321. jkorous added a comment. Specify what "file modified" means and add a test for metadata change CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58418/new/ https://reviews.llvm.org/D58418 Files: clang/cmake/modules/AddClang.cmake clang/incl

[PATCH] D60883: [OpenMP] Avoid emitting maps for target link variables when unified memory is used

ABataev added a comment. Just one question after looking at the test: how we're going to link the device variable to its host copy? I think the address should be passed to the runtime, no? Comment at: lib/CodeGen/CGOpenMPRuntime.h:1628 + /// Return whether the unified_shared

r361668 - Refactor use-marking to better match standard terminology. No

Author: rsmith Date: Fri May 24 13:42:25 2019 New Revision: 361668 URL: http://llvm.org/viewvc/llvm-project?rev=361668&view=rev Log: Refactor use-marking to better match standard terminology. No functionality change intended. Modified: cfe/trunk/lib/Sema/SemaExpr.cpp Modified: cfe/trunk/lib/

[PATCH] D61472: [X86FixupLEAs] Turn optIncDec into a generic two address LEA optimizer. Support LEA64_32r properly.

spatel accepted this revision. spatel added a comment. This revision is now accepted and ready to land. In D61472#1516642 , @craig.topper wrote: > In D61472#1515994 , @spatel wrote: > > > I haven't looked closely a

r361670 - Default arguments are potentially constant evaluated.

Author: rsmith Date: Fri May 24 14:08:12 2019 New Revision: 361670 URL: http://llvm.org/viewvc/llvm-project?rev=361670&view=rev Log: Default arguments are potentially constant evaluated. We need to eagerly instantiate constexpr functions used in them even if the default argument is never actually

RE: r361562 - Use clang_cc1 instead of clang in CodeGen test.

Hi Alina, This test that you added seems to fail on targets that don't build the x86 backend, for example: http://lab.llvm.org:8011/builders/clang-cmake-armv7-selfhost-neon/builds/1855 TEST 'Clang :: CodeGen/loop-vectorize.c' FAILED Script: -- : 'RUN:

[PATCH] D62429: Fix linkage of _ZTS strings for types involving incomplete classes to match the Itanium ABI rules.

rsmith created this revision. rsmith added a reviewer: rjmccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. Without this patch, type_info objects for pointers to incomplete classes compare unequal with libc++ when formed in multiple translation units, because each trans

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous updated this revision to Diff 201338. jkorous added a comment. - simplify link libraries in cmake - fix Release build (messed-up asserts) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58418/new/ https://reviews.llvm.org/D58418 Files: clang/include/clang/DirectoryWatcher/Direc

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 201339. plotfi added a comment. More test improvement. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 Files: clang/include/clang/Driver/Options.td clang/include/cla

r361674 - Mark tests as x86.

Author: asbirlea Date: Fri May 24 14:49:27 2019 New Revision: 361674 URL: http://llvm.org/viewvc/llvm-project?rev=361674&view=rev Log: Mark tests as x86. Modified: cfe/trunk/test/CodeGen/loop-unroll.c cfe/trunk/test/CodeGen/loop-vectorize.c Modified: cfe/trunk/test/CodeGen/loop-unroll.c

[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

stephanemoore accepted this revision. stephanemoore marked 2 inline comments as done. stephanemoore added a comment. (sorry I forgot to send this earlier) Two small things and then I think everything is good. Comment at: clang-tools-extra/clang-tidy/google/GlobalVariableDecla

Re: r361562 - Use clang_cc1 instead of clang in CodeGen test.

Hi Douglas, Please let me know if the build is fixed after r361674. Thank you, Alina On Fri, May 24, 2019 at 2:26 PM wrote: > Hi Alina, > > This test that you added seems to fail on targets that don't build the x86 > backend, for example: > > > http://lab.llvm.org:8011/builders/clang-cmake-ar

[PATCH] D62167: CodeView - add static data members to global variable debug info.

akhuang marked an inline comment as done. akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4385 +// Use the global scope for static members. +DContext = getContextDescriptor( + cast(CGM.getContext().getTranslationUnitDecl()), TheCU);

[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

yaqiji updated this revision to Diff 201352. yaqiji marked 3 inline comments as done. yaqiji added a comment. Added fix message, and change global to nonstatic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D6204

[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

stephanemoore accepted this revision. stephanemoore added a comment. Looks good! Thanks for being patient with me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 _

[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

yaqiji added a comment. Thank you so much for reviewing the code and providing great feedbacks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 ___ cfe-commits

[PATCH] D61816: [CFG] [analyzer] pr41300: Add a branch to skip virtual base initializers when they are handled by the superclass.

NoQ added inline comments. Comment at: clang/include/clang/Analysis/CFG.h:567 +/// &&, ||| expression that uses result of && or ||, RHS +/// vbase inits | handled by superclass; not handled by superclass /// Szelethus wrote: > In the context

[PATCH] D61816: [CFG] [analyzer] pr41300: Add a branch to skip virtual base initializers when they are handled by the superclass.

NoQ updated this revision to Diff 201354. NoQ marked 14 inline comments as done. NoQ added a comment. In D61816#1504590 , @Szelethus wrote: > Hmmm, how about this? > ... > You are right that all virtual bases as initialized before everything else, > but

[PATCH] D61816: [CFG] [analyzer] pr41300: Add a branch to skip virtual base initializers when they are handled by the superclass.

Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/CoreEngine.cpp:451 + if (const auto *CallerCtor = dyn_cast_or_null( + LCtx->getStackFrame()->getCallSite())) { +switch (CallerCtor->getConstructionKind()) { NoQ wrote: > Charu

[PATCH] D61816: [CFG] [analyzer] pr41300: Add a branch to skip virtual base initializers when they are handled by the superclass.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/CoreEngine.cpp:451 + if (const auto *CallerCtor = dyn_cast_or_null( + LCtx->getStackFrame()->getCallSite())) { +switch (CallerCtor->getConstructionKind()) { --

[PATCH] D61816: [CFG] [analyzer] pr41300: Add a branch to skip virtual base initializers when they are handled by the superclass.

Charusso accepted this revision. Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/CoreEngine.cpp:451 + if (const auto *CallerCtor = dyn_cast_or_null( + LCtx->getStackFrame()->getCallSite())) { +switch (CallerCtor->getConstructionKind()) { --

[PATCH] D61817: [analyzer] Add a prunable note for skipping virtual base initializers in subclasses.

NoQ updated this revision to Diff 201359. NoQ added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61817/new/ https://reviews.llvm.org/D61817 Files: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h clang/include/clang/StaticAnalyzer/Core/PathSensi

[PATCH] D62435: Add Attribute NoThrow as an Exception Specifier Type

erichkeane created this revision. erichkeane added reviewers: rnk, lebedev.ri, aaron.ballman. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. In response to https://bugs.llvm.org/show_bug.cgi?id=33235, it became clear that the current mechanism of hacking through ch

[PATCH] D61816: [CFG] [analyzer] pr41300: Add a branch to skip virtual base initializers when they are handled by the superclass.

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. LGTM! Nicely done! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61816/new/ https://reviews.llvm.org/D61816 ___ cfe-commits mailin

[PATCH] D62435: Add Attribute NoThrow as an Exception Specifier Type

rsmith requested changes to this revision. rsmith added a comment. This revision now requires changes to proceed. Seems like a nice approach to the problem, but we need to not break the libclang C ABI :) Comment at: clang/include/clang-c/Index.h:202-204 + * The cursor has a

r361680 - Fix crash deserializing a CUDAKernelCallExpr with a +Asserts binary.

Author: rsmith Date: Fri May 24 16:26:07 2019 New Revision: 361680 URL: http://llvm.org/viewvc/llvm-project?rev=361680&view=rev Log: Fix crash deserializing a CUDAKernelCallExpr with a +Asserts binary. The assertion in setConfig read from the (uninitialized) CONFIG expression. Modified: cfe/

[PATCH] D62437: [clang-tidy] Splits fuchsia-default-arguments

DiegoAstiazaran created this revision. DiegoAstiazaran added a reviewer: juliehockett. DiegoAstiazaran added a project: clang-tools-extra. Herald added subscribers: xazax.hun, mgorny. Splits fuchsia-default-arguments check into two checks. fuchsia-default-arguments-calls warns if a function or me

r361681 - [CFG] Add branch to skip vbase inits when they're handled by superclass.

Author: dergachev Date: Fri May 24 16:37:08 2019 New Revision: 361681 URL: http://llvm.org/viewvc/llvm-project?rev=361681&view=rev Log: [CFG] Add branch to skip vbase inits when they're handled by superclass. This patch adds the run-time CFG branch that would skip initialization of virtual base c

r361682 - [analyzer] Add a prunable note for skipping vbase inits in subclasses.

Author: dergachev Date: Fri May 24 16:37:11 2019 New Revision: 361682 URL: http://llvm.org/viewvc/llvm-project?rev=361682&view=rev Log: [analyzer] Add a prunable note for skipping vbase inits in subclasses. When initialization of virtual base classes is skipped, we now tell the user about it, bec

[PATCH] D61816: [CFG] [analyzer] pr41300: Add a branch to skip virtual base initializers when they are handled by the superclass.

This revision was automatically updated to reflect the committed changes. Closed by commit rL361681: [CFG] Add branch to skip vbase inits when they're handled by superclass. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prio

[PATCH] D61817: [analyzer] Add a prunable note for skipping virtual base initializers in subclasses.

This revision was automatically updated to reflect the committed changes. Closed by commit rC361682: [analyzer] Add a prunable note for skipping vbase inits in subclasses. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D61817?vs=201359&id=201364#toc R

[PATCH] D62437: [clang-tidy] Splits fuchsia-default-arguments

Eugene.Zelenko added a comment. Please mention renaming of existing check in Release Notes (after list of new checks). Comment at: clang-tools-extra/clang-tidy/fuchsia/DefaultArgumentsDeclarationsCheck.cpp:23 +void DefaultArgumentsDeclarationsCheck::check(const MatchFinder::M

[PATCH] D62437: [clang-tidy] Splits fuchsia-default-arguments

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/fuchsia/DefaultArgumentsCallsCheck.cpp:1 +//===--- DefaultArgumentsCallsCheck.cpp - clang-tidy---===// +// Please add space after clang-tidy. C

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D61707: [Preprocessor] Fix crash emitting note with framework location for "file not found" error.

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61707/new/ https://reviews.llvm.org/D61707 ___ cfe-commits mailing list cfe-commi

r361684 - Rename clangToolingRefactor to clangToolingRefactoring for consistency with its directory

Author: nico Date: Fri May 24 17:27:19 2019 New Revision: 361684 URL: http://llvm.org/viewvc/llvm-project?rev=361684&view=rev Log: Rename clangToolingRefactor to clangToolingRefactoring for consistency with its directory See "[cfe-dev] The name of clang/lib/Tooling/Refactoring". Differential Re

[clang-tools-extra] r361684 - Rename clangToolingRefactor to clangToolingRefactoring for consistency with its directory

Author: nico Date: Fri May 24 17:27:19 2019 New Revision: 361684 URL: http://llvm.org/viewvc/llvm-project?rev=361684&view=rev Log: Rename clangToolingRefactor to clangToolingRefactoring for consistency with its directory See "[cfe-dev] The name of clang/lib/Tooling/Refactoring". Differential Re

[PATCH] D62420: Rename clangToolingRefactor to clangToolingRefactoring for consistency with its directory

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE361684: Rename clangToolingRefactor to clangToolingRefactoring for consistency with its… (authored by nico, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llv

[PATCH] D60883: [OpenMP] Avoid emitting maps for target link variables when unified memory is used

gtbercea added a comment. In D60883#1516693 , @ABataev wrote: > Just one question after looking at the test: how we're going to link the > device variable to its host copy? I think the address should be passed to the > runtime, no? The runtime will tak

r361685 - Revert "[Analysis] Link library dependencies to Analysis plugins"

Author: ahatanak Date: Fri May 24 17:50:03 2019 New Revision: 361685 URL: http://llvm.org/viewvc/llvm-project?rev=361685&view=rev Log: Revert "[Analysis] Link library dependencies to Analysis plugins" This reverts commit r361340. The following builder has been broken for the past few days because

Re: r361340 - [Analysis] Link library dependencies to Analysis plugins

I reverted the patch in r361685 to make the bot green again. > On May 23, 2019, at 5:22 PM, Akira Hatanaka wrote: > > Hi Petr, > > This seems to have caused Analysis/checker-plugins.c to fail. Can you > investigate it or revert your commit? > > http://green.lab.llvm.org/green/job/clang-stage2

[PATCH] D62437: [clang-tidy] Splits fuchsia-default-arguments

DiegoAstiazaran updated this revision to Diff 201375. DiegoAstiazaran added a comment. Reduces lines to 80 characters. The files have been also formatted by clang-format. Types are replaced by auto in declarations where the type is spelled in cast. CHANGES SINCE LAST ACTION https://reviews.ll

r361686 - Permit static local structured bindings to be named from arbitrary scopes inside their declaring scope.

Author: rsmith Date: Fri May 24 18:04:17 2019 New Revision: 361686 URL: http://llvm.org/viewvc/llvm-project?rev=361686&view=rev Log: Permit static local structured bindings to be named from arbitrary scopes inside their declaring scope. Modified: cfe/trunk/include/clang/AST/DeclCXX.h cfe

[clang-tools-extra] r361687 - [clangd] tweaks: Add clangBasic dependency to LINK_LIBS

Author: aheejin Date: Fri May 24 18:35:14 2019 New Revision: 361687 URL: http://llvm.org/viewvc/llvm-project?rev=361687&view=rev Log: [clangd] tweaks: Add clangBasic dependency to LINK_LIBS This is necessary to make builds with `-DBUILD_SHARED_LIBS=ON` work. Modified: clang-tools-extra/trunk

[PATCH] D62440: [analyzer] NFC: Change evalCall() to provide a CallEvent.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, mikhail.ramalho, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, a.sidorin, szepet. Herald added a project: clang. This is mostly motivated by me being an

[PATCH] D62441: [analyzer] Introduce a convenient CallDescriptionMap class.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, mikhail.ramalho, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, a.sidorin, szepet, mgorny. Herald added a project: clang. > "When choosing a container,

[PATCH] D62441: [analyzer] NFC: Introduce a convenient CallDescriptionMap class.

NoQ updated this revision to Diff 201382. NoQ added a comment. Bring back an assertion in `findNode<>()`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62441/new/ https://reviews.llvm.org/D62441 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h clang/unittest

[PATCH] D62442: [Driver] Update handling of c++ and runtime directories

phosek created this revision. phosek added reviewers: mcgrathr, leonardchan, saugustine, echristo. Herald added subscribers: cfe-commits, javed.absar, kubamracek. Herald added a project: clang. This is a follow up to r361432 and r361504 which addresses issues introduced by those changes. Specifica

[PATCH] D60543: [clang] Update isDerivedFrom to support Objective-C classes 🔍

stephanemoore updated this revision to Diff 201384. stephanemoore added a comment. Update isDerivedFrom and related matchers to polymorphic matchers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60543/new/ https://reviews.llvm.org/D60543 Files:

[PATCH] D60543: [clang] Update isDerivedFrom to support Objective-C classes 🔍

stephanemoore updated this revision to Diff 201385. stephanemoore marked an inline comment as done. stephanemoore added a comment. Add missing braces to multi-line if statements. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60543/new/ https://revi

[PATCH] D60543: [clang] Update isDerivedFrom to support Objective-C classes 🔍

stephanemoore accepted this revision. stephanemoore added a comment. This revision is now accepted and ready to land. Okay I now have an implementation of Option 2 that //works//. I was hoping to find a more elegant solution but since this is the first working implementation of Option 2 I was ab

[PATCH] D62442: [Driver] Update handling of c++ and runtime directories

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm contingent on verifying intended behavior changes and adding comments. The factoring suggestion for the triple,triple searching is preferred but at your discretion, though I'd really

[PATCH] D62445: [test] Fix plugin tests

hintonda created this revision. hintonda added reviewers: beanz, phosek, george.karpenkov, NoQ, ahatanak, rjmccall. Herald added subscribers: llvm-commits, dexonsmith, mgorny. Herald added projects: clang, LLVM. hintonda edited the summary of this revision. The following changes were required to

[PATCH] D61472: [X86FixupLEAs] Turn optIncDec into a generic two address LEA optimizer. Support LEA64_32r properly.

This revision was automatically updated to reflect the committed changes. Closed by commit rL361691: [X86FixupLEAs] Turn optIncDec into a generic two address LEA optimizer. Support… (authored by ctopper, committed by ). Herald added a subscriber: qcolombet. Changed prior to commit: https://revi

[PATCH] D57184: [clang-format] Allow configuring list of function-like macros that resolve to a type

dextero updated this revision to Diff 201393. dextero marked an inline comment as done. dextero added a comment. - [clang-format] Make documentation a bit clearer - Rebased onto recent master @Typz: thank you for the review! I don't have push access to the repository though. Could you commit thi

<    1   2