aaronpuchert added a comment.

In D59402#1516567 <https://reviews.llvm.org/D59402#1516567>, @aaronpuchert 
wrote:

> If that is wrong, then my reading is that fix-it hints for warnings must 
> always be applied to a note, because the recovery must be a no-op.


Not true, because some warnings provide fix-it hints that don't actually change 
anything except suppressing the warning, for example `-Wshift-op-parentheses`.

Perhaps we could clarify in the docs that fix-it hints on warnings are 
appropriate only if they don't change anything except suppressing the warning.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59402/new/

https://reviews.llvm.org/D59402



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to