[PATCH] D61931: [Driver] Use --android-tls for Android ARM/AArch64 when lld is used

srhines added a comment. This LGTM if Ryan is happy with it. Thanks for taking care of getting a workaround implemented until this can be fixed. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61931/new/ https://reviews.llvm.org/D61931 _

[PATCH] D61909: Add Clang shared library with C++ exports

sylvestre.ledru added a comment. ok, it should probably be installed in that case (it is currently in usr/lib/llvm-9/lib/libclang_shared.so.9 ) by the way, the name of lib isn't super explicit :/ Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61909/new/ https://r

r361059 - Revert r361033 "Add a Visit overload for DynTypedNode to ASTNodeTraverser"

Author: nico Date: Fri May 17 11:31:24 2019 New Revision: 361059 URL: http://llvm.org/viewvc/llvm-project?rev=361059&view=rev Log: Revert r361033 "Add a Visit overload for DynTypedNode to ASTNodeTraverser" It fails to build on some bots. Also revert follow-up r361055. Removed: cfe/trunk/uni

Re: r361033 - Add a Visit overload for DynTypedNode to ASTNodeTraverser

*From: *Stephen Kelly via cfe-commits *Date: *Fri, May 17, 2019 at 1:56 PM *To: *Yitzhak Mandelbaum *Cc: *cfe-commits Hmm, thanks for letting me know! > > Is that an old compiler? > > I'm not near a computer for the weekend. > > Can someone fix or revert? > Sure, reverted in 361059. > > Thanks

[PATCH] D62034: compiler-rt/lib/builtins: s/#include /#include /g to match proper case.

plotfi added a comment. Herald added a subscriber: dexonsmith. In D62034#1506102 , @mstorsjo wrote: > Yes, MinGW headers are all lowercase. > > And the Windows SDK, where the file is spelled with a capital W, isn't > self-consistent (some headers include

[PATCH] D62034: compiler-rt/lib/builtins: s/#include /#include /g to match proper case.

plotfi updated this revision to Diff 200067. plotfi added a comment. Herald added subscribers: openmp-commits, libcxx-commits, lldb-commits, cfe-commits, lebedev.ri, kadircet, arphaman, jkorous, christof, hiraditya, mgorny, ki.stfu, kubamracek. Herald added a reviewer: jfb. Herald added a reviewe

[PATCH] D62034: compiler-rt/lib/builtins: s/#include /#include /g to match proper case.

mclow.lists added a comment. I have no objection to this; but I'm not really confident that this won't break more than it solves. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62034/new/ https://reviews.llvm.org/D62034 _

[PATCH] D62034: compiler-rt/lib/builtins: s/#include /#include /g to match proper case.

plotfi added a comment. In D62034#1506879 , @mclow.lists wrote: > I have no objection to this; but I'm not really confident that this won't > break more than it solves. Actually, I think the existing VFS overlay would fix this without any changes. So I

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ymandel updated this revision to Diff 200072. ymandel added a comment. Updated to incorporate changes to Transformer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61386/new/ https://reviews.llvm.org/D61386 Files: clang-tools-extra/clang-tidy/ut

[PATCH] D62034: compiler-rt/lib/builtins: s/#include /#include /g to match proper case.

mstorsjo requested changes to this revision. mstorsjo added a comment. This revision now requires changes to proceed. No, I don't think this is a good idea. Like I said, the Windows SDK is not self-consistent, so you cannot use it on a case sensitive file system without other case insensitivity

[PATCH] D62045: Modified global variable declaration to fit updated objc guide.

benhamilton requested changes to this revision. benhamilton added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/clang-tidy/google/GlobalVariableDeclarationCheck.cpp:51-52 + + auto NewName = "g" + llvm::StringRef(std::string(1, FC)

[PATCH] D61909: Add Clang shared library with C++ exports

beanz added a comment. @sylvestre.ledru, I’ve added you on D62040 , which is an attempt to document best practices for generating releases. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61909/new/ https://reviews.llvm.org/D61909

r361066 - [OpenMP][bugfix] Add missing math functions variants for log and abs.

Author: gbercea Date: Fri May 17 12:15:53 2019 New Revision: 361066 URL: http://llvm.org/viewvc/llvm-project?rev=361066&view=rev Log: [OpenMP][bugfix] Add missing math functions variants for log and abs. Summary: When including the random header in C++, some of the math functions it relies on ar

[PATCH] D62046: [OpenMP][bugfix] Add missing math functions variants for log and abs.

This revision was automatically updated to reflect the committed changes. Closed by commit rC361066: [OpenMP][bugfix] Add missing math functions variants for log and abs. (authored by gbercea, committed by ). Changed prior to commit: https://reviews.llvm.org/D62046?vs=200048&id=200076#toc Repo

r361067 - [c++20] P1327R1: Support for typeid applied to objects of polymorphic

Author: rsmith Date: Fri May 17 12:19:28 2019 New Revision: 361067 URL: http://llvm.org/viewvc/llvm-project?rev=361067&view=rev Log: [c++20] P1327R1: Support for typeid applied to objects of polymorphic class type in constant evaluation. This reinstates r360977, reverted in r360987, now that its

[PATCH] D61774: [LibTooling] Add RangeSelector library for defining source ranges based on bound AST nodes.

ymandel updated this revision to Diff 200079. ymandel marked 2 inline comments as done. ymandel added a comment. fixed formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61774/new/ https://reviews.llvm.org/D61774 Files: clang/include/clan

[PATCH] D62045: Modified global variable declaration to fit updated objc guide.

stephanemoore requested changes to this revision. stephanemoore marked 4 inline comments as done. stephanemoore added inline comments. Comment at: clang-tools-extra/clang-tidy/google/GlobalVariableDeclarationCheck.cpp:51-52 + + auto NewName = "g" + llvm::StringRef(std::string(1

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea updated this revision to Diff 200088. gtbercea added a comment. - Fix conditions. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/Cod

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea updated this revision to Diff 200089. gtbercea marked 3 inline comments as done. gtbercea added a comment. - Fix format. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 Files: lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea updated this revision to Diff 200091. gtbercea added a comment. - Fix braces. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/CodeGen

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim updated this revision to Diff 200094. hctim added a comment. Merged in master after fixing up some buildbots with the previous patches. Also have pinged libcxx-dev :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61923/new/ https://reviews.l

LLvm masrer and llvm lab unavailable tomorrow

Hello everyone, LLvm masrer and llvm lab will be unavailable tomorrow Saturday, May 18th, from 10:30 am to 2:00 pm PST due to works related to an infrastructure improvement project. Thank you for understanding. Thanks Galina ___ cfe-commits mailing lis

[PATCH] D62045: Modified global variable declaration to fit updated objc guide.

yaqiji updated this revision to Diff 200102. yaqiji added a comment. Updated matching criteria to allow variable declarations for legacy code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 Files: clang-t

[PATCH] D61617: [NewPassManager] Add tuning option: SLPVectorization [clang-change]

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61617/new/ https://reviews.llvm.org/D61617 ___ cfe-comm

[PATCH] D62045: Modified global variable declaration to fit updated objc guide.

stephanemoore requested changes to this revision. stephanemoore added a comment. This revision now requires changes to proceed. Thanks for restoring the support for the legacy style! I noticed that there are some cases where we can preserve an existing fixit. Comment at: clan

[PATCH] D62045: Modified global variable declaration to fit updated objc guide.

yaqiji updated this revision to Diff 200113. yaqiji marked an inline comment as done. yaqiji added a comment. Added fixithint for const as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 Files: clan

[PATCH] D61809: [BPF] Preserve debuginfo array/union/struct type name/access index

yonghong-song updated this revision to Diff 200117. yonghong-song edited the summary of this revision. yonghong-song added a comment. array index may not be constant and remove inst_name Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61809/new/ https://reviews.llv

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous updated this revision to Diff 200123. jkorous added a comment. fix link libraries in cmake CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58418/new/ https://reviews.llvm.org/D58418 Files: clang/cmake/modules/AddClang.cmake clang/include/clang/DirectoryWatcher/DirectoryWatche

[PATCH] D62045: Modified global variable declaration to fit updated objc guide.

stephanemoore added inline comments. Comment at: clang-tools-extra/clang-tidy/google/GlobalVariableDeclarationCheck.cpp:45 + + auto NewName = (IsConst? "k": "g") + llvm::StringRef(std::string(1, FC)).upper()) + + Decl->getName().substr(1).str());

[PATCH] D62092: [analyzer] Create the beta package that is more stable than alpha, move unix.cstring.OutOfBounds there

Szelethus created this revision. Szelethus added reviewers: NoQ, dkrupp, o.gyorgy, dcoughlin, Charusso, a.sidorin, xazax.hun, rnkovacs. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, donat.nagy, mikhail.ramalho, szepet, baloghadamsoftware, whisperity. As per

[PATCH] D62093: [analyzer] Divide checkers into 3 categories: released, alpha, developer

Szelethus created this revision. Szelethus added reviewers: NoQ, dcoughlin, dkrupp, o.gyorgy, xazax.hun, rnkovacs, Charusso, a.sidorin. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, donat.nagy, mikhail.ramalho, szepet, baloghadamsoftware, whisperity. Szelethu

[PATCH] D61839: [analyzer] Hide developer-only checker/package options by default

Szelethus updated this revision to Diff 200127. Szelethus retitled this revision from "[analyzer][WIP] Hide developer-only checker/package options by default" to "[analyzer] Hide developer-only checker/package options by default". Szelethus added a comment. - Hide several more checkers - Rename

[PATCH] D62094: [analyzer] Categorize checker/plugin options into 3 categories, same as for checkers

Szelethus created this revision. Szelethus added reviewers: NoQ, dcoughlin, rnkovacs, xazax.hun, Charusso, a_sidorin, dkrupp, o.gyorgy. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, donat.nagy, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, whisperit

[PATCH] D38479: Make -mgeneral-regs-only more like GCC's

phosek added a comment. We (Fuchsia) would like to see this landed as well so we can start using this in our kernel. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D38479/new/ https://reviews.llvm.org/D38479 ___ cfe-commits mailing list cfe-

[PATCH] D61931: [Driver] Use --android-tls for Android ARM/AArch64 when lld is used

MaskRay abandoned this revision. MaskRay added a comment. Abandon in favor of D62055 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61931/new/ https://reviews.llvm.org/D61931 ___ cfe-

<    1   2