benhamilton requested changes to this revision. benhamilton added inline comments. This revision now requires changes to proceed.
================ Comment at: clang-tools-extra/clang-tidy/google/GlobalVariableDeclarationCheck.cpp:51-52 + + auto NewName = "g" + llvm::StringRef(std::string(1, FC)).upper()) + + Decl->getName().substr(1).str()); + ---------------- I don't see any guidance in the style guide about prefixing with `g` either. I assume we should remove that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
