[PATCH] D59711: PR41183: Don't emit Wstrict-prototypes warning for an implicit function declaration.

This revision was automatically updated to reflect the committed changes. Closed by commit rC360084: PR41183: Don't emit strict-prototypes warning for an implicit function (authored by jyknight, committed by ). Changed prior to commit: https://reviews.llvm.org/D59711?vs=191924&id=198341#toc Re

r360084 - PR41183: Don't emit strict-prototypes warning for an implicit function

Author: jyknight Date: Mon May 6 14:37:59 2019 New Revision: 360084 URL: http://llvm.org/viewvc/llvm-project?rev=360084&view=rev Log: PR41183: Don't emit strict-prototypes warning for an implicit function declaration. It should emit _only_ an implicit-function-declaration warning, not both of th

[PATCH] D61545: [analyzer] Fix a crash in RVO from within blocks.

NoQ updated this revision to Diff 198342. NoQ added a comment. No, this is all wrong. We shouldn't unwrap to the parent stack frame here. We should end up exactly in the location context in which the call has happened. But we should still unwrap the block invocation context, as an exception, be

r360086 - Revert "Re-commit r357452: SimplifyCFG SinkCommonCodeFromPredecessors: Also sink function calls without used results (PR41259)"

Author: rupprecht Date: Mon May 6 14:55:05 2019 New Revision: 360086 URL: http://llvm.org/viewvc/llvm-project?rev=360086&view=rev Log: Revert "Re-commit r357452: SimplifyCFG SinkCommonCodeFromPredecessors: Also sink function calls without used results (PR41259)" This reverts r357452 (git commit

[PATCH] D49587: [CMake] Support exporting runtimes using the CMake export

phosek added a comment. In D49587#1488328 , @smeenai wrote: > Seems like you got the wrong diff. It was the right diff but uploaded to a wrong change ;) In D49587#1484829 , @smeenai wrote: > Sorry, had missed th

[PATCH] D49511: [Sema/Attribute] Check for noderef attribute

leonardchan marked 2 inline comments as done. leonardchan added inline comments. Comment at: lib/Sema/SemaType.cpp:4913-4916 +ExpectNoDerefChunk = false; + } + + ExpectNoDerefChunk = state.didParseNoDeref(); dblaikie wrote: > Pointed out in PR41

r360089 - [Sema] Fix for P41774 where `ExpectNoDerefChunk` is assigned twice

Author: leonardchan Date: Mon May 6 15:09:12 2019 New Revision: 360089 URL: http://llvm.org/viewvc/llvm-project?rev=360089&view=rev Log: [Sema] Fix for P41774 where `ExpectNoDerefChunk` is assigned twice Modified: cfe/trunk/lib/Sema/SemaType.cpp Modified: cfe/trunk/lib/Sema/SemaType.cpp URL

[PATCH] D49587: [CMake] Support exporting runtimes using the CMake export

phosek updated this revision to Diff 198347. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49587/new/ https://reviews.llvm.org/D49587 Files: clang/cmake/c

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and include/c++

echristo added reviewers: saugustine, cmatthews. echristo added a comment. Adding Sterling and Chris to this to take a look at the new layout :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59168/new/ https://reviews.llvm.org/D59168 ___ cf

[PATCH] D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard

trixirt updated this revision to Diff 198352. trixirt retitled this revision from "[clang-tidy] misc-header-guard : a simple version of llvm-header-guard" to "[clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard". trixirt added a comment. Move from misc to bugprone Repo

[PATCH] D61615: [COFF] Use COFF stubs for extern_weak functions

rnk created this revision. rnk added reviewers: smeenai, mstorsjo. Herald added subscribers: cfe-commits, hiraditya. Herald added projects: clang, LLVM. A COFF stub indirects the reference to a symbol through memory. A .refptr.$sym global variable pointer is created to refer to $sym. Typically min

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

erik.pilkington added a comment. Duncan pointed out eel.is/c++draft/class.init#class.base.init-13, which appears to claim that initialization ends with the execution of the constructor, excluding temporary destructors. > (13) In a non-delegating constructor, initialization proceeds in the > fo

[PATCH] D49587: [CMake] Support exporting runtimes using the CMake export

smeenai added inline comments. Comment at: libunwind/src/CMakeLists.txt:160 if (LIBUNWIND_INSTALL_LIBRARY) - install(TARGETS ${LIBUNWIND_INSTALL_TARGETS} + if(libcxxabi IN_LIST LLVM_RUNTIME_DISTRIBUTION_COMPONENTS) +set(export_to_llvmruntimes EXPORT LLVMRuntimes) -

[PATCH] D58374: [Clang][NewPM] Don't bail out if the target machine is empty

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58374/new/ https://reviews.llvm.org/D58374 ___ cfe-com

[PATCH] D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard

trixirt added a comment. All of the real work is the header-guard checks is done by their common base class utils/HeaderGuard. The much smaller llvm and bugprone subclasses are only concerned with the style of the fix. My understanding of the directory layout guidance in the docs is that differ

[PATCH] D61615: [COFF] Use COFF stubs for extern_weak functions

rnk updated this revision to Diff 198359. rnk added a comment. - fix some tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61615/new/ https://reviews.llvm.org/D61615 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/test/CodeGen/dso-local-ex

[PATCH] D61617: [NewPassManager] Add tuning option: SLPVectorization [clang-change]

asbirlea created this revision. asbirlea added a reviewer: chandlerc. Herald added subscribers: cfe-commits, jlebar. Herald added a project: clang. NewPassManager is not using CodeGenOpts values before this patch. [to be coupled with D61616 ] Repository: rC Cla

[PATCH] D61619: Make language option `GNUAsm` discoverable with `__has_extension` macro.

vsapsai created this revision. vsapsai added reviewers: aaron.ballman, rsmith. Herald added subscribers: dexonsmith, jkorous, eraman. This can be used for better support of `-fno-gnu-inline-asm` builds. rdar://problem/49540880 https://reviews.llvm.org/D61619 Files: clang/include/clang/Basic/

[PATCH] D61620: [NewPassManager] Add tuning option: LoopUnrolling [clang-change]

asbirlea created this revision. asbirlea added a reviewer: chandlerc. Herald added subscribers: cfe-commits, dmgreen, jlebar. Herald added a project: clang. Use CodeGenOpts's setting for loop unrolling. [to be coupled with D61618 ] Repository: rC Clang https:/

[PATCH] D61621: [X86] Make `x86intrin.h`, `immintrin.h` includable with `-fno-gnu-inline-asm`.

vsapsai created this revision. vsapsai added reviewers: craig.topper, GBuella. Herald added subscribers: dexonsmith, jkorous. vsapsai added a parent revision: D61619: Make language option `GNUAsm` discoverable with `__has_extension` macro.. Currently `immintrin.h` includes `pconfigintrin.h` and `

[PATCH] D61620: [NewPassManager] Add tuning option: LoopUnrolling [clang-change]

chandlerc added a comment. Same comment as on other Clang patch -- let's update an IR generation test to reflect this? Should just be adding a RUN line. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61620/new/ https://reviews.llvm.org/D61620

r360100 - [Clang][NewPM] Don't bail out if the target machine is empty

Author: phosek Date: Mon May 6 16:24:17 2019 New Revision: 360100 URL: http://llvm.org/viewvc/llvm-project?rev=360100&view=rev Log: [Clang][NewPM] Don't bail out if the target machine is empty This matches the behavior of the old pass manager. There are some targets that don't have target machin

[PATCH] D58374: [Clang][NewPM] Don't bail out if the target machine is empty

This revision was automatically updated to reflect the committed changes. Closed by commit rC360100: [Clang][NewPM] Don't bail out if the target machine is empty (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D58374?vs=188999&id=198367#toc Repository:

Re: r359960 - Reduce amount of work ODR hashing does.

There was no cycle for this crash. What happened is that an exponential runtime is reduced to a linear runtime. Without this revision, ODR hashing would have worked if the machine had enough memory and the user waited long enough. void foo(int a, int b) {} When computing the ODR hash for functio

[PATCH] D61617: [NewPassManager] Add tuning option: SLPVectorization [clang-change]

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. Can you update some Clang IR generation test that uses these flags to run w/ the new PM? It should fail without this and pass with this. LGTM w/ that test updated. Repository: rC Cla

[PATCH] D44387: [x86] Introduce the pconfig/encl[u|s|v] intrinsics

vsapsai added a comment. Discussed with the team different approaches and suggesting https://reviews.llvm.org/D61621 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44387/new/ https://reviews.llvm.org/D44387 ___ cfe-commits mailing list cfe-

Re: r359960 - Reduce amount of work ODR hashing does.

On Mon, May 6, 2019 at 4:24 PM Richard Trieu wrote: > > There was no cycle for this crash. Oh, yeah, didn't mean to imply there were - but that a system designed to prevent cycles might also be used/help prevent redundant work like this. > What happened is that an exponential runtime is reduced

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

rjmccall added a comment. In D61165#1492582 , @erik.pilkington wrote: > Duncan pointed out eel.is/c++draft/class.init#class.base.init-13, which > appears to claim that initialization ends with the execution of the > constructor, excluding temporary dest

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

dexonsmith added a comment. In D61165#1492724 , @rjmccall wrote: > In D61165#1492582 , @erik.pilkington > wrote: > > > Duncan pointed out eel.is/c++draft/class.init#class.base.init-13, which > > appears to claim t

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

rsmith added a comment. In D61165#1490417 , @erik.pilkington wrote: > In D61165#1490168 , @rjmccall wrote: > > > I think the intuitive rule is that initialization is complete when the > > full-expression performin

r360104 - Fix typo in risc-v register aliases.

Author: echristo Date: Mon May 6 17:45:47 2019 New Revision: 360104 URL: http://llvm.org/viewvc/llvm-project?rev=360104&view=rev Log: Fix typo in risc-v register aliases. Patch by John. Differential Revision: https://reviews.llvm.org/D61464 Modified: cfe/trunk/lib/Basic/Targets/RISCV.cpp

[PATCH] D61464: [RiscV] Typo in register aliases

This revision was automatically updated to reflect the committed changes. Closed by commit rL360104: Fix typo in risc-v register aliases. (authored by echristo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.o

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

rjmccall added a comment. In D61165#1492780 , @dexonsmith wrote: > In D61165#1492724 , @rjmccall wrote: > > > In D61165#1492582 , > > @erik.pilkington wrote: > > > > > Dunca

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

rjmccall added a comment. In D61165#1492781 , @rsmith wrote: > In D61165#1490417 , @erik.pilkington > wrote: > > > In D61165#1490168 , @rjmccall > > wrote: > > > > > I thin

r360109 - Recommit r359859 "[Attribute/Diagnostics] Print macro if definition is an attribute declaration"

Author: leonardchan Date: Mon May 6 20:20:17 2019 New Revision: 360109 URL: http://llvm.org/viewvc/llvm-project?rev=360109&view=rev Log: Recommit r359859 "[Attribute/Diagnostics] Print macro if definition is an attribute declaration" Updated with fix for read of uninitialized memory. Added:

[PATCH] D61365: [libcxx] [test] Suppress float->int narrowing warning in vector range-construction test.

BillyONeal marked an inline comment as done. BillyONeal added inline comments. Comment at: test/std/containers/sequences/vector/vector.cons/construct_iter_iter.pass.cpp:159 float array[3] = {0.0f, 1.0f, 2.0f}; +#pragma warning(suppress: 4244) // narrowing float to int

[PATCH] D61615: [COFF] Use COFF stubs for extern_weak functions

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM, it's nice if this mechanism comes in handy in other cases than the one it was originally made for. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D61627: [clang driver] Allow -fembed-bitcode combined with -mno-red-zone

wanders created this revision. wanders added reviewers: steven_wu, compnerd, rsmith. wanders added a project: clang. Herald added a subscriber: dexonsmith. The -mno-red-zone (and the option to cancel it out: -mred-zone) were not allowed to be combined with -fembed-bitcode. However this option has

[clang-tools-extra] r360114 - [clang-tidy] Extend bugprone-sizeof-expression to check sizeof(pointers to structures)

Author: baloghadamsoftware Date: Mon May 6 23:16:02 2019 New Revision: 360114 URL: http://llvm.org/viewvc/llvm-project?rev=360114&view=rev Log: [clang-tidy] Extend bugprone-sizeof-expression to check sizeof(pointers to structures) Accidentally taking the size of a struct-pointer type or a value

[PATCH] D61260: [clang-tidy] Extend bugprone-sizeof-expression to check sizeof(pointers to structures)

This revision was automatically updated to reflect the committed changes. Closed by commit rL360114: [clang-tidy] Extend bugprone-sizeof-expression to check sizeof(pointers to… (authored by baloghadamsoftware, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

<    1   2