smeenai added inline comments.
================
Comment at: libunwind/src/CMakeLists.txt:160
if (LIBUNWIND_INSTALL_LIBRARY)
- install(TARGETS ${LIBUNWIND_INSTALL_TARGETS}
+ if(libcxxabi IN_LIST LLVM_RUNTIME_DISTRIBUTION_COMPONENTS)
+ set(export_to_llvmruntimes EXPORT LLVMRuntimes)
----------------
Should be libunwind and not libcxxabi
================
Comment at: llvm/runtimes/CMakeLists.txt:216
+ endif()
+ export(EXPORT LLVMRuntimes FILE ${LLVM_RUNTIMES_FILE})
+ install(EXPORT LLVMRuntimes
----------------
I think the way LLVM's build is set up, targets are always exported to the
export file in the build tree (which requires maintaining the separate list of
targets), but only exported to the install tree if they're in
LLVM_DISTRIBUTION_COMPONENTS. I don't know how much you care about maintaining
that behavior here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D49587/new/
https://reviews.llvm.org/D49587
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
