[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 197645. plotfi added a comment. - change "ifso" for intermediate files to "ifo" - Updated schemas. I have both our own proposal and the proposal that resembles elfeabi here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D61104: [clang][ASTContext] Try to avoid sorting comments for code completion

jkorous planned changes to this revision. jkorous added a comment. @gribozavr thanks for the feedback. I'm rewriting the patch now as I figured out my detection of comments preceding declarations is unsound. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61104/new

[PATCH] D61407: [MS] Change the metadata for heapallocsite calls when the function return type is cast.

akhuang created this revision. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D61407 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGExprScalar.cpp clang/test/CodeGen

[PATCH] D61407: [MS] Change the metadata for heapallocsite calls when the function return type is cast.

akhuang updated this revision to Diff 197651. akhuang added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61407/new/ https://reviews.llvm.org/D61407 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGExprScalar.cpp clang/te

[PATCH] D61366: [libcxx] [test] Don't assert that moved-from containers with non-POCMA allocators are empty.

BillyONeal updated this revision to Diff 197653. BillyONeal added a comment. Also fixed vector test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61366/new/ https://reviews.llvm.org/D61366 Files: test/std/containers/associative/map/map.cons/move_assign.pass.cpp test/std/containers

[PATCH] D61408: Use primary template parameter names for variable template debug info

rnk created this revision. rnk added reviewers: JDevlieghere, aprantl, ormris, dblaikie. Herald added a project: clang. Fixes PR41677 Consider: template constexpr bool is_same_v = false; template constexpr bool is_same_v = true; template constexpr bool is_same_v; Before this change, whe

[PATCH] D61407: [MS] Change the metadata for heapallocsite calls when the function return type is cast.

rnk added a comment. Nice, this is way less complicated than we thought originally. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:572 CGF.CGM.EmitExplicitCastExprType(E, &CGF); + return VisitCastExpr(E); Please revert unrelated whitespace changes.

[PATCH] D61389: Bump DIAG_SIZE_SEMA up to 4000

sunfish abandoned this revision. sunfish added a comment. Cool :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61389/new/ https://reviews.llvm.org/D61389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D61408: Use primary template parameter names for variable template debug info

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Seems totally reasonable to me & it's what we do for other templates (function and class), it seems. Might want to check alias templates too? Repository: rG LLVM Github Monorepo CHANG

r359739 - Revert r359717, "Make check-clang depend on the clang-check binary always"

Author: nico Date: Wed May 1 16:32:38 2019 New Revision: 359739 URL: http://llvm.org/viewvc/llvm-project?rev=359739&view=rev Log: Revert r359717, "Make check-clang depend on the clang-check binary always" The Tooling tests do have a lit.local.cfg with if not config.root.clang_staticanalyzer

r359740 - Consume unexpected "template" keywords after "using"

Author: rtrieu Date: Wed May 1 16:33:49 2019 New Revision: 359740 URL: http://llvm.org/viewvc/llvm-project?rev=359740&view=rev Log: Consume unexpected "template" keywords after "using" The parser was dealing with unexpected "template" keywords after "using" keywords too late and putting the pars

[PATCH] D61350: [clang-tidy] New check calling out uses of +new in Objective-C code

mwyman updated this revision to Diff 197660. mwyman marked 6 inline comments as done. mwyman added a comment. Fixes per review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61350/new/ https://reviews.llvm.org/D61350 Files: clang-tools-extra/clang-tidy/google/AvoidNSObjectNe

[PATCH] D61225: [COFF, ARM64] Align global symbol by size for ARM64 MSVC ABI

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61225/new/ https://reviews.llvm.org/D61225 ___ cfe-commit

[PATCH] D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools.

dyung added a comment. In D61187#1486249 , @probinson wrote: > FYI, we had to disable clangd entirely after this patch, getting a weird > problem with lit that we haven't figured out yet. > In case anybody else has seen something like this, and knows wha

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

erik.pilkington added a comment. In D61165#1485514 , @rjmccall wrote: > Hmm. You know, there's another case where the destructor can be called even > for a non-array: if constructing the object requires a temporary, I believe > an exception thrown from

[PATCH] D61350: [clang-tidy] New check calling out uses of +new in Objective-C code

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/google/AvoidNSObjectNewCheck.cpp:16 +#include "llvm/Support/FormatVariadic.h" + +#include Unnecessary empty line. Comment at: clang-tools-extra/clang-tidy/google/Av

r359744 - [COFF, ARM64] Align global symbol by size for ARM64 MSVC ABI

Author: tomtan Date: Wed May 1 17:38:14 2019 New Revision: 359744 URL: http://llvm.org/viewvc/llvm-project?rev=359744&view=rev Log: [COFF, ARM64] Align global symbol by size for ARM64 MSVC ABI According to alignment section in below ARM64 ABI document, MSVC could increase alignment of global dat

[PATCH] D61225: [COFF, ARM64] Align global symbol by size for ARM64 MSVC ABI

This revision was automatically updated to reflect the committed changes. Closed by commit rL359744: [COFF, ARM64] Align global symbol by size for ARM64 MSVC ABI (authored by TomTan, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r359747 - Replace ad-hoc tracking of pattern for an instantiated class-scope

Author: rsmith Date: Wed May 1 17:49:14 2019 New Revision: 359747 URL: http://llvm.org/viewvc/llvm-project?rev=359747&view=rev Log: Replace ad-hoc tracking of pattern for an instantiated class-scope explicit function specialization with the MemberSpecializationInfo used everywhere else. Not NFC:

r359746 - Diagnose non-dependent qualified friend function template declarations

Author: rsmith Date: Wed May 1 17:49:05 2019 New Revision: 359746 URL: http://llvm.org/viewvc/llvm-project?rev=359746&view=rev Log: Diagnose non-dependent qualified friend function template declarations that don't match any existing declaration. Don't get confused and treat such declarations as t

[PATCH] D61350: [clang-tidy] New check calling out uses of +new in Objective-C code

mwyman updated this revision to Diff 197681. mwyman marked 7 inline comments as done. mwyman added a comment. Updated per review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61350/new/ https://reviews.llvm.org/D61350 Files: clang-tools-extra/clang-tidy/google/AvoidNSObject

[PATCH] D60235: [CMake] Disable libc++ and libc++abi new/delete definitions when built with ASan

phosek abandoned this revision. phosek added a comment. No longer needed, this was done as part of D60926 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60235/new/ https://reviews.llvm.org/D60235 _

[PATCH] D61418: Another attempt to fix "could not find clang-check" lit warning in analyzer-less builds

thakis created this revision. thakis added a reviewer: rnk. Herald added subscribers: dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. r359717 added clang-check as a dep of check-clang unconditionally because I had missed lit.local.cfg in test/Tooling. Instead, only add clang-check

[PATCH] D61304: [OpenCL][PR41609] Deduce static data members to __global addr space

keryell added a comment. In D61304#1485814 , @Anastasia wrote: > In D61304#1485125 , @rjmccall wrote: > > > Presumably a similar rule would apply to thread-locals if you supported > > them. > > > We don't support t

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

jdoerfert added inline comments. Comment at: lib/Headers/openmp_wrappers/__clang_openmp_math.h:29 + +#define __forceinline__ __attribute__((always_inline)) + I think this is a leftover we forgot to remove. Repository: rC Clang CHANGES SINCE LAST ACTION htt

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

rjmccall added a comment. In D61165#1487100 , @erik.pilkington wrote: > It seems like the most common sense interpretation here is to just treat the > initialization of `G` as completed at the point when the constructor finishes > (this appears to be wh

r359759 - Adapt -fsanitize=function to SANITIZER_NON_UNIQUE_TYPEINFO

Author: sberg Date: Wed May 1 23:40:33 2019 New Revision: 359759 URL: http://llvm.org/viewvc/llvm-project?rev=359759&view=rev Log: Adapt -fsanitize=function to SANITIZER_NON_UNIQUE_TYPEINFO This follows up after b7692bc3e9ad2691fc07261904b88fb15f30696b "[UBSan] Fix isDerivedFromAtOffset on iOS A

[PATCH] D60760: Adapt -fsanitize=function to SANITIZER_NON_UNIQUE_TYPEINFO

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL359759: Adapt -fsanitize=function to SANITIZER_NON_UNIQUE_TYPEINFO (authored by sberg, committed by ). Herald added a subs

[PATCH] D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools.

sammccall added a comment. So, apologies everyone for the trouble caused by this patch, and thanks for all the information. It was a mistake to try to change so many things at once. I'll switch the layout back as far as possible while preserving the directory structure. This is a frustrating as

<    1   2