[PATCH] D61118: [MinGW] Fix dllexport of explicit template instantiation

mstorsjo created this revision. mstorsjo added reviewers: rnk, hans, smeenai. Herald added a project: clang. Contrary to MSVC, GCC/MinGW needs to have the dllexport attribute on the template instantiation declaration, not on the definition. Previously clang never marked explicit template instant

[PATCH] D61118: [MinGW] Fix dllexport of explicit template instantiation

smeenai added a comment. LGTM, though I'd wait for Hans and/or Reid too. I like the GCC/MinGW behavior here much more than the MSVC behavior. Having to mark the definitions only in the explicit instantiations case (for MSVC) whereas everything else requires you to mark the declarations is a wei

r359172 - [NFC] test commit removing excess line

Author: nik Date: Thu Apr 25 01:14:39 2019 New Revision: 359172 URL: http://llvm.org/viewvc/llvm-project?rev=359172&view=rev Log: [NFC] test commit removing excess line Modified: cfe/trunk/tools/libclang/CIndex.cpp Modified: cfe/trunk/tools/libclang/CIndex.cpp URL: http://llvm.org/viewvc/ll

[PATCH] D61118: [MinGW] Fix dllexport of explicit template instantiation

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Looks good to me. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61118/new/ https://reviews.llvm.org/D61118 ___ cfe-c

[PATCH] D61120: [clangd] Optimize "don't include me" check.

sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. llvm::Regex is really slow, and regex evaluation during preamble indexing was showing up as 25% on a profile of cl

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

Rakete added a comment. Thanks for working on this! :) Comment at: clang/lib/Parse/ParseDecl.cpp:3533 + if (ExplicitExpr.isInvalid()) { +Diag(ParenLoc, diag::note_explicit_bool_breaking_change_cxx2a) +<< FixItHint::CreateReplacement( ---

[PATCH] D60764: Add clang cc1 option to generate OpenCL builtin functions

Pierre updated this revision to Diff 196590. Pierre added a comment. Forgot to update one argument CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60764/new/ https://reviews.llvm.org/D60764 Files: clang/include/clang/Basic/LangOptions.def clang/include/clang/Driver/CC1Options.td cl

[PATCH] D59814: [Testing] Move clangd::Annotations to llvm testing support

ilya-biryukov updated this revision to Diff 196592. ilya-biryukov added a comment. - Add simple tests - Add equality and stream output operators for Range Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59814/new/ https://reviews.llvm.org/D59814 Fil

[PATCH] D60763: Prototype OpenCL BIFs using Tablegen

Pierre updated this revision to Diff 196591. Pierre marked 10 inline comments as done. Pierre added a comment. In this new patch: - Documentation has been added - The multiclasses in OpenCLBuiltins.td filehave been slighly changed to have a more generic way to generate function prototypes - In C

[PATCH] D60763: Prototype OpenCL BIFs using Tablegen

Pierre added a comment. Other comments: 1- When a header file is included, its function declarations are decorated with the "nounwind" attribute, meaning that the function is not supposed to throw an exception. This decorator is currently not added with the new mechanism. The "readnone" decorato

[PATCH] D58033: Add option for emitting dbg info for call site parameters

djtodoro marked 2 inline comments as done. djtodoro added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:3402 +CmdArgs.push_back("-femit-param-entry-values"); + RenderDebugInfoCompressionArgs(Args, CmdArgs, D, TC); probinson wrote: > If this

[PATCH] D58033: Add option for emitting dbg info for call site parameters

djtodoro updated this revision to Diff 196595. djtodoro marked an inline comment as done. djtodoro edited the summary of this revision. djtodoro added a comment. -Remove unneeded code CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58033/new/ https://reviews.llvm.org/D58033 Files: incl

[PATCH] D61121: [Windows] Separate elements in -print-search-dirs with semicolons

mstorsjo created this revision. mstorsjo added reviewers: rnk, hans, smeenai, thakis. Herald added a project: clang. Path lists on windows should always be separated by semicolons, not colons. Reuse llvm::sys::EnvPathSeparator for this purpose (as that's also a path list that is separated in the

[clang-tools-extra] r359179 - [Testing] Move clangd::Annotations to llvm testing support

Author: ibiryukov Date: Thu Apr 25 03:08:31 2019 New Revision: 359179 URL: http://llvm.org/viewvc/llvm-project?rev=359179&view=rev Log: [Testing] Move clangd::Annotations to llvm testing support Summary: Annotations allow writing nice-looking unit test code when one needs access to locations from

r359179 - [Testing] Move clangd::Annotations to llvm testing support

Author: ibiryukov Date: Thu Apr 25 03:08:31 2019 New Revision: 359179 URL: http://llvm.org/viewvc/llvm-project?rev=359179&view=rev Log: [Testing] Move clangd::Annotations to llvm testing support Summary: Annotations allow writing nice-looking unit test code when one needs access to locations from

[PATCH] D59814: [Testing] Move clangd::Annotations to llvm testing support

sammccall accepted this revision. sammccall added inline comments. Comment at: llvm/lib/Testing/Support/Annotations.cpp:94 +const llvm::Annotations::Range &R) { + return O << llvm::formatv("[{0}, {1})", R.Begin, R.End); +} You

[PATCH] D61122: [clangd] Don't build clangd or run its tests when LLVM_ENABLE_THREADS is off, unless specifically directed to do so

sammccall created this revision. sammccall added reviewers: thakis, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, mgorny. Herald added a project: clang. Introduce a new CLANGD_BUILD option, only default to true if threads are on. (the name doesn't se

[PATCH] D59814: [Testing] Move clangd::Annotations to llvm testing support

ilya-biryukov updated this revision to Diff 196599. ilya-biryukov added a comment. - Added a death test for error conditions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59814/new/ https://reviews.llvm.org/D59814 Files: clang-tools-extra/unitte

[PATCH] D59814: [Testing] Move clangd::Annotations to llvm testing support

This revision was automatically updated to reflect the committed changes. Closed by commit rL359179: [Testing] Move clangd::Annotations to llvm testing support (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D59814?vs=196599&id=196602#toc Repository:

[PATCH] D61120: [clangd] Optimize "don't include me" check.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM (see the comment about a typo, though) Comment at: clangd/index/SymbolCollector.cpp:669 +return false; + return Line.contains_lower("includ"); +}

[PATCH] D61122: [clangd] Don't build clangd or run its tests when LLVM_ENABLE_THREADS is off, unless specifically directed to do so

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. A better name could definitely be nice, e.g. `BUILD_CLANGD` would've been much nicer. But the current one is also okayish, being consistent with existing names is a good reason t

[PATCH] D61120: [clangd] Optimize "don't include me" check.

sammccall added inline comments. Comment at: clangd/index/SymbolCollector.cpp:669 +return false; + return Line.contains_lower("includ"); +} ilya-biryukov wrote: > A typo? Should it be `include`. it's meant to match "include" or "including". I'll add a commen

[PATCH] D61120: [clangd] Optimize "don't include me" check.

ilya-biryukov added inline comments. Comment at: clangd/index/SymbolCollector.cpp:669 +return false; + return Line.contains_lower("includ"); +} sammccall wrote: > ilya-biryukov wrote: > > A typo? Should it be `include`. > it's meant to match "include" or "in

[PATCH] D61126: [clangd] Also perform merging for symbol definitions

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. clangd currently prefers declarations from codegen files. This patch implements that behavior for definition locat

[PATCH] D60485: [AArch64] Add support for MTE intrinsics

javed.absar marked an inline comment as done. javed.absar added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:7129-7131 +// Although it is possible to supply a different return +// address (first arg) to this intrinsic, for now we set +// return address same

Re: r358490 - [AArch64] Implement Vector Funtion ABI name mangling.

Hi Alexey, The new test "declare_simd_aarch64_sve.c" intermittently fails when the git revision contains "a01". .../llvm/tools/clang/test/OpenMP/declare_simd_aarch64_sve.c:38:15: error: CHECK-NOT: excluded string found in input // CHECK-NOT: a01 ^ :75:102: note: found he

[PATCH] D60925: [analyzer] Don't display implementation checkers under -analyzer-checker-help, but do under the new flag -analyzer-checker-help-hidden

Szelethus added a comment. I plan to do the same for non-checker and checker options too. I'll leave this up for just a little while to give people time to object. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60925/new/ https://reviews.llvm.org/D60925 __

[PATCH] D60763: Prototype OpenCL BIFs using Tablegen

Nicola added inline comments. Comment at: clang/include/clang/Basic/OpenCLBuiltins.td:140-144 +class RoundingModes { + list Modes = !if(!or(_Ty1.HasRounding, _Ty2.HasRounding), + ["", "_rte", "_rtz", "_rtp", "_rtn"], + [""]); +}

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

martong added a comment. In D60934#1475908 , @Tyker wrote: > Fixed issues form feedback by @martong Thank you for addressing the comments. `ASTImporter.cpp` and `ASTStructuralEquivalence.cpp` looks good to me now. However, about the equivalence check,

[PATCH] D61077: [clangd] Query index in code completion no-compile mode.

kadircet added inline comments. Comment at: clangd/SourceCode.cpp:503 +case tok::l_brace: + if (State == NamespaceName) { +// Parsed: namespace { I believe it is safe to ignore(just mark the opening brace) anonymous namespaces here. Since there

Re: r358490 - [AArch64] Implement Vector Funtion ABI name mangling.

Hi Russel, thanks for the report, will fix this problem. Best regards, Alexey Bataev 25 апр. 2019 г., в 7:24, Russell Gallop mailto:russell.gal...@gmail.com>> написал(а): Hi Alexey, The new test "declare_simd_aarch64_sve.c" intermittently fails when the git revision contains "a01". .../llvm/

[PATCH] D61015: [LibTooing] Change Transformer's TextGenerator to a partial function.

ilya-biryukov added a comment. Why would we consider this a legitimate failure, rather than a programming error? Same argument could be made about any form of format-string-like functions, e.g. `llvm::formatv` or `sprintf`. Yet, they return strings and not `Expected` or their equivalent. Repos

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

richard.townsend.arm added inline comments. Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1074 + if (!RD->hasTrivialCopyAssignment()) +return true; + return false; Should this function also check for user-provided constructors? CHANGES SINCE LAST ACTION h

[PATCH] D59481: [clangd] Count number of references while merging RefSlabs inside FileIndex

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/index/Background.h:113 + // Note that FileSymbols counts References by incrementing it per each file + // mentioning the symbol, including headers. This contradicts with the We should a

[PATCH] D53072: [clang-format] Create a new tool for IDEs based on clang-format

sammccall added a comment. You may be interested in D60605 , which is a related idea (adding incremental format-and-indent-on-type to clangd). These are opposite extremes in some sense: this patch integrates deeply into clang-format and that patch entirely layer

[PATCH] D59302: [clangd] Surface diagnostics from headers inside main file

ilya-biryukov added inline comments. Comment at: clangd/Diagnostics.cpp:78 +// offsets when displaying that information to users. +Position toOneBased(Position P) { + ++P.line; Could we avoid introducing a function that breaks the invariant of a type? Having a f

[PATCH] D60907: [OpenMP][WIP] Add math functions support in OpenMP offloading

gtbercea updated this revision to Diff 196619. gtbercea added a comment. - Use macros. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60907/new/ https://reviews.llvm.org/D60907 Files: include/clang/Driver/ToolChain.h lib/Driver/ToolChains/Clang.cpp lib/Driv

[PATCH] D53072: [clang-format] Create a new tool for IDEs based on clang-format

yvvan added a comment. @sammccall Having a separate tool is nice because it allows the client to make it plugable. clang-format sometimes changes options quite significantly and it can be nice if you have a choice which version to pick, otherwise it might be unable to read the configuration yo

[PATCH] D60605: [clangd] Revamp textDocument/onTypeFormatting.

ilya-biryukov added a comment. Another example: int test() { ^ } Expected: a newline was added. Actual: newline does not allow to be added. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60605/new/ https://reviews.llvm.org/D60605

[PATCH] D61015: [LibTooing] Change Transformer's TextGenerator to a partial function.

ymandel added a comment. In D61015#1478539 , @ilya-biryukov wrote: > Why would we consider this a legitimate failure, rather than a programming > error? > Same argument could be made about any form of format-string-like functions, > e.g. `llvm::formatv

[PATCH] D60605: [clangd] Revamp textDocument/onTypeFormatting.

ilya-biryukov added a comment. Input: int test() { }^ Expected: int test() { } ^ Actual: int test() {} ^ Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60605/new/ https://reviews.llvm.org/D60605 _

[PATCH] D61015: [LibTooing] Change Transformer's TextGenerator to a partial function.

ilya-biryukov added a comment. I'd argue it's the server's job to validate the inputs in that case. The code that landed so far clearly looks like a C++ DSL to describe transformations of the source. While it **can** be used a dependency in the server-side, I don't see why doing user-input chec

[PATCH] D61112: AMDGPU: Enable _Float16

b-sumner added a comment. Looks good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61112/new/ https://reviews.llvm.org/D61112 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

r359193 - [OPENMP][AARCH64]Fix the test for declare simd, NFC.

Author: abataev Date: Thu Apr 25 07:04:37 2019 New Revision: 359193 URL: http://llvm.org/viewvc/llvm-project?rev=359193&view=rev Log: [OPENMP][AARCH64]Fix the test for declare simd, NFC. Renamed function a01 in the test to fix possible problems with the git hash match during testing. Modified:

[PATCH] D48292: use modern type trait implementations when available

ldionne added a comment. I think this broke the C++03 bots: http://green.lab.llvm.org/green/view/Libcxx/job/libc++%20and%20libc++abi%20trunk/CI_ARCH=64,CI_EXCEPTIONS=ON,CI_STD=c++03/103/consoleFull Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48292/new/ http

[PATCH] D61103: [clang] Add tryToAttachCommentsToDecls method to ASTContext

gribozavr added a comment. > The FIXME in tests is fixed now. ... so instead of deleting the test, could you change it to show the current, better diagnostic? Comment at: clang/include/clang/AST/ASTContext.h:818 + /// For every comment not attached to any decl check if it sh

[PATCH] D61097: [Sema] Emit warning for visibility attribute on internal-linkage declaration

aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:2619 + // Visibility attributes have no effect on symbols with internal linkage. + if (auto ND = dyn_cast(D)) { +if (!ND->isExternallyVisible()) { -

[PATCH] D60274: [ELF] Implement Dependent Libraries Feature

probinson added a comment. I'm okay with the PS4-specific bits. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60274/new/ https://reviews.llvm.org/D60274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[PATCH] D60763: Prototype OpenCL BIFs using Tablegen

Pierre added a comment. I also think we could reduce the size of the tables. To sum up how this is working right now: 1. The isOpenCLBuiltin(char* functionName) funcion is called to determine if a function is part of OpenCL builtin functions. If so, it returns its associated pair (index, number

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

richard.townsend.arm added inline comments. Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1074 + if (!RD->hasTrivialCopyAssignment()) +return true; + return false; richard.townsend.arm wrote: > Should this function also check for user-provided constructors? I

[PATCH] D61112: AMDGPU: Enable _Float16

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61112/new/ https://reviews.llvm.org/D61112 ___ cfe-commits mailing list cfe-commi

[PATCH] D61134: [Analyzer] Iterator Checkers - Do an early return after handling calls

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: NoQ, Szelethus. baloghadamsoftware added a project: clang. Herald added subscribers: Charusso, gamesh411, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet. This patch is more of a fix than a real improvement: in

[PATCH] D54881: [clang-format] Prevent Clang-Format from editing leading whitespace on lines outside of the format range

russellmcc added a comment. Sorry, coming back to this - line-filters are _inclusive_, so how do you indicate a 0-length range from the command line? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54881/new/ https://reviews.llvm.org/D54881

[PATCH] D59407: [clangd] Add RelationSlab

sammccall added a subscriber: hokein. sammccall added a comment. Hi Nathan, sorry for the stall here, and for repeatedly going over the same issues. The design space here is pretty complicated. I think the conclusion of recent offline discussions is: - refs and relations can be the same thing-i

[PATCH] D61104: [clang][ASTContext] Try to avoid sorting comments for code completion

gribozavr added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:800 + /// The result doesn't contain decls that don't have any comment attached. + std::unordered_map getRawCommentsForDeclsNoCache( + const std::unordered_map> Why not Dense

[PATCH] D60910: [WIP] Dumping the AST to JSON

aaron.ballman updated this revision to Diff 196645. aaron.ballman added a comment. Herald added a subscriber: jdoerfert. Rebased to master + small amount of additional functionality. Since it seems this is non-controversial, I will probably commit after next week unless reviewers bring up concer

[PATCH] D61136: [Analyzer] IteratorChecker - Ensure end()>=begin() and refactor begin and end symbol creation

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: NoQ, Szelethus. baloghadamsoftware added a project: clang. Herald added subscribers: Charusso, gamesh411, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet. A container's `end()` is never less than its `begin().

[PATCH] D61015: [LibTooing] Change Transformer's TextGenerator to a partial function.

ymandel added a comment. In D61015#1478586 , @ilya-biryukov wrote: > I'd argue it's the server's job to validate the inputs in that case. > > The code that landed so far clearly looks like a C++ DSL to describe > transformations of the source. While it *

r359200 - [OPENMP] Improved check for the linear dependency in the non-rectangular

Author: abataev Date: Thu Apr 25 09:21:13 2019 New Revision: 359200 URL: http://llvm.org/viewvc/llvm-project?rev=359200&view=rev Log: [OPENMP] Improved check for the linear dependency in the non-rectangular loop nests. Added a checks that the initializer/condition expressions depend only only of

[PATCH] D61126: [clangd] Also perform merging for symbol definitions

kadircet updated this revision to Diff 196654. kadircet added a comment. - Get rid of debug comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61126/new/ https://reviews.llvm.org/D61126 Files: clang-tools-extra/clangd/XRefs.cpp clang-tools

[PATCH] D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment

ztamas added a comment. Ok, is there anything else should be included in this patch? I saw more ideas about how to extend the functionality (custom pointers, fix-it, etc). I interpreted these ideas as nice-to-have things for the future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D59481: [clangd] Count number of references while merging RefSlabs inside FileIndex

kadircet marked 2 inline comments as done. kadircet added a comment. It has been a long time since I've proposed that change and even I forgot some of the high level details. Therefore, I wanted to sum up the state again so that we can decide on how to move forward. Currently we have two differ

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

aganea added inline comments. Comment at: llvm/trunk/unittests/Transforms/Scalar/CMakeLists.txt:14-17 +# Workaround for the gcc 6.1 bug https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80916. +if (CMAKE_COMPILER_IS_GNUCXX AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 6.0) + set_s

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

aganea updated this revision to Diff 196655. aganea marked 3 inline comments as done. aganea added a comment. Please let me know if other changes are needed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61046/new/ https://reviews.llvm.org/D61046 Files: clang/trunk/unittests/AST/ASTI

[PATCH] D60605: [clangd] Revamp textDocument/onTypeFormatting.

sammccall updated this revision to Diff 196656. sammccall added a comment. Avoid removing lines when formatting after \n. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60605/new/ https://reviews.llvm.org/D60605 Files: clangd/CMakeLists.txt clan

[PATCH] D60605: [clangd] Revamp textDocument/onTypeFormatting.

sammccall added a comment. In D60605#1478579 , @ilya-biryukov wrote: > Another example: > > int test() { > > ^ > } > > > Expected: a newline was added. > Actual: newline does not allow to be added. Fixed. In D60605#1478581

[clang-tools-extra] r359202 - [clangd] Use JSON streaming API for Trace rather than pasting strings. NFC

Author: sammccall Date: Thu Apr 25 09:37:07 2019 New Revision: 359202 URL: http://llvm.org/viewvc/llvm-project?rev=359202&view=rev Log: [clangd] Use JSON streaming API for Trace rather than pasting strings. NFC Modified: clang-tools-extra/trunk/clangd/Trace.cpp clang-tools-extra/trunk/tes

[PATCH] D60910: [WIP] Dumping the AST to JSON

hintonda added a comment. Looks good, but just a couple of questions. Comment at: include/clang/AST/JSONNodeDumper.h:73 + Indentation.clear(); + OS << "\n" << Indentation << "}\n"; + TopLevel = true; Just curious, since you clear Indentation on t

[PATCH] D60910: [WIP] Dumping the AST to JSON

aaron.ballman marked 3 inline comments as done. aaron.ballman added inline comments. Comment at: include/clang/AST/JSONNodeDumper.h:73 + Indentation.clear(); + OS << "\n" << Indentation << "}\n"; + TopLevel = true; hintonda wrote: > Just curious, s

[PATCH] D60910: [WIP] Dumping the AST to JSON

hintonda added inline comments. Comment at: include/clang/Frontend/FrontendOptions.h:311 + /// Specifies the output format of the AST. + enum ASTOutputFormat { +AOF_Default, aaron.ballman wrote: > hintonda wrote: > > Why can't you use the enum defined in `c

[PATCH] D61138: [PGO] Enable InstrProf lowering for Clang PGO instrumentation in the new pass manager

xur created this revision. xur added reviewers: vsk, davidxl. Herald added a subscriber: jfb. Currently InstrProf lowering is not enabled for Clang PGO instrumentation in the new pass manager. The following command "-fprofile-instr-generate -fexperimental-new-pass-manager ..." is broken. This CL

[PATCH] D61138: [PGO] Enable InstrProf lowering for Clang PGO instrumentation in the new pass manager

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. Awesome, LGTM You might also update one of the instr prof tests to have two `RUN` lines, one for each pass manager. Feel free to do that (or not) and submit. CHANGES SINCE LAST ACTION

[PATCH] D61077: [clangd] Query index in code completion no-compile mode.

sammccall updated this revision to Diff 196671. sammccall marked 2 inline comments as done. sammccall added a comment. Add comments, add anon-namespacce test, tighten parsing rules slightly (`namespace ::...` is illegal) Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://

[PATCH] D60912: MS ABI: handle inline static data member and inline variable as template static data member

rnk added a subscriber: hans. rnk added a comment. +@hans, per https://bugs.llvm.org/show_bug.cgi?id=37903#c16 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60912/new/ https://reviews.llvm.org/D60912 ___ cfe-commits mailing list cfe-commits

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

nickdesaulniers added a comment. In D56571#1477992 , @jyu2 wrote: > Please let me know if that is clang problem. It's an orthogonal issue with Clang's integrated assembler. @compudj confirmed that setting `-no-integrated-as` solves the issue (which is w

[PATCH] D42642: [CUDA] Detect installation in PATH

aganea added a comment. Herald added a project: LLVM. Just a quick heads-up - the `cuda-detect-path.cu` test fails on WSL/Ubuntu 18.04: aganea@MTL-BJ842:/mnt/f/svn/buildWSL$ /usr/bin/python3.6 bin/llvm-lit -vv ../clang/test/Driver/cuda-detect-path.cu llvm-lit: /mnt/f/svn/llvm/utils/lit/lit/

[PATCH] D61121: [Windows] Separate elements in -print-search-dirs with semicolons

smeenai added a comment. I feel something like `llvm::sys::path::PathListSeparator` would be nicer, since AFAIK any path list should be separated with semicolons on Windows and colons everywhere else. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61121/new/ htt

[PATCH] D61121: [Windows] Separate elements in -print-search-dirs with semicolons

rnk added a comment. > Alternatively, this could just be a local ifdef _WIN32 in this function, or > should we generalize the existing EnvPathSeparator to e.g. a > llvm::sys::path::PathListSeparator? I think it's clear as is. We're just reusing the environment path separator, which is used for

[PATCH] D61121: [Windows] Separate elements in -print-search-dirs with semicolons

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. In D61121#1479031 , @smeenai wrote: > I feel something like `llvm::sys::path::PathListSeparator` would be nicer, > since AFAIK any path list should be separa

[PATCH] D61077: [clangd] Query index in code completion no-compile mode.

sammccall marked 3 inline comments as done. sammccall added inline comments. Comment at: clangd/SourceCode.cpp:503 +case tok::l_brace: + if (State == NamespaceName) { +// Parsed: namespace { kadircet wrote: > I believe it is safe to ignore(just

[PATCH] D61077: [clangd] Query index in code completion no-compile mode.

sammccall updated this revision to Diff 196674. sammccall marked an inline comment as done. sammccall added a comment. Correctly handle absolutely qualifier (::foo::bar). Fix seed scopes for proximity to be consistent with Sema case. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTIO

[PATCH] D61077: [clangd] Query index in code completion no-compile mode.

sammccall updated this revision to Diff 196676. sammccall added a comment. Fix test. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61077/new/ https://reviews.llvm.org/D61077 Files: clangd/CodeComplete.cpp clangd/SourceCode.cpp clangd/SourceCo

r359212 - Fix bug 37903:MS ABI: handle inline static data member and inline variable as template static data member

Author: jyu2 Date: Thu Apr 25 10:45:45 2019 New Revision: 359212 URL: http://llvm.org/viewvc/llvm-project?rev=359212&view=rev Log: Fix bug 37903:MS ABI: handle inline static data member and inline variable as template static data member Added: cfe/trunk/test/CodeGenCXX/microsoft-abi-template

[clang-tools-extra] r359214 - [clangd] Optimize "don't include me" check.

Author: sammccall Date: Thu Apr 25 10:47:07 2019 New Revision: 359214 URL: http://llvm.org/viewvc/llvm-project?rev=359214&view=rev Log: [clangd] Optimize "don't include me" check. Summary: llvm::Regex is really slow, and regex evaluation during preamble indexing was showing up as 25% on a profile

[PATCH] D61120: [clangd] Optimize "don't include me" check.

This revision was automatically updated to reflect the committed changes. sammccall marked 3 inline comments as done. Closed by commit rCTE359214: [clangd] Optimize "don't include me" check. (authored by sammccall, committed by ). Changed prior to commit: https://reviews.llvm.org/D61120?vs=1965

[PATCH] D60912: MS ABI: handle inline static data member and inline variable as template static data member

jyu2 marked an inline comment as done. jyu2 added inline comments. Comment at: lib/CodeGen/CGDeclCXX.cpp:470-471 PrioritizedCXXGlobalInits.push_back(std::make_pair(Key, Fn)); - } else if (isTemplateInstantiation(D->getTemplateSpecializationKind())) { + } else if (isTemplat

r359215 - [PGO] Enable InstrProf lowering for Clang PGO instrumentation in the new pass manager

Author: xur Date: Thu Apr 25 10:52:43 2019 New Revision: 359215 URL: http://llvm.org/viewvc/llvm-project?rev=359215&view=rev Log: [PGO] Enable InstrProf lowering for Clang PGO instrumentation in the new pass manager Currently InstrProf lowering is not enabled for Clang PGO instrumentation in the

[PATCH] D60912: MS ABI: handle inline static data member and inline variable as template static data member

jyu2 closed this revision. jyu2 added a comment. committed rGc19f4f806972 : Fix bug 37903:MS ABI: handle inline static data member and inline variable as… (authored by jyu2). CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D61138: [PGO] Enable InstrProf lowering for Clang PGO instrumentation in the new pass manager

This revision was automatically updated to reflect the committed changes. Closed by commit rC359215: [PGO] Enable InstrProf lowering for Clang PGO instrumentation in the new pass… (authored by xur, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/

r359216 - creduce-clang-crash: add -F flag to grep to avoid interpreting string as regex

Author: akhuang Date: Thu Apr 25 11:00:25 2019 New Revision: 359216 URL: http://llvm.org/viewvc/llvm-project?rev=359216&view=rev Log: creduce-clang-crash: add -F flag to grep to avoid interpreting string as regex Modified: cfe/trunk/utils/creduce-clang-crash.py Modified: cfe/trunk/utils/cred

[PATCH] D61140: Copy Argument Passing Restrictions setting when importing a CXXRecordDecl definition

shafik created this revision. shafik added reviewers: martong, teemperor, aprantl, a_sidorin. Herald added a subscriber: rnkovacs. For a `CXXRecordDecl` the `RecordDeclBits` are stored in the `DeclContext`. Currently when we import the definition of a `CXXRecordDecl` via the `ASTImporter` we do

[PATCH] D61140: Copy Argument Passing Restrictions setting when importing a CXXRecordDecl definition

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Could we test this by doing -dump-ast of From and To and FileCheck-ing the output? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61140/new/ https://reviews.llvm.org/D61140 _

[PATCH] D59725: Additions to creduce script

akhuang marked an inline comment as done. akhuang added inline comments. Comment at: cfe/trunk/utils/creduce-clang-crash.py:185 +for msg in self.expected_output: + output += 'grep %s t.log || exit 1\n' % pipes.quote(msg) + lebedev.ri wrote: > >>! In D597

r359217 - DebugInfo: Fix bitrotted test case

Author: dblaikie Date: Thu Apr 25 11:11:48 2019 New Revision: 359217 URL: http://llvm.org/viewvc/llvm-project?rev=359217&view=rev Log: DebugInfo: Fix bitrotted test case This test was updated with some CHECK suffix variants, but dropped checking for the unsuffixed 'CHECK' Modified: cfe/trunk

[PATCH] D60907: [OpenMP] Add math functions support in OpenMP offloading

gtbercea added a comment. Ping @hfinkel @tra Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60907/new/ https://reviews.llvm.org/D60907 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D59725: Additions to creduce script

lebedev.ri added inline comments. Comment at: cfe/trunk/utils/creduce-clang-crash.py:185 +for msg in self.expected_output: + output += 'grep %s t.log || exit 1\n' % pipes.quote(msg) + akhuang wrote: > lebedev.ri wrote: > > >>! In D59725#1477362, @arichar

[PATCH] D61140: Copy Argument Passing Restrictions setting when importing a CXXRecordDecl definition

teemperor added a comment. In D61140#1479111 , @aprantl wrote: > Could we test this by doing -dump-ast of From and To and FileCheck-ing the > output? +1 for this. Importing a simple record should test this? E.g. something like this: diff --git a/cla

[PATCH] D60907: [OpenMP] Add math functions support in OpenMP offloading

hfinkel added a comment. In D60907#1479118 , @gtbercea wrote: > Ping @hfinkel @tra The last two comments in D47849 indicated exploration of a different approach, and one which still seems superior to this one. Can you

[PATCH] D47358: : Implement {un,}synchronized_pool_resource.

mclow.lists added a comment. In D47358#1438929 , @Quuxplusone wrote: > Rebased. Added `_NOEXCEPT` to `upstream_resource()` and `options()` (this is > OK per [res.on.exception.handling]/5). That's fine, but then we should have a test for that. We have th

[PATCH] D60485: [AArch64] Add support for MTE intrinsics

t.p.northover accepted this revision. t.p.northover added inline comments. This revision is now accepted and ready to land. Comment at: lib/CodeGen/CGBuiltin.cpp:7129-7131 +// Although it is possible to supply a different return +// address (first arg) to this intrinsic,

  1   2   3   >