[PATCH] D60995: [clang][HeaderSearch] Make sure there are no backslashes in suggestedPath

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Can you document this in `HeaderSearch.h`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60995/new/ https://reviews.llvm.org/D6099

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

nikic added inline comments. Comment at: llvm/trunk/unittests/IR/ConstantRangeTest.cpp:398-401 +#if defined(__GNUC__) && __GNUC__ >= 7 +// Silence warning: variable 'HaveInterrupt3' set but not used +(void)&HaveInterrupt3; +#endif tstellar wrote:

[PATCH] D60995: [clang][HeaderSearch] Make sure there are no backslashes in suggestedPath

kadircet updated this revision to Diff 196392. kadircet added a comment. - Update documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60995/new/ https://reviews.llvm.org/D60995 Files: clang/include/clang/Lex/HeaderSearch.h clang/lib/Le

[PATCH] D60995: [clang][HeaderSearch] Make sure there are no backslashes in suggestedPath

sammccall added inline comments. Comment at: clang/include/clang/Lex/HeaderSearch.h:710 + /// Suggest a path by which the specified file could be found, for use in + /// diagnostics to suggest a #include. Returned path will be valid for + /// include-directive. ---

[PATCH] D60995: [clang][HeaderSearch] Make sure there are no backslashes in suggestedPath

kadircet updated this revision to Diff 196393. kadircet added a comment. - Update comments to focus on forward slashes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60995/new/ https://reviews.llvm.org/D60995 Files: clang/include/clang/Lex/Header

Re: r359048 - C++ DR2387: a variable template declared wtih (or instantiated with) a

Hi Richard, This seems to break libc++, found while doing an integrate. The errors are: In file included from valarray:4: .../include/c++/v1/valarray:1062:60: error: explicit instantiation declaration of 'valarray<_Tp>' with internal linkage _LIBCPP_EXTERN_TEMPLATE(_LIBCPP_FUNC_VIS valarray::vala

r359075 - [clang][HeaderSearch] Make sure there are no backslashes in suggestedPath

Author: kadircet Date: Wed Apr 24 01:45:03 2019 New Revision: 359075 URL: http://llvm.org/viewvc/llvm-project?rev=359075&view=rev Log: [clang][HeaderSearch] Make sure there are no backslashes in suggestedPath Reviewers: sammccall Differential Revision: https://reviews.llvm.org/D60995 Modified:

[PATCH] D60995: [clang][HeaderSearch] Make sure there are no backslashes in suggestedPath

This revision was automatically updated to reflect the committed changes. Closed by commit rL359075: [clang][HeaderSearch] Make sure there are no backslashes in suggestedPath (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prio

r359076 - Revert r359048: C++ DR2387: a variable template declared wthi

Author: ibiryukov Date: Wed Apr 24 01:50:24 2019 New Revision: 359076 URL: http://llvm.org/viewvc/llvm-project?rev=359076&view=rev Log: Revert r359048: C++ DR2387: a variable template declared wthi The change breaks libc++ with the follwing error: In file included from valarray:4: .../include/c+

Re: r359048 - C++ DR2387: a variable template declared wtih (or instantiated with) a

Reverted in r359076. On Wed, Apr 24, 2019 at 10:28 AM Ilya Biryukov wrote: > Hi Richard, > > This seems to break libc++, found while doing an integrate. The errors are: > > In file included from valarray:4: > .../include/c++/v1/valarray:1062:60: error: explicit instantiation > declaration of 'va

[PATCH] D61029: clang-cl: List valid values for /std: in /? output

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61029/new/ https://reviews.llvm.org/D61029 ___ cfe-commits mailing list cfe-commits@lists

r359077 - Fix unquoted spaces in args in clang --verbose output

Author: hans Date: Wed Apr 24 02:06:03 2019 New Revision: 359077 URL: http://llvm.org/viewvc/llvm-project?rev=359077&view=rev Log: Fix unquoted spaces in args in clang --verbose output The behaviour of not quoting spaces appears to have been introduced by mistake in r190620. Patch by Brad Moody!

[PATCH] D60997: Fix unquoted spaces in args in clang --verbose output

This revision was automatically updated to reflect the committed changes. Closed by commit rC359077: Fix unquoted spaces in args in clang --verbose output (authored by hans, committed by ). Changed prior to commit: https://reviews.llvm.org/D60997?vs=196191&id=196398#toc Repository: rC Clang

r359078 - [clang][HeaderSuggestion] Handle the case of dotdot with an absolute path

Author: kadircet Date: Wed Apr 24 02:23:31 2019 New Revision: 359078 URL: http://llvm.org/viewvc/llvm-project?rev=359078&view=rev Log: [clang][HeaderSuggestion] Handle the case of dotdot with an absolute path Summary: Include insertion in clangd was inserting absolute paths when the include direc

[clang-tools-extra] r359078 - [clang][HeaderSuggestion] Handle the case of dotdot with an absolute path

Author: kadircet Date: Wed Apr 24 02:23:31 2019 New Revision: 359078 URL: http://llvm.org/viewvc/llvm-project?rev=359078&view=rev Log: [clang][HeaderSuggestion] Handle the case of dotdot with an absolute path Summary: Include insertion in clangd was inserting absolute paths when the include direc

[PATCH] D60873: [clang][HeaderSuggestion] Handle the case of dotdot with an absolute path

This revision was automatically updated to reflect the committed changes. Closed by commit rL359078: [clang][HeaderSuggestion] Handle the case of dotdot with an absolute path (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prio

[clang-tools-extra] r359079 - [clangd] Fix handling of include paths in windows tests

Author: kadircet Date: Wed Apr 24 02:42:53 2019 New Revision: 359079 URL: http://llvm.org/viewvc/llvm-project?rev=359079&view=rev Log: [clangd] Fix handling of include paths in windows tests Modified: clang-tools-extra/trunk/unittests/clangd/CodeCompleteTests.cpp clang-tools-extra/trunk/u

[PATCH] D60605: [clangd] Revamp textDocument/onTypeFormatting.

ilya-biryukov added a comment. Found an issue today. Input (break a line at ^): // here is my comment ^// another comment Expected: // here is my comment ^// another comment Actual (an extra comment marker is added): // here is my comment // // another comment Repository: rCTE

r359081 - Add 'REQUIRES: shell' to verbose-output-quoting.c

Author: hans Date: Wed Apr 24 03:12:30 2019 New Revision: 359081 URL: http://llvm.org/viewvc/llvm-project?rev=359081&view=rev Log: Add 'REQUIRES: shell' to verbose-output-quoting.c The lit shell couldn't handle these run lines. Modified: cfe/trunk/test/Driver/verbose-output-quoting.c Modifi

[PATCH] D60485: [AArch64] Add support for MTE intrinsics

t.p.northover added inline comments. Comment at: include/clang/Sema/Sema.h:10762 bool AllowName); + bool SemaBuiltinARMMemoryTaggingCall(unsigned BuiltinID, CallExpr *TheCall); public: Slightly misaligned. Comm

[PATCH] D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment

ztamas updated this revision to Diff 196410. ztamas added a comment. Remove outdated comment from docs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60507/new/ https://reviews.llvm.org/D60507 Files: clang-tools-extra/clang-tidy/bugprone/Bugpron

Re: [PATCH] D61040: [Fuchsia] Support multilib for -fsanitize=address and -fno-exceptions

On Tue, Apr 23, 2019 at 11:36 PM Petr Hosek via Phabricator < revi...@reviews.llvm.org> wrote: > phosek added inline comments. > > > > Comment at: clang/lib/Driver/ToolChains/CommonArgs.h:122 > + > +/// \p Flag must be a flag accepted by the driver with its leading '-' > removed,

[PATCH] D60907: [OpenMP][WIP] Add math functions support in OpenMP offloading

gtbercea added a comment. In D60907#1473406 , @Hahnfeld wrote: > So the scheme is: `pow` is defined in `__clang_openmp_math.h` to call > `__kmpc_pow`. This lives in `libomptarget-nvptx` (both bc and static lib) and > just calls `pow` which works because

r359098 - Use llvm::stable_sort

Author: maskray Date: Wed Apr 24 07:43:05 2019 New Revision: 359098 URL: http://llvm.org/viewvc/llvm-project?rev=359098&view=rev Log: Use llvm::stable_sort Modified: cfe/trunk/lib/AST/DeclObjC.cpp cfe/trunk/lib/AST/RecordLayoutBuilder.cpp cfe/trunk/lib/AST/VTableBuilder.cpp cfe/tr

[PATCH] D59725: Additions to creduce script

lebedev.ri added a comment. I've stumbled into an issue with the script: It got a line: `clang: /build/llvm/lib/Transforms/Scalar/IndVarSimplify.cpp:2582: bool {anonymous}::IndVarSimplify::run(llvm::Loop*): Assertion `L->isRecursivelyLCSSAForm(*DT, *LI) && "LCSSA required to run indvars!"' fai

[PATCH] D58033: Add option for emitting dbg info for call site parameters

probinson added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:3402 +CmdArgs.push_back("-femit-param-entry-values"); + RenderDebugInfoCompressionArgs(Args, CmdArgs, D, TC); If this is now a cc1-only option, this part goes away right? CHANGE

[PATCH] D60907: [OpenMP][WIP] Add math functions support in OpenMP offloading

gtbercea added a subscriber: gregrodgers. gtbercea added a comment. @gregrodgers Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60907/new/ https://reviews.llvm.org/D60907 ___ cfe-commits mailing list cfe-commits@lists

r359107 - clang-cl: List valid values for /std: in /? output

Author: nico Date: Wed Apr 24 08:31:13 2019 New Revision: 359107 URL: http://llvm.org/viewvc/llvm-project?rev=359107&view=rev Log: clang-cl: List valid values for /std: in /? output Differential Revision: https://reviews.llvm.org/D61029 Modified: cfe/trunk/include/clang/Driver/CLCompatOption

[PATCH] D61029: clang-cl: List valid values for /std: in /? output

This revision was automatically updated to reflect the committed changes. Closed by commit rL359107: clang-cl: List valid values for /std: in /? output (authored by nico, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revi

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

ilya-biryukov updated this revision to Diff 196462. ilya-biryukov marked 53 inline comments as done. ilya-biryukov added a comment. - Simplify rawByExpanded by using a helper function. - Add a FIXME to add spelled-to-expanded mapping - s/raw*/spelled* - Split token collector and token buffer tests

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

ilya-biryukov added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tokens.h:59 + explicit Token(const clang::Token &T); + + tok::TokenKind kind() const { return Kind; } sammccall wrote: > Token should be copyable I think? Sure, they are copyabl

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

efriedma added a comment. > For NotPod, it is aggregate which is specific in the document Yes, it's an aggregate which is returned in registers... but it's returned in integer registers, unlike Pod which is returned in floating-point registers. CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D60764: Add clang cc1 option to generate OpenCL builtin functions

Pierre updated this revision to Diff 196474. Pierre marked an inline comment as done. Pierre added a comment. The name of the command line option has been updated. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60764/new/ https://reviews.llvm.org/D60764 Files: clang/include/clang/Basi

[PATCH] D61054: lib/Header: Fix Visual Studio builds

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. LGTM This would break if someone does a debug and release build simultaneously, the copies occur simultaneously and the filesystem gets unhappy, That seems fairly contrived though, and this

[clang-tools-extra] r359112 - [clangd] Fix broken helper deep in unit test. NFC

Author: sammccall Date: Wed Apr 24 10:00:38 2019 New Revision: 359112 URL: http://llvm.org/viewvc/llvm-project?rev=359112&view=rev Log: [clangd] Fix broken helper deep in unit test. NFC Modified: clang-tools-extra/trunk/unittests/clangd/TestIndex.cpp Modified: clang-tools-extra/trunk/unittes

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

shafik added inline comments. Comment at: clang/trunk/unittests/AST/ASTImporterTest.cpp:4054 +} } aganea wrote: > Fixes > ``` > [2097/2979] Building CXX object > tools/clang/unittests/Tooling/CMakeFiles/ToolingTests.dir/LookupTest.cpp.o > /mnt/f/svn/cla

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

nikic added inline comments. Comment at: clang/trunk/unittests/AST/ASTImporterTest.cpp:4054 +} } shafik wrote: > aganea wrote: > > Fixes > > ``` > > [2097/2979] Building CXX object > > tools/clang/unittests/Tooling/CMakeFiles/ToolingTests.dir/LookupTest

[PATCH] D61077: [clangd] Query index in code completion no-compile mode.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, arphaman, mgrang, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. We scrape the enclosing scopes from the source file, and use them in the query. Repository: rCTE Clan

[PATCH] D58537: lib/Header: Simplify CMakeLists.txt

vzakhari added a comment. In D58537#1476570 , @tstellar wrote: > Can you test D61054 ? I will do it ASAP, but I am currently having problems with my build system. I guess it is OK to proceed with this change. I will se

[PATCH] D60974: Clang IFSO driver action.

compnerd added a comment. Okay, if the TBE isn't suitable for the pre-merged format, then I think that this should be okay with the current approach. This is more about the generation and not wanting to have to maintain a separate side table of information manually. It just is a different tra

[PATCH] D61079: Skip type units/type uniquing when we know we're only emitting the type once (vtable-based emission when triggered by a strong vtable, with -fno-standalone-debug)

dblaikie created this revision. dblaikie added a reviewer: aprantl. Herald added a project: clang. Herald added a subscriber: cfe-commits. (this would regress size without a corresponding LLVM change that avoids putting other user defined types inside type units when they aren't in their own type

[PATCH] D60974: Clang IFSO driver action.

phosek added a comment. Aside from comments that @jakehehrlich already made which I agree with, I'm also concerned about the use of `yaml2obj`. AFAIK that tool has always been intended as a testing, not a production tool, but with this change this would no longer be the case. Specifically, it f

[PATCH] D61027: Fix crash on switch conditions of non-integer types in templates

cpplearner added a comment. (I am ensadc at bugzilla) Does this cause regression in the following case? template void f() { switch (N) case 0:; // should be diagnosed switch (0) case N:; // should be diagnosed } Currently clang diagnoses these `switch` statements even if the t

[PATCH] D59725: Additions to creduce script

arichardson added a comment. In D59725#1477042 , @lebedev.ri wrote: > I've stumbled into an issue with the script: > It got a line: `clang: > /build/llvm/lib/Transforms/Scalar/IndVarSimplify.cpp:2582: bool > {anonymous}::IndVarSimplify::run(llvm::Loop*)

[PATCH] D59725: Additions to creduce script

lebedev.ri added inline comments. Comment at: cfe/trunk/utils/creduce-clang-crash.py:185 +for msg in self.expected_output: + output += 'grep %s t.log || exit 1\n' % pipes.quote(msg) + >>! In D59725#1477362, @arichardson wrote: >>>! In D59725#1477042, @le

[PATCH] D61083: Recommitting r358783 and r358786 "[MS] Emit S_HEAPALLOCSITE debug info" with fixes for buildbot error (undefined assembler label).

akhuang created this revision. akhuang added a reviewer: rnk. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, aprantl. Herald added projects: clang, LLVM. This emits labels around heapallocsite calls and S_HEAPALLOCSITE debug info in codeview. Currently only changes FastISel, so em

[PATCH] D61083: Recommitting r358783 and r358786 "[MS] Emit S_HEAPALLOCSITE debug info" with fixes for buildbot error (undefined assembler label).

akhuang updated this revision to Diff 196496. akhuang added a comment. - remove added whitespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61083/new/ https://reviews.llvm.org/D61083 Files: llvm/include/llvm/CodeGen/MachineFunction.h llvm/i

[PATCH] D60967: Move setTargetAttributes after setGVProperties in SetFunctionAttributes

scott.linder added a comment. @rjmccall Would you expect similar conflicts in explicit visibility to result in diagnostics? For example, marking a `static` variable with an explicit visibility attribute doesn't warn, instead the explicit visibility attribute is silently ignored. GCC 7.3 complai

r359132 - [OPENMP]Initial support for non-rectangular loop nest.

Author: abataev Date: Wed Apr 24 12:58:30 2019 New Revision: 359132 URL: http://llvm.org/viewvc/llvm-project?rev=359132&view=rev Log: [OPENMP]Initial support for non-rectangular loop nest. Added basic semantic analysis for the non-rectangular loop nests for OpenMP 5.0 support. Modified: cfe/

[PATCH] D60967: Move setTargetAttributes after setGVProperties in SetFunctionAttributes

rjmccall added a comment. Yeah, that seems like a missing warning. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60967/new/ https://reviews.llvm.org/D60967 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

aganea updated this revision to Diff 196505. aganea marked 7 inline comments as done. aganea added a comment. Adressed some of the comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61046/new/ https://reviews.llvm.org/D61046 Files: clang/trunk/unittests/AST/ASTImporterTest.cpp

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

aganea added inline comments. Comment at: llvm/trunk/lib/Target/AMDGPU/R600ISelLowering.cpp:1717-1722 +// Fix spurious warning with gcc 7.3 -O3 for NewBldVec[i] below +// warning: array subscript is above array bounds [-Warray-bounds] +#if defined(__GNUC__) && __GNUC__ >=

[PATCH] D50294: [Driver] Use -gdwarf-3 by default for FreeBSD

emaste added a subscriber: arichardson. emaste added a comment. Herald added a project: clang. In D50294#1246980 , @MaskRay wrote: > In D50294#1245454 , @emaste wrote: > > > I'm using this change: > > https://githu

[PATCH] D60523: [clang] Don't segfault on incorrect using directive (PR41400)

Tyker added a subscriber: jkooker. Tyker added a comment. @jkooker i don't think it is possible for `ASTContext::getDependentNameType` to deal with `NSS = nullptr` except by reporting the error. we probably don't want to just report the error because the error could have been handled before invo

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

tstellar added inline comments. Comment at: llvm/trunk/unittests/Transforms/Scalar/CMakeLists.txt:14-17 +# Workaround for the gcc 6.1 bug https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80916. +if (CMAKE_COMPILER_IS_GNUCXX AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 6.0) + set

[PATCH] D61083: Recommitting r358783 and r358786 "[MS] Emit S_HEAPALLOCSITE debug info" with fixes for buildbot error (undefined assembler label).

rnk added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:1078 + MCSymbol *EndLabel = std::get<1>(HeapAllocSite); + if (BeginLabel->isDefined() && EndLabel->isDefined()) { +DIType *DITy = std::get<2>(HeapAllocSite); I

Re: r359048 - C++ DR2387: a variable template declared wtih (or instantiated with) a

Thanks for the revert. Looks like this is probably an unfortunate interaction with the internal_linkage attribute. On Wed, 24 Apr 2019, 01:48 Ilya Biryukov via cfe-commits, < cfe-commits@lists.llvm.org> wrote: > Reverted in r359076. > > On Wed, Apr 24, 2019 at 10:28 AM Ilya Biryukov > wrote: >

[PATCH] D58573: [analyzer] Move UninitializedObjectChecker out of alpha

gribozavr added a comment. Thanks for the checker! We are hitting a crash on `_Atomic` fields, could you take a look? https://bugs.llvm.org/show_bug.cgi?id=41590 Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58573/new/ https://reviews.llvm.org/D58573

[PATCH] D58573: [analyzer] Move UninitializedObjectChecker out of alpha

Szelethus added a comment. In D58573#1477581 , @gribozavr wrote: > Thanks for the checker! We are hitting a crash on `_Atomic` fields, could > you take a look? https://bugs.llvm.org/show_bug.cgi?id=41590 Thanks! Yup, consider it fixed (in a little wh

[PATCH] D61079: Skip type units/type uniquing when we know we're only emitting the type once (vtable-based emission when triggered by a strong vtable, with -fno-standalone-debug)

aprantl added a comment. I hope I'm getting this right, but if I remember correctly, the significant part in this test is what is a FwdDecl as opposed to a definition. The identifiers no longer make it into the debug info and you should see no difference in the produced binaries with this chang

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 196516. plotfi added a comment. Updated to support properly setting OBJECT/FUNC types as well as section flags. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 Files:

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

rnk added inline comments. Comment at: clang/trunk/unittests/AST/ASTImporterTest.cpp:4054 +} } nikic wrote: > shafik wrote: > > aganea wrote: > > > Fixes > > > ``` > > > [2097/2979] Building CXX object > > > tools/clang/unittests/Tooling/CMakeFiles/Tool

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1477302 , @phosek wrote: > Aside from comments that @jakehehrlich already made which I agree with, I'm > also concerned about the use of `yaml2obj`. AFAIK that tool has always been > intended as a testing, not a producti

[PATCH] D61051: [analyzer] Treat functions without runtime branches as "small".

Szelethus added a comment. Nice! I have no objections (other than the nits) to this! Ill take a second look later, because I really need to play around with `CFG` a bit to give a definitive LGTM. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h:

[PATCH] D60974: Clang IFSO driver action.

jakehehrlich added a comment. To be clear I'm only really giving my thumbs up to a specific high level plan that I believe handles a case that llvm-elfabi wouldn't otherwise handle on its own. I consider the specifics like the output format still in the air right now. I strongly believe that a

[PATCH] D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check'

hintonda updated this revision to Diff 196521. hintonda added a comment. - Remove unnecessary comparison. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60629/new/ https://reviews.llvm.org/D60629 Files: clang-tools-extra/clang-tidy/add_new_check.

[PATCH] D61027: Fix crash on switch conditions of non-integer types in templates

eandrews added a comment. I ran the test you provided and it does throw errors without instantiation bash-4.2$ clang -cc1 test/SemaTemplate/test2.cpp test/SemaTemplate/test2.cpp:3:7: error: statement requires expression of integer type ('int *' invalid) switch (N) case 0:; // should

[clang-tools-extra] r359142 - [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals

Author: dhinton Date: Wed Apr 24 14:25:57 2019 New Revision: 359142 URL: http://llvm.org/viewvc/llvm-project?rev=359142&view=rev Log: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals Summary: Looks at conditionals and finds cases of ``cast<>``, which will assert rather th

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

aganea marked 3 inline comments as done. aganea added inline comments. Comment at: clang/trunk/unittests/AST/ASTImporterTest.cpp:4054 +} } rnk wrote: > nikic wrote: > > shafik wrote: > > > aganea wrote: > > > > Fixes > > > > ``` > > > > [2097/2979] Build

[PATCH] D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals

This revision was automatically updated to reflect the committed changes. Closed by commit rL359142: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals (authored by dhinton, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prio

Re: r359048 - C++ DR2387: a variable template declared wtih (or instantiated with) a

On Wed, 24 Apr 2019 at 13:28, Richard Smith wrote: > > Thanks for the revert. > > Looks like this is probably an unfortunate interaction with the > internal_linkage attribute. I think this is a libc++ bug. When _LIBCPP_HIDE_FROM_ABI_PER_TU_BY_DEFAULT is enabled, we have: #define _LIBCPP_HIDE_FR

[PATCH] D60974: Clang IFSO driver action.

compnerd added a comment. @jakehehrlich - when do you expect to have your idea put up? I don't think that it is fair to have this wait until you have time to put something up that can be discussed. I think that getting this working and then iterating on it and migrating it over to some shared

[PATCH] D61051: [analyzer] Treat functions without runtime branches as "small".

NoQ marked 4 inline comments as done. NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h:723 + /// should always inline simply because it's small enough. + bool isSmall(AnalysisDeclContext *ADC) const; + S

[PATCH] D61083: Recommitting r358783 and r358786 "[MS] Emit S_HEAPALLOCSITE debug info" with fixes for buildbot error (undefined assembler label).

akhuang updated this revision to Diff 196525. akhuang added a comment. - Add test case and comment for undefined labels Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61083/new/ https://reviews.llvm.org/D61083 Files: llvm/include/llvm/CodeGen/Mac

[PATCH] D61097: [Sema] Emit warning for visibility attribute on internal-linkage declaration

scott.linder created this revision. scott.linder added reviewers: rjmccall, espindola. Herald added a project: clang. Herald added a subscriber: cfe-commits. GCC warns on these cases, but we currently just silently ignore the attribute. Repository: rC Clang https://reviews.llvm.org/D61097 Fi

[PATCH] D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check'

hintonda updated this revision to Diff 196531. hintonda added a comment. - Change check back to previous version which is much clearer. - Apply namespace change to new check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60629/new/ https://reviews.

[PATCH] D60974: Clang IFSO driver action.

compnerd added a comment. @phosek - I completely agree, I really would prefer that this not promote the `yaml2obj` tool to an officially supported tool. The reason for using the same output format is for testing convenience, and this should not really invoke the tool (this should work without

[PATCH] D60974: Clang IFSO driver action.

jakehehrlich added a comment. In D60974#1477690 , @compnerd wrote: > @jakehehrlich - when do you expect to have your idea put up? I don't think > that it is fair to have this wait until you have time to put something up > that can be discussed. I think

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

rnk added inline comments. Comment at: clang/trunk/unittests/AST/ASTImporterTest.cpp:4054 +} } aganea wrote: > rnk wrote: > > nikic wrote: > > > shafik wrote: > > > > aganea wrote: > > > > > Fixes > > > > > ``` > > > > > [2097/2979] Building CXX object

[PATCH] D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check'

hintonda marked an inline comment as done. hintonda added inline comments. Comment at: clang-tools-extra/clang-tidy/rename_check.py:267 - if old_module != new_module: + if old_module != new_module or new_module == 'llvm': +if new_module == 'llvm': alexfh

[PATCH] D61083: Recommitting r358783 and r358786 "[MS] Emit S_HEAPALLOCSITE debug info" with fixes for buildbot error (undefined assembler label).

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61083/new/ https://reviews.llvm.org/D61083

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

TomTan added a comment. In D60349#1477183 , @efriedma wrote: > > For NotPod, it is aggregate which is specific in the document > > Yes, it's an aggregate which is returned in registers... but it's returned in > integer registers, unlike Pod which is retur

[PATCH] D61098: [clang] [RISC-V] Add validation for inline assembly constraints

mhorne created this revision. mhorne added reviewers: asb, apazos, shiva0217. Herald added subscribers: cfe-commits, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, kito-cheng, niosHD, sabuasal, simoncook, johnrusso, rbar. Herald added a project:

[PATCH] D61098: [clang] [RISC-V] Add validation for inline assembly constraints

mhorne added a comment. Apologies if I didn't tag the right reviewers; I took a look at those who seemed to be most involved with the RISC-V target, but if there's anyone more appropriate to review clang changes then feel free to add them instead :) Repository: rG LLVM Github Monorepo CHANG

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 196535. plotfi added a comment. First stab at trying to properly handle Weak Symbols Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 Files: clang/include/clang/Driver/

[PATCH] D60930: [codeview] Fix symbol names for dynamic initializers and atexit stubs

rnk added a comment. In D60930#1474460 , @jyu2 wrote: > Looks good to me. We are basically de-mangled name for those __E initialize > global’s function and __F destroy global's function. Thanks! I'm going to land this, but @rjmccall, let me know if

Re: r359067 - [Builtins] Implement __builtin_is_constant_evaluated for use in C++2a

Thanks! Can you update cxx_status.html to mark P0595R2 as done? On Tue, 23 Apr 2019 at 19:21, Eric Fiselier via cfe-commits wrote: > > Author: ericwf > Date: Tue Apr 23 19:23:30 2019 > New Revision: 359067 > > URL: http://llvm.org/viewvc/llvm-project?rev=359067&view=rev > Log: > [Builtins] Implem

r359148 - [codeview] Fix symbol names for dynamic initializers and atexit stubs

Author: rnk Date: Wed Apr 24 15:45:44 2019 New Revision: 359148 URL: http://llvm.org/viewvc/llvm-project?rev=359148&view=rev Log: [codeview] Fix symbol names for dynamic initializers and atexit stubs Summary: Add a new variant to GlobalDecl for these so that we can detect them more easily during

[PATCH] D60930: [codeview] Fix symbol names for dynamic initializers and atexit stubs

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC359148: [codeview] Fix symbol names for dynamic initializers and atexit stubs (authored by rnk, committed by ). Changed p

[PATCH] D60605: [clangd] Revamp textDocument/onTypeFormatting.

sammccall updated this revision to Diff 196538. sammccall added a comment. Fix comment wrapping behavior: - when splitting a comment before //, don't add another // - if the editor inserts // before the cursor to continue a line comment, indent it and adjust to three slashes if needed. This doe

[PATCH] D61083: Recommitting r358783 and r358786 "[MS] Emit S_HEAPALLOCSITE debug info" with fixes for buildbot error (undefined assembler label).

This revision was automatically updated to reflect the committed changes. Closed by commit rL359149: Recommitting r358783 and r358786 "[MS] Emit S_HEAPALLOCSITE debug info" with… (authored by akhuang, committed by ). Changed prior to commit: https://reviews.llvm.org/D61083?vs=196525&id=196540#t

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

tstellar added inline comments. Comment at: llvm/trunk/unittests/Transforms/Scalar/CMakeLists.txt:14-17 +# Workaround for the gcc 6.1 bug https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80916. +if (CMAKE_COMPILER_IS_GNUCXX AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 6.0) + set

[PATCH] D61103: [clang] Add tryToAttachCommentsToDecls method to ASTContext

jkorous created this revision. jkorous added reviewers: gribozavr, arphaman. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Loading external comments and sorting them is expensive - mostly due to getDecomposedLoc() begin expensive. For modules with very large nu

[PATCH] D61040: [Fuchsia] Support multilib for -fsanitize=address and -fno-exceptions

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1507 +Multilib::flags_list &Flags) { + if (Enabled) +Flags.push_back(std::str

[PATCH] D61104: [clang][ASTContext] Try to avoid sorting comments for code completion

jkorous created this revision. jkorous added reviewers: gribozavr, arphaman. Herald added subscribers: cfe-commits, dexonsmith, mgrang. Herald added a project: clang. For large number of deserialized comments (~100k) the way how we try to attach them to declaration in completion comments is too e

[PATCH] D60990: [Driver] Support priority for multilibs

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/include/clang/Driver/Multilib.h:81 + /// Returns the multilib priority. + int priority() const { return Priority; } Say explic

r359155 - PR41427: This has apparently been fixed already, just add a regression

Author: rsmith Date: Wed Apr 24 16:45:56 2019 New Revision: 359155 URL: http://llvm.org/viewvc/llvm-project?rev=359155&view=rev Log: PR41427: This has apparently been fixed already, just add a regression test. Added: cfe/trunk/test/SemaTemplate/ctad.cpp Added: cfe/trunk/test/SemaTemplate/cta

[PATCH] D61040: [Fuchsia] Support multilib for -fsanitize=address and -fno-exceptions

mcgrathr added inline comments. Comment at: clang/lib/Driver/ToolChains/Fuchsia.cpp:179 + .flag("+fno-exceptions"); + Multilib ASan = Multilib("/asan", "", "", 2).flag("+fsanitize=address"); + Multilibs.push_back(Default); Add a comment

[PATCH] D55229: [COFF] Statically link certain runtime library functions

rnk commandeered this revision. rnk edited reviewers, added: mgrang; removed: rnk. rnk added a comment. In D55229#1455472 , @rnk wrote: > This patch fixes a lot of LNK4286 warnings when running `check-asan` on > Windows, so I'd like to get it committed up

[PATCH] D55229: [COFF] Statically link certain runtime library functions

rnk updated this revision to Diff 196553. rnk added a comment. Herald added a project: clang. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55229/new/ https://reviews.llvm.org/D55229 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/te

  1   2   >