[PATCH] D59221: [asan] Add gcc 8's driver option -fsanitize=pointer-compare and -fsanitize=pointer-substract.

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Seems like harmless plumbing. Given that the LLVM side of this is accepted, this lgtm. Comment at: test/Driver/fsanitize.c:837 +// RUN: %clang -target x86_64-linux-gnu -fsan

[PATCH] D60548: Variable auto-init: also auto-init alloca

rjmccall added inline comments. Comment at: lib/CodeGen/PatternInit.cpp:17 + +llvm::Constant *patternFor(CodeGenModule &CGM, llvm::Type *Ty) { + // The following value is a guaranteed unmappable pointer value and has a Please use a qualified declaration here ins

Re: r357610 - Bug-40323: MS ABI adding template static member in the linker directive section to make sure init function can be called before main.

Hi Jennifer, this caused https://bugs.llvm.org/show_bug.cgi?id=41471 Do you think this is easy to fix, or should we revert for now? Thanks, Nico On Wed, Apr 3, 2019 at 1:20 PM Jennifer Yu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: jyu2 > Date: Wed Apr 3 10:21:40 2019 > New

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea updated this revision to Diff 194758. gtbercea marked 2 inline comments as done. gtbercea added a comment. - Fix enum. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 Files: lib/CodeGen/CGOpenMPRuntime.cpp li

r358230 - Remove use of lookahead from _Pragma handling and from all other

Author: rsmith Date: Thu Apr 11 14:18:22 2019 New Revision: 358230 URL: http://llvm.org/viewvc/llvm-project?rev=358230&view=rev Log: Remove use of lookahead from _Pragma handling and from all other internal lexing steps in the preprocessor. It is not safe to use the preprocessor's token lookahead

r358231 - [C++20] Implement context-sensitive header-name lexing and pp-import parsing in the preprocessor.

Author: rsmith Date: Thu Apr 11 14:18:23 2019 New Revision: 358231 URL: http://llvm.org/viewvc/llvm-project?rev=358231&view=rev Log: [C++20] Implement context-sensitive header-name lexing and pp-import parsing in the preprocessor. Added: cfe/trunk/test/CXX/cpp/cpp.module/ cfe/trunk/test/

RE: r357610 - Bug-40323: MS ABI adding template static member in the linker directive section to make sure init function can be called before main.

Hi Nico, Iet’s revert it now. I will try to re-submit latter. Thanks. Jennifer From: Nico Weber [mailto:tha...@chromium.org] Sent: Thursday, April 11, 2019 2:04 PM To: Yu, Jennifer Cc: cfe-commits Subject: Re: r357610 - Bug-40323: MS ABI adding template static member in the linker directive s

Re: r357340 - Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps.

I tried using this to see why X86ISelLowering.cpp takes so long to build on my system. The output json produced by this flag is at http://s000.tinyupload.com/?file_id=00019982161870973700 It looks like this produces lots of useful information for frontend time, but in this case most time is spent

r358232 - Revert r357610, it caused PR41471

Author: nico Date: Thu Apr 11 14:26:34 2019 New Revision: 358232 URL: http://llvm.org/viewvc/llvm-project?rev=358232&view=rev Log: Revert r357610, it caused PR41471 Removed: cfe/trunk/test/CodeGenCXX/microsoft-abi-template-static-init.cpp Modified: cfe/trunk/lib/CodeGen/CGDeclCXX.cpp Mod

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea updated this revision to Diff 194760. gtbercea added a comment. - Split patch. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/CodeGe

Re: r357610 - Bug-40323: MS ABI adding template static member in the linker directive section to make sure init function can be called before main.

Done in 358232. Thanks! On Thu, Apr 11, 2019 at 5:19 PM Yu, Jennifer wrote: > Hi Nico, > > > > Iet’s revert it now. I will try to re-submit latter. > > Thanks. > > Jennifer > > > > *From:* Nico Weber [mailto:tha...@chromium.org] > *Sent:* Thursday, April 11, 2019 2:04 PM > *To:* Yu, Jennifer >

RE: r357610 - Bug-40323: MS ABI adding template static member in the linker directive section to make sure init function can be called before main.

Thank you so much. Jennifer From: Nico Weber [mailto:tha...@chromium.org] Sent: Thursday, April 11, 2019 2:25 PM To: Yu, Jennifer Cc: cfe-commits Subject: Re: r357610 - Bug-40323: MS ABI adding template static member in the linker directive section to make sure init function can be called befo

[PATCH] D60548: Variable auto-init: also auto-init alloca

jfb updated this revision to Diff 194762. jfb marked 2 inline comments as done. jfb added a comment. - Change name, qualify declaration. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60548/new/ https://reviews.llvm.org/D60548 Files: lib/CodeGen/CGBuiltin.cpp

[PATCH] D60570: [Sema] Add more tests for the behavior of argument-dependent name lookup

riccibruno updated this revision to Diff 194763. riccibruno added a comment. Herald added a subscriber: eraman. Also test for inline namespaces. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60570/new/ https://reviews.llvm.org/D60570 Files: test/CXX/basic/bas

[PATCH] D60548: Variable auto-init: also auto-init alloca

jfb marked 2 inline comments as done. jfb added inline comments. Comment at: lib/CodeGen/PatternInit.h:22 + +llvm::Constant *patternFor(CodeGenModule&, llvm::Type*); + rjmccall wrote: > Please choose names that mean something outside of the mental context you >

[PATCH] D60573: [Sema] ADL: Associated namespaces for class types and enumeration types (CWG 1691)

riccibruno updated this revision to Diff 194765. riccibruno added a comment. Removed the call to `isTransparentContext()` in the loop in `CollectEnclosingNamespace`. It is not actually needed since we only care about finding the innermost enclosing namespace. Repository: rC Clang CHANGES SI

[PATCH] D60151: [clang-tidy] Rename llvm checkers to llvm-project

MyDeveloperDay added a comment. >> I suppose we could keep the names and directory structure and just change >> the namespace. That would just be a special case in the scripts. Haven't >> looked into it yet, but will do so as soon as I can. > > Isn't that matching done on strings? I.e. is t

[PATCH] D59459: [analyzer][NFC] Prefer binary searches in CheckerRegistry

Szelethus updated this revision to Diff 194768. Szelethus added a comment. Change asserts according to reviewer feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59459/new/ https://reviews.llvm.org/D59459 Files: include/clang/StaticAnalyzer/Frontend/CheckerRegistry.h lib/Stat

[PATCH] D59459: [analyzer][NFC] Prefer binary searches in CheckerRegistry

Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp:70 + Collection, Info, + FullNameLT{}); +} baloghadamsoftware wrote: > Please note that `llvm::lower_bound()` uses `

Re: r358104 - Don't emit an unreachable return block.

Thanks, your fix looks good to me. - Marco. Il 11/04/19 05:05, John McCall ha scritto: > > > On 10 Apr 2019, at 21:50, wolfgang.p...@sony.com wrote: > >> Hi, >> This commit seems to be causing a test failure on several buildbots >> (e.g. >> http://lab.llvm.org:8011/builders/clang-ppc64be-linux-l

[PATCH] D60548: Variable auto-init: also auto-init alloca

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Comment at: lib/CodeGen/PatternInit.h:22 + +llvm::Constant *patternFor(CodeGenModule&, llvm::Type*); + jfb wrote: > rjmccall wrote: > > Please choo

[PATCH] D60573: [Sema] ADL: Associated namespaces for class types and enumeration types (CWG 1691)

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Hmm. Does this never impact code that's just using a locally-defined type within its scope? I guess if ADL is involved, unqualified lookup must have reached the scope of the innermost na

[PATCH] D60548: Variable auto-init: also auto-init alloca

jfb marked an inline comment as done. jfb added inline comments. Comment at: lib/CodeGen/PatternInit.h:22 + +llvm::Constant *patternFor(CodeGenModule&, llvm::Type*); + rjmccall wrote: > jfb wrote: > > rjmccall wrote: > > > Please choose names that mean something

[PATCH] D60151: [clang-tidy] Rename llvm checkers to llvm-project

hintonda added a comment. In D60151#1463484 , @MyDeveloperDay wrote: > >> I suppose we could keep the names and directory structure and just change > >> the namespace. That would just be a special case in the scripts. Haven't > >> looked into it yet,

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea updated this revision to Diff 194781. gtbercea added a comment. - Handle OpenMP simd case. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h

[PATCH] D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals

hintonda marked an inline comment as done. hintonda added inline comments. Comment at: clang-tools-extra/clang-tidy/llvm/PreferIsaOrDynCastInConditionalsCheck.h:37-39 +/// if (var && isa(var)) {} +/// // is replaced by: +/// if (dyn_cast_or_null(var.foo())) {} ---

[PATCH] D60573: [Sema] ADL: Associated namespaces for class types and enumeration types (CWG 1691)

rsmith accepted this revision. rsmith added a comment. > I have applied the fix to all language versions, even though I think that the > DR only applies to C++14 DRs don't have a specific version that they are intended to apply to; that's up to us to determine, and generally we apply them retro

[PATCH] D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals

hintonda updated this revision to Diff 194782. hintonda added a comment. - Update isa_and_nonnull diagnostic message, and fix typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59802/new/ https://reviews.llvm.org/D59802 Files: clang-tools-extra

[libunwind] r358242 - Creating release candidate final from release_710 branch

Author: tstellar Date: Thu Apr 11 16:41:27 2019 New Revision: 358242 URL: http://llvm.org/viewvc/llvm-project?rev=358242&view=rev Log: Creating release candidate final from release_710 branch Added: libunwind/tags/RELEASE_710/final/ - copied from r358241, libunwind/branches/release_70/

r358243 - Variable auto-init: also auto-init alloca

Author: jfb Date: Thu Apr 11 17:11:27 2019 New Revision: 358243 URL: http://llvm.org/viewvc/llvm-project?rev=358243&view=rev Log: Variable auto-init: also auto-init alloca Summary: alloca isn’t auto-init’d right now because it’s a different path in clang that all the other stuff we support (it’s

[PATCH] D60548: Variable auto-init: also auto-init alloca

This revision was automatically updated to reflect the committed changes. Closed by commit rC358243: Variable auto-init: also auto-init alloca (authored by jfb, committed by ). Changed prior to commit: https://reviews.llvm.org/D60548?vs=194762&id=194787#toc Repository: rC Clang CHANGES SINC

[PATCH] D60548: Variable auto-init: also auto-init alloca

jfb added a comment. I got an lgtm from @pcc on IRC, so I'll commit this. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60548/new/ https://reviews.llvm.org/D60548 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D60573: [Sema] ADL: Associated namespaces for class types and enumeration types (CWG 1691)

riccibruno added a comment. In D60573#1463569 , @rjmccall wrote: > Hmm. Does this never impact code that's just using a locally-defined type > within its scope? I guess if ADL is involved, unqualified lookup must have > reached the scope of the innermo

[PATCH] D60573: [Sema] ADL: Associated namespaces for class types and enumeration types (CWG 1691)

riccibruno added a comment. In D60573#1463611 , @rsmith wrote: > > I have applied the fix to all language versions, even though I think that > > the DR only applies to C++14 > > DRs don't have a specific version that they are intended to apply to; that's

r358245 - Enable frame pointer elimination for OpenBSD on x86 and mips64.

Author: brad Date: Thu Apr 11 18:29:18 2019 New Revision: 358245 URL: http://llvm.org/viewvc/llvm-project?rev=358245&view=rev Log: Enable frame pointer elimination for OpenBSD on x86 and mips64. Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp cfe/trunk/test/Driver/frame-pointer-elim.c

[PATCH] D60541: [clang-format] Use SpacesBeforeTrailingComments for "option" directive

dchai removed a subscriber: cfe-commits. dchai added a comment. Can someone please merge this for me? I don't have commit access. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60541/new/ https://reviews.llvm.org/D60541

[PATCH] D58749: [index-while-building] IndexRecordHasher

jkorous added a comment. We did performance tests of alternative approach - just hashing the serialized bit code representation. There's a performance regression in the sense that while the current implementation costs approx. extra 2.2% in build time the alternative approach costs 3.8%. We ar

[PATCH] D59756: [clangd] Support dependent bases in type hierarchy

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/unittests/clangd/TypeHierarchyTests.cpp:405 + *Result, + AllOf(WithName("S"), WithKind(SymbolKind::Struct), +Parents(AllOf(WithName("S"), WithKind(SymbolKind

[PATCH] D60573: [Sema] ADL: Associated namespaces for class types and enumeration types (CWG 1691)

rjmccall added a comment. In D60573#1463641 , @riccibruno wrote: > In D60573#1463569 , @rjmccall wrote: > > > Hmm. Does this never impact code that's just using a locally-defined type > > within its scope? I gues

Re: r357340 - Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps.

Hi Nico, yes, you are right, current implementation is mostly focused on frontend. Yes, I can impove BE time output after getting feedback like yours one. Do you need detailed info about BE passes times? Btw, did you try -ftime-report option? It could give you detailed info on BE passes bottlenecks

<    1   2