[PATCH] D59076: [coroutines][PR40978] Emit error for co_yield within catch block

riccibruno added a comment. This is causing https://bugs.llvm.org/show_bug.cgi?id=41171. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59076/new/ https://reviews.llvm.org/D59076 ___ cfe-commits mailing list cfe-commi

r356705 - [CodeGen][ObjC] Annotate calls to objc_retainAutoreleasedReturnValue

Author: ahatanak Date: Thu Mar 21 12:59:49 2019 New Revision: 356705 URL: http://llvm.org/viewvc/llvm-project?rev=356705&view=rev Log: [CodeGen][ObjC] Annotate calls to objc_retainAutoreleasedReturnValue with notail on x86-64. On x86-64, the epilogue code inserted before the tail jump blocks the

[PATCH] D59655: [AArch64] Split the neon.addp intrinsic into integer and fp variants

aemerson marked an inline comment as done. aemerson added inline comments. Comment at: llvm/lib/IR/AutoUpgrade.cpp:574 + if (ArgTy->getElementType()->isFloatingPointTy()) { +auto fArgs = F->getFunctionType()->params(); +Type *Tys[] = {fArgs[0], fArgs[1]}; ---

[PATCH] D59656: [CodeGen][ObjC] Annotate calls to objc_retainAutoreleasedReturnValue with notail on x86-64

This revision was automatically updated to reflect the committed changes. Closed by commit rL356705: [CodeGen][ObjC] Annotate calls to objc_retainAutoreleasedReturnValue (authored by ahatanak, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

r356706 - [Driver] Pass -malign-double from the driver to the cc1 command line

Author: ctopper Date: Thu Mar 21 13:07:24 2019 New Revision: 356706 URL: http://llvm.org/viewvc/llvm-project?rev=356706&view=rev Log: [Driver] Pass -malign-double from the driver to the cc1 command line -malign-double is currently only implemented in the -cc1 interface. But its declared in Optio

[PATCH] D59624: [Driver] Pass -malign-double from the driver to the cc1 command line

This revision was automatically updated to reflect the committed changes. Closed by commit rL356706: [Driver] Pass -malign-double from the driver to the cc1 command line (authored by ctopper, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to c

[PATCH] D35068: [analyzer] Detect usages of unsafe I/O functions

NoQ added a comment. Herald added a subscriber: Charusso. There seems to be a crash in this code. @koldaniel, would you like to take a look? https://bugs.llvm.org/show_bug.cgi?id=41185 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D35068/new/ https://reviews.llvm.

[PATCH] D59279: [Analyzer] Checker for non-determinism caused by iteration of unordered container of pointers

rnkovacs added a comment. In D59279#1427017 , @mgrang wrote: > Following are the assumptions/limitations of this patch: > > 1. The assumption is that iteration of ordered containers of pointers is > not non-deterministic. > Could you please explain wh

Re: r356222 - [analyzer] Support C++17 aggregates with bases without constructors.

This one seems to be fixed by the second patch and is looks similar to the testcase that's already there - https://reviews.llvm.org/D59622 Different backtraces are moderately expected :) On 3/21/19 6:58 AM, Alexander Kornienko wrote: Thanks for the fix! Meanwhile, I found a couple of code sampl

[PATCH] D59655: [AArch64] Split the neon.addp intrinsic into integer and fp variants

efriedma added a comment. The IR at this Comment at: llvm/lib/IR/AutoUpgrade.cpp:574 + if (ArgTy->getElementType()->isFloatingPointTy()) { +auto fArgs = F->getFunctionType()->params(); +Type *Tys[] = {fArgs[0], fArgs[1]}; aemerson wrote: >

[PATCH] D59523: Thread Safety: also look at ObjC methods

aaronpuchert added inline comments. Comment at: lib/Analysis/ThreadSafetyCommon.cpp:283-285 + if (isa(D) + ? (cast(D)->getCanonicalDecl() == Canonical) + : (cast(D)->getCanonicalDecl() == Canonical)) { aaron.ballman wrote: > Also so

[PATCH] D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior.

teemperor updated this revision to Diff 191765. teemperor retitled this revision from "[ASTImporter] Allow adding a import strategy to the ASTImporter" to "[ASTImporter] Add an ImportInternal method to allow customizing Import behavior.". teemperor edited the summary of this revision. teemperor a

[PATCH] D59279: [Analyzer] Checker for non-determinism caused by iteration of unordered container of pointers

mgrang added a comment. In D59279#1438500 , @rnkovacs wrote: > In D59279#1427017 , @mgrang wrote: > > > Following are the assumptions/limitations of this patch: > > > > 1. The assumption is that iteration of order

[PATCH] D59650: [NFC] ExceptionEscapeCheck: small refactoring

JonasToth added a comment. Why not having normal overloads? The analysis for `Stmt` is implemented with the private methods. Explicit template specialization is a bit overkill and so easily understood (but not too complex in this case either).l Repository: rCTE Clang Tools Extra CHANGES SIN

[libunwind] r356708 - Bump version to 8.0.1

Author: tstellar Date: Thu Mar 21 13:32:00 2019 New Revision: 356708 URL: http://llvm.org/viewvc/llvm-project?rev=356708&view=rev Log: Bump version to 8.0.1 Modified: libunwind/branches/release_80/CMakeLists.txt Modified: libunwind/branches/release_80/CMakeLists.txt URL: http://llvm.org/vie

r356710 - [OPENMP] Simplify codegen for allocate directive on local variables.

Author: abataev Date: Thu Mar 21 13:36:16 2019 New Revision: 356710 URL: http://llvm.org/viewvc/llvm-project?rev=356710&view=rev Log: [OPENMP] Simplify codegen for allocate directive on local variables. Simplified codegen for the allocate directive for local variables, initial implementation of t

r356709 - [X86] Correct the value of MaxAtomicInlineWidth for pre-586 cpus

Author: ctopper Date: Thu Mar 21 13:36:08 2019 New Revision: 356709 URL: http://llvm.org/viewvc/llvm-project?rev=356709&view=rev Log: [X86] Correct the value of MaxAtomicInlineWidth for pre-586 cpus Use the new cx8 feature flag that was added to the backend to represent support for cmpxchg8b. Us

[PATCH] D59566: [X86] Correct the value of MaxAtomicInlineWidth for pre-586 cpus

This revision was automatically updated to reflect the committed changes. Closed by commit rL356709: [X86] Correct the value of MaxAtomicInlineWidth for pre-586 cpus (authored by ctopper, committed by ). Herald added a project: LLVM. Changed prior to commit: https://reviews.llvm.org/D59566?vs=1

[PATCH] D59650: [NFC] ExceptionEscapeCheck: small refactoring

lebedev.ri added a comment. In D59650#1438515 , @JonasToth wrote: > Why not having normal overloads? The analysis for `Stmt` is implemented with > the private methods. Explicit template specialization is a bit overkill and > so easily understood (but not

r356712 - Improve the diagnostic for #include_next occurring in a file not found

Author: rsmith Date: Thu Mar 21 13:42:13 2019 New Revision: 356712 URL: http://llvm.org/viewvc/llvm-project?rev=356712&view=rev Log: Improve the diagnostic for #include_next occurring in a file not found in the include path. Instead of making the incorrect claim that the included file has an abso

[PATCH] D59655: [AArch64] Split the neon.addp intrinsic into integer and fp variants

aemerson updated this revision to Diff 191774. aemerson added a comment. Simplify logic and don't try to upgrade if IR is invalid. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59655/new/ https://reviews.llvm.org/D59655 Files: clang/lib/CodeGen/

r356715 - [OPENMP]Fix a warning about unused variable, NFC.

Author: abataev Date: Thu Mar 21 13:52:04 2019 New Revision: 356715 URL: http://llvm.org/viewvc/llvm-project?rev=356715&view=rev Log: [OPENMP]Fix a warning about unused variable, NFC. Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntimeNVPT

[PATCH] D59665: Call to HandleNameConflict in VisitEnumDecl mistakeningly using Name instead of SearchName

shafik created this revision. shafik added reviewers: teemperor, martong, a_sidorin. Herald added a subscriber: rnkovacs. https://reviews.llvm.org/D51633 added error handling to the `ASTNodeImporter::VisitEnumDecl(...)` for the conflicting names case. This could lead to erroneous return of an er

[PATCH] D59655: [AArch64] Split the neon.addp intrinsic into integer and fp variants

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59655/new/ https://reviews.llvm.org/D59655 ___

[PATCH] D59665: Call to HandleNameConflict in VisitEnumDecl mistakeningly using Name instead of SearchName

shafik added a comment. I was not able to come up with a test that would detect this issue using either `clang-import-test` nor via any of the methods used in `ASTImpoterTest.cpp`. I created a regression test on the lldb side, which should pass once this is committed: https://reviews.llvm.org/

[PATCH] D59650: [NFC] ExceptionEscapeCheck: small refactoring

JonasToth added a comment. > Looks like pointless code duplication that is easily avoidable. True, but I would prefer the refactoring to be private then (so the template stuff with the boilerplate) and a simple overloading interface dispatching to the templated stuff. In the end I think the pub

[PATCH] D59670: [Sema] Fix an assert when a block captures a constexpr local

erik.pilkington created this revision. erik.pilkington added reviewers: rjmccall, rsmith. Herald added subscribers: dexonsmith, jkorous. Herald added a project: clang. `MarkVarDeclODRUsed` indirectly calls `captureInBlock`, which creates a copy expression. The copy expression is insulated in it's

[PATCH] D59466: [clang-tidy] openmp-exception-escape - a new check

lebedev.ri updated this revision to Diff 191783. lebedev.ri added a comment. Rebased for D59650 changes, NFC. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59466/new/ https://reviews.llvm.org/D59466 Files: clang-

[PATCH] D59650: [NFC] ExceptionEscapeCheck: small refactoring

lebedev.ri updated this revision to Diff 191782. lebedev.ri added a comment. Keep templated function out of the public interface. In D59650#1438603 , @JonasToth wrote: > > Looks like pointless code duplication that is easily avoidable. > > True, but I wou

[PATCH] D59650: [NFC] ExceptionEscapeCheck: small refactoring

lebedev.ri marked an inline comment as done. lebedev.ri added inline comments. Comment at: clang-tidy/utils/ExceptionAnalyzer.cpp:226 +ExceptionAnalyzer::ExceptionInfo +ExceptionAnalyzer::analyzeBoilerplate(const T *Node) { + ExceptionInfo ExceptionList; Please

[PATCH] D59650: [NFC] ExceptionEscapeCheck: small refactoring

JonasToth added inline comments. Comment at: clang-tidy/utils/ExceptionAnalyzer.cpp:226 +ExceptionAnalyzer::ExceptionInfo +ExceptionAnalyzer::analyzeBoilerplate(const T *Node) { + ExceptionInfo ExceptionList; lebedev.ri wrote: > Please bikeshed on the name. I do

[PATCH] D40988: Clang-format: add finer-grained options for putting all arguments on one line

russellmcc added a comment. Ping! Still looking for help on this - I definitely don't want to diminish the complexity of this code, and would really appreciate any help getting this in. I've already apologized for the gap from feedback in July 2018 to response in October - and I'm happy to ag

[PATCH] D57660: [Sema] SequenceChecker: Handle references, members and structured bindings.

riccibruno added a comment. Friendly ping. One thing I am wondering about is whether `MemoryLocation` and `getMemoryLocation` is duplicating something that is already present somewhere else. It feels like something similar should already exist but I can't find anything (but that is not saying m

[PATCH] D54881: [clang-format] Prevent Clang-Format from editing leading whitespace on lines outside of the format range

russellmcc added a comment. Sorry for the ambiguity. I meant, "running clang-format on the changed lines locally was not enough". I'll edit the description to clarify. To go in more detail, let's imagine you changed line 3. You run clang-format locally on line 3, but because of the bug fixed

[PATCH] D59673: [Driver] Allow setting the DWO name DWARF attribute separately

aaronpuchert created this revision. aaronpuchert added reviewers: dblaikie, echristo. Herald added subscribers: cfe-commits, jdoerfert, aprantl. Herald added a project: clang. With Split DWARF the resulting object file (then called skeleton CU) contains the file name of another ("DWO") file with t

[PATCH] D59673: [Driver] Allow setting the DWO name DWARF attribute separately

dblaikie added a comment. Pleasue include mention of the bug (PR40276) in the commit message & clarify that while this is useful for some remote compilation models, it's not strictly necessary/the only way to do it (a remote compilation model that keeps relative paths and uses compilation-dir i

r356722 - [AArch64] Split the neon.addp intrinsic into integer and fp variants.

Author: aemerson Date: Thu Mar 21 15:31:37 2019 New Revision: 356722 URL: http://llvm.org/viewvc/llvm-project?rev=356722&view=rev Log: [AArch64] Split the neon.addp intrinsic into integer and fp variants. This is the result of discussions on the list about how to deal with intrinsics which requir

[PATCH] D59655: [AArch64] Split the neon.addp intrinsic into integer and fp variants

This revision was automatically updated to reflect the committed changes. Closed by commit rL356722: [AArch64] Split the neon.addp intrinsic into integer and fp variants. (authored by aemerson, committed by ). Changed prior to commit: https://reviews.llvm.org/D59655?vs=191774&id=191792#toc Rep

[PATCH] D59629: [clang-format] correctly format protobuf fields named "enum".

dchai added a comment. I don't have commit access; can someone please merge this on my behalf? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59629/new/ https://reviews.llvm.org/D59629 ___ cfe-commits mailing list cfe

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous marked an inline comment as done. jkorous added a comment. In D58418#1431765 , @thakis wrote: > In D58418#1431399 , @jkorous wrote: > > > In D58418#1430630 , @thakis

[PATCH] D57965: Clean up ObjCPropertyDecl printing

jkorous accepted this revision. jkorous added a comment. This revision is now accepted and ready to land. LGTM. Thanks for working on this! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57965/new/ https://reviews.llvm.org/D57965 ___

[PATCH] D40988: Clang-format: add finer-grained options for putting all arguments on one line

jkorous added a comment. @russellmcc the patch has been approved by @MyDeveloperDay https://reviews.llvm.org/D40988#1430502 Do you mean you don't have commit access and need someone to land the patch on your behalf? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D40988/new/ https://revi

r356724 - This test assumes that -rtlib defaults to libgcc. But that isn't true in the face of -DCLANG_DEFAULT_RTLIB=compiler-rt.

Author: saugustine Date: Thu Mar 21 16:30:50 2019 New Revision: 356724 URL: http://llvm.org/viewvc/llvm-project?rev=356724&view=rev Log: This test assumes that -rtlib defaults to libgcc. But that isn't true in the face of -DCLANG_DEFAULT_RTLIB=compiler-rt. Subscribers: dberris, jdoerfert, llvm-c

[PATCH] D59631: [AArch64] Support selecting TPIDR_EL[1-3] as the thread base

philip.derrin removed a reviewer: olista01. philip.derrin added a comment. In D59631#1437744 , @olista01 wrote: > Is there an existing compiler which this option is trying to be compatible > with? GCC for AArch64 doesn't currently have an option for this,

[PATCH] D59631: [AArch64] Support selecting TPIDR_EL[1-3] as the thread base

philip.derrin updated this revision to Diff 191800. philip.derrin edited the summary of this revision. philip.derrin added a comment. Merged -mtpidr= with existing AArch32 option -mtp= CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59631/new/ https://reviews.llvm.org/D59631 Files: cla

[PATCH] D59673: [Driver] Allow setting the DWO name DWARF attribute separately

aaronpuchert added a comment. In D59673#1438716 , @dblaikie wrote: > Use llvm-dwarfdump rather than llvm-objdump to dump the contents of the > debug_info section and test the dwo_name there (rather than dumping hex) I didn't know about llvm-dwarfdump, I

[PATCH] D59673: [Driver] Allow setting the DWO name DWARF attribute separately

aaronpuchert updated this revision to Diff 191813. aaronpuchert added a comment. Use llvm-dwarfdump to inspect debug info, remove unneeded flags. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59673/new/ https://reviews.llvm.org/D59673 Files: include/clang/Basi

[PATCH] D59665: Call to HandleNameConflict in VisitEnumDecl mistakeningly using Name instead of SearchName

a_sidorin added a subscriber: davide. a_sidorin added a comment. Hi Shafik, Honestly, I was always wondering what does HandleNameConflict actually do. Its implementation in ASTImporter is trivial and I don't see any of its overrides in LLDB code too. Why do we check its result to be non-empty i

[PATCH] D40988: Clang-format: add finer-grained options for putting all arguments on one line

russellmcc added a comment. Yes, I don’t have commit access and would need someone else to land the patch. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D40988/new/ https://reviews.llvm.org/D40988 ___ cfe-commits mailing list cfe-c

[PATCH] D47111: : Implement monotonic_buffer_resource.

Quuxplusone updated this revision to Diff 191814. Quuxplusone added a comment. Herald added a subscriber: jdoerfert. Rebased on master. Added `_NOEXCEPT` to the `resource()` method (this is OK per [res.on.exception.handling]/5). @ckennelly ping! Repository: rCXX libc++ CHANGES SINCE LAST AC

[PATCH] D59407: [clangd] Add RelationSlab

nridge marked 8 inline comments as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/index/Index.h:43 +public: + using value_type = std::pair>; + using const_iterator = std::vector::const_iterator; kadircet wrote: > nridge wrote: > > kadi

[PATCH] D47358: : Implement {un,}synchronized_pool_resource.

Quuxplusone updated this revision to Diff 191815. Quuxplusone added a comment. Herald added a subscriber: jdoerfert. Rebased. Added `_NOEXCEPT` to `upstream_resource()` and `options()` (this is OK per [res.on.exception.handling]/5). Repository: rCXX libc++ CHANGES SINCE LAST ACTION https:/

[PATCH] D59377: Frontend: Remove CompilerInstance::VirtualFileSystem, NFC

jkorous accepted this revision. jkorous added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59377/new/ https://reviews.llvm.org/D59377 ___ cfe-commits mailing list cfe-commits

[PATCH] D42034: [clang-format] In tests, expected code should be format-stable

mzeren-vmw added inline comments. Comment at: cfe/trunk/unittests/Format/FormatTest.cpp:78 EXPECT_EQ(Expected.str(), format(Code, Style)); if (Style.Language == FormatStyle::LK_Cpp) { // Objective-C++ is a superset of C++, so everything checked for C++ --

[PATCH] D58797: [Sema] Add some compile time _FORTIFY_SOURCE diagnostics

nickdesaulniers added a comment. This is causing false positive warnings for the Linux kernel: https://github.com/ClangBuiltLinux/linux/issues/423 :( https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/fs/statfs.c#n128 Consider this untested case: if (sizeof(buf) == s

<    1   2