aemerson marked an inline comment as done.
aemerson added inline comments.
================
Comment at: llvm/lib/IR/AutoUpgrade.cpp:574
+ if (ArgTy->getElementType()->isFloatingPointTy()) {
+ auto fArgs = F->getFunctionType()->params();
+ Type *Tys[] = {fArgs[0], fArgs[1]};
----------------
efriedma wrote:
> This code is weird... you're computing the types in two different ways.
> Also, missing a check for F->arg_size() (so we don't crash on invalid IR).
I'll consolidate the logic, but none of the other code here checks for IR
validity. By the time we reach here the IR should be valid, we're just
translating it to a newer version. I can put an assert anyway.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59655/new/
https://reviews.llvm.org/D59655
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
