[PATCH] D55044: [clang-tidy] check for Abseil make_unique

lebedev.ri added a comment. Please always upload all patches with full context (`=U9`) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55044/new/ https://reviews.llvm.org/D55044 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

lebedev.ri added inline comments. Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:55 + IgnoreMacros(Options.getLocalOrGlobal("IgnoreMacros", true)), + UseLegacyFunction(Options.getLocalOrGlobal("UseLegacyFunction", false)) {} I'm not sure it m

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

MyDeveloperDay added inline comments. Comment at: clang-tidy/abseil/WrapUniqueCheck.cpp:7 +// License. See LICENSE.TXT for details. +// +//===--===// License as above Comment a

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

MyDeveloperDay added inline comments. Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:163 + // Conservatively disable for list initializations + if (UseLegacyFunction && New->getInitializationStyle() == CXXNewExpr::ListInit) { +return; elide the bra

[clang-tools-extra] r356125 - [clangd] Store explicit template specializations in index for code navigation purposes

Author: kadircet Date: Thu Mar 14 01:35:17 2019 New Revision: 356125 URL: http://llvm.org/viewvc/llvm-project?rev=356125&view=rev Log: [clangd] Store explicit template specializations in index for code navigation purposes Summary: This introduces ~4k new symbols, and ~10k refs for LLVM. We need

[PATCH] D59083: [clangd] Store explicit template specializations in index for code navigation purposes

This revision was automatically updated to reflect the committed changes. Closed by commit rL356125: [clangd] Store explicit template specializations in index for code navigation… (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Reposit

[PATCH] D57893: [analyzer] Fix function macro crash

bruntib updated this revision to Diff 190575. bruntib added a comment. I've uploaded another version of the last fix. The previous one contained an UB, although it worked practically. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57893/new/ https://reviews.llvm.

[PATCH] D59283: Fixed global constant/variable naming check on C++ class for ObjC++ files.

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: test/clang-tidy/google-objc-global-variable-declaration.mm:11 +}; \ No newline at end of file nit: I think we should have a newline at end o

[PATCH] D59264: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux

MaskRay added a comment. > A nonzero __dso_handle has to match the value passed to __cxa_atexit but a > zero __dso_handle matches every function registered. So it matters that DSO > fini calls use &__dso_handle to match their registrations for the dlclose case Yes, but this won't matter if we c

[PATCH] D59350: [clangd] Build Dex index after loading all shards in BackgroundIndex.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Herald added a project: clang. Currently after loadding all shards, we use MemIndex which has poor query performance, we should use Dex. Repository: rCT

[PATCH] D59309: [clang-format] BreakAfterReturnType ignored on functions with numeric template parameters

klimek added a comment. Why did the numeric constant break this? Which path would the function run through? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59309/new/ https://reviews.llvm.org/D59309 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D59350: [clangd] Build Dex index after loading all shards in BackgroundIndex.

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clangd/index/Background.cpp:609 + reset(IndexedSymbols.buildIndex(IndexType::Heavy, DuplicateHandling::Merge)); + vlog("BackgroundIndex: built symbol in

[clang-tools-extra] r356126 - [clangd] Build Dex index after loading all shards in BackgroundIndex.

Author: hokein Date: Thu Mar 14 02:57:10 2019 New Revision: 356126 URL: http://llvm.org/viewvc/llvm-project?rev=356126&view=rev Log: [clangd] Build Dex index after loading all shards in BackgroundIndex. Summary: Currently after loadding all shards, we use MemIndex which has poor query performance

[PATCH] D59309: [clang-format] BreakAfterReturnType ignored on functions with numeric template parameters

MyDeveloperDay added a comment. In D59309#1428799 , @klimek wrote: > Why did the numeric constant break this? Which path would the function run > through? as its looking though the parameter list is doesn't recognize a numeric constant as being a valid

[PATCH] D59350: [clangd] Build Dex index after loading all shards in BackgroundIndex.

hokein updated this revision to Diff 190579. hokein marked an inline comment as done. hokein added a comment. Format the code. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59350/new/ https://reviews.llvm.org/D59350 Files: clangd/index/Background

[PATCH] D59350: [clangd] Build Dex index after loading all shards in BackgroundIndex.

This revision was automatically updated to reflect the committed changes. Closed by commit rL356126: [clangd] Build Dex index after loading all shards in BackgroundIndex. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL L

[PATCH] D57765: [ARM] Add Cortex-M35P Support

LukeCheeseman added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57765/new/ https://reviews.llvm.org/D57765 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r356127 - [clangd] Fix an out-of-date FIXME, NFC.

Author: hokein Date: Thu Mar 14 03:01:07 2019 New Revision: 356127 URL: http://llvm.org/viewvc/llvm-project?rev=356127&view=rev Log: [clangd] Fix an out-of-date FIXME, NFC. Modified: clang-tools-extra/trunk/clangd/index/Index.h Modified: clang-tools-extra/trunk/clangd/index/Index.h URL: htt

[PATCH] D58896: Suppress -Wchar-subscripts if the index is a literal char

edward-jones added a comment. In D58896#1419964 , @aaron.ballman wrote: > Do you have some evidence that the current behavior is causing a lot of false > positives in the wild? For ASCII character literals, I can sort of guess at > why people might want

[PATCH] D58345: [clangd] Using symbol name to map includes for STL symbols.

ioeric added inline comments. Comment at: clangd/include-mapping/gen_std.py:46 +// +// Generated from cppreference offline HTML book v%s. +//===--===// I'd suggest dropping `v` prefix as it might

[PATCH] D33029: [clang-format] add option for dangling parenthesis

klimek added a comment. In D33029#1423949 , @MyDeveloperDay wrote: > In D33029#1423947 , @lebedev.ri > wrote: > > > In D33029#1423944 , > > @MyDeveloperDay wrote: > > > >

[PATCH] D59309: [clang-format] BreakAfterReturnType ignored on functions with numeric template parameters

klimek added a comment. In D59309#1428807 , @MyDeveloperDay wrote: > In D59309#1428799 , @klimek wrote: > > > Why did the numeric constant break this? Which path would the function run > > through? > > > as its lo

[PATCH] D57765: [ARM] Add Cortex-M35P Support

olista01 accepted this revision. olista01 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57765/new/ https://reviews.llvm.org/D57765 ___ cfe-commits mailing list cfe-commi

[PATCH] D55170: [clang-format]: Add NonEmptyParentheses spacing option

klimek added a comment. In D55170#1423941 , @MyDeveloperDay wrote: > In D55170#1423798 , @reuk wrote: > > > Thanks for the review, and for approving this PR. It's very much > > appreciated! > > > > I don't have me

[PATCH] D59353: [WebAssembly] Use rethrow intrinsic in the rethrow block

aheejin created this revision. aheejin added a reviewer: dschuff. Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100. Herald added a project: clang. Because in wasm we merge all catch clauses into one big catchpad, in case none of the types in catch handlers matches after we

[PATCH] D52150: [clang-format] BeforeHash added to IndentPPDirectives

klimek accepted this revision. klimek added a comment. Given this doesn't add an extra option (but only an extra enum) and is fairly straight forward, LG. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52150/new/ https://reviews.llvm.org/D52150 ___

[PATCH] D58345: [clangd] Using symbol name to map includes for STL symbols.

hokein updated this revision to Diff 190592. hokein marked 4 inline comments as done. hokein added a comment. Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58345/new/ https://reviews.llvm.org/D58345 Files: clangd/StdSymbolMap.inc

[PATCH] D58345: [clangd] Using symbol name to map includes for STL symbols.

hokein added inline comments. Comment at: clangd/index/CanonicalIncludes.cpp:123 static const std::vector> SystemHeaderMap = { ioeric wrote: > ioeric wrote: > > hokein wrote: > > > sammccall wrote: > > > > hokein wrote: > > > > > ioeric wrote: > > > >

[PATCH] D59354: [clangd] Print arguments in template specializations

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D59354 Files: clang-tools-extra/clangd/AST.cpp cl

[PATCH] D59354: [clangd] Print arguments in template specializations

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:57 +return Func->getTemplateSpecializationArgsAsWritten()->arguments(); + if (auto *Cls = llvm::dyn_cast(&ND)) +return Cls->getTemplateArgsAsWritten()->arguments(); For `Cl

[PATCH] D58345: [clangd] Using symbol name to map includes for STL symbols.

ioeric accepted this revision. ioeric added inline comments. This revision is now accepted and ready to land. Comment at: clangd/index/CanonicalIncludes.cpp:111 - {"std::addressof", ""}, - // Map symbols in to their preferred includes. {"std::basic_filebuf", ""}

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

shiva0217 updated this revision to Diff 190595. shiva0217 added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Passing small data limitation by module flag. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57497/new/ https://reviews

[PATCH] D58345: [clangd] Using symbol name to map includes for STL symbols.

hokein updated this revision to Diff 190598. hokein marked an inline comment as done. hokein added a comment. One more comment. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58345/new/ https://reviews.llvm.org/D58345 Files: clangd/StdSymbolMap.in

[clang-tools-extra] r356134 - [clangd] Using symbol name to map includes for STL symbols.

Author: hokein Date: Thu Mar 14 04:25:26 2019 New Revision: 356134 URL: http://llvm.org/viewvc/llvm-project?rev=356134&view=rev Log: [clangd] Using symbol name to map includes for STL symbols. Summary: Using suffix path mapping relies on the STL implementations, and it is not portable. This patch

[PATCH] D58345: [clangd] Using symbol name to map includes for STL symbols.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE356134: [clangd] Using symbol name to map includes for STL symbols. (authored by hokein, committed by ). Changed prior to commit: https://reviews.llvm.org/D58345?vs=190598&id=190600#toc Repository:

[PATCH] D59309: [clang-format] BreakAfterReturnType ignored on functions with numeric template parameters

MyDeveloperDay added a comment. That works because the argument list is just tok::identifier and TT_StartOfName so if we see StartOfName we are going to return true identifier will simply be skipped round the loop `` int Test(A a) {} AnnotatedTokens(L=0): M=0 C=0 T=Unknown S=1 B=0 BK=0 P=

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

klimek added a comment. In D28462#1406716 , @jacob-keller wrote: > In regards to whether clang-format should support this feature, I think it's > pretty clear that a large number of users want it to. The tool already > supports formatting various other

[PATCH] D59309: [clang-format] BreakAfterReturnType ignored on functions with numeric template parameters

klimek added a comment. In D59309#1428969 , @MyDeveloperDay wrote: > That works because the argument list is just tok::identifier and > TT_StartOfName Should we fix isStartOfName then? In A or A<8> A should be TT_StartOfName, too, right? CHANGES SIN

[PATCH] D59309: [clang-format] BreakAfterReturnType ignored on functions with numeric template parameters

MyDeveloperDay added a comment. of course, this isn't legal int TestFn(A=1) { return a; } and, would see the TT_StartOfName for (a) and would break int TestFn(A a = 1) { return a; } CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59309/new/ https://reviews.llvm.or

[PATCH] D59309: [clang-format] BreakAfterReturnType ignored on functions with numeric template parameters

MyDeveloperDay added a comment. In D59309#1428970 , @klimek wrote: > In D59309#1428969 , @MyDeveloperDay > wrote: > > > That works because the argument list is just tok::identifier and > > TT_StartOfName > > > Sho

[PATCH] D59309: [clang-format] BreakAfterReturnType ignored on functions with numeric template parameters

MyDeveloperDay added a comment. In D59309#1428970 , @klimek wrote: > In D59309#1428969 , @MyDeveloperDay > wrote: > > > That works because the argument list is just tok::identifier and > > TT_StartOfName > > > Sho

[PATCH] D57860: [analyzer] Validate checker option names and values

xazax.hun added a comment. Did we test all the codepaths including the package level configs? If not, please add some package level config option related tests. Otherwise the patch looks good to me after all the comments are resolved. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57860/

[PATCH] D59300: [clangd] Tune the fuzzy-matching algorithm

ilya-biryukov updated this revision to Diff 190604. ilya-biryukov added a comment. - Adjust the tweaks, bring back removed heuristics. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59300/new/ https://reviews.llvm.org/D59300 Files: clang-tools-ex

[PATCH] D59300: [clangd] Tune the fuzzy-matching algorithm

ilya-biryukov added a comment. Here are the stats for the latest version. We now get a significant bump for initialisms and a much lower hit in non-initialism cases. ==

[PATCH] D59347: [DebugInfo] Combine Trivial and NonTrivial flags

probinson added a comment. I'd preserve the trivial test cases and show that the NonTrivial flag is *not* present. I can suggest ways to achieve this if you like (note there is no CHECK-DAG-NOT combined directive). Comment at: test/CodeGenCXX/debug-info-composite-triviality.

[PATCH] D59360: [clang-tidy] Fix more false positives for bugprone-string-integer-assignment

courbet created this revision. courbet added reviewers: JonasToth, alexfh, xazax.hun. Herald added subscribers: jdoerfert, rnkovacs. Herald added a project: clang. And add various tests gleaned for our codebase. See PR27723. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D59360

[PATCH] D57464: Generalize method overloading on addr spaces to C++

ebevhan added a comment. In D57464#1425904 , @Anastasia wrote: > I think not. :( But I am wondering if we could proceed for now in some > general direction and then make any improvements later. Probably the biggest > part of this patch is not going to ch

[PATCH] D59327: [Sema] Fix a use-after-free of a _Nonnull ParsedAttr

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59327/new/ https://reviews.llvm.org/D59327 ___

[PATCH] D59361: [CUDA][Windows] Partial fix for bug 38811 (Step 1 of 3)

emankov created this revision. emankov added a reviewer: tra. Herald added subscribers: cfe-commits, jdoerfert. Herald added a project: clang. Partial fix for the clang Bug 38811 "Clang fails to compile with CUDA-9.x on Windows". Adding `defined(_W

[PATCH] D59360: [clang-tidy] Fix more false positives for bugprone-string-integer-assignment

alexfh added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/StringIntegerAssignmentCheck.cpp:50 +public: + CharExpressionDetector(const QualType CharType, const ASTContext &Ctx) + : CharType(CharType), Ctx(Ctx) {} No need for the top-le

[PATCH] D59309: [clang-format] BreakAfterReturnType ignored on functions with numeric template parameters

klimek added a comment. Yea, the a b(c) problem is the olden C++ problem clang-format will never be able to solve, thus all these crazy heuristics. So, inching closer to understanding this - I totally missed the isLiteral() that short-circuits out before. I'm more happy with your current approa

[PATCH] D59360: [clang-tidy] Fix more false positives for bugprone-string-integer-assignment

courbet marked 3 inline comments as done. courbet added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/StringIntegerAssignmentCheck.cpp:115 +Expr::EvalResult EvalResult; +if (!E->EvaluateAsInt(EvalResult, Ctx, Expr::SE_AllowSideEffects)) + return

[PATCH] D59360: [clang-tidy] Fix more false positives for bugprone-string-integer-assignment

courbet updated this revision to Diff 190610. courbet added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59360/new/ https://reviews.llvm.org/D59360 Files: clang-tools-extra/clang-tidy/bugprone/StringIntegerAs

r356142 - [analyzer] Fix function macro crash

Author: szelethus Date: Thu Mar 14 06:38:16 2019 New Revision: 356142 URL: http://llvm.org/viewvc/llvm-project?rev=356142&view=rev Log: [analyzer] Fix function macro crash Re-commit D57893. Differential Revision: https://reviews.llvm.org/D57893 Modified: cfe/trunk/lib/StaticAnalyzer/Core/Pl

[clang-tools-extra] r356141 - [clang-tidy] Add additional patterns to the abseil-duration-unnecessary-conversion check.

Author: hwright Date: Thu Mar 14 06:38:16 2019 New Revision: 356141 URL: http://llvm.org/viewvc/llvm-project?rev=356141&view=rev Log: [clang-tidy] Add additional patterns to the abseil-duration-unnecessary-conversion check. Differential Revision: https://reviews.llvm.org/D59183 Modified: c

[PATCH] D59183: [clang-tidy] Expand cases covered by the abseil-duration-unnecessary-conversion check

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE356141: [clang-tidy] Add additional patterns to the abseil-duration-unnecessary… (authored by hwright, committed by ). Changed prior to commit: https://reviews.llvm.org/D59183?vs=190456&id=190613#toc

[PATCH] D57893: [analyzer] Fix function macro crash

This revision was automatically updated to reflect the committed changes. Closed by commit rL356142: [analyzer] Fix function macro crash (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.o

r356148 - Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

Author: nico Date: Thu Mar 14 07:18:56 2019 New Revision: 356148 URL: http://llvm.org/viewvc/llvm-project?rev=356148&view=rev Log: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations This adds support for static_assert() (and _Static_assert()

[PATCH] D59354: [clangd] Print arguments in template specializations

kadircet updated this revision to Diff 190617. kadircet marked 3 inline comments as done. kadircet added a comment. Herald added a subscriber: jdoerfert. - Address comments - Add template specializations to fuzzyFind results Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D59364: [clangd] Add std subnamespace symbols to the symbol map.

hokein created this revision. hokein added a reviewer: ioeric. Herald added subscribers: jdoerfert, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a reviewer: serge-sans-paille. Herald added a project: clang. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D59364

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

This revision was automatically updated to reflect the committed changes. Closed by commit rC356148: Objective-C++11: Support static_assert() in @interface/@implementation ivar… (authored by nico, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D

r356151 - [ASTImporter] Fix import of NestedNameSpecifierLoc.

Author: balazske Date: Thu Mar 14 07:20:23 2019 New Revision: 356151 URL: http://llvm.org/viewvc/llvm-project?rev=356151&view=rev Log: [ASTImporter] Fix import of NestedNameSpecifierLoc. Summary: Import type location in case of TypeSpec and TypeSpecWithTemplate. Without this fix the imported Nesp

r356152 - Remove unused variable to silence compiler warning [NFC]

Author: uabelho Date: Thu Mar 14 07:20:50 2019 New Revision: 356152 URL: http://llvm.org/viewvc/llvm-project?rev=356152&view=rev Log: Remove unused variable to silence compiler warning [NFC] The only use of MI was removed in r356142. Modified: cfe/trunk/lib/StaticAnalyzer/Core/PlistDiagnosti

[PATCH] D55358: [ASTImporter] Fix import of NestedNameSpecifierLoc.

This revision was automatically updated to reflect the committed changes. Closed by commit rL356151: [ASTImporter] Fix import of NestedNameSpecifierLoc. (authored by balazske, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SIN

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

aaron.ballman added inline comments. Comment at: clang/test/Parser/objc-static-assert.m:29 +struct S { + @defs(A); +}; Given that static assertions are member declarations of a struct, should this "replay" the static asserts from the interface (including failin

[PATCH] D59354: [clangd] Print arguments in template specializations

kadircet added inline comments. Comment at: clang/lib/AST/TypePrinter.cpp:1644 +llvm::raw_ostream &OS) { + A.getTypeSourceInfo()->getType().print(OS, PP); +} ilya-biryukov wrote: > Maybe print the result of `getTypeLoc()` here, if

[PATCH] D57855: [analyzer] Reimplement checker options

Szelethus marked 3 inline comments as done. Szelethus added a comment. > Let's put at least a FIXME here that the documentation for this option was > missing. I'd prefer to just simply fix this. @NoQ, could you help us fill in the gaps? We need a desctiption for - `nullability:NoDiagnoseCallsT

[PATCH] D59354: [clangd] Print arguments in template specializations

kadircet updated this revision to Diff 190624. kadircet added a comment. - Get rid of debug printing - Update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59354/new/ https://reviews.llvm.org/D59354 Files: clang-tools-extra/clangd/AST.cpp

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

Szelethus updated this revision to Diff 190625. Szelethus edited the summary of this revision. Szelethus added a comment. Herald added subscribers: Charusso, jdoerfert. Also, don't forget package options :^) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57858/new/ https://reviews.llvm.o

r356154 - Fix test after r356148

Author: nico Date: Thu Mar 14 07:40:48 2019 New Revision: 356154 URL: http://llvm.org/viewvc/llvm-project?rev=356154&view=rev Log: Fix test after r356148 Modified: cfe/trunk/test/Parser/objc-static-assert.mm Modified: cfe/trunk/test/Parser/objc-static-assert.mm URL: http://llvm.org/viewvc/l

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

thakis marked 2 inline comments as done. thakis added inline comments. Comment at: clang/test/Parser/objc-static-assert.m:29 +struct S { + @defs(A); +}; aaron.ballman wrote: > Given that static assertions are member declarations of a struct, should this > "repl

[PATCH] D57922: [analyzer] Insert checker options into AnalyzerOption::ConfigTable

Szelethus updated this revision to Diff 190628. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57922/new/ https://reviews.llvm.org/D57922 Files: include/clang/StaticAnalyzer/Frontend/CheckerRegistry.h lib/StaticAnalyzer/Core/AnalyzerOptions.cpp lib/StaticAnalyzer/Frontend/CheckerReg

[PATCH] D57860: [analyzer] Validate checker option names and values

Szelethus updated this revision to Diff 190629. Szelethus marked 6 inline comments as done. Szelethus added a comment. Fixes according to inline comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57860/new/ https://reviews.llvm.org/D57860 Files: include/clang/Basic/DiagnosticDri

[PATCH] D57860: [analyzer] Validate checker option names and values

Szelethus updated this revision to Diff 190630. Szelethus added a comment. Add a testcase for packages. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57860/new/ https://reviews.llvm.org/D57860 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/StaticAnalyzer/Frontend

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

aaron.ballman added inline comments. Comment at: clang/test/Parser/objc-static-assert.m:29 +struct S { + @defs(A); +}; thakis wrote: > aaron.ballman wrote: > > Given that static assertions are member declarations of a struct, should > > this "replay" the static

r356156 - [CodeGen][ObjC] Remove the leading 'l' from symbols for protocol

Author: ahatanak Date: Thu Mar 14 08:17:37 2019 New Revision: 356156 URL: http://llvm.org/viewvc/llvm-project?rev=356156&view=rev Log: [CodeGen][ObjC] Remove the leading 'l' from symbols for protocol metadata and protocol list The leading 'l' tells ld64 to remove the symbol name, which can make d

[PATCH] D59234: [CodeGen][ObjC] Remove the leading 'l' from symbols for protocol metadata and protocol list

ahatanak added a comment. Okay, I'll remove the leading 'l' from other symbols and make them internal in a separate patch. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59234/new/ https://reviews.llvm.org/D59234 ___

[PATCH] D59234: [CodeGen][ObjC] Remove the leading 'l' from symbols for protocol metadata and protocol list

This revision was automatically updated to reflect the committed changes. Closed by commit rL356156: [CodeGen][ObjC] Remove the leading 'l' from symbols for protocol (authored by ahatanak, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to comm

[PATCH] D55269: [CUDA] Fix nvidia-cuda-toolkit detection on Ubuntu

jdenny added a comment. Herald added a project: LLVM. In D55269#1320382 , @tra wrote: > In D55269#1320207 , @Hahnfeld wrote: > > > In D55269#1319109 , @jdenny wrote: > > > >

[PATCH] D59319: [OpenMP][Offloading][1/3] A generic and simple target region interface

ABataev added inline comments. Comment at: openmp/libomptarget/deviceRTLs/common/target_region.h:27 + +/// The target region _kernel_ interface for GPUs +/// jdoerfert wrote: > ABataev wrote: > > All exported functions are declared in the `interface.h` file. I do

[PATCH] D59367: [Sema] Adjust address space of operands in remaining builtin operators

Anastasia created this revision. Anastasia added reviewers: rjmccall, bevinh. Herald added subscribers: jdoerfert, ebevhan. Fix address space of reference operand in the remaining builtin compound assignment operators. https://reviews.llvm.org/D59367 Files: lib/Sema/SemaOverload.cpp test/C

[PATCH] D59354: [clangd] Print arguments in template specializations

ilya-biryukov added a comment. Mostly nits, but could you elaborate why can't we print the type-loc when printing the template argument (see the corresponding comment)? Comment at: clang-tools-extra/clangd/AST.cpp:66 +return Var->getTemplateArgsInfo().arguments(); + retur

[PATCH] D59354: [clangd] Print arguments in template specializations

kadircet updated this revision to Diff 190642. kadircet marked 2 inline comments as done. kadircet added a comment. - Address some of the comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59354/new/ https://reviews.llvm.org/D59354 Files: cl

[PATCH] D59354: [clangd] Print arguments in template specializations

kadircet marked 7 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:84 +if (auto STL = TL.getAs()) { + std::vector ArgLocs; + for (unsigned I = 0; I < STL.getNumArgs(); I++) ilya-biryukov wrote: >

[PATCH] D58777: [analyzer] Fix an assertation failurure for invalid sourcelocation, add a new debug checker

Szelethus updated this revision to Diff 190643. Szelethus marked 7 inline comments as done. Szelethus added a comment. Fixes according to inline comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58777/new/ https://reviews.llvm.org/D58777 Files: docs/analyzer/developer-docs/Debu

[PATCH] D58777: [analyzer] Fix an assertation failurure for invalid sourcelocation, add a new debug checker

Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Checkers/DebugCheckers.cpp:271 +//===--===// +// Emits a report for each and every Stmt. +//===-

[PATCH] D59307: Patch llvm bug 41033 concerning atomicity of statement expressions

mibintc added a comment. In D59307#1428145 , @jfb wrote: > In D59307#1428101 , @mibintc wrote: > > > In D59307#1427644 , @jfb wrote: > > > > > I think you also want to test C

[PATCH] D59307: Patch llvm bug 41033 concerning atomicity of statement expressions

mibintc added a comment. In D59307#1427853 , @erichkeane wrote: > This is my concern here: > https://godbolt.org/z/icS4fa > The patch will change template instantiation. > > GCC doesn't seem to allow using _Atomic in C++ mode, which is perhaps a > nece

[PATCH] D59307: Patch llvm bug 41033 concerning atomicity of statement expressions

mibintc abandoned this revision. mibintc added a comment. The bug should be fixed at the atomic-load (drop _Atomic qualifier) then this patch won't be needed in StmtExpr Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59307/new/ https://reviews.llvm.org/D59307

r356161 - [analyzer] Fix an assertation failure for invalid sourcelocation, add a new debug checker

Author: szelethus Date: Thu Mar 14 09:10:29 2019 New Revision: 356161 URL: http://llvm.org/viewvc/llvm-project?rev=356161&view=rev Log: [analyzer] Fix an assertation failure for invalid sourcelocation, add a new debug checker For a rather short code snippet, if debug.ReportStmts (added in this p

[PATCH] D58777: [analyzer] Fix an assertation failurure for invalid sourcelocation, add a new debug checker

This revision was automatically updated to reflect the committed changes. Closed by commit rC356161: [analyzer] Fix an assertation failure for invalid sourcelocation, add a new… (authored by Szelethus, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5

[PATCH] D59300: [clangd] Tune the fuzzy-matching algorithm

ioeric added inline comments. Comment at: clang-tools-extra/clangd/FuzzyMatch.cpp:74 static bool isAwful(int S) { return S < AwfulScore / 2; } -static constexpr int PerfectBonus = 3; // Perfect per-pattern-char score. +static constexpr int PerfectBonus = 4; // Perfect per-patter

[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

riccibruno added a comment. IIRC, last time I looked only 4 statement/expression classes currently have some abbreviation defined. It would probably be useful to have someone go systematically through the list of classes and fix this. Repository: rC Clang CHANGES SINCE LAST ACTION https:/

[PATCH] D59196: [NFC][clang][PCH] ASTStmtReader::VisitStmt(): fixup faulty assert.

riccibruno added a comment. I am not an expert in the serialization code (just did some modifications), but this seems reasonable to me. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59196/new/ https://reviews.llvm.org/D59196 _

[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

lebedev.ri added a comment. In D59214#1429384 , @riccibruno wrote: > IIRC, last time I looked only 4 statement/expression classes currently have > some abbreviation defined. Yep, that is what i'm seeing in this diff. In D59214#1429384

[PATCH] D59254: [RFC] Implementation of Clang randstruct

jfb requested changes to this revision. jfb added a comment. This revision now requires changes to proceed. I find it easier to understand the code by looking at the tests. When you add tests, please make sure you test for: - Alignment attribute - Packed attribute - No unique address attribute -

[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

riccibruno added a comment. In D59214#1429400 , @lebedev.ri wrote: > In D59214#1429384 , @riccibruno > wrote: > > > IIRC, last time I looked only 4 statement/expression classes currently have > > some abbreviation

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

VelocityRa marked 11 inline comments as done. VelocityRa added a comment. Waiting for further feedback before pushing an update. Comment at: lib/Format/WhitespaceManager.cpp:436 +static void +AlignTokenSequenceAll(unsigned Start, unsigned End, unsigned Column, +

[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

lebedev.ri added a comment. In D59214#1429422 , @riccibruno wrote: > In D59214#1429400 , @lebedev.ri > wrote: > > > In D59214#1429384 , @riccibruno > > wrote: > > > > > IIR

[PATCH] D59354: [clangd] Print arguments in template specializations

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang/lib/AST/TypePrinter.cpp:1646 +break; + case TemplateArgument::ArgKind::Type: +A.getTypeSourceInfo()->getType().print(OS, PP); ilya-biryukov wrote: > Maybe simpli

  1   2   >